f2317ac0da
Asking for a test because my DB is quite polluted these days and I may have forgot to set a value somewhere <!-- First of all, THANK YOU for your contribution. --> ## Changes Proposed: - Sniffs spawns for Draenei Vessel (already sniffed before) - Pools normal Vessel them with trapped Vessel at 50% chance (confirmed in sniff) - Prevent trap from triggering at distance - Fixes trapped Vessel being unlootable - Fixes campfire with bad z coords using sniffed data ## Issues Addressed: <!-- If your fix has a relating issue, link it below --> - Closes https://github.com/azerothcore/azerothcore-wotlk/issues/14332 - Closes https://github.com/chromiecraft/chromiecraft/issues/4618 ## SOURCE: <!-- If you can, include a source that can strengthen your claim --> WotLK Classic ## Tests Performed: <!-- Does it build without errors? Did you test in-game? What did you test? On which OS did you test? Describe any other tests performed --> - Tested ingame - ## How to Test the Changes: <!-- Describe in a detailed step-by-step order how to test the changes --> 1. `.quest add 10028` 2. `.tele Tuurem` 3. see if behaviour improves ## Known Issues and TODO List: <!-- Is there anything else left to do after this PR? --> - [ ] I haven't found a way to make a truly empty loot table without worldserver errors so I duplicated the table for normal vessel and lowered the chance to 0.1 (I've seen no loot in WotLK Classic, but it was lootable) - [ ] <!-- If you intend to contribute repeatedly to our project, it is a good idea to join our discord channel. We set ranks for our contributors and give them access to special resources or knowledge: https://discord.com/invite/DasJqPba) Do not remove the instructions below about testing, they will help users to test your PR --> ## How to Test AzerothCore PRs When a PR is ready to be tested, it will be marked as **[WAITING TO BE TESTED]**. You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here: http://www.azerothcore.org/wiki/How-to-test-a-PR **REMEMBER**: when testing a PR that changes something **generic** (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but **especially** check that the PR does not cause any regression (i.e. introducing new bugs). **For example**: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but **we should test Y and Z as well**.
AzerothCore
Introduction
AzerothCore (AC) is an open-source game-server application for World of Warcraft, currently supporting the 3.3.5a game version.
It is written in C++ and is based on MaNGOS, TrinityCore and SunwellCore.
Why AzerothCore?
- Stability
- The authenticity of the content
- Modularity
- A lot of modules to choose from
- Better configuration files system
- Compatibility with other emulators
- Friendly and helpful community
Stability
As players and administrators ourselves, we take great care into the stability of our core. Other projects focus on the development side of things and tend to forget that users want stability above everything else.
Hence why nobody is allowed to push commits directly to the core. All changes are reviewed and tested before they get to the master branch which means we need as many testers as possible to avoid stalling issues.
Authenticity
Fixing and implementing missing blizzlike content is one of our priorities, and we can boast to offer the most content-complete open-source emulator.
Modules
Modules are essential to AzerothCore's success. Modules allow users to plug them in and out easily, and do not require to modify the core files. It also means users can keep pulling the git changes from the main repository and only develop their modules.
We have a lot of modules already made, some of them are very important and will ease your work:
- Transmogrification
- Eluna (lua engine) support
- Full list available in the AzerothCore catalogue (link at the end)
Configuration files
Our configuration file system allows the user to use a tiny configuration file for better readability and maintenance.
Compatibility with other emulators
Not very far from its ancestor TrinityCore, most scripts can be adapted quite easily. For MaNGOS compatibility, it might require more knowledge but it shares a common base.
Philosophy
Our main goal is to create a playable game server, offering a fully working game experience.
Here are the main points we focus on:
- Stability
- Ease of use / Practicability
- Playability (in-game content)
- Customization
- Community-driven software (check our discord)
We also welcome new users (even non-English speaking users!) and help them learn/improve their skills (C++, SQL, Git, software collaboration, tutoring/wiki, etc...).
Unlike other projects which focus more on the developer's side of things, we want users to be able to run their server with as few troubles as possible. All of our contributors run their private servers (local or public).
That's why AzerothCore is easier to use, to maintain, to understand, to develop on, and to customize to suit your needs, than other emulators.
In short, we focus on the user experience (UX), whether it be the player's experience, the developer's experience, or the administrator's experience.
How to Thank us
Being an open-source project, we rely on volunteers to pursue development. Here are ways to help us if you use AzerothCore:
Github Star
Click on the "star this repository" button to help us gain more visibility on Github!
By contributing
Check the CONTRIBUTING section below.
Financially 💰
You can support the AzerothCore by donating. The money will be used to pay freelance developers for more open-source fixes.
Advertising
By talking about us on different platforms or to people who would like to get involved.
Contributing
AzerothCore is a learning project, and there are lots of different ways to contribute to the project:
- By testing our fixes (we can teach you how to correctly use Git to help us but that will also help you out tremendously)
- By developing directly to the core or the modules
- By reporting bugs within the project
- By creating new modules
- By improving our wiki
- By providing direct support to our community (on Discord, StackOverflow or specialized forums)
- By making extra content (video tutorial for example)
- By putting bounties on issues
If you want to contribute to the project, you will find a lot of resources that will guide you in our wiki.
Feel free to join us on our Discord chat server where we teach a lot of new people how to get started and who are now important contributors!
Installation
Installation instructions are available here.
We also have an auto-installation bash script here (Warning: try it/analyze it before running it).
Dockerization of AzerothCore is fully supported, and we have various community-made tutorials (eg: AWS / Digital Ocean installation).
Support
Our self-made wiki probably has a lot of answers for you.
For help requests, it is recommended to ask your question on StackOverflow and link it in our chat.
Authors & Contributors
This project exists thanks to:
- The AzerothCore developers and contributors
- The SunwellCore developers xinef and pussywizard
- All the TrinityCore developers and contributors
- All the MaNGOS, ScriptDev2 and UDB developers and contributors
Important Links
-
AzerothCore catalogue (modules, tools, etc...)
License
- The new AzerothCore source components are released under the GNU AGPL v3
- The old sources based on MaNGOS/TrinityCore are released under the GNU GPL v2
Special thanks
JetBrains is providing free open-source licenses to the AzerothCore developers.
