mirror of
https://github.com/mod-playerbots/azerothcore-wotlk.git
synced 2026-01-31 09:33:47 +00:00
* fix(DB/SmartAI): improve Harry surrendering during quest 'Gambling Debt' (#23598) * fix(DB/Quest): The Kalu'ak dailies reward 500 rep (#23600) * chore(DB): import pending files Referenced commit(s):fb03f41b2a* fix(DB/GameEvent): Remove midsummer pole in K3 (#23614) * chore(DB): import pending files Referenced commit(s):7b0000d6ee* fix(DB/SmartAI): increase reliability of quest event Foolish Endeavors (#23612) * chore(DB): import pending files Referenced commit(s):86f219abbc* fix(Scripts/AreaTrigger): players become stuck after Last Rites (#23613) * chore(DB): import pending files Referenced commit(s):c1a8047cf1* fix(Core/Vmaps): Fix inconsistency of hitInstance and hitModel to cause wrong area ids (#23233) Co-authored-by: ModoX <moardox@gmail.com> Co-authored-by: Shauren <shauren.trinity@gmail.com> Co-authored-by: Grimdhex <237474256+Grimdhex@users.noreply.github.com> Co-authored-by: sudlud <sudlud@users.noreply.github.com> * fix(DB/Gameobject): Sniffed Values for 'Wild Mustard' spawns (#23608) * fix(DB/SmartAI): remove large combat distance of Frostbrood Sentry (#23607) * chore(DB): import pending files Referenced commit(s):41d40b236f* fix(DB/ReputationRewardRate): Patch 3.0.0 gain for Northrend factions (#23597) * chore(DB): import pending files Referenced commit(s):067a898caa* fix(Core/Map): It should be ensured that the instance is unloaded only after the Creature Respawn. (#23103) * fix(Scripts/Northrend): Sniffing Out The Perpetrator horde (#23620) * fix(Scripts/Northrend): ensure Drakuru stays in place during Betrayal (#23619) * chore(DB): import pending files Referenced commit(s):928e145694* fix(DB/SmartAI): quest 'Reconnaissance Flight' (#23628) Co-authored-by: dr-j <dr-j@users.noreply.github.com> Co-authored-by: Killyana <morphone1@gmail.com> * fix(DB/QuestOfferReward): remove mention of a beta recipe in text (#23629) * fix(DB/Conditions): update quest conditions to drop chokers (#23610) * chore(DB): import pending files Referenced commit(s):bca8f7ce07* refactor(Core/PlayerScript): Delete OnPlayerChat, use OnPlayerCanUseChat (#23617) * fix(Core/SmartAI): startup warnings unused params (#23551) * fix(Core/Unit): Druid Talent Survival of the Fittest lacking immunity to creature daze (#23471) * fix(DB/SAI): Fix Fizzcrank Paradrop teleporters (#23633) * chore(DB): import pending files Referenced commit(s):94ba1c210d* fix(Core): Fix waterwalking after dying in instance (#23593) * fix(DB/SAI): don't remove all auras when mounting flamebringer (#23640) * chore(DB): import pending files Referenced commit(s):22f91f3802* fix(DB/SAI): Emerald Lasher goes out of the terrain when aggroed. (#23642) * chore(DB): import pending files Referenced commit(s):f9d6fe41de* fix(DB/SAI): Burning Depths Necromancer no longer stays in place. (#23641) * chore(DB): import pending files Referenced commit(s):1037471c8d* fix(DB/SAI): Remove SmartAI from Valkyrion Harpoon Gun. (#23646) * chore(DB): import pending files Referenced commit(s):8e3a7e6dcf* fix(DB/Creature): Fix Weakened Reanimated Frost Wyrm inhabit type (#23645) * chore(DB): import pending files Referenced commit(s):3baa18ef5b* fix(DB/Spell): Infectious Bites should stack from different casters (#23647) * chore(DB): import pending files Referenced commit(s):5aede412ab* fix(DB/SAI): Solve various issues with It Goes to 11... quest. (#23651) * fix(DB/Loot): Fireproof Satchel will now always drop the Ritual of Torch (#23585) * chore(DB): import pending files Referenced commit(s):1090c209b3* fix(Scripts/Northrend): Betrayal quest (#23650) * fix(Script/BlackTemple): Reliquary of Souls will use 45 degree in front to set incombat (#22938) * fix(Scripts/Spell): Fix Animal Blood spawning when it shouldn't (#23656) * fix(Scripts/BoreanTundra): Script Bloodspore Haze/Psychosis (#23657) * chore(DB): import pending files Referenced commit(s):baf7957e36* fix(DB/SAI): Sibling Rivalry quest credit if mounted (#23659) * chore(DB): import pending files Referenced commit(s):6919cc679d* fix(docs/license): use GPLv2 as MaNGOS-based project (#23655) * fix(Core/Achievements): a character can only have 1 race realm first (#23626) * chore: fix leftover license header (#23678) * fix(Scripts/HoL): Update Loken script (#23587) * fix(Scripts/DTK): Update King Dred script (#23572) * fix(DB/SAI): Bitter Departure quest credit (#23658) * chore(DB): import pending files Referenced commit(s):e595425578* fix(DB/Conditions): Ice Shard require Icy Imprisonment (#23661) * chore(DB): import pending files Referenced commit(s):8294652e77* fix(DB/Loot): add Scourge Curio drop to Lost Shandaral Spirit (#23686) * chore(DB): import pending files Referenced commit(s):b6ed4347fe* fix(DB/Gameobject): fix spell focus location for 'Will of the Titans' (#23683) * chore(DB): import pending files Referenced commit(s):388f18895d* fix(DB/Creature): update IOC Demolisher spells (#23685) * chore(DB): import pending files Referenced commit(s):cdfa50c990* fix(Scripts/Northrend): IOC boss cast ability Mortal Strike (#23684) * fix(Scripts/BoreanTundra): Fix Beryl Sorcerer engaging mobs (#23690) * fix(Core/Entities): Improve interactions between taxis and players regarding PvP flag. (#23681) * fix(DB/Creature): Peon Gakra should be an innkeeper (#23699) * chore(DB): import pending files Referenced commit(s):6abff4ac2b* fix(Scripts/SholazarBasin): Fix Song of Wind and Water double credit (#23707) * fix(DB/SAI): Reanimated Frost Wyrm engage after being hit by quest spell (#23697) * fix(DB/SAI): Timely respawn Nesingwary Trappers (#23703) * fix(DB/Creature): Fix Fjord Hawk Matriarch unit flags (#23696) * fix(DB/Conditions): Fix Fordragon Resolve target conditions (#23701) * chore(DB): import pending files Referenced commit(s):2942d63125* fix(DB/Script): Move Tailhorn Stag and Amberpine Woodsman behavior into SmartAI. (#23708) * fix(DB/Creature): Set Trigger flag on Steam Vent. (#23710) * chore(DB): import pending files Referenced commit(s):435ca302ef* fix(DB/SAI): To Stars' Rest! taxi flight (#23712) * chore(DB): import pending files Referenced commit(s):ab4d59ac9d* fix (DB/Creature): Set Surveyor Orlond flags. (#23714) * chore(DB): import pending files Referenced commit(s):e8ec77dca7* fix(DB/Loot): Fix Master Summoner Staff drop chance (#23717) * chore(DB): import pending files Referenced commit(s):182c055e6e* fix(Scripts/DTK): Fix Oh Novos! achievement (#23539) (#23718) * fix(Core/Spells): Remove King Mrgl-Mrgl costume on spell casting (#23713) * chore(DB): import pending files Referenced commit(s):8c963a11ce* fix(DB/Reputation): Utigarde Pinnacle normal reputation (#23719) * chore(DB): import pending files Referenced commit(s):88ed7d66d5* fix(Scripts/HoS): Clean up faction update hacks (#23720) * fix(DB/Reputation): Lower reputation according to rates handling (#23722) * fix(DB/Reputation): Oculus normal & UP correction (#23723) * chore(DB): import pending files Referenced commit(s):abc2cf3028* fix(Scripts/Oculus): Implement crossfaction support for drakes (#23704) * fix(DB/Quest): Correct prerequisite for Reclaimed Ration (#23736) Co-authored-by: blinkysc <blinkysc@users.noreply.github.com> * fix(DB/Quest): Correct prerequisite for Salvaging Life's Strength (#23734) Co-authored-by: blinkysc <blinkysc@users.noreply.github.com> * chore(DB): import pending files Referenced commit(s):afd8197588* fix(Core/Movement): Fix SummonMovementInform for summons (#23725) * refactor(Core/Movement): Fix Build (#23739) * fix(DB/SAI): Update Iron Rune Construct SAI to use DO_ACTION instead … (#23716) * chore(DB): import pending files Referenced commit(s):7cc39f78e2* fix(DB/SAI): Fix Flamebringer gossip interaction (#23740) * chore(DB): import pending files Referenced commit(s):9cb683cfcd* fix(DB/SAI): Nerub'ar member packs now attack together. (#23727) * chore(DB): import pending files Referenced commit(s):6f5a1b7ccc* fix(DB/SAI): Remove Harrison Johnes quest flag on escort accept (#23700) * chore(DB): import pending files Referenced commit(s):bacf15d356* Update crash issue template with log submission guidelines (#23754) * Merge * Updated OnPlayerChat method name to OnPlayerCanUseChat --------- Co-authored-by: sogladev <sogladev@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: 天鹭 <18535853+PkllonG@users.noreply.github.com> Co-authored-by: ModoX <moardox@gmail.com> Co-authored-by: Shauren <shauren.trinity@gmail.com> Co-authored-by: Grimdhex <237474256+Grimdhex@users.noreply.github.com> Co-authored-by: sudlud <sudlud@users.noreply.github.com> Co-authored-by: dr-j <dr-j@users.noreply.github.com> Co-authored-by: Killyana <morphone1@gmail.com> Co-authored-by: Undo <50205200+UndoUreche@users.noreply.github.com> Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com> Co-authored-by: killerwife <killerwife@gmail.com> Co-authored-by: Tereneckla <Tereneckla@pm.me> Co-authored-by: Rocco Silipo <108557877+Rorschach91@users.noreply.github.com> Co-authored-by: Ryan Turner <16946913+TheSCREWEDSoftware@users.noreply.github.com> Co-authored-by: blinkysc <37940565+blinkysc@users.noreply.github.com> Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com> Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com> Co-authored-by: Traesh <Traesh@users.noreply.github.com> Co-authored-by: blinkysc <blinkysc@users.noreply.github.com>
271 lines
12 KiB
Markdown
271 lines
12 KiB
Markdown
<!--
|
|
Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
|
|
SPDX-License-Identifier: curl
|
|
-->
|
|
|
|
# BUGS
|
|
|
|
## There are still bugs
|
|
|
|
curl and libcurl keep being developed. Adding features and changing code
|
|
means that bugs sneak in, no matter how hard we try to keep them out.
|
|
|
|
Of course there are lots of bugs left. Not to mention misfeatures.
|
|
|
|
To help us make curl the stable and solid product we want it to be, we need
|
|
bug reports and bug fixes.
|
|
|
|
## Where to report
|
|
|
|
If you cannot fix a bug yourself and submit a fix for it, try to report an as
|
|
detailed report as possible to a curl mailing list to allow one of us to have
|
|
a go at a solution. You can optionally also submit your problem in [curl's
|
|
bug tracking system](https://github.com/curl/curl/issues).
|
|
|
|
Please read the rest of this document below first before doing that.
|
|
|
|
If you feel you need to ask around first, find a suitable [mailing
|
|
list](https://curl.se/mail/) and post your questions there.
|
|
|
|
## Security bugs
|
|
|
|
If you find a bug or problem in curl or libcurl that you think has a security
|
|
impact, for example a bug that can put users in danger or make them
|
|
vulnerable if the bug becomes public knowledge, then please report that bug
|
|
using our security development process.
|
|
|
|
Security related bugs or bugs that are suspected to have a security impact,
|
|
should be reported on the [curl security tracker at
|
|
HackerOne](https://hackerone.com/curl).
|
|
|
|
This ensures that the report reaches the curl security team so that they
|
|
first can deal with the report away from the public to minimize the harm and
|
|
impact it has on existing users out there who might be using the vulnerable
|
|
versions.
|
|
|
|
The curl project's process for handling security related issues is
|
|
[documented separately](https://curl.se/dev/secprocess.html).
|
|
|
|
## What to report
|
|
|
|
When reporting a bug, you should include all information to help us
|
|
understand what is wrong, what you expected to happen and how to repeat the
|
|
bad behavior. You therefore need to tell us:
|
|
|
|
- your operating system's name and version number
|
|
|
|
- what version of curl you are using (`curl -V` is fine)
|
|
|
|
- versions of the used libraries that libcurl is built to use
|
|
|
|
- what URL you were working with (if possible), at least which protocol
|
|
|
|
and anything and everything else you think matters. Tell us what you expected
|
|
to happen, tell use what did happen, tell us how you could make it work
|
|
another way. Dig around, try out, test. Then include all the tiny bits and
|
|
pieces in your report. You benefit from this yourself, as it enables us to
|
|
help you quicker and more accurately.
|
|
|
|
Since curl deals with networks, it often helps us if you include a protocol
|
|
debug dump with your bug report. The output you get by using the `-v` or
|
|
`--trace` options.
|
|
|
|
If curl crashed, causing a core dump (in Unix), there is hardly any use to
|
|
send that huge file to anyone of us. Unless we have the same system setup as
|
|
you, we cannot do much with it. Instead, we ask you to get a stack trace and
|
|
send that (much smaller) output to us instead.
|
|
|
|
The address and how to subscribe to the mailing lists are detailed in the
|
|
`MANUAL.md` file.
|
|
|
|
## libcurl problems
|
|
|
|
When you have written your own application with libcurl to perform transfers,
|
|
it is even more important to be specific and detailed when reporting bugs.
|
|
|
|
Tell us the libcurl version and your operating system. Tell us the name and
|
|
version of all relevant sub-components like for example the SSL library
|
|
you are using and what name resolving your libcurl uses. If you use SFTP or
|
|
SCP, the libssh2 version is relevant etc.
|
|
|
|
Showing us a real source code example repeating your problem is the best way
|
|
to get our attention and it greatly increases our chances to understand your
|
|
problem and to work on a fix (if we agree it truly is a problem).
|
|
|
|
Lots of problems that appear to be libcurl problems are actually just abuses
|
|
of the libcurl API or other malfunctions in your applications. It is advised
|
|
that you run your problematic program using a memory debug tool like valgrind
|
|
or similar before you post memory-related or "crashing" problems to us.
|
|
|
|
## Who fixes the problems
|
|
|
|
If the problems or bugs you describe are considered to be bugs, we want to
|
|
have the problems fixed.
|
|
|
|
There are no developers in the curl project that are paid to work on bugs.
|
|
All developers that take on reported bugs do this on a voluntary basis. We do
|
|
it out of an ambition to keep curl and libcurl excellent products and out of
|
|
pride.
|
|
|
|
Please do not assume that you can just lump over something to us and it then
|
|
magically gets fixed after some given time. Most often we need feedback and
|
|
help to understand what you have experienced and how to repeat a problem.
|
|
Then we may only be able to assist YOU to debug the problem and to track down
|
|
the proper fix.
|
|
|
|
We get reports from many people every month and each report can take a
|
|
considerable amount of time to really go to the bottom with.
|
|
|
|
## How to get a stack trace
|
|
|
|
First, you must make sure that you compile all sources with `-g` and that you
|
|
do not 'strip' the final executable. Try to avoid optimizing the code as well,
|
|
remove `-O`, `-O2` etc from the compiler options.
|
|
|
|
Run the program until it cores.
|
|
|
|
Run your debugger on the core file, like `<debugger> curl core`. `<debugger>`
|
|
should be replaced with the name of your debugger, in most cases that is
|
|
`gdb`, but `dbx` and others also occur.
|
|
|
|
When the debugger has finished loading the core file and presents you a
|
|
prompt, enter `where` (without quotes) and press return.
|
|
|
|
The list that is presented is the stack trace. If everything worked, it is
|
|
supposed to contain the chain of functions that were called when curl
|
|
crashed. Include the stack trace with your detailed bug report, it helps a
|
|
lot.
|
|
|
|
## Bugs in libcurl bindings
|
|
|
|
There are of course bugs in libcurl bindings. You should then primarily
|
|
approach the team that works on that particular binding and see what you can
|
|
do to help them fix the problem.
|
|
|
|
If you suspect that the problem exists in the underlying libcurl, then please
|
|
convert your program over to plain C and follow the steps outlined above.
|
|
|
|
## Bugs in old versions
|
|
|
|
The curl project typically releases new versions every other month, and we
|
|
fix several hundred bugs per year. For a huge table of releases, number of
|
|
bug fixes and more, see: https://curl.se/docs/releases.html
|
|
|
|
The developers in the curl project do not have bandwidth or energy enough to
|
|
maintain several branches or to spend much time on hunting down problems in
|
|
old versions when chances are we already fixed them or at least that they have
|
|
changed nature and appearance in later versions.
|
|
|
|
When you experience a problem and want to report it, you really SHOULD
|
|
include the version number of the curl you are using when you experience the
|
|
issue. If that version number shows us that you are using an out-of-date curl,
|
|
you should also try out a modern curl version to see if the problem persists
|
|
or how/if it has changed in appearance.
|
|
|
|
Even if you cannot immediately upgrade your application/system to run the
|
|
latest curl version, you can most often at least run a test version or
|
|
experimental build or similar, to get this confirmed or not.
|
|
|
|
At times people insist that they cannot upgrade to a modern curl version, but
|
|
instead, they "just want the bug fixed". That is fine, just do not count on us
|
|
spending many cycles on trying to identify which single commit, if that is
|
|
even possible, that at some point in the past fixed the problem you are now
|
|
experiencing.
|
|
|
|
Security wise, it is almost always a bad idea to lag behind the current curl
|
|
versions by a lot. We keep discovering and reporting security problems
|
|
over time see you can see in [this
|
|
table](https://curl.se/docs/vulnerabilities.html)
|
|
|
|
# Bug fixing procedure
|
|
|
|
## What happens on first filing
|
|
|
|
When a new issue is posted in the issue tracker or on the mailing list, the
|
|
team of developers first needs to see the report. Maybe they took the day off,
|
|
maybe they are off in the woods hunting. Have patience. Allow at least a few
|
|
days before expecting someone to have responded.
|
|
|
|
In the issue tracker, you can expect that some labels are set on the issue to
|
|
help categorize it.
|
|
|
|
## First response
|
|
|
|
If your issue/bug report was not perfect at once (and few are), chances are
|
|
that someone asks follow-up questions. Which version did you use? Which
|
|
options did you use? How often does the problem occur? How can we reproduce
|
|
this problem? Which protocols does it involve? Or perhaps much more specific
|
|
and deep diving questions. It all depends on your specific issue.
|
|
|
|
You should then respond to these follow-up questions and provide more info
|
|
about the problem, so that we can help you figure it out. Or maybe you can
|
|
help us figure it out. An active back-and-forth communication is important
|
|
and the key for finding a cure and landing a fix.
|
|
|
|
## Not reproducible
|
|
|
|
We may require further work from you who actually see or experience the
|
|
problem if we cannot reproduce it and cannot understand it even after having
|
|
gotten all the info we need and having studied the source code over again.
|
|
|
|
## Unresponsive
|
|
|
|
If the problem have not been understood or reproduced, and there is nobody
|
|
responding to follow-up questions or questions asking for clarifications or
|
|
for discussing possible ways to move forward with the task, we take that as a
|
|
strong suggestion that the bug is unimportant.
|
|
|
|
Unimportant issues are closed as inactive sooner or later as they cannot be
|
|
fixed. The inactivity period (waiting for responses) should not be shorter
|
|
than two weeks but may extend months.
|
|
|
|
## Lack of time/interest
|
|
|
|
Bugs that are filed and are understood can unfortunately end up in the
|
|
"nobody cares enough about it to work on it" category. Such bugs are
|
|
perfectly valid problems that *should* get fixed but apparently are not. We
|
|
try to mark such bugs as `KNOWN_BUGS material` after a time of inactivity and
|
|
if no activity is noticed after yet some time those bugs are added to the
|
|
`KNOWN_BUGS` document and are closed in the issue tracker.
|
|
|
|
## `KNOWN_BUGS`
|
|
|
|
This is a list of known bugs. Bugs we know exist and that have been pointed
|
|
out but that have not yet been fixed. The reasons for why they have not been
|
|
fixed can involve anything really, but the primary reason is that nobody has
|
|
considered these problems to be important enough to spend the necessary time
|
|
and effort to have them fixed.
|
|
|
|
The `KNOWN_BUGS` items are always up for grabs and we love the ones who bring
|
|
one of them back to life and offer solutions to them.
|
|
|
|
The `KNOWN_BUGS` document has a sibling document known as `TODO`.
|
|
|
|
## `TODO`
|
|
|
|
Issues that are filed or reported that are not really bugs but more missing
|
|
features or ideas for future improvements and so on are marked as
|
|
*enhancement* or *feature-request* and get added to the `TODO` document and
|
|
the issues are closed. We do not keep TODO items open in the issue tracker.
|
|
|
|
The `TODO` document is full of ideas and suggestions of what we can add or
|
|
fix one day. You are always encouraged and free to grab one of those items and
|
|
take up a discussion with the curl development team on how that could be
|
|
implemented or provided in the project so that you can work on ticking it odd
|
|
that document.
|
|
|
|
If an issue is rather a bug and not a missing feature or functionality, it is
|
|
listed in `KNOWN_BUGS` instead.
|
|
|
|
## Closing off stalled bugs
|
|
|
|
The [issue and pull request trackers](https://github.com/curl/curl) only hold
|
|
"active" entries open (using a non-precise definition of what active actually
|
|
is, but they are at least not completely dead). Those that are abandoned or
|
|
in other ways dormant are closed and sometimes added to `TODO` and
|
|
`KNOWN_BUGS` instead.
|
|
|
|
This way, we only have "active" issues open on GitHub. Irrelevant issues and
|
|
pull requests do not distract developers or casual visitors.
|