Commit Graph

54 Commits

Author SHA1 Message Date
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
Jelle Meeus
e8af1aaffc fix(Scripts/Spells): warlock seed of corruption (#19322)
* remove seed of corruption handling in unit.cpp

* add generic and warlock aurascript

add warlock  aurascript

add enum

add generic aurascript

add OnRemove

2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)

detonation threshold scaling added in: df5afca278

Co-authored-by: ariel- <ariel-@users.noreply.github.com>

* add LoS check to generic damage

* refactor 2 scripts to 1 with args

refactor const_cast to GetAura()->GetEffect(

refactor reduce a line

* fix detonation threshold scaling

changed SPELL_DIRECT_DAMAGE to DOT

* remove not needed IsExpired() check

removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE

* update comment

* refactor script with args to single spellscript, fix detonate by evade

* refactor

detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged

* refactor to 2 spell scripts again

* rename detonation spell from seed_of_corruption to seed_of_corruption_damage

avoids confusion with seed of corruption (with dot effect)

---------

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
2024-07-17 01:50:38 +02:00
Jelle Meeus
a69d02e513 fix(Scripts/Spells): warlock demonic pact (#19386)
* add Demonic Pact Aura script

2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)

Co-authored-by: ariel- <ariel-@users.noreply.github.com>

* spell_warlock aura:spell_warl_demonic_pact_aura

* fixup! spell_warlock aura:spell_warl_demonic_pact_aura

* remove not needed spell correction, flag is already set

* subtract current proc bonus before calculating new bonus

* also increase healing done

* remove Demonic Pact handling in Unit

* refactor indent, remove bonus from spell group effects e.g. totem of wrath

* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"

This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.

* refactor indent

* manually set proc cooldown

---------

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
2024-07-13 12:38:59 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
avarishd
a39175bc3b fix(Core/Spells): Demonic Knowledge missing 1% per rank (#17495) 2023-10-18 19:21:46 -03:00
avarishd
e8b81430af fix(Core/Spells): Script Void Star Talisman resistances. (#17427)
* fix(Core/Spells): Script Void Star Talisman resistances.

* add check for armor

* change comment loc

* .

* fix(Core/Spells): Script Lord Valthalak's Amulet

* Revert "fix(Core/Spells): Script Lord Valthalak's Amulet"

This reverts commit 5a6a0a8e1fd596e0ffae906cfdac2f68fb1bc78d.

* Use spellInfo instead of hardcode
2023-10-10 13:12:11 -03:00
Skjalf
c7b7b7dc07 fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet (#17342)
* fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet

* Update src/server/game/Entities/Pet/Pet.cpp
2023-09-25 08:07:09 -03:00
Tereneckla
88d31a1a71 fix (Core/Spells) Correct Life Tap mana gain and cleanup (#15278) 2023-03-11 19:28:12 -03:00
UltraNix
ae84bf67c4 fix(Core/Spells): Fixed Glyph of Kilrogg. (#13802)
Fixes #13623
2022-11-16 01:26:05 -03:00
Angelo Venturini
ad4ce0895f fix: Qaston revert (#13320)
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271)"

This reverts commit e05f61d1b3.

* Revert "fix(Core): Crash (#13292)"

This reverts commit a818bcf3e2.

* Revert "fix: Crash (#13241)"

This reverts commit be423a91b5.

* delete sql

* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079)"

This reverts commit cbd3fd0967.

* add sql revert

* fix sql

* remove update from world.updates
2022-10-05 21:53:20 +02:00
Angelo Venturini
be423a91b5 fix: Crash (#13241) 2022-10-03 16:14:43 -03:00
IntelligentQuantum
cbd3fd0967 refactor(Core/Spells): Implement QAston Proc System (#11079)
* .

* sql

* .

* .

* 1

* 2

* 3

* 4

* 5

* 6

* 7

* 8

* 9

* 10

* 11

* 12

* 13

* 14

* 15

* Update spell_item.cpp

* Update Unit.cpp

* 16

* 17

* 18

* 19

* 20

* 21

* Update Unit.cpp

* REVERT UltraNIX Commit

* 22

* 23

* .

* .

* .

* warrior

* warlock

* shaman rogue priest paladin mage

* spell item

* hunter

* druid

* dk

* war

* error style

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* .

* DOND DEL ME WAD DO DO

* error 2

* .

* .

* .

* FIX

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp

* .

* ja genau

* Update .gitignore

* .

* .

* .,

* .

* .

* .

* .

* Update Unit.cpp
2022-10-02 19:39:34 +02:00
Maelthyr
1f472bddd3 refactor(Core/Combat): Code style and improvement of ThreatMgr (#12992) 2022-09-25 15:20:34 -03:00
UltraNix
b81a14976c fix(Scripts/Spells): Glyph of Felguard. (#12497)
* fix(Scripts/Spells): Glyph of Felguard.

Fixes #12432

* Update.
2022-07-24 13:38:03 -03:00
UltraNix
fed8d51044 fix(Scripts/Spells): Shadowburn should give Sould Shard only if targe… (#12030)
...t yields experience/honor to the player.

Fixes #12021
2022-06-14 19:42:55 -03:00
Maelthyr
c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00
UltraNix
4511cf5751 fix(Core/Spells): Seed of Corruption detonation should obey LoS (#10916)
- Source: TrinityCore
- Closes #4521
2022-03-18 13:05:20 +01:00
Kargatum
5969df4e30 refactor(Core/Logging): switch to fmt style for LOG_ (#10366)
* feat(Core/Common): add support fmt style for ASSERT and ABORT

* correct CheckCompactArrayMaskOverflow

* 1

* Update src/server/game/Spells/Spell.cpp

* rework logging

* add fmt replace logs

* logging

* FMT_LOG_

* settings

* fix startup

* 1

* 2

* 3

* 4

* 5

* fmt::print

* to fmt
2022-01-27 16:44:41 +01:00
UltraNix
e1617a0044 fix(Core/Spells): Restored special Rolling DoTs mechanic for Corruption and SW:Pain (#10206)
Fixes #9867
2022-01-21 13:39:11 -03:00
UltraNix
16cac81e5a fix(Scripts/Spells): Drain Soul generates Soul Shard only from targets that yields experience or honor on death. (#9417)
Fixes #9083
2021-12-05 19:53:14 -03:00
Kargatum
f62664c987 refactor(Core/Misc): headers cleanup (#9259) 2021-11-22 17:24:39 +07:00
Nefertumm
61c7488698 fix(Core/Spells): possible crashes within class spells (#9168) 2021-11-21 11:41:51 -03:00
Kitzunu
03c84db04d fix(Script/Spells): Validate Warlock spells (#9181) 2021-11-14 01:48:16 -03:00
Kitzunu
7c1fb0b088 refactor(Scripts/Spells): convert spell_warlock into new system (#9066) 2021-11-09 11:45:43 +01:00
Skjalf
1e57b6fb99 fix(Core/Spells): add several missing null checks for the DamageInfo struct to fix a crash (#8322) 2021-10-10 16:07:14 +02:00
Skjalf
99cc428511 fix(Core/Spells): Improved Drain Soul triggering from every target … (#8144)
...that dies and not just the one affected by Drain Soul and move the Drain Soul code to spell scripts

- TC Ports: d9743c984f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec) and  2b1b36f561 (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
2021-10-07 18:58:46 +02:00
Kargatum
52aa0e9966 feat(License): add new headers information about license (#7941)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2021-09-30 13:40:52 +07:00
IntelligentQuantum
fec27d8d8a fix(Core/Spell): Warlock Banish (#7832) 2021-09-16 17:10:54 +02:00
Kitzunu
2f449326e0 refactor(Core): Rename ...Manager to ...Mgr (#6910)
* Rename MapManager.h to MapMgr.h

* Rename BanManager.h to BanMgr.h

* Rename MapManager.cpp to MapMgr.cpp

* Rename BanManager.cpp to BanMgr.cpp

* Rename MapRefManager.h to MapRefMgr.h

* Rename ThreatManager.h to ThreatMgr.h

* Rename GridRefManager.h to GridRefMgr.h

* Rename ThreatManager.cpp to ThreatMgr.cpp

* Rename GroupRefManager.h to GroupRefMgr.h

* Rename HostileRefManager.h to HostileRefMgr.h

* Rename HostileRefManager.cpp to HostileRefMgr.cpp

* Rename MMapManager.h to MMapMgr.h

* Rename FollowerRefManager.h to FollowerRefMgr.h

* Rename VMapManager2.h to VMapMgr2.h

* Rename IVMapManager.h to IVMapMgr.h

* Rename MMapManager.cpp to MMapMgr.cpp

* Rename VMapManager2.cpp to VMapMgr2.cpp

* Rename RefManager.h to RefMgr.h

* Rename WaypointManager.h to WaypointMgr.h

* Rename WaypointManager.cpp to WaypointMgr.cpp

* Rename MPQManager.h to MPQMgr.h

* Rename MPQManager.cpp to MPQMgr.cpp

* Rename IMMAPManager.h to IMMAPMgr.h

* fix build

* Update Main.cpp

* chore(Core/Misc): Remove toxic language

* Revert "chore(Core/Misc): Remove toxic language"

* fix build

* build
2021-09-15 17:50:28 +02:00
Viste
a9796af174 fix(Core/Misc): bunch of crashfixes (#7307) 2021-09-14 14:38:56 +02:00
UltraNix
45218224b4 fix(Core/Spells): show Execute/Slam misses/dodges/parries in combat log (#7494)
- Closes #7428.
2021-08-26 11:45:22 +02:00
Francesco Borzì
f73ef1cd5a fix(Core/Unit): -Wdeprecated-enum-enum-conversion warning (#6868) 2021-07-13 11:51:58 +02:00
Kargatum
5787d00d54 chore(Core/Logging): replace most server loggers (#5726)
* chore(Core/Logging): replace most server loggers

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-06-21 03:07:12 +02:00
Kitzunu
a75e34c793 feat(Core/Spell): AssertSpellInfo (#6115)
* feat(Core/Spell): AssertSpellInfo

(cherry picked from commit e52878b6b5)
(cherry picked from commit 8c44259fae)
Co-Authored-By: Shauren <shauren.trinity@gmail.com>
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>

* Update SpellMgr.h
2021-06-03 07:39:48 +02:00
UltraNix
f4c226423d feat(Core/Misc): implement ObjectGuid class (port from TC) (#4885) 2021-04-25 22:18:03 +02:00
Kargatum
4af4cbd3d9 feat(Core/Logging): rework logging (#4692)
* feat(Core/Logging): rework logging

* correct level for sql.sql

* del unused config options

* Correct build

* correct after merge

* whitespace

20:29:37 1. 'Player.cpp'. Replace (1)
20:29:37 2. 'ObjectMgr.cpp'. Replace (3)

* 1

* correct logging

* correct affter merge

* 1

* 2

* LOG_LEVEL_WARN

* #include "AppenderDB.h"

* 3

* 4

* 5

* 1. 'WorldSocket.cpp'. Replace (1)

* 6

* 1
2021-04-17 11:20:07 +02:00
Francesco Borzì
f6a17164be fix(Core/License): issue with old files license (#4762) 2021-03-17 09:46:01 -06:00
Kitzunu
28f1dc5c0c refactor(Core): replace NULL with nullptr (#4593) 2021-03-02 01:34:20 +01:00
Kitzunu
dbc0ff6554 refactor(Core): sort #includes alphabetically (#4579) 2021-02-24 22:34:42 +01:00
Stifler82
d7981de01e fix(Core/Spell): solve issue with Life Tap All Ranks (#4408) 2021-02-11 15:08:27 +01:00
Kitzunu
0d52b4ca4a feat(Core/Spell): Implement ValidateSpellInfo (#4323)
* feat(Core/Spell): Implement ValidateSpellInfo

* cherry-pick from 2b5d7eef3a & a0a158b5b8

* sLog->outError

* cleanup

* convert to ValidateSpellInfo

* fix error log

* improve sLog->outError

* remove non related spells stuff from Validate

* remove the last

* build

* build x2
2021-02-01 18:57:25 +01:00
Francesco Borzì
d4a58700d4 refactor(Core): apply clang-tidy modernize-use-override (#3817) 2020-12-06 18:04:55 +01:00
Kargatum
5e20b46812 refactor(Core/Scripts): restyle scripts lib with astyle (#3467) 2020-10-11 10:35:34 +02:00
Kitzunu
1f89282b22 refactor(Core): NULL -> nullptr (#3275)
* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 11:55:09 +02:00
Poszer
41486e348b fix(Core/Spells): Spell ID Shadow Ward (Warlock) (#1971)
- Set correct ID of warlock spell Shadow Ward. It was set to -7235(Shadow Protection) which is wrong
- Correct spellID is 6229 (Shadow Ward)
2019-06-17 19:09:17 +02:00
talamortis
1fd6b4cff5 [Core / Spell ] Warlock Life Tap
Fixed an issue where warlock could kill itself using max rank till fizzled and then low rank.
2018-10-27 21:03:34 +01:00
d3tr0l
4f2c6fcc31 [Core/Script] Fixed the amount of mana gained from Life tap
Patch 3.3.3: Life Tap: This spell no longer scales with spirit, and instead scales with spell power.
2018-09-20 19:18:27 +01:00
talamortis
e715dd3f61 Core/Script: Warlock lifetap's damage
Fixed warlocks Lifetap todo the same damage as displayed on tooltip.
2018-09-20 18:24:38 +01:00
Nefertumm
dd300003e2 Update license links (#783) 2018-03-12 10:54:57 +01:00