Commit Graph

2395 Commits

Author SHA1 Message Date
天鹿
f05200fcca feat(Core/Scripts): Optimize AuctionHouseScript need#18672 (#18698)
Add files via upload
2024-04-11 17:10:02 -03:00
天鹿
33592f93cf feat(Core/Scripts): Optimize ArenaTeamScript need#18672 (#18699)
Add files via upload
2024-04-11 17:09:47 -03:00
天鹿
e28a432fa2 feat(Core/Scripts): Optimize ArenaScript need#18672 (#18700)
Add files via upload
2024-04-11 17:09:32 -03:00
天鹿
bcf1ffa9f5 feat(Core/Scripts): Optimize MovementHandlerScript need#18672 (#18701)
* Add files via upload

* Add files via upload
2024-04-11 17:09:17 -03:00
天鹿
83c4382c70 feat(Core/Scripts): Optimize AccountScript need#18672 (#18697)
Add files via upload
2024-04-11 17:09:02 -03:00
Anton Popovichenko
f792b0d708 feat(Core/Scripts): Optimize PlayerScripts by calling only overridden/implemented functions. (#18672)
* feat(Core/Scripts): Optimize PlayerScripts by calling only overridden/implemented functions.

* Fix codestyle.

* Fix typo

* PLAYERHOOK_END is not a hook

* Address code review feedback.

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>

* Codestyle fixes

* Fix typo



Co-authored-by: PkllonG

---------

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>
2024-04-11 17:08:30 -03:00
Johaine
3a93ae1af1 feat(Core/Optimization): Correctly document sendBuffer size and optimize it. (#18647)
* Fix comment documenting WorldSocket

The buffer is constructed with 4096 bytes but later resized in
WorldSocketThread::SocketAdded() according to the configuration
setting Network.OutUBuff (currently 65536 bytes)

* Reuse calculated packet size

Instead of recalculating the current packet size three times at
worst, calculate it once and reuse it when required.

* Reduce reserved buffer size per WorldSocket

Don't reserve 64kB of memory for every WorldSocket's output
buffer.

Instead, start with a 4kB baseline for every WorldSocket and grow
the buffer size dynamically when we have single packets that do
not fit the current buffer.
2024-04-06 10:22:32 -03:00
Anton Popovichenko
f7f1952f4b fix(Core/Player): Fix memory leak. (#18671) 2024-04-05 07:04:55 -03:00
Anton Popovichenko
1f640c9872 feat(Core/Optimization): Optimize build of units update object by leveraging cache (#18637)
* feat(Core/Optimization): Optimize build of units update object by leveraging cache.

* Remove whitespaces.

* Add alternative hooks to handle transmog and other similar things.

* Fix build on some compilers.

* Fix codestyle

* Fix build again.

* Take into account updateType.
2024-04-05 08:03:11 +02:00
sudlud
94df67b1c2 fix(Core/Battleground): correctly limit Eye of the Storm max points to 1600 (#18669)
- before the max points could exceed 1600 on winning which e.g.
  resulted in the achievement 'The Perfect Storm' not beeing
  triggered correctly
2024-04-04 18:29:34 -03:00
Anton Popovichenko
47f9d66874 feat(Core/Optimization): Create index for sSkillLineAbilityStore to speedup search by skillLine. (#18622)
* feat(Core/Optimization): Create index for sSkillLineAbilityStore to speedup search by skillLine.

* Remove whitespace.
2024-04-01 05:50:12 -03:00
Anton Popovichenko
aee2eefb92 feat(Core/Optimization): Reduce CPU consumption by allocating sendBuffer only when it is needed. (#18628)
* feat(Core/Optimization): Reduce CPU consumption by allocating the sendBuffer only when it is needed.

* Remove whitespaces.
2024-04-01 05:49:42 -03:00
Dan
a870173558 fix(Scripts/BossAI): add optional variable to BossAI class to make sure the boss calls for help (#18630)
init
2024-03-30 11:31:41 -03:00
Anton Popovichenko
73340b94e3 feat(Core/Compression): Move packets compression from map to network thread (#18602)
* feat(Code/Compression): Move packets compression from map to network thread.

* Code style fix

* Remove unicode letter
2024-03-28 08:57:29 -03:00
Elmsroth
b1cf830009 chore(PlayerScript/Hook) : Add CanSetTradeItem Hook in PlayerScript (#18583)
* chore(PlayerScript/Hook) : Add CanSetTradeItem Hook in PlayerScript

* Allowing non traded slots

* Fix typo and codestyle
2024-03-26 21:28:37 -03:00
silviu20092
5b8bc792b8 feat(core): account delete hook (#18605)
Add account delete hook
2024-03-26 20:57:42 -03:00
skelUA
1a537236a8 fix(Core/Spell): Fix spell 35329 (Vibrant Blood) (#18587) 2024-03-20 05:01:57 -03:00
Mykhailo Redko
33f951d742 fix(Core/Spells): Fixed work of sobering spells and other improvements for drunk system (#18390)
* fix(Core/Spells): Fix sobering spells and possible uint8 overflow/underflow in SPELL_EFFECT_INEBRIATE handler.

* fix(Core/Spells): Improvements for SPELL_AURA_MOD_FAKE_INEBRIATE handling
2024-03-20 01:45:01 -03:00
skelUA
0c964dadae fix (Core/Scripting): SMART_EVENT_NEAR_PLAYERS (#18514)
* FIX SMART_EVENT_NEAR_PLAYERS

* FIX SMART_EVENT_NEAR_PLAYERS (fix build)
2024-03-20 01:38:57 -03:00
Gultask
b69df485cf fix(DB/BlackTemple): Rework Black Temple (#18569)
* init

* more

* Update rev_1710358311839208100.sql
2024-03-18 22:31:05 +01:00
Dan
42c41525de fix(Scripts/TheEye): increase dagger proc chance and make sure mind control only targets players (#18563) 2024-03-16 17:28:40 -03:00
Walter Pagani
64f372fca3 chore. Avoid failures in the tests of custom items (#18519)
* chore. Avoid failures in the tests of custom items

* Report error but continue with the rest of the item

* change LOG_ERROR for LOG_DEBUG
2024-03-15 20:09:10 -03:00
Elmsroth
ab02c36e67 feat(Scripts/Commands): Implement ".reset items" command (#18393)
Syntax : .reset items equiped|bags|bank|keyring|currency|vendor_buyback|all|allbags #playername
Delete items in the player inventory (equiped, bank, bags etc...) depending on the chosen option.
#playername : Optionnal target player name (if player is online only). If not provided the command will execute on the selected target player.


Update src/server/scripts/Commands/cs_reset.cpp

Accepted

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Update data/sql/updates/pending_db_world/rev_1708782048020249700.sql

Accepted

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Update data/sql/updates/pending_db_world/rev_1708782048020249700.sql

Accepted

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Update src/server/game/Miscellaneous/Language.h

Accepted

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
fix uint16 vs uint16_t


fix crash and code cleanup

Fix typo

sql fix

Missing typo

selected instead or selecter

AC code style fix

Re-Fix typos

MISSING typos

missing typos
2024-03-15 10:23:31 -03:00
Andrew
3bcdc4d23e fix(Core/Spells): Domination affect max 5 targets (#18555) 2024-03-15 08:20:51 +01:00
Walter Pagani
7a7ea27293 fix(SpellInfoCorrections) Raid buffs should ignore LoS (#18518) 2024-03-15 01:20:36 -03:00
sudlud
307c1ab09d refactor(Core): remove some unused variables (#18538)
- let's get rid of some compiler warnings
2024-03-13 06:52:43 -03:00
sudlud
bf17d93727 fix(Core/PVP): Fix OutDoorPVP CustomSpell handling (#18389)
* fix(Core/PVP): Fix OutDoorPVP CustomSpell handling

- the function HandleCustomSpell() should only return
  true if it actually handled a spell

* comment unused parameter
2024-03-10 15:35:29 +01:00
skelUA
da453b2a8d fix(Core/SmartScripts): LOS check spell for SmartScipts (#18501)
* Fix spell 35329 (Vibrant Blood)

* [PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)

* Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"

This reverts commit 2eaeb78bdee5b09f1ea5685a9b039f9221df4abe.

* Revert "Fix spell 35329 (Vibrant Blood)"

This reverts commit 0e7ee59588709050e2af9cc15e8ff1ed358936b2.

* Revert "Revert "Fix spell 35329 (Vibrant Blood)""

This reverts commit 5e4424b4d81ec3c1de1d6f73e48d848e63e92b79.

* Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)""

This reverts commit b3a9553a45e81f65b2eb15f127c5ca9eb99b6d1e.

* Revert "Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"""

This reverts commit 0ced477c767b9087eefdf516d0e0fccf1567e6e3.

* Revert "Revert "Revert "Fix spell 35329 (Vibrant Blood)"""

This reverts commit a8da732cfb4369f218e96175fc8f33eafc1e69c9.

* Revert "Revert "Fix spell 35329 (Vibrant Blood)""

This reverts commit 5e4424b4d81ec3c1de1d6f73e48d848e63e92b79.

* Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)""

This reverts commit b3a9553a45e81f65b2eb15f127c5ca9eb99b6d1e.

* Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"

This reverts commit 2eaeb78bdee5b09f1ea5685a9b039f9221df4abe.

* Revert "Fix spell 35329 (Vibrant Blood)"

This reverts commit 0e7ee59588709050e2af9cc15e8ff1ed358936b2.

* FIX LOS SAI
2024-03-08 11:15:45 -03:00
Dan
1c8644b3bc fix(Scripts/TheEye): make legendary TK dagger have 100% proc chance (#18482)
initial
2024-03-04 10:44:35 +01:00
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Anton Popovichenko
34598bfccf feat(Core/UpdateTime): Improve diff time measurement. (#18387)
* feat(Core/UpdateTime): Improve diff time measurement.

* Codestyle fixes
2024-02-25 12:08:15 -03:00
Dan
4fcd3402ca fix(Core/SmartAI): implement param maxCount for SMART_TARGET_PLAYER_RANGE (#18394)
* init

* conditional
2024-02-25 11:50:07 -03:00
Elmsroth
729a1ff539 fix(Crash/Quest/Spell) : The Boon of Remulos (#18379)
Fix the spell : https://www.wowhead.com/wotlk/spell=57678/emerald-acorn-effect
Used in quest : https://www.wowhead.com/wotlk/quest=13075/the-boon-of-remulos

The crashed was caused by a nullptr Excception. It also could be throuwn in another similar test that has also been fixed.
If the spell did not have a CastTimeEntry a nullptr Exception was not checked.
2024-02-22 22:40:26 -03:00
sudlud
d94d10aa9f fix(Core): Prevent gift wrapping of limited duration items (#18334)
fix(Core): Prevent gift wrapping of items with duration

- remaining duration is not beeing stored in character_gifts
- gift wrapping of items with duration preserved
  them infinitely
2024-02-19 21:23:13 +01:00
sudlud
7e419fba5a fix(Core/Guild): Prevent swapping limited duration items into guild bank (#18335) 2024-02-19 21:22:51 +01:00
Mykhailo Redko
86bff27611 fix(Core/GameObject): Remove unneeded ClearGossipMenuFor call (#18331) 2024-02-18 11:21:52 +01:00
Anton Popovichenko
72e75982be fix(Core/Taxi): Fixes crash when player logins and continues flight (#18270)
* fix(Core/Taxi): Fixes crash when player logins and continue flight

* Update WaypointMovementGenerator.cpp
2024-02-12 08:18:05 -03:00
AnchyDev
1d8c4056b3 feat(Core/Hooks): Add the KillRewarder reference to the OnRewardKillRewarder hook. (#18290)
* Another hackfix attempt at warden payload forcechecks ban fix.

* Revert last commit, interrupt all forcechecks instead of just _dataSent ones.

* Add rewarder parameter to OnRewardKillRewarder hook.

* Undo old warden changes.

* Removed too much!
2024-02-10 21:58:49 +01:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Nathan Handley
425a490a7b feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType (#18293)
* Create HasActivePower for script intercept

* Replace relevant player-related getPowerType() comparators with HasActivePowerType

* Change OnPlayerHasActivePowerType to regular bool instead of optional

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-09 06:27:02 -03:00
Kalimist
1324f420f2 Fix(Core/CharacterHandler): Incorrect behavior using an equipment set… (#18253)
* Fix(Core/CharacterHandler): Incorrect behavior using an equipment set if it will result in a full inventory.

* Fixing the error message to -Equiment swap failed - inventory is full- like the Blizzlike error message
2024-02-03 14:34:33 +01:00
3ster
000ec142a2 Check if triggered spell has cast time (#18231)
* Check if triggered spell has cast time

* Fix client crash upon manually cancelling finished spell
2024-02-03 11:52:34 +01:00
Benjamin Jackson
b6c429c5a8 fix(Core/Quests): Create quest money reward config and adjust max level bonus reward function. (#18222)
* Init.

* Drop RewardBonusMoney column.

How's that for deprecation.

* Add formula source link.

* Remove deprecated info in conf.

* Newline.
2024-01-31 23:21:27 +01:00
Kitzunu
69dc8804e6 feat(Core/Spell): Add helper for TriggeredCastFlag (#18227)
* feat(Core/Spell): Add helper for TriggeredCastFlag

* Lol

* fix build
2024-01-26 13:51:42 +01:00
Flashaholic88
c18bd64136 fix(Core/Misc): typo (#18221) 2024-01-23 21:38:32 +01:00
sudlud
e447351b0f fix(Core/Creature): Remove automated z spawn correction (#18200)
* fix(Core/Creature): Remove automated z spawn correction

* comment out unused parameter

* remove gridLoad parameter from Creature::LoadCreatureFromDB()
2024-01-21 07:33:00 -03:00
Tereneckla
4cfad0ffac fix (Core/Unit) Apply Capacitor cooldown on trigger proc instead of on stack add (#18189)
fix capacitor cooldown
2024-01-20 08:51:49 -03:00
Pedro Antonio
2c7c3b6832 fix(CORE/OPvP): Halaa Mechanics not working properly (#15634) 2024-01-14 14:00:53 -03:00
sudlud
1785df7117 fix(Core/Player): Fix Player not starting at full health (#18136)
* fix(Core/Player): Fix Player not starting at full health

* remove first call to UpdateMaxHealth() and SetFullHealth()
2024-01-14 11:07:52 -03:00
Nathan Handley
4321b8a4de feat(Core/Scripting): Implement new hook OnBeforePlayerLogout() (#18163)
* new hook OnPlayerPreLogout

* Changed PreLogout to BeforeLogout per review

* Renamed OnPlayerBeforeLogout to OnBeforePlayerLogout per review

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-01-14 00:10:49 +01:00