Commit Graph

143 Commits

Author SHA1 Message Date
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
AG
2779833768 feat(Core/Grids): Implement visibility notifier (#15919)
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
TuriansNotBad
89ba87495e fix(Core/Position): Normalize Position.GetRelativeAngle (#16825)
Normalize GetRelativeAngle

Normalize angle returned by both Position.GetRelativeAngle functions.
2023-09-17 21:35:34 +02:00
Skjalf
f5d0246292 feat(Core/Object): Add helper to allow removing allowed looters (#16709) 2023-07-08 21:45:06 -03:00
Skjalf
1a562948a6 fix(Core/Object): Permanently invisible creatures should be able to e… (#15498) 2023-03-20 13:16:58 -03:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix
14f3b444ae fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SU… (#14054)
* fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SUMMONER` summon flag.

Fixes #6674

* Update.
2023-01-06 00:52:05 +01:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
UltraNix
003bd93666 fix(DB/Conditions): Pint-Sized Pink Pachyderm and Wolpertinger should… (#13946)
fix(DB/Conditions): Pint-Sized Pink Pachyderm and Wolpertinger should be visible only to party members or drunk players.

Fixes #13900
2022-12-06 12:47:43 -03:00
UltraNix
3603f44dad fix(Core/Spells): FIxed calculating LoS for dynamic objects. (#13795)
Fixes #13777
2022-11-16 01:19:29 -03:00
UltraNix
ab9c648504 fix(Core/Movement): Removed some leftover after c8f43d8584. (#13524)
Closes #2623
2022-10-29 07:11:36 -03:00
Skjalf
ca9c19ffd4 feat(Core/GameObject): Add an overload to SummonGameObject() to accep… (#12821)
feat(Core/GameObject): Add an overload to SummonGameObject() to accept positions
2022-08-21 19:48:34 -03:00
Maelthyr
d0d1671745 feat(Core/Debug): GetDebugInfo implementation (#12705)
Cherry-pick: 9a924fb9d5

Co-authored-by: jackpoz <giacomopoz@gmail.com>

Co-authored-by: jackpoz <giacomopoz@gmail.com>
2022-08-15 09:43:41 -03:00
Maelthyr
2c7b274bc5 refactor(Core): Improve struct alignment and codestyle (#12335)
refactor(Core): improve struct alignment and codestyle
2022-07-10 14:19:11 -04:00
UltraNix
12a07ff91f fix(Core/Spells): Fixed LoS problems with hunter traps. (#12348)
* fix(Core/Spells): Fixed LoS problems with hunter traps.

Fixes #12332

* missing
2022-07-10 14:18:36 -04:00
UltraNix
a2bc0ae028 fix(Core/Objects): Include combat reach instead of object size in LoS… (#12013)
... calculations.

Fixed LoS calculations for dynamic objects.
Modified combat reach of Deep Pool Threshfin.
Fixes #11886
2022-06-13 01:03:06 -03:00
UltraNix
99f1cd84e2 fix(Core/Spells): Improvements to Far Sight spell: (#11683)
* fix(Core/Spells): Improvements to Far Sight spell:

Far Sight should not interrupt while casting another spell.
Corrected setting Far Sight object as an active object.
Fixed grid activation range for active dynamic objects.
When Far Sight is over, the camera be reset to player.
Enable swapping camera between Far Sight and Sentry Totem.
Fixes #6368

* Update.

* Update.
2022-05-23 04:26:51 -03:00
Kitzunu
969cb68c35 fix(Core/Auras): INVISIBILITY_UNK10 also applies the flag PLAYER_FIELD_BYTE… (#11588)
* ore/Auras: INVISIBILITY_UNK10 also applies the flag PLAYER_FIELD_BYTE2_INVISIBILITY_GLOW

* cherry-pick commit (230f40f359)

Co-Authored-By: Meji <2695278+meji46@users.noreply.github.com>

* Update Object.h

* Update Object.h

Co-authored-by: Meji <2695278+meji46@users.noreply.github.com>
2022-05-08 23:10:10 +02:00
IntelligentQuantum
659775548f feat(Core/SmartScripts): Add an action_param3 to "summon gob" to control when the object will despawn (#10254)
* cherry-pick commit (TrinityCore/TrinityCore@ca4f1e3)
2022-04-17 03:48:22 +02:00
UltraNix
47790c9714 fix(Core/Vmaps): Stop M2s from occluding for spellcast LoS. Original autho… (#11341)
* Core/Vmaps: Stop M2s from occluding for spellcast LoS. Original authors: @Shauren & @HelloKitty

Fixes #11293

* buildfix.

Co-Authored-By: HelloKitty <5829095+HelloKitty@users.noreply.github.com>
2022-04-10 09:24:35 -03:00
Kitzunu
285504e79d fix(Core/Object): Fix WorldObject::SetZoneScript unsafe cast to InstanceMap (#11226)
* cherry-pick commit (e9992066a5)

Co-Authored-By: HelloKitty <5829095+HelloKitty@users.noreply.github.com>

Co-authored-by: HelloKitty <5829095+HelloKitty@users.noreply.github.com>
2022-04-01 19:37:56 -03:00
Kitzunu
535c7451a2 feat(Core/Unit): New helpers for DynamicFlags (#11230)
* feat(Core/Unit): New helpers for DynamicFlags

* cherry-pick commit (d611925dc7)

Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* oopsie

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-04-01 07:14:29 -03:00
UltraNix
ccf7cf82d1 fix(Core/Objects): Fixed typo in m_visibilityDistanceOverride initialization (#11170)
Fixes #9870
Fixes #11127
2022-03-27 10:12:29 -04:00
IntelligentQuantum
7ad65752fa feat(Core/Maps): Improvements to Cinematic function (#10765) 2022-03-11 08:21:54 +01:00
acidmanifesto
69e2f2e3aa fix/feat: (Core/PacketIO): updated sound and creature addon (#10813)
* fix\feat: (Core/PacketIO): updated sound and creature addon

updated SMSG_PLAY_SOUND, SMSG_PLAY_MUSIC and SMSG_PLAY_OBJECT_SOUND via tc cherry pick
https://github.com/TrinityCore/TrinityCore/pull/2363 and 0f1f7ef401 by @joschiwald  and @ForesterDev
This so far a attempt to align atleast with sound with tc, and correct a potentional issue of hearing creature sounds that is not in visible range. I notice PlaySound was being defined in some weird dependency as it isnt with tc so I renamed it to Playsound. Notice a isLarge still being used in the creature addon when it was depreciated, so i removed that a that seem to of interfered with visibilitydistanceType.

Co-Authored-By: joschiwald <736792+joschiwald@users.noreply.github.com>
Co-Authored-By: ForesterDev <11771800+ForesterDev@users.noreply.github.com>
2022-02-26 10:05:58 -05:00
UltraNix
4509a36e91 fix(Core): Crashfix. (#10744)
Fixes #10601
Fixes #10733
2022-02-22 11:15:50 -05:00
Kitzunu
455899dc75 fix(Core/Misc): Change const to be after type name (#10591) 2022-02-14 16:05:45 -03:00
Kitzunu
cf65cd6baf refactor(Core/Misc): sqrt/log/exp() to std::sqrt/log/exp() (#9792) 2022-02-09 11:59:30 +01:00
Francesco Borzì
cfd9ebe107 fix(Core): macOS build (part 2) (#10586) 2022-02-08 12:41:31 +01:00
IntelligentQuantum
93520f6466 feat(Core/Position): own file (#10505) 2022-02-08 05:12:42 -03:00
Kitzunu
f4c6a4ce27 fix(Core/Misc): Remove c++ check for c++11 (#10439) 2022-02-04 19:00:33 +01:00
Kargatum
5969df4e30 refactor(Core/Logging): switch to fmt style for LOG_ (#10366)
* feat(Core/Common): add support fmt style for ASSERT and ABORT

* correct CheckCompactArrayMaskOverflow

* 1

* Update src/server/game/Spells/Spell.cpp

* rework logging

* add fmt replace logs

* logging

* FMT_LOG_

* settings

* fix startup

* 1

* 2

* 3

* 4

* 5

* fmt::print

* to fmt
2022-01-27 16:44:41 +01:00
Kargatum
8b7df23f06 feat(Core/Time): Implement saparated manager for game time (#8630) 2022-01-24 17:55:00 +07:00
Francesco Borzì
abc56842c4 refactor(Core): remove unused imports (#10296) 2022-01-22 11:21:35 +01:00
Kargatum
6d7f58e6ed feat(Core/Common): delete old Tokenizer (#10121) 2022-01-21 14:59:05 +07:00
Francesco Borzì
9dc88def35 refactor(Core): apply clang-tidy modernize-* (#9975)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2022-01-17 14:35:07 +01:00
Skjalf
fe4899202d feat(Core/Conditions): Implement CONDITION_SOURCE_CREATURE_VISIBILITY (#10208) 2022-01-17 06:05:32 -03:00
IntelligentQuantum
725b1266b4 refactor(Core/Packet): Chat (#9509)
* Chat

* .

* Update GameObject.cpp

* Update Object.cpp

* Update Player.cpp
2022-01-08 07:11:06 -03:00
Cláudio Costa
5d45c52c3e fix(Core/Creature): Fire Elemental Invasion changes (#9372)
* fix(DB): Blazing elemental invasion event

- Fixed Elemental Invader's SmartAI;
- Re-arranged Elemental Rifts SmartAI for controlled spawning of
  Invaders.

* SmartAI: SetCounter to be able to subtract

* Target unit or summoner changed for worldobjects

* extra checks and last sql file

* Codestyle

* codestyle

* adding Baron to elemental invasions

* changed owner or summoner target (SmartAI)

* codestyle
2022-01-06 19:30:23 +01:00
Kitzunu
cb7e355291 refactor(Core/Misc): sin() to std::sin() (#9795) 2022-01-06 19:29:40 +01:00
Kitzunu
317e793b12 refactor(Core/Misc): atan2() to std::atan2() (#9793)
- prefer std functions over C functions
2022-01-03 13:24:06 -03:00
Francesco Borzì
6d7b024deb fix(Core/Object): macOS build (#9968) 2022-01-02 09:08:33 -03:00
Kitzunu
913e65f97f refactor(Core/Misc): fabs() to std::fabs() (#9790)
- prefer std functions over C functions
2021-12-31 20:41:00 -03:00
Kitzunu
ac99eb48e1 refactor(Core/Misc): abs() to std::abs() (#9789) 2021-12-31 19:29:39 -03:00
Noxies
bbf08c1aaa fix(Core/TemporarySummon): Implement TEMPSUMMON_TIMED_DESPAWN_OOC_ALIVE (#9915) 2021-12-30 08:05:46 -03:00
Kitzunu
7617ae4645 refactor(Core/Misc): fmod() to std::fmod() (#9796)
- prefer std functions over C functions
2021-12-21 01:16:59 -03:00
Francesco Borzì
cbc7e5466a refactor(Core): remove unused imports (#9767) 2021-12-19 19:41:14 +01:00
Kargatum
51adbffae4 feat(Core/Modules): add separated lib for modules (#9281) 2021-12-02 20:28:58 +07:00