Commit Graph

143 Commits

Author SHA1 Message Date
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Anton Popovichenko
423b676802 fix(Scripts/IcecrownCitadel): Fix Sindragosa respawn (#18179)
Fix Sindragosa respawn
2024-01-16 08:37:05 -03:00
daobashun
bd296db80c fix(Scripts/IcecrownCitadel): Lich King Whispers uses localized languages (#18125) 2024-01-14 11:09:04 -03:00
IntelligentQuantum
4ec284577e chore(Scripts/Northrend): remove useless includes (#18061) 2023-12-25 02:15:56 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
qwe900
e8ccda12e4 fix(Scripts/ICC/Sindragosa) Airphase should not be forced after 50s if already in p2 (under 35%) (#17722)
* Update boss_sindragosa.cpp

* Update boss_sindragosa.cpp
2023-11-20 13:48:45 +01:00
KJack
3d20f8902b feat(Core/Instance): InstanceScript: create Remove functions (#17702)
InstanceScript: create `Remove` helper functions
2023-11-14 08:13:28 -03:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
KJack
632b55faa5 fix (Scripts/ICC): Make Valithria starting health dynamic, fix broken channeling spell (#17586)
* Make Valithria starting health dynamic based on actual max health

* Fix Risen Archmage broken spell channel and combat log spam
2023-10-25 18:53:00 -03:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Anton Popovichenko
f4658a1df2 fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. (#17070)
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.

* Fix build
2023-08-25 09:15:07 -03:00
UltraNix
c3acf75618 fix(Core/Spells): Taunt always set proper target while channelling sp… (#13948)
* fix(Core/Spells): Taunt always set proper target while channelling spells.

Fixes #13841

* Update.

* Update.
2023-08-06 03:16:05 +02:00
daobashun
fa59b30184 fix(Scripts/IcecrownCitadel): Tirion Fordring attacks the Lich King empty-handed (#15823)
* Fixed Tirion Fordring's final stage attacking the Lich King empty-handed

* Tirion Fordring's uses text in BroadcastText to speak

* Code format changes

* Add data to the data table

* Update rev_1680658371591699800.sql

Change from INSERT to INSERT/INSERT

* Update and rename boss_the_lich_king.cpp to boss_the_lich_king.cpp的

Remove useless comments

* Rename boss_the_lich_king.cpp的 to boss_the_lich_king.cpp

The input method caused an unexpected rename

* Delete the extra rows

* Update boss_the_lich_king.cpp

Delete references that can be omitted
2023-04-26 23:04:37 -03:00
Skjalf
c9973f3a80 fix(Scripts/IcecrownCitadel): Fix Svalna crash (#15862) 2023-04-07 12:57:52 -03:00
Skjalf
e2cfb5c5a9 fix(Scripts/IcecrownCitadel): Fix Putricide crash (#15846) 2023-04-06 18:19:46 -03:00
Skjalf
67dd96e502 fix(Scripts/IcecrownCitadel): Fix Sindragosa's icewall poping up prem… (#15836)
fix(Scripts/IcecrownCitadel): Fix Sindragosa's icewall poping up prematurely
2023-04-05 16:36:18 -03:00
Skjalf
caf54517bf fix(Scripts/IcecrownCitadel): Fix possible crash if bosses engage off… (#15832)
fix(Scripts/IcecrownCitadel): Fix possible crash if bosses engage offline players
2023-04-05 13:40:21 -03:00
Skjalf
28c770a517 fix(Scripts/IcecrownCitadel): Prevent Sindragosa's landing trigger fr… (#15814)
fix(Scripts/IcecrownCitadel): Prevent Sindragosa's landing trigger from firing during combat
2023-04-04 08:34:30 -03:00
Skjalf
572a7ea60d feat(Scripts/IcecrownCitadel): Allow game masters to skip boss checks (#15810) 2023-04-03 23:29:51 -03:00
Skjalf
ea1eed7362 fix(Scripts/IcecrownCitadel): Script Sindragosa's respawn/waypoints (#15792) 2023-04-03 00:07:10 -03:00
qwe900
c8c042d326 fix(Scripts/IcecrownCitadel): Fixing last issue on Nerubs in ICC (#15651)
now they fight after landing
2023-03-29 19:54:46 -03:00
Skjalf
8e697633b8 fix(Scripts/IcecrownCitadel): Fix Nerubar Broodkeeper flickering anim… (#15642)
* fix(Scripts/IcecrownCitadel): Fix Nerubar Broodkeeper flickering animation

partial cherry-pick of f8db738e8d

Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
Co-Authored-By: Houston <69751143+HoustonCore@users.noreply.github.com>
Co-Authored-By: Lucas Nascimento <keader.android@gmail.com>

* Update icecrown_citadel.cpp

* fix the spiders before sindragosa as well

* Update icecrown_citadel.cpp

---------

Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
Co-authored-by: Houston <69751143+HoustonCore@users.noreply.github.com>
Co-authored-by: Lucas Nascimento <keader.android@gmail.com>
2023-03-29 01:16:37 -03:00
Skjalf
8dced9fcf1 fix(Scripts/IcecrownCitadel): Fix Blood-Queen Lana`thel reset and fli… (#15601)
fix(Scripts/IcecrownCitadel): Fix Blood-Queen Lana`thel reset and flickering animation
2023-03-27 22:52:18 -03:00
Skjalf
a959942d82 fix(Scripts/IcecrownCitadel): Sindragosa shouldn't kill everything on… (#15602)
fix(Scripts/IcecrownCitadel): Sindragosa shouldn't kill everything on evade
2023-03-27 03:43:38 -03:00
qwe900
dd43ea4849 fix(Scripts/IcecrownCitadel): Lichking "Harvest Soul" Fix (#15573)
Players now not stucking anymore in the strangulating vehicle and getting teleported
2023-03-24 21:11:51 -03:00
Skjalf
825d0dc2bb fix(Scripts/IcecrownCitadel): Prevent the LK from despawning Tirion F… (#15561)
fix(Scripts/IcecrownCitadel): Prevent the LK from despawning Tirion Forddring
2023-03-24 08:03:20 -03:00
Skjalf
9aee5c41e2 fix(Scripts/Misc): Fix bosses not reseting after the despawn update (#15507)
* fix bosses not reseting

* fix lk

* fix tirion not respawning

* up
2023-03-21 15:05:04 -03:00
Skjalf
7b3b22a2e6 fix(Scripts/IcecrownCitadel): Rewrite the Spire Frostwyrms (#15490) 2023-03-19 18:38:32 -03:00
Skjalf
40ff0c607e fix(Scripts/IcecrownCitadel): Fix ICC buff not being reapplied after … (#15407) 2023-03-16 05:20:25 -03:00
Maelthyr
0200a288cd refactor(Scripts/Northrend): conversion to std::chrono (#15269)
Co-authored-by: Maelthyrr <maelthyrr@users.noreply.github.com>
2023-03-07 09:23:33 -03:00
Stefano Borzì
034b521501 feat(CI): add cppcheck (#15211)
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-03-05 18:47:18 +01:00
Skjalf
efe62bea4a fix(Scripts/IcecrownCitadel): fix Lord Marrowgar bone spikes (#15238) 2023-03-01 17:16:37 -03:00
Kitzunu
bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Skjalf
0dbb8c814c refactor(Core/InstanceScript): refactored load and save methods (#14977)
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com>
2023-02-12 15:53:48 -03:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
Skjalf
bf30c66ba4 feat(Core/GameObject): Expand IsSummonedBy() to GameObjects (#14789)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-29 09:44:33 -03:00
Skjalf
b4e3f1310b feat(Core/Unit): Add KillSelf overload (#14785)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-28 17:57:23 -03:00
Maelthyr
3024bee3ba refactor(Core/UnitAI): Update target selector (#13169)
* refactor(Core/UnitAI): Update TargetSelector.

Cherry-pick:
*https://github.com/TrinityCore/TrinityCore/pull/19930

Co-authored-by: Treeston <treeston@users.noreply.github.com>

* fix GGC/CLang errors in scripts

* .

* missing a file and fix a script error

* .

* fix path changes dude to a miss click in the second commit

* .

Co-authored-by: Maelthyrr <lynethris@protonmail.ch>
Co-authored-by: Treeston <treeston@users.noreply.github.com>
2022-12-06 09:27:13 -03:00
Maelthyr
c1c9dc6105 refactor(Core/ScriptedAI): few improvements with threat methods (#13146)
improve threat scripts

Co-authored-by: Maelthyrr <lynethris@protonmail.ch>
2022-11-12 13:29:28 +01:00
Walter Pagani
b4419512a3 fix(Scripts/ICC): gossip in boss Deathbringer Saurfang (#12381) 2022-10-14 17:35:06 +02:00
Angelo Venturini
ad4ce0895f fix: Qaston revert (#13320)
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271)"

This reverts commit e05f61d1b3.

* Revert "fix(Core): Crash (#13292)"

This reverts commit a818bcf3e2.

* Revert "fix: Crash (#13241)"

This reverts commit be423a91b5.

* delete sql

* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079)"

This reverts commit cbd3fd0967.

* add sql revert

* fix sql

* remove update from world.updates
2022-10-05 21:53:20 +02:00
IntelligentQuantum
cbd3fd0967 refactor(Core/Spells): Implement QAston Proc System (#11079)
* .

* sql

* .

* .

* 1

* 2

* 3

* 4

* 5

* 6

* 7

* 8

* 9

* 10

* 11

* 12

* 13

* 14

* 15

* Update spell_item.cpp

* Update Unit.cpp

* 16

* 17

* 18

* 19

* 20

* 21

* Update Unit.cpp

* REVERT UltraNIX Commit

* 22

* 23

* .

* .

* .

* warrior

* warlock

* shaman rogue priest paladin mage

* spell item

* hunter

* druid

* dk

* war

* error style

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* .

* DOND DEL ME WAD DO DO

* error 2

* .

* .

* .

* FIX

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp

* .

* ja genau

* Update .gitignore

* .

* .

* .,

* .

* .

* .

* .

* Update Unit.cpp
2022-10-02 19:39:34 +02:00
Maelthyr
1f472bddd3 refactor(Core/Combat): Code style and improvement of ThreatMgr (#12992) 2022-09-25 15:20:34 -03:00
Maelthyr
d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
Maelthyr
dfc6adb081 refactor(Core/Combat): DeleteThreatLists() become ClearAllThreat() (#11824)
refactor(Chore/Combat): DeleteThreatLists() become ClearAllThreat()
2022-05-23 05:51:52 -03:00
Maelthyr
c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00
Maelthyr
5ede1177c5 refactor(Core/Combat): implement compatiblity layer for ResetAllThreat() (#11778)
* implement ResetAllThreat()

* .
2022-05-17 12:01:25 -03:00
UltraNix
bbd760cc1a fix(Scripts/IcecrownCitadel): Increases radius of Sindragosa's boundary. (#11579)
Fixes #11439
2022-04-30 21:41:25 +02:00
Kitzunu
778d1bb9fa fix(Scripts/ICC): Change trigger flag for Battle Experience spell (#11466)
* fix(Scripts/ICC): Change trigger flag for Battle Ecperience spell

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/6785

* cherry-pick part of commit (TrinityCore/TrinityCore@5b8e68e)
2022-04-21 19:12:39 +02:00