Commit Graph

4555 Commits

Author SHA1 Message Date
skelUA
da453b2a8d fix(Core/SmartScripts): LOS check spell for SmartScipts (#18501)
* Fix spell 35329 (Vibrant Blood)

* [PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)

* Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"

This reverts commit 2eaeb78bdee5b09f1ea5685a9b039f9221df4abe.

* Revert "Fix spell 35329 (Vibrant Blood)"

This reverts commit 0e7ee59588709050e2af9cc15e8ff1ed358936b2.

* Revert "Revert "Fix spell 35329 (Vibrant Blood)""

This reverts commit 5e4424b4d81ec3c1de1d6f73e48d848e63e92b79.

* Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)""

This reverts commit b3a9553a45e81f65b2eb15f127c5ca9eb99b6d1e.

* Revert "Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"""

This reverts commit 0ced477c767b9087eefdf516d0e0fccf1567e6e3.

* Revert "Revert "Revert "Fix spell 35329 (Vibrant Blood)"""

This reverts commit a8da732cfb4369f218e96175fc8f33eafc1e69c9.

* Revert "Revert "Fix spell 35329 (Vibrant Blood)""

This reverts commit 5e4424b4d81ec3c1de1d6f73e48d848e63e92b79.

* Revert "Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)""

This reverts commit b3a9553a45e81f65b2eb15f127c5ca9eb99b6d1e.

* Revert "[PATCH] Flight of the Wintergarde Defender fix (https://forums.wow.sumy.ua/viewtopic.php?p=35#p35)"

This reverts commit 2eaeb78bdee5b09f1ea5685a9b039f9221df4abe.

* Revert "Fix spell 35329 (Vibrant Blood)"

This reverts commit 0e7ee59588709050e2af9cc15e8ff1ed358936b2.

* FIX LOS SAI
2024-03-08 11:15:45 -03:00
Dan
903820077c fix(Scripts/TheEye): make Solarian not overlap casts and not cast arcane missiles into p2 transition (#18480)
* initial

* add voiceline

* move position of yells

* change voicings
2024-03-08 07:55:42 +01:00
Dan
9e7c443f3c fix(Scripts/TheEye): Al'ar phoenix spawn positions in p2 (#18504)
* wip

* wip

* finalise
2024-03-06 16:51:51 -03:00
Dan
663566af4b fix(Scripts/TheEye): make sure Solarian does not cast arcane missiles on target with Wrath of the Astromancer active (#18496)
* initial

* add target reset

* fix targetting

* revert
2024-03-04 18:04:48 -03:00
Dan
429cd226f3 fix(Scripts/TheEye): amend Al'ar divebomb timer in p2 (#18495)
initial
2024-03-04 16:54:29 -03:00
Dan
77e1062c4b fix(Scripts/TheEye): make sure Telonicus doesn't erroneously cast Conflagration and cast Remote Toy instead (#18481)
how the frick did I miss this
2024-03-04 09:34:52 -03:00
Dan
2f2a4be72f fix(Scripts/TheEye): make sure Al'ar does not melee during transitions (#18479)
* init

* Update boss_alar.cpp
2024-03-04 09:13:33 -03:00
Dan
1c8644b3bc fix(Scripts/TheEye): make legendary TK dagger have 100% proc chance (#18482)
initial
2024-03-04 10:44:35 +01:00
Alethrion
016d9806dc fix(Scripts/SerpentshrineCavern) Filter Watery Grave Target (#18463)
Filter_Target
2024-03-01 06:46:23 -03:00
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Anton Popovichenko
22f2a8f731 fix(Core/Spell): Fix crash in Rogue T10 4P Bonus (#18413) 2024-02-25 19:55:32 -03:00
Andrew
42cde6286f fix(Scripts/TheEye): Fix Capernian not casting if at max range (#18402) 2024-02-25 17:46:06 -03:00
Anton Popovichenko
34598bfccf feat(Core/UpdateTime): Improve diff time measurement. (#18387)
* feat(Core/UpdateTime): Improve diff time measurement.

* Codestyle fixes
2024-02-25 12:08:15 -03:00
Winfidonarleyan
1768e4a633 chore(Common/Debugging): change report codestyle (#18383) 2024-02-25 12:07:40 -03:00
Winfidonarleyan
2a2cc3c22f chore(Core/Shared): little cleanup (#18385) 2024-02-25 12:07:08 -03:00
sudlud
27da4554cf fix(Conf): remove ThreatRadius (unused) (#18329)
fix(Conf): remove ThreatRadius (unuused)
2024-02-25 12:06:44 -03:00
Dan
4fcd3402ca fix(Core/SmartAI): implement param maxCount for SMART_TARGET_PLAYER_RANGE (#18394)
* init

* conditional
2024-02-25 11:50:07 -03:00
Dan
a2f8922411 fix(Scripts/TheEye): remove faulty aurascript and do visual transition in normal script instead (#18395) 2024-02-25 11:49:49 -03:00
Dan
def167d7cc fix(Scripts/TheEye): Kael'thas - allow phases to progress as well when all creatures die as well as other fixes (#18397) 2024-02-25 11:49:19 -03:00
Elmsroth
729a1ff539 fix(Crash/Quest/Spell) : The Boon of Remulos (#18379)
Fix the spell : https://www.wowhead.com/wotlk/spell=57678/emerald-acorn-effect
Used in quest : https://www.wowhead.com/wotlk/quest=13075/the-boon-of-remulos

The crashed was caused by a nullptr Excception. It also could be throuwn in another similar test that has also been fixed.
If the spell did not have a CastTimeEntry a nullptr Exception was not checked.
2024-02-22 22:40:26 -03:00
Andrew
d76ca96795 fix(Scripts/TheEye): Fix Capernian chase distance (#18372)
* fix(Scripts/TheEye): Fix Capernian chase distance

* Update boss_kaelthas.cpp
2024-02-21 12:33:05 +01:00
Dan
7e80d8e6bb fix(Scripts/TerokkarForest): fix behaviour of skull piles in Skettis (#18371)
* initial

* fix

* include ancient skull pile

* fix

* fix with debug

* finalise
2024-02-21 07:41:06 +01:00
Angelo Venturini
72ba824941 fix(Core/ItemStorage): Fix container items count on server load (#18367) 2024-02-20 21:31:52 +01:00
Andrew
ea0f214678 fix(Scripts/TheEye): Thaladred should only chase players (#18365) 2024-02-20 19:33:39 +01:00
Dan
e3c282ec1d fix(Scripts/SSC): remove double spawn of Seer Olum and implement correctly (#18364)
* initial

* fix double definition

* finalise

* remove npc flag in script

* handle in reset

likely fathomlord is created before olum so flag removing doesnt work

* put in instance script
2024-02-20 08:31:14 +01:00
sudlud
d94d10aa9f fix(Core): Prevent gift wrapping of limited duration items (#18334)
fix(Core): Prevent gift wrapping of items with duration

- remaining duration is not beeing stored in character_gifts
- gift wrapping of items with duration preserved
  them infinitely
2024-02-19 21:23:13 +01:00
sudlud
7e419fba5a fix(Core/Guild): Prevent swapping limited duration items into guild bank (#18335) 2024-02-19 21:22:51 +01:00
Dan
5955f287ed fix(Scripts/SSC): do reset threat list for p3 in the right place (#18354)
init
2024-02-19 11:52:59 +01:00
Mykhailo Redko
86bff27611 fix(Core/GameObject): Remove unneeded ClearGossipMenuFor call (#18331) 2024-02-18 11:21:52 +01:00
Andrew
5e7e5ce417 fix(Scripts/TheEye): A'lar stop casting flame buffet when any valid t… (#18313)
fix(Scripts/TheEye): A'lar stop casting flame buffet when any valid target is in range
2024-02-12 16:04:35 +01:00
Anton Popovichenko
72e75982be fix(Core/Taxi): Fixes crash when player logins and continues flight (#18270)
* fix(Core/Taxi): Fixes crash when player logins and continue flight

* Update WaypointMovementGenerator.cpp
2024-02-12 08:18:05 -03:00
Dan
a4dc083b42 fix(Scripts/Hyjal): move Hyjal boss waypoints to DB (#18299)
* put anetheron movement in wps

* move all wps to db for bosses
2024-02-12 08:17:39 -03:00
Dan
fb49062a56 fix(Scripts/TheEye): make sure Solarian always get reset to REACT STATE aggressive on reset (#18302)
initial
2024-02-12 08:17:24 -03:00
Dan
bf71d8e7f1 fix(Scripts/TheEye): some Al'ar fixes (#18305) 2024-02-12 08:16:46 -03:00
Walter Pagani
f18145ca12 feat(fix/build) ignore mariadb in the conditional (#18310)
* feat(fix/build) ignore mariadb in the conditional

* Parentheses in the second condition
2024-02-11 14:28:43 +01:00
AnchyDev
1d8c4056b3 feat(Core/Hooks): Add the KillRewarder reference to the OnRewardKillRewarder hook. (#18290)
* Another hackfix attempt at warden payload forcechecks ban fix.

* Revert last commit, interrupt all forcechecks instead of just _dataSent ones.

* Add rewarder parameter to OnRewardKillRewarder hook.

* Undo old warden changes.

* Removed too much!
2024-02-10 21:58:49 +01:00
Walter Pagani
6b1dd7e19e fix(Core/Database) mysql_stmt_bind_param deprecated in MySQL 8.3 (#18295)
* feat(fix/build) Test on MacOS

* Syntax error

* Syntax error

* Adding missing parameters

* typo

* deprecated

* Check MySQL version
2024-02-10 21:31:17 +01:00
stoudtlr
04266cc18d fix(Deps): Fixed finding openssl 3.2 on windows (#18284)
* Cherry-pick commit (94aed68968)

Co-authored-by: github.com/Shauren <shauren.trinity@gmail.com>
2024-02-10 18:49:40 +01:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
sudlud
c47c945aa4 fix(Conf): disable LeaveGroupOnLogout by default (#18245) 2024-02-09 13:24:57 -03:00
Nathan Handley
425a490a7b feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType (#18293)
* Create HasActivePower for script intercept

* Replace relevant player-related getPowerType() comparators with HasActivePowerType

* Change OnPlayerHasActivePowerType to regular bool instead of optional

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-09 06:27:02 -03:00
Dan
d42e04097c fix(Scripts/TheEye): Solarian movement (#18268)
* first implementation

* better implementation

* don't move before first spell

* chase in p2 again

* Update boss_astromancer.cpp

* oops
2024-02-08 06:05:38 -03:00
Kalimist
65d6bd0472 fix(Core/Creature): hardcoded gossip in zone_azshara (#18289)
* Changing hardcoded text in #define to enum member

- Changing #define to new enum member for AddGossipItemFor method

* Adding SQL Query File

* Forgot to add ';' in DELETE FROM
2024-02-08 07:41:23 +01:00
Dan
af880d516f refactor(Scripts/ZulAman): refactor Halazzi (#18267)
* initial

* some fixes

* last booboos

* fixes after test

* finale

* actual final

* blegh
2024-02-07 23:43:38 -03:00
Dan
bc25ade498 fix(Scripts/TheEye): refactor Al'ar (#18264)
* initial

* restore quill event

* with ismoving and debug

* final before timers

* clear all debuffs

* remove justreachedhome bossai

* huh?

* some fixes

* more fixes

* add 2 extra platforms for p1

* fix coords

* finalise

* change melt armor timer so it is not delayed

indefinitely - this is because we have a dive after 30 secs
that delays all timers. So at 30 secs we will have melt armor at
33 seconds, which then gets an extra 15 seconds from the delay all and another dive
after 30 so it gets pushed back even more before being able to be cast
2024-02-07 23:43:19 -03:00
Dan
b8118fa06b fix(Scripts/TheEye): Re-factor Kael'thas (#18272)
* restructuring base files and instance files

* small fix

* some fixes

* fix

* some fixes

* up until kael phase

* weapon despawn fix

* final for now

* some minor details

* fix weapon despawn

* fix by clearing validator

still has debug statements to check how far we get

* finalise with stop casting

* codestyle

* remove redundant delay
2024-02-07 23:42:20 -03:00
Dan
c513da85c8 fix(Scripts/SSC): some Vashj fixes (#18276)
* initial

* script tainted elemental

* sql

* codestyle
2024-02-06 17:47:37 +01:00
Dan
1ec72ae6dc fix(Scripts/TheEye): add Kael adds to the cpp script (#18257)
* initial

* add sql file to change to script

* make sure scheduler runs

* fix focus gaze mechanic

* leftover tabs

* remove comment
2024-02-04 11:11:12 -03:00
sudlud
186cb58a0f fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs (#18239)
* fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs

* update comments and waypoints for smoother movement

* move initalization to Reset() function
2024-02-03 15:11:36 +01:00
Kalimist
1324f420f2 Fix(Core/CharacterHandler): Incorrect behavior using an equipment set… (#18253)
* Fix(Core/CharacterHandler): Incorrect behavior using an equipment set if it will result in a full inventory.

* Fixing the error message to -Equiment swap failed - inventory is full- like the Blizzlike error message
2024-02-03 14:34:33 +01:00