Benjamin Jackson
c3e22c0fe2
fix(Scripts/HyjalSummit): Couple Archimonde adjustments. ( #19193 )
...
* Init.
Co-Authored-By: cyberium <cyberium@users.noreply.github.com >
Co-Authored-By: killerwife <killerwife@users.noreply.github.com >
* Corrections.
* Adjust fear timer.
* Wrong spell.
* Whitespace.
* Use the much cooler and more hip scheduler.
* Correct teleport timers.
Matches up with sniffed 3.4.3 data.
* Swap magic number for constant.
Co-Authored-By: killerwife <killerwife@users.noreply.github.com >
* Adjust notation.
* Public.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Kitzunu's fault.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: cyberium <cyberium@users.noreply.github.com >
Co-authored-by: killerwife <killerwife@users.noreply.github.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-04 14:31:22 -03:00
Kitzunu
bd29e9e1b3
fix(Core/Spell): Implement SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT ( #19254 )
...
feat(Core/Spell): Implement SPELL_ATTR1_AURA_STAYS_AFTER_COMBAT
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19248
2024-07-04 14:30:59 -03:00
Kitzunu
aebb99ecda
fix(Core/Character): TeleportTo() in HandlePlayerLoginFromDB() causes… ( #19237 )
...
fix(Core/Character): TeleportTo() in HandlePlayerLoginFromDB() causes breakdown in the network communication
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/16307
2024-07-04 14:30:25 -03:00
Kitzunu
e8f7d70ee0
refactor(Script/Dalaran): Minigob Manabonk ( #19244 )
...
* refactor(Script/Dalaran): Minigob Manabonk
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/16841
* Update src/server/scripts/Northrend/zone_dalaran.cpp
2024-07-04 14:28:10 -03:00
Kitzunu
6031ae2eb9
chore(Core/Conf): Show better logging when fatal config options are m… ( #19236 )
...
chore(Core/Conf): Show better logging when fatal config options are missing
* Show better log when the server halts due to missing fatal config option
* Change error to warning for missing config options. As they are not errors
* Update output when autoupdater is disabled for all databases
2024-07-04 14:25:28 -03:00
Kitzunu
385d7fd515
chore(Core/DBC): define unused unknown dbc fields ( #19262 )
...
* chore(Core/DBC): define unused unknown dbc fields
* Name unused unknown dbc fields using WDBX and wowdev.wiki
* rename SpellShapeshiftEntry to SpellShapeshiftFormEntry to properly match the DBC used
* rename sSpellShapeshiftStore to sSpellShapeshiftFormStore to properly match the DBC used
* Comment out unused field for GlyphPropertiesEntry
* Comment out unused field for MapEntry
* forgot one
* SpellShapeshiftfmt to SpellShapeshiftFormfmt
* SpellShapeshiftFormEntryfmt
2024-07-04 14:23:25 -03:00
Kitzunu
193e906a84
fix(Core/Spells): Shapeshift should show in Old Hillsbrad Foothills a… ( #19274 )
...
fix(Core/Spells): Shapeshift should show in Old Hillsbrad Foothills as horde
2024-07-04 14:21:33 -03:00
Kitzunu
8745ac9c2e
fix(Core/Loot): implement automatic pass in group loot for items that… ( #19272 )
...
* fix(Core/Loot): implement automatic pass in group loot for items that cannot be looted
* cherry-pick commit (00fdf6e99a )
* closes https://github.com/chromiecraft/chromiecraft/issues/4523
Co-Authored-By: Wyrserth <43747507+Wyrserth@users.noreply.github.com >
* whoopise
---------
Co-authored-by: Wyrserth <43747507+Wyrserth@users.noreply.github.com >
2024-07-04 14:21:00 -03:00
Kitzunu
e878cedb7f
feat(Core/SAI): implement new removeObjectFromWorld param for SMART_A… ( #19275 )
...
feat(Core/SAI): implement new removeObjectFromWorld param for SMART_ACTION_FORCE_DESPAWN
2024-07-04 14:20:41 -03:00
Jelle Meeus
cf1185551d
fix(Core/Pet): prevent LoadPetFromDB to trigger a fake summon spell cast in most cases ( #19277 )
...
* add CategoryRecoveryTime check
* add RecoveryTime check
2024-07-04 14:20:24 -03:00
avarishd
f84a4f1408
fix(Scripts/TK): Kael'thas mind control should reset threat ( #19264 )
...
* fix(Scripts/TK): Kael'thas mind control should reset threat
* lol
* -2 lines
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-04 13:50:45 -03:00
Kitzunu
d5ba5e0168
fix(Core/Quest): typo in RewardQuest makes LFG quests not reward if dead ( #19271 )
...
fix(Core/Quest): typo in RewardQuest
* Allow LFG quests to be rewarded even when dead
2024-07-04 09:41:53 -03:00
Benjamin Jackson
e41080468f
fix(Scripts/TheEye): Kael'thas adjustments. ( #19213 )
...
* Init.
* Update advisor phase timer.
2024-07-04 09:26:23 -03:00
thomasjteachey
fa8680746e
fix(Core/Arena): Check to see if other members in your arena team are queued or in a r… ( #18808 )
...
* Check to see if other members in your arena team are queued or in a rated arena already and, if so, do not allow queue to go through
* Accidentally put team party check inside the for loop
* some basic logic efficiency changes
* minor syntax issue
2024-07-04 08:42:36 -03:00
sudlud
60be029e4c
fix(Core/Scripting): fix OnBeforeCreateInstanceScript hook ( #19252 )
...
- to me this hook should obviously provide an option to overwrite
the InstanceScript pointer
- this is e.g. beeing used by mod-eluna (but currently broken)
2024-07-03 14:54:45 -03:00
Kitzunu
e839581649
fix(Core/Player): Allow players to enter the world ( #19261 )
2024-07-03 12:06:48 +02:00
Kitzunu
0a8175ef03
refactor(Core/ObjectMgr): Handle Profanity & Reserved Names in load ( #19259 )
...
* refactor(Core/ObjectMgr): Handle Profanity & Reserved Names in load
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/18556
* Update ObjectMgr.cpp
* Update ObjectMgr.cpp
* I swear I am not drunk
* We already check all of these
* fix build
* Forgot we dont send the responsecode in senderrormessage
* last commit I swear
2024-07-03 00:23:32 +02:00
Kitzunu
f96d4c8670
Revert "Add (core\db): Support for Homebind Orientation ( #13389 )" ( #19257 )
...
* Revert "Add (core\db): Support for Homebind Orientation (#13389 )"
This reverts commit 2e6f6e26da .
Changes to be committed:
modified: src/server/database/Database/Implementation/CharacterDatabase.cpp
modified: src/server/game/DungeonFinding/LFGScripts.cpp
modified: src/server/game/Entities/Player/Player.cpp
modified: src/server/game/Entities/Player/Player.h
modified: src/server/game/Entities/Player/PlayerStorage.cpp
modified: src/server/game/Entities/Player/PlayerUpdates.cpp
modified: src/server/game/Handlers/CharacterHandler.cpp
modified: src/server/game/Handlers/MiscHandler.cpp
modified: src/server/game/Handlers/MovementHandler.cpp
modified: src/server/game/Maps/Map.cpp
modified: src/server/game/Spells/Spell.cpp
modified: src/server/scripts/Commands/cs_misc.cpp
modified: src/server/scripts/Commands/cs_tele.cpp
modified: src/server/scripts/Northrend/VaultOfArchavon/instance_vault_of_archavon.cpp
Untracked files:
data/sql/updates/pending_db_world/rev_1719945200692175000.sql
* Revert "Add (core\db): Support for Homebind Orientation (#13389 )"
* whoops
2024-07-02 22:02:15 +02:00
Kitzunu
5a4692e45a
chore(Core/Misc): #include cleanup ( #19255 )
2024-07-02 15:52:02 +02:00
Jelle Meeus
47ad691c92
refactor(Scripts/EasternKingdoms): RegisterSpellScript macro ( #19241 )
...
* zone_undercity spell:spell_blight_worm_ingest
* zone_blasted_lands spell:spell_razelikh_teleport_group
* zone_isle_of_queldanas spell:spell_bh_cleanse_quel_delar
2024-07-01 23:28:03 +02:00
Kitzunu
1289e351a2
fix(Script/Commands): output lookup quest and npc near ( #19243 )
...
* close https://github.com/azerothcore/azerothcore-wotlk/issues/19216
2024-07-01 07:24:54 -03:00
Kitzunu
688d7e2fdf
fix(Script/GunshipBattle): Wipe if no player is on the deck ( #19239 )
...
* fix(Script/GunshipBattle): Wipe if no player is on the deck
* reorder
* Update boss_icecrown_gunship_battle.cpp
* Update worldserver.conf.dist
* Update boss_icecrown_gunship_battle.cpp
* missed it!
* Update instance_icecrown_citadel.cpp
2024-06-30 18:30:44 -03:00
Andrew
8b81b1dad1
fix(Scripts/Hyjal): Workaround bosses getting stuck in progress ( #19231 )
2024-06-30 05:39:29 -03:00
Jelle Meeus
ed38e6e550
fix(Scripts/Naxxramas): Gothik missing visuals at minions death ( #18666 )
...
* add sql rev
* enable NPC_TRIGGER
* add npc_gothik_trigger
* add rest of script
* spell info correction
* fix compile issue
* fix desummon call
* remove comment
* access gothik by GUID
* add missing function overrides
* add braces
* add missing trigger, adjust CGUID value
* fixup! add missing trigger, adjust CGUID value
* select skulls based on coordinates
style
invert remove
remove CGUID comment
fix remove_if check, use correct def
* JustSummoned: target same side with mapLOS
* select random initial target on the same side
* add REACT_AGGRESSIVE and increase CallForHelp radius
* refactor spellscript
* style
2024-06-29 15:12:12 -03:00
Jelle Meeus
75582eb34b
fix(Core/Spell): implement taunt DR CREATURE_FLAG_EXTRA_OBEYS_TAUNT_DIMINISHING_RETURNS ( #19128 )
...
* skip other effects in case of taunt DR
* set flags_extra creature_template
fe38b78c87
Co-authored-by: offl <offl@users.noreply.github.com >
* update query to only entries found in acore_world.creature_template
* add name as comment
* fix ci codestyle
---------
Co-authored-by: offl <offl@users.noreply.github.com >
2024-06-29 11:59:16 -03:00
Kitzunu
bc91074b14
fix(build): mac ( #19229 )
2024-06-29 11:48:58 -03:00
Vitaly Kogogin
02b58ff02e
fix(core/character-creation): get main part of cyrillic name ( #18971 )
...
fix(character/creation): get main part of cyrillic name
2024-06-29 10:56:06 -03:00
avarishd
63c8c6480e
fix(Core/Spells): Eye of Grillok improvements ( #19148 )
...
* fix(Core/Spells): Eye of Grillok improvements
* my eyes
* discovery of RegisterSpellAndAuraScriptPair
* comment
2024-06-29 07:33:23 -03:00
Dinkledork
01f063e242
fix(Scripts/World): Emerald Dragons no longer have 0% health events ( #18893 )
...
Events happen at 75, 50 or 25 percent health and should not include 0%.
2024-06-29 06:13:14 -03:00
Jelle Meeus
64e92b9bb5
refactor(Scripts/Spells): Spell Scripts registry macros, rogue killing spree ( #19226 )
...
* spell_rogue pair:spell_rog_killing_spree move public AddTarget up
spell_rogue pair:spell_rog_killing_spree
* fixup! spell_rogue pair:spell_rog_killing_spree
2024-06-29 06:11:50 -03:00
Jelle Meeus
e3da4e4986
refactor(Scripts/World): Spell Scripts registry macros ( #19224 )
...
* boss_emerald_dragons spell:spell_dream_fog_sleep
* boss_emerald_dragons spell:spell_mark_of_nature
2024-06-29 06:06:59 -03:00
Jelle Meeus
0d7f4c43e8
refactor(Scripts/SunwellPlateau): Spell Scripts registry macros ( #19223 )
2024-06-29 06:06:38 -03:00
Walter Pagani
77be5bb19d
fix(Spells/SpellInfoCorrections) Remove friendly mask on goblins ( #18912 )
...
Co-authored-by: Jelle Meeus <sogladev@gmail.com >
2024-06-29 00:28:29 -03:00
avarishd
7ae10d8ba6
fix(DB/Area): Horvon the Armorer & Greatfather Aldrimus phasing ( #19138 )
2024-06-29 00:24:50 -03:00
Kitzunu
84d666322e
chore(Core/DBC): Comment unused CreatureDisplayInfoExtraEntry field ( #19170 )
...
* chore(Core/DBC): Comment unused CreatureDisplayInfoExtraEntry field
* Update DBCfmt.h
2024-06-29 00:21:36 -03:00
Jelle Meeus
29f376f9bc
fix(Core/Spells): Midsummer spinning visual interrupt on gossip ( #19211 )
...
* handle removal in periodic effect
* do removal with aurascript
* Revert "do removal with aurascript"
This reverts commit 383dd7b255e18d52f5fbecbfcb47ac08331ba626.
* Revert "handle removal in periodic effect"
This reverts commit ab6984e95613df3fa32d45489f607650c9700ff7.
* add AURA_INTERRUPT_FLAG_TALK to 45406
2024-06-28 13:41:47 -03:00
Benjamin Jackson
fd87ce1bf3
fix(Scripts/Karazhan): Destroy Netherspite portals on death. ( #19203 )
...
Init.
2024-06-28 05:52:46 -03:00
Benjamin Jackson
617341230e
fix(Scripts/Karazhan): Allow portal color effects to overlap on players. ( #19204 )
...
Init.
2024-06-28 05:25:36 -03:00
avarishd
5b2a088da0
fix(Core/Auras): Add SPELL_ATTR0_CU_ONLY_ONE_AREA_AURA ( #19209 )
...
https: //github.com/azerothcore/azerothcore-wotlk/pull/19208
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com >
2024-06-28 05:23:38 -03:00
Benjamin Jackson
c28a0973a2
fix(Scripts/SlavePens): Adjust Ahune spell casts. ( #19202 )
...
* Bad boss 0/10.
* Unneeded comment.
Damage already exists, though might need scripting or something to adjust its damage output.
2024-06-27 21:26:55 +02:00
Greg Wilkinson
2835f883c8
fix(Core/Misc): fmt ( #19192 )
...
Update LOG_ERROR for Model data query.
2024-06-27 18:06:40 +02:00
Jelle Meeus
7e0dff5839
fix(Scripts/Karazhan) Nightbane take off phase handling ( #18934 )
...
* nightbane fly skip ground phase
use conditional schedule takeoff instead
invincibility fix and timing
no need to delay ScheduleGround
* (WIP) cursed boss
new inro
lands
attack flag is not removed.. cant attack :)
* fix intro, refactor fly to air, handle waypoints, air facing, urn,...
* add PassiveAI header
* revert removal of helper target on roof
2024-06-27 18:03:19 +02:00
Jelle Meeus
a740c252f9
refactor(Scripts/BlackrockMountain): Spell Scripts registry macros ( #19186 )
...
* boss_garr aura:spell_garr_separation_nexiety_aura
* boss_garr spell:spell_garr_frenzy
* molten_core aura:spell_mc_play_dead_aura
* boss_magmadar spell:spell_magmadar_lava_bomb
* boss_majordomo_executus spell:spell_hate_to_zero
* boss_majordomo_executus aura:spell_majordomo_separation_nexiety_aura
* boss_majordomo_executus spell:spell_summon_ragnaros
* boss_shazzrah spell:spell_shazzrah_gate_dummy
* boss_baron_geddon aura:spell_geddon_inferno_aura
* boss_baron_geddon aura:spell_geddon_armageddon_aura
* boss_razorgore spell:spell_egg_event
* instance_blackwing_lair spell:spell_bwl_shadowflame
* fixup! boss_majordomo_executus aura:spell_majordomo_separation_nexiety_aura
* fixup! boss_garr aura:spell_garr_separation_nexiety_aura
* fixup! fixup! boss_garr aura:spell_garr_separation_nexiety_aura
2024-06-27 18:03:08 +02:00
Andrew
c9725dd4b2
fix(Core/AI): Don't set boss state to none if already complete ( #19139 )
2024-06-26 22:40:04 +02:00
RaZoRR
4e6d433dd2
fix(Scripts/AzjolNerub): Anub'Arak clear debuff spell ( #19140 )
...
* fix(CORE/Raid): Anub'Arak not using proper spell to clear his debuffs on submerge
Anub'Arak (id: 34564) was using the RemoveAllAuras method instead of the ClearAllDebuffs spell to clear all his debuffs when submerging.
Closes AzerothCore issue #19136
* fix(instace/Azjol'Nerub): Anub'Arak not removing debuffs on submerge
anub'arak was not removing his debuffs on submerging with the right spell.
closes issue #19113
* Update boss anub'arak of PR #19140
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Update boss Anub'Arak code improvement
* Update boss anub'arak
* Update src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_anubarak_trial.cpp
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-06-26 22:35:31 +02:00
Benjamin Jackson
5740fda8ad
fix(Scripts/SlavePens): Remove permanent knockback aura on ice spear bunny. ( #19152 )
...
Init.
2024-06-26 22:26:58 +02:00
Jelle Meeus
a9c93cc94e
refactor(Scripts/Kalimdor): Spell Scripts registry macros ( #19185 )
...
* zone_dustwallow_marsh spell:spell_ooze_zap
* zone_dustwallow_marsh spell:spell_ooze_zap_channel_end
* zone_dustwallow_marsh spell:spell_energize_aoe
* zone_feralas spell:spell_gordunni_trap
* zone_durotar aura:spell_mount_check_aura
* zone_durotar spell:spell_voljin_war_drums
* zone_durotar spell:spell_voodoo
* boss_salramm aura:spell_boss_salramm_steal_flesh_aura
* instance_zulfarrak spell:spell_zulfarrak_summon_zulfarrak_zombies
* instance_zulfarrak spell:spell_zulfarrak_unlocking
2024-06-26 22:26:35 +02:00
Jelle Meeus
b259ec6df7
refactor(Scripts/Karazhan): Spell Scripts registry macros ( #19184 )
...
* instance_karazhan aura:spell_karazhan_brittle_bones_aura
* instance_karazhan aura:spell_karazhan_overload_aura
* instance_karazhan spell:spell_karazhan_blink
2024-06-26 22:26:19 +02:00
Jelle Meeus
40b63666ad
feat(Core/Movement): implement Pause and Resume to WaypointMovementGenerator ( #19176 )
...
* implement Pause and Resume for WaypointMovementGenerator
Co-authored-by: ccrs <ccrs@users.noreply.github.com >
* prevent restart from external sources if wp is paused
* don't update stopmove on every update
SetFacing breaks otherwise
* timer args not used
---------
Co-authored-by: ccrs <ccrs@users.noreply.github.com >
2024-06-26 22:24:59 +02:00
Jelle Meeus
77d3eb52df
fix(Core/Spell): Bladestorm remove reset swing and allow meleeSwingSpell during ( #19093 )
...
* remove reset swing
* allow meleeswingspell on PLAYER_ALLOW_ONLY_ABILITY
2024-06-26 22:23:09 +02:00