Commit Graph

151 Commits

Author SHA1 Message Date
Andrew
baf7957e36 fix(Scripts/Spell): Fix Animal Blood spawning when it shouldn't (#23656) 2025-11-14 09:31:30 +01:00
天鹭
6d64ecd24f fix(Core/Vmaps): Fix inconsistency of hitInstance and hitModel to cause wrong area ids (#23233)
Co-authored-by: ModoX <moardox@gmail.com>
Co-authored-by: Shauren <shauren.trinity@gmail.com>
Co-authored-by: Grimdhex <237474256+Grimdhex@users.noreply.github.com>
Co-authored-by: sudlud <sudlud@users.noreply.github.com>
2025-11-11 01:51:52 -03:00
天鹭
a1c8e0f221 refactor(Core): SendDirectMessage (#23230) 2025-10-30 14:21:26 -03:00
天鹭
53238a68d3 refactor(Core): DespawnOrUnsummon (#23141) 2025-10-13 03:36:23 -03:00
sogladev
b1d526e59d feat(Scripts/Spells): GM utility spells and Beastmaster Mode (#22964)
Co-authored-by: ratkosrb <ratkomladic2@abv.bg>
2025-10-12 16:00:49 +02:00
Jelle Meeus
73a18d6499 fix(Scripts/Spells): Friendship Bread does not display hearts when eating (#22875) 2025-09-11 23:02:28 -03:00
Takenbacon
73317b2706 feat(Core/Grids): Remove WorldObject separation in grid containers (#22595) 2025-08-09 06:36:24 +02:00
Jelle Meeus
bde4e076ed fix(Scripts/Spells): DK Ghoul pet is no longer immune to Horn of Winter and other stat mod auras (#22636) 2025-08-06 19:01:29 -03:00
Jelle Meeus
53e1cd553b fix(Scripts/Spells): Update Death Knight Ebon Gargoyle auras and damage, and Ghoul auras (#22398)
Co-authored-by: Tereneckla <Tereneckla@pm.me>
2025-07-20 08:10:47 +02:00
Jelle Meeus
3b13fe6207 fix(Scripts/Spells): add script to GM spell CooldownAll (#22383) 2025-06-29 13:28:21 +02:00
Benjamin Jackson
c5cb54c2ea fix(Scripts/ScarletEnclave): Improve Might of Mograine aura behavior. (#22320) 2025-06-15 22:47:46 +02:00
Benjamin Jackson
52799d76f6 refactor(Core): Add definition file for area table entries. (#22054) 2025-05-09 15:48:02 +02:00
Andrew
be422f2f2a fix(Scripts/Spells): Fix Isle of Queldanas Orb of Translocation (#21325) 2025-02-05 07:43:39 +01:00
Jelle Meeus
a1cf6a7ceb fix(Scripts/ZulAman): Zul'Jin reduce procs of Energy Storm Aura (#21169) 2025-01-14 22:09:07 -03:00
Andrew
fb3749718e fix(Scripts/Spells): Move Curse of Mending (7098 & 39647) to spell sc… (#21117) 2025-01-09 20:15:50 +01:00
Jelle Meeus
638b8ea621 fix(Scripts/Spells): Death Knight Army of the Dead auras (#19795) 2024-12-28 14:23:14 +01:00
Kitzunu
ed008a8780 refactor(Core/Spells): Add helpers for HasAuraType (#20802) 2024-12-01 08:50:59 -03:00
Jelle Meeus
047a21d31a fix(Scripts/ZulAman): Halazzi Phases (#20650) 2024-11-20 09:08:21 -03:00
Jelle Meeus
3565e4a9eb feat(Core/WorldState): improved WorldState scripting (#20141)
* implement world state script

based on
0b87ca9d9e

Co-authored-by: killerwife <killerwife@gmail.com>

* refactor to use onleave and onenter instead of spell_area

allows players to right click remove adal's buff

* add MapMgr.h

* refactor: use condition enum instead of uint32, prefix WORLD_STATE where needed

* remove lock from WorldState::Update

sWorldState->Update() is only called from World::Update

* remove unsafe SmartAI action of setWorldState

---------

Co-authored-by: killerwife <killerwife@gmail.com>
2024-11-12 12:15:27 -03:00
Andrew
91b8cc29cf fix(Scripts/Spells): Limit Cyclone (39594) to 4 targets (#20506) 2024-11-10 14:54:33 -03:00
avarishd
705b8ab50e fix(Scripts/Item): Obsidian Armor & Frostfire Regalia Set (#20453) 2024-11-06 01:28:53 -03:00
Andrew
98ae32e1da fix(Scripts/Spells): Remove immunity application from Preparation buff (#20042) 2024-09-25 12:00:57 -03:00
Jelle Meeus
188b864d79 fix(DB/ArgentTournament): Stabled Campaign Warhorse missing error message (#19926)
* fix lance requirement error msg

* ;
2024-09-21 18:48:04 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Kitzunu
9af86553c5 chore(Core/Misc): update floor and ceil to std (#19837) 2024-09-03 08:01:00 -03:00
Kitzunu
de2bcbdabf refactor(Core/Misc): Acore::StringFormat to fmt format (#19838)
refactor(Core/Utilities): Acore::StringFormat to fmt format

* closes https://github.com/azerothcore/azerothcore-wotlk/issues/10356
2024-09-03 07:59:37 -03:00
Benjamin Jackson
f88812443d refactor(Core): Correct typo. (#19830)
Init.
2024-08-31 17:38:03 -03:00
Andrew
806d4962cf fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets (#19752)
* fix(Scripts/Spells): L1 Arcane Charge should hit 3 targets

* Daily Nitpicks
2024-08-27 22:26:05 +02:00
Jelle Meeus
53e0779ae8 fix(Scripts/Spells): General's Heart trinket (#19756)
* handle aura with spell_gen_absorb0_hitlimit1

* refactor enscapsulate limit
2024-08-27 22:25:41 +02:00
Andrew
52cd493ad8 fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by dama… (#19730)
* fix(Scripts/BlackTemple): L5 Arcane Charge should be modified by damage taken mods

* Create rev_1724540286668312700.sql

* Update spell_generic.cpp

* update to new format
2024-08-26 01:25:10 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
Saqra1
a950a7f44e fix(Core/Pets): Add option to revive pets with full mana (#19383)
* fix(Scripts/Spells): Revive pets with full mana in bgs

* Pets were incorrectly revived without restoring its mana

* Closes #15894

* ready for merge

---------

Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-17 12:38:10 +02:00
avarishd
90c7658320 fix(Script/Spells): Script Glumdor's Steal Weapon (#19258)
* fix(Core/Spells): Script Glumdor's Steal Weapon

* add creature check
2024-07-17 01:44:49 +02:00
sudlud
37e3d89f91 fix(CI): linux-build: add -Werror parameter (#19240)
* fix(CI): linux-build: add -Werror parameter

* add KI

tzunu

* Revert "feat(CI): enable fail-fast for pch/nopch (#19058)"

This reverts commit 564cbca7d3.

* Update midsummer.cpp - drop unused variable

* initialize variable

* Update core-build-nopch.yml - drop gcc12

* fix(Core/CalendarMgr): do not use element after delete, but before

* attempt to fix Socket.h error

* Revert "attempt to fix Socket.h error"

This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.

* fix Socket.h error - attempt 2

* Update Socket.h

* Update Socket.h

* npc_shattrath_daily_quest: init variable templateID

* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()

* boss_archimonde: drop unused variable

* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"

This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.

* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough

* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058)""

This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-07-07 22:00:24 +02:00
avarishd
76b389ed07 fix(Core/Spells): Script Drunken Haze & Drunken Skull Crack (#19164)
* fix(Core/Spells):  Script Drunken Haze & Drunken Skull Crack

* bruh

* sigh
2024-06-25 22:36:25 +02:00
xaenerys0
03031d3616 fix(Scripts/Spells): Flag of Ownership (#18757)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-06-16 10:20:25 +02:00
Jelle Meeus
845fa07aad fix(Scripts/Ulduar): update Boss Keepers, Gossip Keepers, Yogg Keepers, Yogg-Saron (#18943)
* gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

* refactor: remove _keepersGUID[4]

* make keeper auras only target players, remove apply scale immunity to well/keepers

include caster in cast

* update keeper flags

* summon and despawn gossip keepers

spawn only if fight done

add intro spell and handle outro

fix off by 1

fix casting simple teleport, only spawn after teleporting

remove empty line

* add teleport to shared ulduar.h

* each keeper triggers their own gossip spawn

* update is called in Reset(), no need to do it here

* add SpellHit override to Freya, Hodir

* Freya, Hodir: use scheduler to schedule post-fight teleport

* JustSummoned rename cr to summon

* sanity well summons are handled by freya instead of sara

* rename pCreature to creature

* keeper use RegisterUlduarCreatureAI

* Freya, Hodir, Thorim: increase despawn time

* despawn tentacles, sanity wells after fight

despawn tentacles after fight

* change order of teleport spells

* am missing header?
2024-05-25 12:06:21 -03:00
Jelle Meeus
d44c8990c1 fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaumeux (#18807)
* fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaumeux

* remove blank line

* remove four_horsement_consumption SpellScript

* update comment
2024-05-11 13:54:26 +01:00
Anton Popovichenko
22f2a8f731 fix(Core/Spell): Fix crash in Rogue T10 4P Bonus (#18413) 2024-02-25 19:55:32 -03:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
天鹿
bf87cc5230 fix(Core): Build (#17989)
Update spell_generic.cpp
2023-12-11 09:54:44 -03:00
Angelo Venturini
31b66ad80a fix(Core/SSC): Fix Lady Vashj summons (#17982) 2023-12-11 02:46:12 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Kitzunu
5bfeabde81 chore(Core/Misc): rename spellInfo pointers (#17914)
* Rename all
2023-12-02 06:03:15 -03:00
avarishd
bc688c2a51 fix(Core/Spells): Script Choking Vines (#17615)
* fix(DB/Custom): Choking Vines should stack from different sources

* script spell

* comment
2023-11-02 08:53:45 -03:00
avarishd
39bad395c2 fix(Core/Spells): Script Yeh'kinya's Bramble (#17516)
* fix(Core/Spells): Script Yeh'kinya's Bramble

* rogue screechers
2023-10-21 08:10:00 -03:00
avarishd
2c28cc0eb7 fix(DB/Items): Unhatched Jubling Egg obtaining + RP (#17478) 2023-10-20 20:39:04 -03:00
avarishd
e30718db36 fix(Core/Spells): Script Scourge Banner (#17523)
* fix(Core/Spells): Script Scourge Banner

* correct statecheck
2023-10-16 23:13:54 +02:00
avarishd
91c6bdd540 fix(Core/Spells): Script Lord Valthalak's Amulet (#17431)
* fix(Core/Spells): Script Lord Valthalak's Amulet

* cs
2023-10-07 07:34:35 -03:00