Commit Graph

97 Commits

Author SHA1 Message Date
Francesco Borzì
cb7e28df05 refactor(src/server/game/*): remove unused imports (big part 1) (#20310) 2024-10-27 10:25:40 +01:00
Francesco Borzì
5a96ce283d refactor(Scripts): remove unused imports (#20086) 2024-09-29 13:20:21 +02:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
Francesco Borzì
393d9a5987 refactor(Scripts/Outland): remove unused imports (#19461) 2024-07-21 19:15:20 -03:00
Jelle Meeus
0dc822d21e fix(Scripts/Magtheridon): Clicking cubes should Banish Magtheridon (#18856)
* init

* rewrite without action

* fix: add Talk(SAY_BANISH)
2024-05-04 11:56:48 -03:00
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
IntelligentQuantum
79a2bb84e9 chore(Scripts/Outland): Remove useless includes (#18049) 2023-12-24 09:37:41 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
KJack
3d20f8902b feat(Core/Instance): InstanceScript: create Remove functions (#17702)
InstanceScript: create `Remove` helper functions
2023-11-14 08:13:28 -03:00
Dan
29af6cc886 fix(Scripts/Magtheridon): make the timers of Quake and Blast Nova independent from each other (#17364)
* initial

* fix timers

* add delay for duration

* Update boss_magtheridon.cpp

10s
2023-09-28 05:48:40 -03:00
Angelo Venturini
be5db26d24 fix(Scripts/MagtheridonLair): Magtheridon Debris (#17249)
* fix(Core/Scripts): Magtheridon Debris

* unhack

* cleanup

* eof line

* unused variable

* more cleanup
2023-09-17 07:43:10 -03:00
Dan
76d1d02dce fix(Scripts/Magtheridon): add correct way to reset threat list (#17198)
* test

* fix but check

* fix?
2023-09-06 18:33:34 +02:00
Eddy Vega
056b28ea21 fix(Scripts/Magtheridon): Remove ThreatList before release (#17128)
init
2023-09-05 06:37:04 -03:00
Dan
dd647da913 fix(Scripts/MagtheridonsLair): make it so no attack is being done during Quake and fix p1 cheese tactic (#17136)
* initial

- adds condition for taunt speech
- makes it so no attack happens whatsoever during quake

* fix p1 channeler skip bug

* initialise channelers

* doforallminions

* thisiswhathappenswhenyoucodeinbrowser

* Update src/server/scripts/Outland/HellfireCitadel/MagtheridonsLair/boss_magtheridon.cpp

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-09-04 21:20:09 -03:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Skjalf
93113edc7d fix(Scripts/MagtheridonLair): Script Manticron Cube conditions (#16867)
* fix(Scripts/MagtheridonLair): Script Manticron Cube conditions

Co-Authored-By: Lucas Nascimento <keader.android@gmail.com>

* Create rev_1690769530684832000.sql

Co-Authored-By: Lucas Nascimento <keader.android@gmail.com>

* missing include

* warning

---------

Co-authored-by: Lucas Nascimento <keader.android@gmail.com>
2023-08-01 16:11:12 -03:00
Angelo Venturini
5c132654cd fix(Scripts/MagtheridonLair): Fix double schedule (#16831) 2023-07-27 23:44:47 -03:00
Dan
338a5fe308 fix(Scripts/Magtheridon): allow for Magtheridon to also break free immediately when all Hellfire Channelers are killed (#16794)
* initial

* oops

* add space

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>

* another space

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>

* everything in doaction, scheduler is dumb

* leftovers

turns out the free say line was unused

---------
2023-07-23 03:27:19 -03:00
Angelo Venturini
5aa44033ab fix(Scripts/MagtheridonsLair): Fix emote spam (#16746) 2023-07-12 16:08:13 -03:00
Angelo Venturini
a8964a6ed1 fix(Core/Magtheridon): Fix Manticron Cube mechanic (#16745) 2023-07-12 14:17:34 -03:00
Angelo Venturini
09541e3bd7 fix(Scripts/MagtheridonsLair): fix Magtheridon's Quake spell (#16730)
* fix(Core/Magtheridon): fix Magtheridon's Quake spell

* missing sql
2023-07-10 22:34:34 -03:00
Gultask
e29429462c chore(Scripts/MagtheridonsLair): Adjust Magtheridon's timers (#16723)
Update boss_magtheridon.cpp
2023-07-10 05:59:55 -03:00
Dan
fd474c8b40 fix(Scripts/HellfireRamparts): Nazan and Vazruden properly reset (#16694)
* initial

dumb mistake made by me. probably fixed now

* Update boss_vazruden_the_herald.cpp

dumdum
2023-07-09 01:39:19 -03:00
Angelo Venturini
fb7164be05 fix(Scripts/HellfireRamparts): Fix Nazan not casting abilities (#16598) 2023-06-21 23:26:11 -03:00
Skjalf
7ae4b85c43 fix(Scripts/HellfireRamparts): Fix Gargolmar Retalliation procs with … (#16585)
fix(Scripts/HellfireRamparts): Fix Gargolmar Retalliation procs with targets behind him
2023-06-18 11:54:05 -03:00
Dan
a10c183e99 chore(Scripts/MagtheridonsLair): rework Magtheridon boss script (#16527)
* initial commit

* remove leftovers

* codestyle
2023-06-14 18:23:13 -03:00
Angelo Venturini
7a37d51538 refactor(Scripts/ShatteredHalls): move Porung from SAI to cpp (#16417)
* refactor(Scripts/ShatteredHalls): move Porung from SAI to cpp

* Space
2023-06-06 23:38:01 -03:00
Dan
40eb5da6d5 fix(Scripts/ShatteredHalls): hack fix to prevent pets from pulling the non-attackable peons in Nethekurse room (#16396)
* initial

hack fix added

* add sql to change unit flags

* using setimmunetoall() instead

* remove comment add credit

bump

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

* Update update-peon-unit-flag.sql

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

* add intro start on lockpick

might still have some troubles with double starting the intro with AT
--please give report if so

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-31 23:22:38 -03:00
Skjalf
1e49eef413 fix(Scripts/ShatteredHalls): Nethekurse shouldn't roleplay in combat (#16395) 2023-05-28 17:40:15 -03:00
Skjalf
d985615908 fix(Scripts/ShatteredHalls): Fire Executioner's call on heroic only (#16394) 2023-05-28 17:40:06 -03:00
Skjalf
97f3037021 fix(Scripts/ShatteredHalls): Implement the Flame Gauntlet event (#16383)
Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-28 15:50:50 -03:00
Gultask
ce788f68c2 fix(Scripts/ShatteredHalls): Prevent boss from being pulled early (#16389)
* init

* Update boss_nethekurse.cpp
2023-05-28 14:43:56 -03:00
Angelo Venturini
0755f8cde3 fix(Core/Script): Kargath should prevent adds spawn on death (#16388) 2023-05-28 13:28:35 -03:00
Skjalf
cd248ef665 fix(Scripts/ShatteredHalls): Fix Nethekurse delay after peon dies (#16384)
* fix(Scripts/ShatteredHalls): Fix Nethekurse delay after peon dies

* Update boss_nethekurse.cpp

* typo

* Update boss_nethekurse.cpp

* Update boss_nethekurse.cpp
2023-05-28 10:52:46 -03:00
Angelo Venturini
a56a400a13 fix(Scripts/ShatteredHalls): Rewrite Warchief Kargath Bladefist (#16355) 2023-05-23 06:48:23 -03:00
Angelo Venturini
67be37def6 fix(Core/Scripts): Rewrite Warbringer O'mrogg (#16346)
* fix(Core/Scripts): Rewrite Warbringer O'mrogg

* typo
2023-05-21 18:24:07 -03:00
Skjalf
6a73c38eb6 fix(Scripts/ShatteredHalls): Rework Nethekurse (#16265) 2023-05-21 18:11:31 -03:00
Gultask
c5f2031833 chore(Scripts/BloodFurnace): Clean up Keli'dan script (#16321)
* init

* Update rev_1684449165991504600.sql

* leftover
2023-05-20 18:25:38 -03:00
Eddy Vega
1724088e06 fix(Scripts/HellfireCitadel): Mass struct/model update (#16264)
* init

* .

* check codestyle (ubuntu-20.04)

* ubuntu-20.04-clang-with-modules

* clang
2023-05-14 19:13:42 -03:00
Dan
7e258bbd28 fix(Scripts/ShatteredHalls): fix some timers/mechanics of Grand Warlock Nethekurse (#16167) 2023-05-13 16:36:07 -03:00
Dan
8e28b64ccf fix(Scripts/HellfireRamparts): modernise boss scripts for Hellfire Ramparts (#16250)
* first two bosses

* add vazruden+nazan

* dumb mistake fix

* remove double summon say from Omor

* new attempt at scheduling talking

* fix boolean condition for speaking

* debug

* revert debug

* initial

* diff comment
2023-05-13 14:50:46 -03:00
Dan
154fa624f0 fix(Scripts/ShatteredHalls): fixes to Warbring O'mrogg combat scripts and timers (#16091)
* initial attempt at combat fix

with modernising

* fixes to scheduler

first Draft PR commit. Scheduler now works with boolean in capture list of lambda function.

* whitespaces

* debug

* debug2

* debug3

* debug4

* add omrogg equip query and debug5

* remove tabs

* Update data/sql/updates/pending_db_world/omroggequip.sql

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

* grouped taskscheduler

* added more groups

* adjust timer

* better handling

* v2 (too many commits)

* fixed melee

* clean up debug info

removal of yells

* more debug

* attempt at fix

* some changes to scheduling

* final

* whitespaces and extra lines

* better formatting

* final whitespace fix

* context fix

* dumb fix

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-13 14:01:22 -03:00
Gultask
fec1692716 fix(DB/SAI): Rework Trash SAI for Blood Furnace (#16123)
* init

* Update rev_1682710323496877200.sql
2023-05-10 06:29:01 -03:00
Skjalf
590dcca82b chore(Scripts/BloodFurnace): Clean up unused code in Broggok script (#16145)
* chore(Scripts/BloodFurnace): Clean up unused code in Broggok script

* Update boss_broggok.cpp
2023-05-01 01:09:44 -03:00
Gultask
c3948567e2 fix(Scripts/ShatteredHalls): Update Grand Warlock Netherkurse (#16063)
init
2023-04-23 09:06:08 -03:00
Kitzunu
bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Skjalf
65f031c340 refactor(Scripts/BloodFurnace): Modernize Broggok script (#14982) 2023-02-12 23:43:33 -03:00