Commit Graph

5355 Commits

Author SHA1 Message Date
Dan
c513da85c8 fix(Scripts/SSC): some Vashj fixes (#18276)
* initial

* script tainted elemental

* sql

* codestyle
2024-02-06 17:47:37 +01:00
Yunfan Li
9784f932e9 Merge branch 'master' into Playerbot 2024-02-06 17:51:47 +08:00
Dan
1ec72ae6dc fix(Scripts/TheEye): add Kael adds to the cpp script (#18257)
* initial

* add sql file to change to script

* make sure scheduler runs

* fix focus gaze mechanic

* leftover tabs

* remove comment
2024-02-04 11:11:12 -03:00
sudlud
186cb58a0f fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs (#18239)
* fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs

* update comments and waypoints for smoother movement

* move initalization to Reset() function
2024-02-03 15:11:36 +01:00
Kalimist
1324f420f2 Fix(Core/CharacterHandler): Incorrect behavior using an equipment set… (#18253)
* Fix(Core/CharacterHandler): Incorrect behavior using an equipment set if it will result in a full inventory.

* Fixing the error message to -Equiment swap failed - inventory is full- like the Blizzlike error message
2024-02-03 14:34:33 +01:00
3ster
000ec142a2 Check if triggered spell has cast time (#18231)
* Check if triggered spell has cast time

* Fix client crash upon manually cancelling finished spell
2024-02-03 11:52:34 +01:00
sudlud
a2f21bd46e fix(Scripts/Midsummer): Add SpellScript for "Fire Festival Fortitude" (#18246)
- implement zone wide buff
- Blizzard originally used gameobject 181431 'Fire Festival Fury Trap'
  for this implementation
2024-02-01 09:17:17 -03:00
Benjamin Jackson
b6c429c5a8 fix(Core/Quests): Create quest money reward config and adjust max level bonus reward function. (#18222)
* Init.

* Drop RewardBonusMoney column.

How's that for deprecation.

* Add formula source link.

* Remove deprecated info in conf.

* Newline.
2024-01-31 23:21:27 +01:00
Dan
ba01bec5b3 fix(Scripts/SSC): make sure Vashj faces the random people when doing Forked Lightning (#18232)
initial
2024-01-30 06:27:24 -03:00
Yunfan Li
1ef5b9a6b4 Merge branch 'master' into Playerbot 2024-01-29 11:46:32 +08:00
Kitzunu
69dc8804e6 feat(Core/Spell): Add helper for TriggeredCastFlag (#18227)
* feat(Core/Spell): Add helper for TriggeredCastFlag

* Lol

* fix build
2024-01-26 13:51:42 +01:00
Flashaholic88
c18bd64136 fix(Core/Misc): typo (#18221) 2024-01-23 21:38:32 +01:00
Kitzunu
26b50b8849 fix(Conf): typo (#18209) 2024-01-23 18:09:25 +01:00
Yunfan Li
b314b04001 Merge branch 'master' into Playerbot 2024-01-23 12:31:39 +08:00
Mike Delago
d0eae390b6 fix(Core/DatabseWorkerPool): implement DatabaseIncompatibleVersion to better support MariaDB (#18201)
* fix(Core): Rework Database Version Check for MariaDB support

* incorporate "smarter" version comparison

* rename function to be more accurate

* Factor magic numbers into defines. Revise comments

* clean up triple newline

* Doxygenify the docs

* remove blankspace

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-01-21 14:48:57 +01:00
sudlud
e447351b0f fix(Core/Creature): Remove automated z spawn correction (#18200)
* fix(Core/Creature): Remove automated z spawn correction

* comment out unused parameter

* remove gridLoad parameter from Creature::LoadCreatureFromDB()
2024-01-21 07:33:00 -03:00
Benjamin Jackson
c9bc5084be fix(Scripts/Midsummer): Correct behavior for Striking Back quests. (#18171)
* Init.

Make use of spell for summoning Ahune's lieutenants, set up gossip/smart scripts for the cast and lieutenant summon speech, and remove permanent lieutenant spawns.

Partially cherry-picked from 91268f6631

Co-Authored-By: Xfurry <172444+xfurry@users.noreply.github.com>

* Use GUIDs for creature delete, add game_event_creature delete.

* Various adjustments.

Move comment block, add Desolace stones gossip menu options, add a delete before insert.

* Set up conditions.

* Add spell cast comments.

Sourced from Wrath Classic Wowhead.

* Add basic combat SmartAI.

* Remove comment block.

* Add creature name comments.

* Use `id1` in preparatory creature delete.

---------

Co-authored-by: Xfurry <172444+xfurry@users.noreply.github.com>
2024-01-21 00:05:18 +01:00
MellianStudios
a89fa73b72 fix(Scripts/Command): prevent crash on set motd (#18203)
* prevent crash on set motd

* updated version

* another version

* Update cs_server.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-01-21 00:04:46 +01:00
Tereneckla
4cfad0ffac fix (Core/Unit) Apply Capacitor cooldown on trigger proc instead of on stack add (#18189)
fix capacitor cooldown
2024-01-20 08:51:49 -03:00
Dan
9024ec314d fix(Scripts/SSC): make sure Vashj doesn't move during P2 (#18187)
* initial commit

* final
2024-01-20 08:50:07 -03:00
Anton Popovichenko
423b676802 fix(Scripts/IcecrownCitadel): Fix Sindragosa respawn (#18179)
Fix Sindragosa respawn
2024-01-16 08:37:05 -03:00
Yunfan Li
9e172c9113 Merge branch 'master' into Playerbot 2024-01-15 21:00:38 +08:00
Pedro Antonio
2c7c3b6832 fix(CORE/OPvP): Halaa Mechanics not working properly (#15634) 2024-01-14 14:00:53 -03:00
Alethrion
e5a130d67f fix(Scripts/Karazhan): Add cleave and threat resets to Nightbane (#18133)
* Threat_Reset_Cleave

* Minor_Fix

* Fix_Threat_Timing

* Fix_Cleave_Targeting
2024-01-14 11:09:50 -03:00
daobashun
bd296db80c fix(Scripts/IcecrownCitadel): Lich King Whispers uses localized languages (#18125) 2024-01-14 11:09:04 -03:00
sudlud
8720e08da8 fix(DB/SAI): Move GameObjectScript go_midsummer_bonfire to SAI (#18135) 2024-01-14 11:08:18 -03:00
sudlud
1785df7117 fix(Core/Player): Fix Player not starting at full health (#18136)
* fix(Core/Player): Fix Player not starting at full health

* remove first call to UpdateMaxHealth() and SetFullHealth()
2024-01-14 11:07:52 -03:00
Yunfan Li
b70e64dbcf Merge branch 'master' into Playerbot 2024-01-14 15:23:52 +08:00
Nathan Handley
4321b8a4de feat(Core/Scripting): Implement new hook OnBeforePlayerLogout() (#18163)
* new hook OnPlayerPreLogout

* Changed PreLogout to BeforeLogout per review

* Renamed OnPlayerBeforeLogout to OnBeforePlayerLogout per review

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-01-14 00:10:49 +01:00
Angelo Venturini
a1891d8d8f fix(Core/ThreatMgr): Remove temp threat on resetting threat list (#18162) 2024-01-13 05:45:43 -03:00
Andrew
c863a8cfb5 fix(Scripts/Rogue): Fix Vanish not granting stealth (#18155) 2024-01-12 02:28:32 -03:00
sudlud
96d8d1d89a fix(Core/Creature): Reduce z offset for automated spawn correction (#18153)
- this is necessary to correctly spawn creatures within small defines
- 0.42f is as good as 1.0f to detect and correct reasonable z errors
in DB spawn data
2024-01-11 11:15:41 -03:00
Grimgravy
db4a6bab34 fix(Scripts/Quest): improve Securing the Celestial Ridge (#17847)
* fix(Scripts/Quest): improve Securing the Celestial Ridge

* update
2024-01-08 19:46:05 +01:00
daobashun
9c95ac6d2e fix(Scripts/PilgrimsBounty): Correct text for Turkey Tracker (#18123)
* closes https://github.com/chromiecraft/chromiecraft/issues/6356
2024-01-08 19:41:26 +01:00
Yunfan Li
600b0873e7 Merge branch 'master' into Playerbot 2024-01-08 23:30:50 +08:00
Andrew
e9ab01cc3b fix(Scripts/SerpentshrineCavern): Fix Lurker pool not respawning afte… (#18130)
fix(Scripts/SerpentshrineCavern): Fix Lurker pool not respawning after being fished after a wipe
2024-01-07 19:53:58 +01:00
Andrew
39ea396113 feat(Scripts/Commands): Implement gameobject respawn command (#18129) 2024-01-07 17:58:17 +01:00
Kitzunu
bceb6173c2 fix(Core/Player): Sometimes Player whisper is sent as boss whisper (#18128)
* fix(Core/Player): Sometimes Player emot is sent as boss whisper

* actually change it to whisper as it is boss whisper

* Update Player.cpp
2024-01-07 12:14:20 -03:00
Kitzunu
7a859da266 fix(Script/Spell): Vanish Purge behavior (#18127) 2024-01-07 12:03:53 -03:00
Yunfan Li
cb795ae5d4 Merge branch 'master' into Playerbot 2024-01-07 22:41:44 +08:00
Alethrion
d069fe5dac fix(Scripts/SSC): Update Hydross Mark Timers (#18114)
* Scheduler_Fix

* Thanks_Bench

* Thanks_Again_Bench

* Thanks_elthehablo

* Stupid_Last_Line
2024-01-06 19:23:46 +01:00
Yunfan Li
213300bf66 Merge branch 'master' into Playerbot 2024-01-06 17:54:45 +08:00
Kitzunu
2558f25623 fix(Core/Quest): Calculate reward money with RATE_REWARD_BONUS_MONEY … (#18104)
* fix(Core/Quest): Calculate reward money with RATE_REWARD_BONUS_MONEY instead of RATE_DROP_MONEY

* Update worldserver.conf.dist
2024-01-04 18:57:53 +01:00
Yunfan Li
ccf92f481d Merge branch 'master' into Playerbot 2024-01-04 19:22:20 +08:00
Kitzunu
6202835cff fix(Core/LFG): Hide XP from max players (#18103)
* Cherry-pick Player::IsMaxLevel from TrinityCore
* Correctly hide XP reward for max level players in LFG
* Closes #18101
2024-01-03 19:47:26 +01:00
AG
8f127f9e21 Fix combat movement (#18026)
* Improve combat movement

 - Removed a bunch of logic related to another attempt at fixing combat movement.
- Removed SMART_ACTION_SET_CASTER_COMBAT_DIST and updated smarts scripts accordingly.
- Cherry-picked 7fb7432620
- Cherry-picked 63a6e1e048

Co-Authored-By: Ludovic Barbier <ludovic.barbier03@gmail.com>
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>

* Some more cleanup + fix sql

* More fixes to caster chase/combat movement + some cherry picks because why not

- Fix casters always trying to chase to melee range
- Fix casters another case of casters sometimes walking back instead of stopping
- Cleaned up some code
- Cherry picked ca25e8d019
- Cherry picked 96b289cadb

Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>

* Added parentheses

* Fixed caster combat movement when target is rooted

- Made a few adjustments to chase range and stuff, but nothing set in stone.

* convert uint to int

---------

Co-authored-by: Ludovic Barbier <ludovic.barbier03@gmail.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2024-01-03 09:56:24 +01:00
Andrew
f9f71fff36 fix(Core/Player): Check if the player can summon the warlock pet on B… (#18064)
fix(Core/Player): Check if the player can summon the warlock pet on BG ress
2024-01-01 14:56:32 +01:00
Andrew
413cde96dd refactor(Scripts/Areatrigger): Move Scholazar Waygate script to SAI (#18054)
* refactor(Scripts/Areatrigger): Move Scholazar Waygate script to SAI

* Update rev_1703449890835634600.sql
2024-01-01 14:01:16 +01:00
Andrew
c4a7ef2eb0 refactor(Scripts/TheEye): Update Astromancer's spellscripts to new re… (#18058)
refactor(Scripts/TheEye): Update Astromancer's spellscripts to new register method
2024-01-01 14:00:33 +01:00
Andrew
e3fd42f3d4 feat(Core/World): Implement DoForAllPlayers() helper for all online p… (#18060)
* feat(Core/World): Implement DoForAllPlayers() helper for all online players

* Update src/server/game/World/World.cpp

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>

* Update src/server/game/World/World.cpp

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>

* rename

* Update WorldMock.h

* Update WorldMock.h

---------

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>
2024-01-01 13:57:57 +01:00