Jelle Meeus
775b9ff29a
fix(Core/Player): correct SpellPriority logic ( #21052 )
...
Co-authored-by: killerwife <killerwife@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2025-04-30 02:09:20 +01:00
Jelle Meeus
094c15a323
fix(Core/Spells): implement SPELL_ATTR7_TREAT_AS_NPC_AOE ( #21787 )
...
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2025-03-28 11:18:40 +01:00
Jelle Meeus
00eeb0051a
fix(Core/SpellAuraEffects): use caster's level to scale amount to break crowd control auras ( #20153 )
2024-12-06 12:19:03 +01:00
Kitzunu
ed008a8780
refactor(Core/Spells): Add helpers for HasAuraType ( #20802 )
2024-12-01 08:50:59 -03:00
Jelle Meeus
9a1f27121a
fix(Core/Unit): Flight Form riding crop, vehicle speed auras ( #20079 )
...
* vehicle aura stacking
Rename flight speed related auras
Co-authored-by: Laise <fenrisse@gmail.com >
* rename to better match existing flight auras
2024-10-01 21:39:42 +02:00
Kitzunu
386aea03ee
chore(Core/Misc): Some cleanup ( #19970 )
...
* remove weird blanks
* update if
* ) ) to ))
* missed some ) )
* now switch
* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Grimdhex
7457aef78d
refactor(Core/Entities): Cleanup Unit header file ( #19622 )
...
* move several enum definitions in a new files
* move more things
* remove the include comment
* move the related code to CharmInfo in this own file
*original idea of Ovahlord
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* fix clang build errors and few blank lines
* missing forward declaration
* new tentative to fix gcc/clang build
* add several include could be necessary for gcc/clang compilation
* .
* revert some include since the last AC update
* fix some loop inconsistencies
* align all enums in UnitDefine.h
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-08-15 05:12:44 -03:00
Tereneckla
6289be19c7
fix (Core/Spells): Commanding Shout and Blood Pact remember percentage of health ( #19479 )
...
* Update SpellAuraEffects.cpp
* add comment
2024-07-26 21:47:04 -03:00
Kitzunu
8bca8a45ed
chore(Core/Spells): Fix compile warning ( #19278 )
...
* chore(Core/Spells): Fix compile warning
* s
2024-07-04 14:47:36 -03:00
Kitzunu
385d7fd515
chore(Core/DBC): define unused unknown dbc fields ( #19262 )
...
* chore(Core/DBC): define unused unknown dbc fields
* Name unused unknown dbc fields using WDBX and wowdev.wiki
* rename SpellShapeshiftEntry to SpellShapeshiftFormEntry to properly match the DBC used
* rename sSpellShapeshiftStore to sSpellShapeshiftFormStore to properly match the DBC used
* Comment out unused field for GlyphPropertiesEntry
* Comment out unused field for MapEntry
* forgot one
* SpellShapeshiftfmt to SpellShapeshiftFormfmt
* SpellShapeshiftFormEntryfmt
2024-07-04 14:23:25 -03:00
Kitzunu
193e906a84
fix(Core/Spells): Shapeshift should show in Old Hillsbrad Foothills a… ( #19274 )
...
fix(Core/Spells): Shapeshift should show in Old Hillsbrad Foothills as horde
2024-07-04 14:21:33 -03:00
avarishd
63c8c6480e
fix(Core/Spells): Eye of Grillok improvements ( #19148 )
...
* fix(Core/Spells): Eye of Grillok improvements
* my eyes
* discovery of RegisterSpellAndAuraScriptPair
* comment
2024-06-29 07:33:23 -03:00
Jelle Meeus
77d3eb52df
fix(Core/Spell): Bladestorm remove reset swing and allow meleeSwingSpell during ( #19093 )
...
* remove reset swing
* allow meleeswingspell on PLAYER_ALLOW_ONLY_ABILITY
2024-06-26 22:23:09 +02:00
Benjamin Jackson
d6d49a9e45
refactor(Core/ObjectMgr): Implement display probabilities. ( #19068 )
...
* Init.
Cherry-picked from TC commits 9d210476e5 and c488fb219a
Co-Authored-By: Traesh <9392905+traesh@users.noreply.github.com >
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* Add brute data.
Needs validation against what existed before, i.e. Classic change prevention.
* Add validation info for brute data.
* Remove incomplete data queries.
* Requested changes.
* Whitespace.
* Requested change.
Table name.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Requested change.
Table name.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Resolve the funny merge conflicts.
I wonder why git blame doesn't work on a file with 20k lines in it that's odd huh champ.
* Remove unused parameter.
* Remove uses of unused parameter.
* Use unused parameter.
Hopefully?
* I will cry.
* Sobbing endlessly.
* Remove comment.
* Adjust table structure query.
Remove length parameters and allow null for build value.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Adjust column datatype and add check constraint.
---------
Co-authored-by: Traesh <9392905+traesh@users.noreply.github.com >
Co-authored-by: Shauren <shauren.trinity@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-06-16 18:12:16 +02:00
Andrew
78aaa136cc
fix(Scripts/BlackTemple): Fix Free Friend spell ( #19065 )
2024-06-15 13:43:30 -03:00
Mykhailo Redko
33f951d742
fix(Core/Spells): Fixed work of sobering spells and other improvements for drunk system ( #18390 )
...
* fix(Core/Spells): Fix sobering spells and possible uint8 overflow/underflow in SPELL_EFFECT_INEBRIATE handler.
* fix(Core/Spells): Improvements for SPELL_AURA_MOD_FAKE_INEBRIATE handling
2024-03-20 01:45:01 -03:00
Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
Nathan Handley
425a490a7b
feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType ( #18293 )
...
* Create HasActivePower for script intercept
* Replace relevant player-related getPowerType() comparators with HasActivePowerType
* Change OnPlayerHasActivePowerType to regular bool instead of optional
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-09 06:27:02 -03:00
IntelligentQuantum
258e369ee5
chore(Core): remove useless includes ( #18036 )
2023-12-23 12:16:27 -03:00
Angelo Venturini
10c9a2729b
fix(Core/SAI/SSC): Allow Farthest target to set a min distance ( #17992 )
2023-12-11 19:57:44 -03:00
Winfidonarleyan
eb1ecc38a5
feat(Core/Scripting): move all script objects to separated files ( #17860 )
...
* feat(Core/Scripts): move all script objects to separated files
* Apply 5bfeabde81
* try gcc build
* again
2023-12-02 21:13:20 +01:00
Andrew
d55b6753c9
feat(Core/Scripting): Implement Unit hooks to modify damage before ca… ( #17785 )
2023-11-18 23:36:59 -03:00
Christopher Galbraith
ae5bf57dba
fix(Core/Spell): Titan's Grip check if player has 2H and shield equipped ( #16984 )
...
* check if player has a 2H and shield equipped
* null check item2 for shield
* style whitespace
* removed unnecessary logic
* remove unnecessary brackets
---------
Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com >
2023-11-12 17:51:26 +01:00
Kitzunu
bbadc32bea
Revert Visibility Notifier changes ( #17682 )
...
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569 )"
This reverts commit 79b39f9655 .
* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480 )"
This reverts commit 60e27511c5 .
* Revert "fix(Core): GridCleanUpDelay Log (#17436 )"
This reverts commit 90b16ca065 .
* Revert "feat(Core/Grids): Implement visibility notifier (#15919 )"
This reverts commit 2779833768 .
2023-11-12 00:48:49 +01:00
Ludwig
2e5d5f2dc7
fix(Events): fix commoner spawns, auras and equips for all events ( #17632 )
...
* fix(Core/Spells): Implement Gossip NPC Appearance spells
65511 Gossip NPC Appearance - Brewfest
65522 Gossip NPC Appearance - Winter Veil
65523 Gossip NPC Appearance - Default
65524 Gossip NPC Appearance - Lunar Festival
65525 Gossip NPC Appearance - Hallow's End
65526 Gossip NPC Appearance - Midsummer
65527 Gossip NPC Appearance - Spirit of Competition
65528 Gossip NPC Appearance - Pirates' Day
65529 Gossip NPC Appearance - Day of the Dead (DotD)
* fix(DB/SAI): fix commoner spawns and auras
* equip random mug on spell 65511 Gossip NPC Appearance - Brewfest
* check if creature before equipping brewfest mug
* minor optical fixes, DELETE first, then remove duplicate spawns
* fix two displayIDs in NPC Gossip Appearance spells
* Remove whitespace at the end of the lines
* remove commoner spawns for event 7 Harvest festival from game_event_creature
* fix harvest festival event id
* Update rev_1698785311231174200.sql
2023-11-10 20:26:49 +01:00
Kitzunu
f757e93da5
refactor(Core/Misc): Make DeathState enum class ( #17607 )
2023-10-28 10:54:03 +02:00
AG
60e27511c5
fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation ( #17480 )
...
* Bug fixes
- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time
* Removed logic to set gameobject as active
- More alignement with TC.
- Reduces CPU usage drastically
* Revert back to using time_t instead of std chrono
* Invoke SetNoCreate() method to reduce CPU usage drastically
* Remove setActive from static and motion transports
* Fix performance issues
* Added SetFarVisible to WG and some dungeon scripts
- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)
* Removed comments related to VISIBILITY_COMPENSATION
* Fix log
* Deleted unused files + corrected a check
* Added missing header
* Removed unused parameter
* Removed another unsued parameter
* Changed vector to set for i_visibleNow
- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
avarishd
a39175bc3b
fix(Core/Spells): Demonic Knowledge missing 1% per rank ( #17495 )
2023-10-18 19:21:46 -03:00
KJack
f127e583aa
fix(core/scripting) Calculate percent-based damage before ModifyPeriodicDamageAurasTick hook ( #17387 )
...
Moved damage calculation for `SPELL_AURA_PERIODIC_DAMAGE_PERCENT` to before the hook.
Co-authored-by: KJack <kjack@electricnightowl.com >
2023-10-08 15:38:07 -03:00
AG
2779833768
feat(Core/Grids): Implement visibility notifier ( #15919 )
...
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Francesco Borzì
5d01b700fd
refactor(Core): remove unused imports ( #17094 )
2023-08-28 13:39:43 +02:00
UltraNix
c3acf75618
fix(Core/Spells): Taunt always set proper target while channelling sp… ( #13948 )
...
* fix(Core/Spells): Taunt always set proper target while channelling spells.
Fixes #13841
* Update.
* Update.
2023-08-06 03:16:05 +02:00
The GhostRider
2176435938
fix(Core/Spell): Net-o-Matic ( #16482 )
2023-06-08 22:33:31 -03:00
Gultask
64c7c99bda
revert(Core/Player): Revert Delayed Damage System ( #16246 )
...
* Revert "fix(Core/Spells): Delayed Damage system (#16183 )"
This reverts commit d282cce4af .
* Revert "fix: Crash on ProcessDelayedDamages (#16166 )"
This reverts commit 3dbdea5e28 .
* Revert "fix(core\player): Missing combat animation (#14199 )"
This reverts commit a238e5e27b .
2023-05-13 13:50:27 -03:00
M'Dic
7e58650cf5
revert(Core): ChrRace.dbc full implementation ( #16114 )
...
* revert (core): ChrRace.dbc full implementation
we revert this due to several issues arrising. Although the dbc reading is done in full and correctly. Azerothcore relied on the original handling (althought not propper) for so long that there is
* revert
* Update remove_charrace_dbc.sql
* Update remove_charrace_dbc.sql
* Update remove_charrace_dbc.sql
2023-04-29 08:23:11 -03:00
M'Dic
a238e5e27b
fix(core\player): Missing combat animation ( #14199 )
2023-04-29 12:27:13 +02:00
M'Dic
3eae4c5713
fix(core/dbc): improve ChrRace DBC handling ( #14843 )
...
Cherry pick of https://github.com/TrinityCore/TrinityCore/pull/24508
Co-authored-by: HelloKitty <5829095+HelloKitty@users.noreply.github.com >
2023-04-28 01:29:33 +02:00
M'Dic
8aa2a2ac0f
chore (core): Clean up ( #15977 )
...
* chore (core): Clean up
* Update SmartScript.cpp
* more clean up
* Update boss_xt002.cpp
2023-04-16 21:04:56 -04:00
UltraNix
1acbb9ee53
fix(Core/Spells): Fixed Spiritual Attunement not working with partial… ( #15767 )
...
fix(Core/Spells): Fixed Spiritual Attunement not working with partial overheals.
Fixes #14430
2023-04-02 10:13:16 -03:00
Gultask
0b04c7f3b6
fix(Core/Spells): Un-hack Spellcloth trigger spell ( #15284 )
...
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com >
2023-03-05 16:29:41 -03:00
Kitzunu
f039836a2f
chore(Core/Misc): Change all TODO to doxygen comment ( #14966 )
2023-02-12 10:05:34 -03:00
UltraNix
7f7a2f5a92
fix(Core/Creatures): Critters should start fleeing upon entering comb… ( #14253 )
2023-01-28 11:01:43 +01:00
UltraNix
44226e4754
fix(Core/Spells): Update crit chance on shapeshifting to/from feral f… ( #14683 )
2023-01-28 10:57:38 +01:00
UltraNix
7a03130b94
fix(Core/Spells): Regen auras should not be removed by Rapid Recupera… ( #14269 )
...
fix(Core/Spells): Regen auras should not be removed by Rapid Recuperation.
Fixes #14263
2023-01-06 00:53:10 +01:00
Angelo Venturini
9e18b86311
fix(Core/Auras): SPELL_AURA_MOD_SCALE should scale additively instead… ( #14425 )
...
...multiplicatively
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2023-01-02 20:43:20 -03:00
Kitzunu
4870b14b1f
refactor(Core/Object): getLevel() -> GetLevel() ( #14122 )
...
* refactor(Core/Object): getLevel() -> GetLevel()
* fix build and sneak some doxygen in
* codeSTLE
* codestyle
2022-12-31 17:39:23 +01:00
Skjalf
a73d4173df
feat(Core/Scripting): Pass SpellInfo through the ModifyPeriodicDamage… ( #14360 )
...
feat(Core/Scripting): Pass SpellInfo through the ModifyPeriodicDamageAurasTick() hook
2022-12-24 11:38:21 -03:00
Angelo Venturini
4992940453
fix(Core/Auras): Implement Roc form ( #13959 )
...
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com >
2022-12-11 10:58:20 -03:00