Commit Graph

2051 Commits

Author SHA1 Message Date
Dan
fb49062a56 fix(Scripts/TheEye): make sure Solarian always get reset to REACT STATE aggressive on reset (#18302)
initial
2024-02-12 08:17:24 -03:00
Dan
bf71d8e7f1 fix(Scripts/TheEye): some Al'ar fixes (#18305) 2024-02-12 08:16:46 -03:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Nathan Handley
425a490a7b feat(Core/Unit): New helper HasActivePowerType and script hook OnPlayerHasActivePowerType (#18293)
* Create HasActivePower for script intercept

* Replace relevant player-related getPowerType() comparators with HasActivePowerType

* Change OnPlayerHasActivePowerType to regular bool instead of optional

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-09 06:27:02 -03:00
Dan
d42e04097c fix(Scripts/TheEye): Solarian movement (#18268)
* first implementation

* better implementation

* don't move before first spell

* chase in p2 again

* Update boss_astromancer.cpp

* oops
2024-02-08 06:05:38 -03:00
Kalimist
65d6bd0472 fix(Core/Creature): hardcoded gossip in zone_azshara (#18289)
* Changing hardcoded text in #define to enum member

- Changing #define to new enum member for AddGossipItemFor method

* Adding SQL Query File

* Forgot to add ';' in DELETE FROM
2024-02-08 07:41:23 +01:00
Dan
af880d516f refactor(Scripts/ZulAman): refactor Halazzi (#18267)
* initial

* some fixes

* last booboos

* fixes after test

* finale

* actual final

* blegh
2024-02-07 23:43:38 -03:00
Dan
bc25ade498 fix(Scripts/TheEye): refactor Al'ar (#18264)
* initial

* restore quill event

* with ismoving and debug

* final before timers

* clear all debuffs

* remove justreachedhome bossai

* huh?

* some fixes

* more fixes

* add 2 extra platforms for p1

* fix coords

* finalise

* change melt armor timer so it is not delayed

indefinitely - this is because we have a dive after 30 secs
that delays all timers. So at 30 secs we will have melt armor at
33 seconds, which then gets an extra 15 seconds from the delay all and another dive
after 30 so it gets pushed back even more before being able to be cast
2024-02-07 23:43:19 -03:00
Dan
b8118fa06b fix(Scripts/TheEye): Re-factor Kael'thas (#18272)
* restructuring base files and instance files

* small fix

* some fixes

* fix

* some fixes

* up until kael phase

* weapon despawn fix

* final for now

* some minor details

* fix weapon despawn

* fix by clearing validator

still has debug statements to check how far we get

* finalise with stop casting

* codestyle

* remove redundant delay
2024-02-07 23:42:20 -03:00
Dan
c513da85c8 fix(Scripts/SSC): some Vashj fixes (#18276)
* initial

* script tainted elemental

* sql

* codestyle
2024-02-06 17:47:37 +01:00
Dan
1ec72ae6dc fix(Scripts/TheEye): add Kael adds to the cpp script (#18257)
* initial

* add sql file to change to script

* make sure scheduler runs

* fix focus gaze mechanic

* leftover tabs

* remove comment
2024-02-04 11:11:12 -03:00
sudlud
186cb58a0f fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs (#18239)
* fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs

* update comments and waypoints for smoother movement

* move initalization to Reset() function
2024-02-03 15:11:36 +01:00
sudlud
a2f21bd46e fix(Scripts/Midsummer): Add SpellScript for "Fire Festival Fortitude" (#18246)
- implement zone wide buff
- Blizzard originally used gameobject 181431 'Fire Festival Fury Trap'
  for this implementation
2024-02-01 09:17:17 -03:00
Dan
ba01bec5b3 fix(Scripts/SSC): make sure Vashj faces the random people when doing Forked Lightning (#18232)
initial
2024-01-30 06:27:24 -03:00
sudlud
e447351b0f fix(Core/Creature): Remove automated z spawn correction (#18200)
* fix(Core/Creature): Remove automated z spawn correction

* comment out unused parameter

* remove gridLoad parameter from Creature::LoadCreatureFromDB()
2024-01-21 07:33:00 -03:00
Benjamin Jackson
c9bc5084be fix(Scripts/Midsummer): Correct behavior for Striking Back quests. (#18171)
* Init.

Make use of spell for summoning Ahune's lieutenants, set up gossip/smart scripts for the cast and lieutenant summon speech, and remove permanent lieutenant spawns.

Partially cherry-picked from 91268f6631

Co-Authored-By: Xfurry <172444+xfurry@users.noreply.github.com>

* Use GUIDs for creature delete, add game_event_creature delete.

* Various adjustments.

Move comment block, add Desolace stones gossip menu options, add a delete before insert.

* Set up conditions.

* Add spell cast comments.

Sourced from Wrath Classic Wowhead.

* Add basic combat SmartAI.

* Remove comment block.

* Add creature name comments.

* Use `id1` in preparatory creature delete.

---------

Co-authored-by: Xfurry <172444+xfurry@users.noreply.github.com>
2024-01-21 00:05:18 +01:00
MellianStudios
a89fa73b72 fix(Scripts/Command): prevent crash on set motd (#18203)
* prevent crash on set motd

* updated version

* another version

* Update cs_server.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-01-21 00:04:46 +01:00
Dan
9024ec314d fix(Scripts/SSC): make sure Vashj doesn't move during P2 (#18187)
* initial commit

* final
2024-01-20 08:50:07 -03:00
Anton Popovichenko
423b676802 fix(Scripts/IcecrownCitadel): Fix Sindragosa respawn (#18179)
Fix Sindragosa respawn
2024-01-16 08:37:05 -03:00
Pedro Antonio
2c7c3b6832 fix(CORE/OPvP): Halaa Mechanics not working properly (#15634) 2024-01-14 14:00:53 -03:00
Alethrion
e5a130d67f fix(Scripts/Karazhan): Add cleave and threat resets to Nightbane (#18133)
* Threat_Reset_Cleave

* Minor_Fix

* Fix_Threat_Timing

* Fix_Cleave_Targeting
2024-01-14 11:09:50 -03:00
daobashun
bd296db80c fix(Scripts/IcecrownCitadel): Lich King Whispers uses localized languages (#18125) 2024-01-14 11:09:04 -03:00
sudlud
8720e08da8 fix(DB/SAI): Move GameObjectScript go_midsummer_bonfire to SAI (#18135) 2024-01-14 11:08:18 -03:00
Andrew
c863a8cfb5 fix(Scripts/Rogue): Fix Vanish not granting stealth (#18155) 2024-01-12 02:28:32 -03:00
Grimgravy
db4a6bab34 fix(Scripts/Quest): improve Securing the Celestial Ridge (#17847)
* fix(Scripts/Quest): improve Securing the Celestial Ridge

* update
2024-01-08 19:46:05 +01:00
daobashun
9c95ac6d2e fix(Scripts/PilgrimsBounty): Correct text for Turkey Tracker (#18123)
* closes https://github.com/chromiecraft/chromiecraft/issues/6356
2024-01-08 19:41:26 +01:00
Andrew
e9ab01cc3b fix(Scripts/SerpentshrineCavern): Fix Lurker pool not respawning afte… (#18130)
fix(Scripts/SerpentshrineCavern): Fix Lurker pool not respawning after being fished after a wipe
2024-01-07 19:53:58 +01:00
Andrew
39ea396113 feat(Scripts/Commands): Implement gameobject respawn command (#18129) 2024-01-07 17:58:17 +01:00
Kitzunu
7a859da266 fix(Script/Spell): Vanish Purge behavior (#18127) 2024-01-07 12:03:53 -03:00
Alethrion
d069fe5dac fix(Scripts/SSC): Update Hydross Mark Timers (#18114)
* Scheduler_Fix

* Thanks_Bench

* Thanks_Again_Bench

* Thanks_elthehablo

* Stupid_Last_Line
2024-01-06 19:23:46 +01:00
Andrew
413cde96dd refactor(Scripts/Areatrigger): Move Scholazar Waygate script to SAI (#18054)
* refactor(Scripts/Areatrigger): Move Scholazar Waygate script to SAI

* Update rev_1703449890835634600.sql
2024-01-01 14:01:16 +01:00
Andrew
c4a7ef2eb0 refactor(Scripts/TheEye): Update Astromancer's spellscripts to new re… (#18058)
refactor(Scripts/TheEye): Update Astromancer's spellscripts to new register method
2024-01-01 14:00:33 +01:00
Andrew
e3fd42f3d4 feat(Core/World): Implement DoForAllPlayers() helper for all online p… (#18060)
* feat(Core/World): Implement DoForAllPlayers() helper for all online players

* Update src/server/game/World/World.cpp

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>

* Update src/server/game/World/World.cpp

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>

* rename

* Update WorldMock.h

* Update WorldMock.h

---------

Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>
2024-01-01 13:57:57 +01:00
sudlud
87c3421262 fix(Scripts/Midsummer): Improve Torch Catching based on sniffs (#18071)
- Update creature 26188 '[PH] Torch Catching Target Bunny' with sniffed values
- correctly randomize torch target positions
2024-01-01 09:06:54 -03:00
Andrew
a11434b24f refactor(Core/GameObject): Move the GameObject state save handling to… (#18080)
* refactor(Core/GameObject): Move the GameObject state save handling to instance level

* Update GameObject.h

* remove leftover

* small improvements
2024-01-01 01:51:33 -03:00
Alexandru-Mihai Maftei
ebe89b875f fix(Scripts/ScarletMonastery): Prevent Whitemane from dying before resurrecting Mograine (#18082)
The current code only prevents Whitemane from dying before casting sleep, but the players can inflict enough DPS on her before that, that she can die before resurrecting Mograine.
When this happens, the dungeon is broken and cannot progress.
2023-12-30 12:47:02 -03:00
IntelligentQuantum
6a6cefb512 chore(Scripts/EK): remove useless includes (#18075)
* chore(Scripts/Kalimdor): remove useless includes

* chore(Scripts/EK): remove useless includes
2023-12-28 16:15:16 -03:00
IntelligentQuantum
fa884ae385 chore(Scripts/Kalimdor): remove useless includes (#18065) 2023-12-26 06:08:37 -03:00
sudlud
1710d4d1c3 fix(Scripts/Midsummer): Implement Midsummer Bonfire mechanics (#18023) 2023-12-25 03:06:15 -03:00
IntelligentQuantum
4ec284577e chore(Scripts/Northrend): remove useless includes (#18061) 2023-12-25 02:15:56 -03:00
IntelligentQuantum
79a2bb84e9 chore(Scripts/Outland): Remove useless includes (#18049) 2023-12-24 09:37:41 -03:00
Andrew
0ad882338c chore(Scripts): Remove placeholder Ironforge/AlteracMountains files (#18047) 2023-12-24 08:09:07 -03:00
Andrew
d83d623792 chore(Scripts/World): Remove unused legacy scripts (#18048) 2023-12-24 08:04:37 -03:00
attacksnack
b0ebaf4c96 fix(Scripts/Spells): Fix Ritual of Souls with Improved Healthstone 2023-12-23 23:29:34 -03:00
Andrew
330ed952df fix(Scripts/SerpentshrineCavern): Despawn Lurker's pool and fix visua… (#18037)
fix(Scripts/SerpentshrineCavern): Despawn Lurker's pool and fix visual issue on death
2023-12-23 16:12:07 +01:00
IntelligentQuantum
016bb86d3b refactor(Scripts): remove useless includes (#18004) 2023-12-22 18:41:28 +01:00
Andrew
9df2c485fc fix(Scripts/SerpentshrineCavern): Fix Lurker spawn coords and spout s… (#18014)
fix(Scripts/SerpentshrineCavern): Fix Lurker spawn coords and spout shouldnt hit players on water at all
2023-12-14 16:42:20 -03:00
Dan
4d40b03644 fix(Scripts/SSC): play emerge animation on the Lurker Below and make sure whirl doesn't happen during spout (#18009)
* initial

* forgor register hook
2023-12-12 20:13:12 -03:00
Angelo Venturini
18af46d357 fix(Core/SSC): Rancid Mushroom mechanic (#18008)
* fix(Core/SSC): Rancid Mushroom mechanic

* missing clear smart_scripts

* build

* build again
2023-12-12 18:29:05 -03:00
Andrew
00ee7bd920 fix(Scripts/SerpentshrineCavern): fix Hydross not casting Water Tomb … (#18003)
fix(Scripts/SerpentshrineCavern): fix Hydross not casting Water Tomb & Vile Sludge
2023-12-12 08:46:19 +01:00