Commit Graph

364 Commits

Author SHA1 Message Date
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Dan
a4dc083b42 fix(Scripts/Hyjal): move Hyjal boss waypoints to DB (#18299)
* put anetheron movement in wps

* move all wps to db for bosses
2024-02-12 08:17:39 -03:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Kalimist
65d6bd0472 fix(Core/Creature): hardcoded gossip in zone_azshara (#18289)
* Changing hardcoded text in #define to enum member

- Changing #define to new enum member for AddGossipItemFor method

* Adding SQL Query File

* Forgot to add ';' in DELETE FROM
2024-02-08 07:41:23 +01:00
IntelligentQuantum
fa884ae385 chore(Scripts/Kalimdor): remove useless includes (#18065) 2023-12-26 06:08:37 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Gultask
d3bef76fae fix(Scripts/Darkshore): Rabid Thistle Bear spawning with StandState Dead (#17875) 2023-11-26 21:22:58 -03:00
KJack
42ec86680c fix(Scripts/RuinsOfAhnQiraj): Andorov does not respawn after being killed (#17788) 2023-11-20 21:18:13 -03:00
Andrew
0fe18f7c6b fix(Scripts/ThousandNeedles): Improve the handling of quest 5151 (Hyp… (#17811) 2023-11-20 18:14:43 -03:00
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
Andrew
a5b5278929 refactor(Scripts/World): Clean up script files (#17728)
* refactor(Scripts/World): Clean up script files

* Update boss_azuregos.cpp
2023-11-16 14:00:42 -03:00
Andrew
deff0ac587 refactor(Scripts/Ashenvale): Move Naga Brazier script to SAI (#17733) 2023-11-16 13:58:42 -03:00
Andrew
d325332090 refactor(Scripts/OHF): Clean up script files (#17724) 2023-11-15 20:44:39 -03:00
Andrew
db851b483e refactor(Scripts/RuinsOfAhnQiraj): Clean up script files (#17723) 2023-11-15 20:41:56 -03:00
Andrew
03612e8bff refactor(Scripts/TempleOfAhnQiraj): Clean up script files (#17718)
* refactor(Scripts/TempleOfAhnQiraj): Clean up script files

* Update src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_fankriss.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_ouro.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-11-15 14:17:29 -03:00
avarishd
4cb25b4b5e fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds (#17667)
* fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds

* Ss

* DoForAllSummons
2023-11-14 08:53:17 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
KJack
f7fdc7cb6c refactor(Scripts/RuinsOfAhnQiraj)Ç AQ20: Modernize Kurinnaxx (#17671) 2023-11-10 18:59:46 -03:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
podmepodme
945d7c6afe fix(Script/Misc): Replace hardcoded gossip and texts with DB ones. (#17502)
* fix(CORE/Creature): replace shadowmoon valley hardcoded gossips

* fix(CORE/GameObject): replace terokkar forrest hardcoded gossips

* fix(Core/Creature): replace shattrath city hardcoded gossips

* style(Core): code style edit

* style(CORE) codestyle edit

* style(CORE) codestyle edit

* style(CORE): codestyle edit

* ready for merge

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-10-22 03:16:51 +02:00
avarishd
214948bafb fix(DB/Quest): Port Cleansing Witch Hill from Trinity. (#17420)
* fix(DB/Quest): Port Cleansing Witch Hill from Trinity.

https: //github.com/TrinityCore/TrinityCore/issues/22262
Co-Authored-By: Carlos Morales <carlos.morales@insmet.cu>

* ""

Co-Authored-By: Carlos Morales <carlos.morales@insmet.cu>

---------

Co-authored-by: Carlos Morales <carlos.morales@insmet.cu>
2023-10-10 20:26:43 -03:00
Skjalf
0bf559f975 feat(Core/Instance): Add TaskScheduler to the InstanceScript class (#17284)
feat(Core/Instance): Add TaskScheduler to the instancescript class
2023-09-17 10:56:02 -03:00
Kitzunu
f1111be152 chore(misc): cleanup (#17274) 2023-09-17 10:19:09 -03:00
Dan
45d6009cb7 fix(Scripts/Darkshore): ensure Kerlonian Evershade is always in bear form (#17062)
initial
2023-09-17 09:42:07 -03:00
Francesco Borzì
eaa6487fc2 refactor(Scripts): remove unused imports (#17097) 2023-08-27 22:25:22 -03:00
Anton Popovichenko
f4658a1df2 fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. (#17070)
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.

* Fix build
2023-08-25 09:15:07 -03:00
podmepodme
820eac083c fix(Scripts/Orgrimmar): replace hardcoded gossips in zone_orgrimmar (#16947)
* fix(CORE/Creature): replace hardcoded gossips in zone_orgrimmar

Closes AzerothCore issue #4179

* fix(CORE): Codestyle

* refactor(CORE/Character): Switch statement for thrall dialog

* fix(CORE): Codestyle
2023-08-25 08:52:51 -03:00
Skjalf
80a8f6d47a fix(Scripts/OHF): Don't update the escort steps when Drake dies (#17024)
* fix(Scripts/OHF): Don't update the escort steps when Drake dies

* update gossip req

* Update rev_1692233536025387200.sql
2023-08-20 15:46:39 -03:00
Dan
8621118b83 fix(Scripts/OHF): Fix not being able to start the escort if you already killed Lt. Drake (#17006) 2023-08-14 13:05:20 -03:00
Skjalf
8dc8424f09 fix(Scripts/OHF): Killing Drake should not be required to start Thral… (#17000)
fix(Scripts/OHF): Killing Drake should not be required to start Thrall's escort
2023-08-13 13:39:08 -03:00
Grimgravy
c256d8da55 fix(Scripts/Spell): Improve Inoculation quest (#15759)
* fix(Core/Quest): Improve Inoculation

* update fix

* .

* ..
2023-08-12 00:17:06 +02:00
Johaine
f0a96b4489 fix(Scripts/EscapeFromDurnholde): Fix escort mission getting stuck (#16636)
Fix stuck event

Fix escort event possibly getting stuck by preventing
DATA_ESCORT_PROGRESS from being decreased
2023-08-02 14:52:18 -03:00
Skjalf
d4e97a25f4 fix(Scripts/Azuregos): Arcane Vacuum should also reset pet threat (#16868) 2023-07-31 05:44:35 -03:00
天鹿
90e23cbc66 fix(Core/Raid): Archimonde's Unable to kill (#15128)
Fix(Core);[raid]Archimonde's BUG
2023-07-27 10:33:24 -03:00
Dan
b55ebc186d fix(Scripts/TempleOfAhnQiraj): make C'thun Dark Glare face location of last eyebeam before cast, instead of random target (#16785)
* initial

* fix oopsie

* whitespace
2023-07-18 08:45:58 -03:00
Dan
e5f0f97858 fix(Scripts/TempleOfAhnQiraj): let small Eye Tentacles attack the raid (#16784)
* initial

* whitespace

* hrm

* easier
2023-07-17 16:19:40 -03:00
The GhostRider
3186edc568 fix(DB/SAI): Shay Leafrunner (#16454)
* fix(DB/SAI): Wandering-Shay-Quest

* fix(DB/SAI): Wandering-Shay-Quest

* Update rev_1685747385631953200.sql

* Update rev_1685747385631953200.sql

---------

Co-authored-by: dario strani <xspid@lastrevenge.ddns.net>
2023-06-25 23:43:59 -03:00
Dan
a15016ac08 fix(Scripts/ZulFarrak): add Hearthstone mechanic to Blys party when event not started in time (#16333)
* initial

* codestyle

* remove unused taskscheduler

* fix unsummon mechanic

better syntax

* fix other issues

* another issue

* dummy fix

* should fix gossip and event

* attempt to fix movement

* attempt at fixing Bly walk

* also make Weegli hostile + another attempt at move

ment fix

* another attempt at walk fix

* initialise and debug

* debuggo

* v2

* moooore

* oops

* try to fix with boolean again

* fix?

* fixmaybe

* revert

* remove leftovers

* and more on Weegli
2023-06-18 12:06:59 -03:00
Johaine
5060407598 fix(Scripts/TheBlackMorass): rework time rift event logic (#16535)
* Fix visual crystals

This fixes the crystals not despawning on Medivh's death and being
resummoned after every reset

* Fix summoning circle visual after cleanup

Fix respawn of summoning circle visual NPC
Move respawn to same moment as Medivh respawn

* Fix race condition during script cleanup after event failure

This fixes the bug that rifts still spawn after shield is at 0%,
enabling players to exploit the instance and defeat bosses at their own
pace.

In general, removing rifts schedules spawning of new rifts

After failing the event (shield at 0%) this introduces a race between
rift despawn and (scheduler) cleanup

Fix it by introducing a check if the event has been started and should
still progress.

* Fix softlock of event during break after boss

Make sure that the delay condition is removed if event fails

Meeting certain conditions it was possible to softlock the event by
extending the after-boss-break indefinitely

* Cleanup failed instance without player interaction

This respawns Medivh and re-enables the event 5 minutes after a failure

Retrying the event shouldn't require all players to leave the instance
and to reenter

* Misc cleanups

Remove unused DataTypes

Rename variable to something more self-explanatory

Remove unnecessary checks and make scheduling of rifts more
straightforward

Fix typos
2023-06-18 11:47:27 -03:00
Eddy Vega
be622fa720 refactor(Scripts/CavernsOfTime): Mass struct/model update (#16268)
init
2023-05-28 16:30:30 -03:00
Angelo Venturini
de06f4327a fix(Core/Instance): AhnQiraj crash (#16124) 2023-04-30 01:30:57 +02:00
天鹿
df77b5f4f7 chore(core): cleanup code p3 (#16073)
* Update MMapMgr.cpp

* Update UpdateFetcher.cpp

* Update AuctionHouseMgr.cpp

* Update AuctionHouseMgr.h

* Update BattlegroundAV.cpp

* Update ChannelMgr.cpp

* Update ThreatMgr.h

* Update Player.h

* Update PlayerSettings.cpp

* Update ObjectMgr.cpp

* Update Guild.cpp

* Update Guild.h

* Update Map.cpp

* Update World.cpp

* Update boss_nefarian.cpp

* Update boss_prince_malchezaar.cpp

* Update boss_venoxis.cpp

* Update zone_elwynn_forest.cpp

* Update zulfarrak.cpp

* Update boss_novos.cpp
2023-04-24 08:13:07 -03:00
Timothy Vaccarelli
309f5c4adf fix(DB/SAI): Use SAI for Spitelash Naga in Azshara (#15808)
* Add SAI for Spitelash Naga in Azshara
2023-04-22 10:22:34 -03:00
avarishd
8696e7be7f fix(DB/Creature): Tamed Kodo - Remove gosisp flag. (#15165)
* fix(DB/Creature): Tamed Kodo - Remove gosisp flag.

* fix worldserver warning (assigned gossip, but no flag)

also typo

* Use &~
2023-04-22 10:08:25 -03:00
avarishd
1062977283 fix(Scripts/OldHillsbrad): Old Hillsbrad Foothills - Captain Skarloc casting wrong spell (#15486) 2023-03-20 06:05:31 -03:00
UltraNix
684bb1793d fix(Scripts): Crashfix. (#15459) 2023-03-19 16:29:57 +01:00
Skjalf
e2eb9fb82b fix(Scripts/BlackMorass): Don't pick the same rift spot in succession (#15359) 2023-03-12 13:27:39 -03:00
UltraNix
761c8dffad fix(Scripts/BlackMorass): Fixed rift mobs texts on summon. (#15339) 2023-03-12 00:21:51 -03:00
Skjalf
1155c4061f fix(Scripts/BlackMorass): Fix Aeonus not spawning, mobs spawning duri… (#15346) 2023-03-12 00:16:11 -03:00