Supression traps should always hit players.
Supression traps should not be disarmed after Broodlord defeat.
Supression traps should be visible after disarm.
Fixes#10768
* fix\feat: (Core/PacketIO): updated sound and creature addon
updated SMSG_PLAY_SOUND, SMSG_PLAY_MUSIC and SMSG_PLAY_OBJECT_SOUND via tc cherry pick
https://github.com/TrinityCore/TrinityCore/pull/2363 and 0f1f7ef401 by @joschiwald and @ForesterDev
This so far a attempt to align atleast with sound with tc, and correct a potentional issue of hearing creature sounds that is not in visible range. I notice PlaySound was being defined in some weird dependency as it isnt with tc so I renamed it to Playsound. Notice a isLarge still being used in the creature addon when it was depreciated, so i removed that a that seem to of interfered with visibilitydistanceType.
Co-Authored-By: joschiwald <736792+joschiwald@users.noreply.github.com>
Co-Authored-By: ForesterDev <11771800+ForesterDev@users.noreply.github.com>
* fix(Core/Reputations): Faction rep gained by killing mobs is now properly rounded up.
Do not increase reputation rank if exceeds max rank cap.
Fixes#8718
* fix (core): EffectInstaKill Prevents spell animation before deal damage execution
This fixes the issue of spell animations of chain effects of a spell dealing with EffectInstaKill. This was identified as a issue in support of @malcrom 's current scripting efforts. We fix the issue by putting a half second delay and making the delay of a function possible and independent.
Co-Authored-By: Malcrom <malcromdev@gmail.com>
* Fix double to float
Co-Authored-By: Malcrom <malcromdev@gmail.com>
* Remove the STD
I put the STD in STUD and all I need is U
* Update src/server/game/Spells/SpellEffects.cpp
per @kitzunu the great
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
* Update src/server/game/Spells/SpellEffects.cpp
per @nefertumm the beast
Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>
* Update src/server/game/Spells/SpellEffects.cpp
Co-authored-by: Kargatum <dowlandtop@yandex.com>
* Update src/server/game/Spells/SpellEffects.cpp
Co-authored-by: Kargatum <dowlandtop@yandex.com>
* Update src/server/game/Spells/SpellEffects.cpp
Co-authored-by: Kargatum <dowlandtop@yandex.com>
* Update src/server/game/Spells/SpellEffects.cpp
Co-authored-by: Kargatum <dowlandtop@yandex.com>
* Update src/server/game/Spells/SpellEffects.cpp
Co-authored-by: Kargatum <dowlandtop@yandex.com>
* Notes Added
Co-authored-by: Malcrom <malcromdev@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>
Co-authored-by: Kargatum <dowlandtop@yandex.com>
Update Position::GetPosition() and similar methods signatures to reflect 2a4c9bc changes by return a Position object instead of accepting a Position parameter by reference.
Cherry pick of 2585e799f9
- Reworked spell category cooldowns.
- Implemented category cooldowns for pets.
- Properly shows pet spell cooldowns in player's UI.
- Corrected pet spell cooldowns with infinity duration.
- Do not add/remove infinity spell cooldown on aura apply/remove if casted by item.
- Closes#5263
