Commit Graph

180 Commits

Author SHA1 Message Date
sudlud
4459afc98d fix(Core/Movement): Allow MoveFollow to not inherit speed of the target (#21711) 2025-03-15 21:47:11 +01:00
Takenbacon
ee69a569c4 fix(Core/Grids): Grid improvements (#20955) 2025-02-14 22:11:27 +01:00
Kitzunu
47c5ff904f refactor(Core/Disables): Convert from Namespace to Class Structure (#21109) 2025-02-01 22:48:52 +01:00
Takenbacon
c8734af4bc fix(Core/Movement): Fix creatures not resuming movement after being talked to (#20945)
Fix creatures not resuming movement after being talked to
2024-12-18 20:19:31 +01:00
Takenbacon
e9c86737fb refactor(Core/Random): Remove unused map based RNG (#20939)
Remove unused map based RNG
2024-12-18 13:48:06 +01:00
Benjamin Jackson
2654ec83cd fix(Core/AI): Increase movement leash extension interval. (#20867)
Init.
2024-12-08 21:04:41 +01:00
Francesco Borzì
a9f0f371e5 refactor(src/server/game): optimise imports (#20541) 2024-11-13 11:37:20 +01:00
Grimdhex
08bfecdbea fix(Core/Movement): remove unecessary reset() (#20419)
Co-authored-by: Ovahlord <18347559+ovahlord@users.noreply.github.com>
2024-11-03 17:36:48 -03:00
Grimdhex
0b031de2ea fix(Core/Movement): fix a small memory leak in RandomMovementGenerator (#20258)
* fix(Core/Movement): memory leak and possible crash

Co-Authored-By: Ovahlord <18347559+ovahlord@users.noreply.github.com>

* .

* fix review

---------

Co-authored-by: Ovahlord <18347559+ovahlord@users.noreply.github.com>
2024-11-01 09:39:37 -03:00
Francesco Borzì
2317004417 refactor(src/server/database|shared): remove unused import (#20316) 2024-10-28 10:04:42 +01:00
Francesco Borzì
6e2306f24a refactor(src/server/game/Movement): remove unused imports (#20098) 2024-09-29 18:14:12 +02:00
Jelle Meeus
a7578e1cce fix(Scripts/TheEye): Kael'thas p5 transition, flight, MotionMaster:MoveTakeoff (#20005)
Co-authored-by: killerwife <killerwife@gmail.com>
2024-09-24 08:33:21 -03:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
00e35a201e fix(Core/AI): Reduce movement leash extension interval. (#19923)
* Init.

* Use GetGameTime() instead of system call.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Update leash timer if rooted.

* Remove unnecessary checks, add extension for fanning.

More parity with VMaNGOS implementation.

---------

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-09-11 03:25:32 -03:00
天鹿
fafd351e44 fix(Core/AI): creature leashing behavior. (#19897)
* Update Unit.cpp

* Update TargetedMovementGenerator.cpp

* Update Unit.cpp

* Update Unit.cpp
2024-09-09 07:07:11 -03:00
Benjamin Jackson
b47b5d2c51 fix(Core/AI): Initialize movement leash timer to five seconds. (#19898)
Init.

https: //github.com/vmangos/core/commit/c8510cbbd4dccbdac9900cc507910ef3ae0e6c43

Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>
2024-09-08 21:44:09 -03:00
Benjamin Jackson
bf18b9bdfb fix(Core/AI): Improve creature leashing behavior. (#19751)
* Init.

https: //github.com/vmangos/core/commit/7d2f1e2923734ea1b983eeaa0208cfd158d4af02
Co-Authored-By: ratkosrb <35845488+ratkosrb@users.noreply.github.com>

* Hackfix for pets.

* Whoops.

* Correct evade uses.

* Conflict.

* Actually fix grace timer.

* Add visibility distance check.

Creatures should always fail combat checks in the open world if they're outside of visibility distance, might not be the case for worldbosses.

---------

Co-authored-by: ratkosrb <35845488+ratkosrb@users.noreply.github.com>
2024-09-03 21:08:56 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Grimdhex
221dbd3fdb chore(Apps/Codestyle): add new codestyle checks for pointers and range loops (#19841)
* chore(Apps/Codestyle): add new codestyle checks for pointers and range loops

* revert a typo
2024-09-03 13:02:38 -03:00
Saqra1
62b825f8bd fix(Core/Movement): Don't move for change in orientation only (#19687)
Changing only the orientation of a unit also flags it as if it were
moving, which causes spells to be interrupted.
2024-09-01 20:57:17 -03:00
Grimdhex
2f85097413 docs(Core): improve several functions documentation (#19677)
* initial release

* fix reviews

* fix some typo and add new documetations for MotionMaster

* new update and fix the cli-codestyle

* fix typo

* fix reviews
2024-08-28 08:17:24 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Francesco Borzì
02a05fbd4c refactor(src/common): remove unused imports (#19506)
* refactor(src/common): remove unused imports

* fix: build

* chore: fix build

* chore: size_t -> std::size_t

* chore: fix fuckup from previous commit

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build with std::size_t

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build

* chore: fix build
2024-07-30 20:06:46 -03:00
Tereneckla
e44e8fe109 fix (Core/Movement) Allow MoveFollow to not inherit walkstate of the target to fix Enchanted Elemental speed (#19498)
* MoveFollow with own walkstate

* switch
2024-07-29 08:30:42 -03:00
Jelle Meeus
40b63666ad feat(Core/Movement): implement Pause and Resume to WaypointMovementGenerator (#19176)
* implement Pause and Resume for WaypointMovementGenerator

Co-authored-by: ccrs <ccrs@users.noreply.github.com>

* prevent restart from external sources if wp is paused

* don't update stopmove on every update

SetFacing breaks otherwise

* timer args not used

---------

Co-authored-by: ccrs <ccrs@users.noreply.github.com>
2024-06-26 22:24:59 +02:00
Jelle Meeus
0d977c986e fix(Core/SmartAI): add prevent almost infinite spinning of mutual target to pets (#19090)
fix(Core/SmartAI)petspin
2024-06-19 21:13:34 -03:00
Anton Popovichenko
b90136d80d fix(Core/Pet): Fix pets chasing when pet and target spins uncontrollable (#18798) 2024-04-24 16:25:37 -03:00
Gultask
b69df485cf fix(DB/BlackTemple): Rework Black Temple (#18569)
* init

* more

* Update rev_1710358311839208100.sql
2024-03-18 22:31:05 +01:00
Anton Popovichenko
72e75982be fix(Core/Taxi): Fixes crash when player logins and continues flight (#18270)
* fix(Core/Taxi): Fixes crash when player logins and continue flight

* Update WaypointMovementGenerator.cpp
2024-02-12 08:18:05 -03:00
AG
8f127f9e21 Fix combat movement (#18026)
* Improve combat movement

 - Removed a bunch of logic related to another attempt at fixing combat movement.
- Removed SMART_ACTION_SET_CASTER_COMBAT_DIST and updated smarts scripts accordingly.
- Cherry-picked 7fb7432620
- Cherry-picked 63a6e1e048

Co-Authored-By: Ludovic Barbier <ludovic.barbier03@gmail.com>
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>

* Some more cleanup + fix sql

* More fixes to caster chase/combat movement + some cherry picks because why not

- Fix casters always trying to chase to melee range
- Fix casters another case of casters sometimes walking back instead of stopping
- Cleaned up some code
- Cherry picked ca25e8d019
- Cherry picked 96b289cadb

Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>

* Added parentheses

* Fixed caster combat movement when target is rooted

- Made a few adjustments to chase range and stuff, but nothing set in stone.

* convert uint to int

---------

Co-authored-by: Ludovic Barbier <ludovic.barbier03@gmail.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2024-01-03 09:56:24 +01:00
IntelligentQuantum
258e369ee5 chore(Core): remove useless includes (#18036) 2023-12-23 12:16:27 -03:00
AG
f7d7c4feb7 fix(Core/Creature): Improve chase movement (#17557)
* Update TargetedMovementGenerator.cpp

* Adding Ovahlord as co-author

TIL: you can assign multiple authors to a commit 😛
Co-Authored-By: Ovahlord <18347559+ovahlord@users.noreply.github.com>

* Remove unused variable

* Undo some changes

---------

Co-authored-by: Ovahlord <18347559+ovahlord@users.noreply.github.com>
2023-11-26 17:09:24 +01:00
Andrew
7795dc4379 fix(Scripts/SSC): Script Hydross OOC event (#17804)
* fix(Scripts/SSC): Script Hydross OOC event

* Update rev_1700448248255858600.sql

* Update boss_hydross_the_unstable.cpp

* Update rev_1700448248255858600.sql
2023-11-20 10:46:38 +01:00
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
KJack
3c8adc71cd (Scripts/AI) ZG20: Jeklik (Bat Boss) - Implement Bat Riders, other fixes and improvements (#17573)
---------

Co-authored-by: AG <43139552+AGandrup@users.noreply.github.com>
2023-11-12 09:35:35 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Ovahlord
52d37a927d fix(Build): nopch build (#17617) 2023-10-30 00:24:18 +01:00
AG
79b39f9655 fix(Core/Grid): Implement missing GridUnload setting (#17569)
* Implement GridUnload setting

* Minor fixes

- Use GetOption instead of deprecated GetBoolDefault.
- Added a missing check for instances in LoadMap
- Replaced some numbers with global defines

* Possible crashfix + minor improvements

- Initialized initialOrientation which I had forgotten (likely cause of crash)
- Readded a previous check in UpdateSplineMovement
- Made i_objectsToRemove and i_worldObjects tos sets as they were previously, instead of unordered_set.

* Update worldserver.conf.dist

* Fix high CPU usage with preload grid enabled.

This should be it.
2023-10-26 19:32:15 -03:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Kitzunu
f1111be152 chore(misc): cleanup (#17274) 2023-09-17 10:19:09 -03:00
wenzuowei
ee154036bd fix(Core/Movement) Smoother movement of hunter pets when following players (#16796)
* Pets follow the player at the player's speed

* More accurate distance measurement
2023-08-06 03:19:23 +02:00
Dan
3e19b5e637 fix(Scripts/Underbog): modernise boss scripts (#16149) 2023-06-04 23:42:40 -03:00
天鹿
ab7c12fe41 chore(core): Cleanup code p2 (#16041)
* Update AchievementMgr.cpp

* Update M2Stores.cpp

* Update LFGHandler.cpp

* Update PetHandler.cpp

* Update WaypointMovementGenerator.cpp

* Update ScriptMgr.cpp

* Update SpellAuras.cpp

* Update Spell.cpp

* Update SecretMgr.cpp

* Update SpellScript.cpp

* Update SecretMgr.cpp

* Update Spell.cpp

* Update SpellAuras.cpp

* Add files via upload

* Update PetHandler.cpp

* Update PetHandler.cpp

* Update CalendarMgr.cpp

* Update LFG.h

* Update WaypointMovementGenerator.cpp

* Update MapScripts.cpp

* Update Unit.cpp

* Update SmartScript.cpp
2023-05-13 15:00:29 -03:00
天鹿
d75bcf0f67 chore(core): Cleanup code (#16012)
* Update SmartScript.cpp

* Update M2Stores.cpp

* Update PetHandler.cpp

* Update WaypointMovementGenerator.cpp

* Update WorldSession.cpp

* Update spell_item.cpp

* Update LoginDatabase.cpp
2023-04-19 21:34:48 -03:00
UltraNix
3d5ec682c0 fix(Core/Movement): Updated creature pet's follow movement. (#15360) 2023-03-13 08:14:40 -03:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix
48ce957597 fix(Scripts/BlackMorass): Adds should walk towards Medivh. (#14945) 2023-02-12 08:27:25 -03:00
UltraNix
7f7a2f5a92 fix(Core/Creatures): Critters should start fleeing upon entering comb… (#14253) 2023-01-28 11:01:43 +01:00
UltraNix
7d65250414 fix(Core): Crashfix. (#14667) 2023-01-28 10:58:58 +01:00
UltraNix
592a26cb8c fix(Core): Crashfix. (#14536) 2023-01-11 02:40:03 -03:00