Commit Graph

495 Commits

Author SHA1 Message Date
Kitzunu
5a8b60361a refactor(Core/SpellMgr): simplify dbc data corrections (#3709)
* refactor(Core/SpellMgr): simplify dbc data corrections

* I hate failing builds... so guess sleep isnt neccessary

* only works when you actually fill out them all

* blankspace

* step 1 - rename

* This takes so long Q.Q

* Update SpellMgr.cpp

* Revert "Update SpellMgr.cpp"

This reverts commit e1de9712a52fd6547761c3ccd70c17a7d4aa8036.

* Revert "Revert "Update SpellMgr.cpp""

This reverts commit e9253c2846b83bfe2760e71a0fc52d2d9fbed853.

* revert

* DONE

* cleanup

* cleanup

* New error so good, why try to correct spells that dont exist :)

* brackets

* Github merge conflict fix SUCKS
2020-11-21 17:03:19 +01:00
Kitzunu
fb69db212f fix(Core/Player): Improve rested removal (#3715) 2020-11-19 10:11:56 -06:00
Kitzunu
973dcbf47c fix(Core/SpellMgr): Thorns should not miss (#3695) 2020-11-18 10:06:41 -06:00
aradep
788f8b5257 feat(Core/Config): configurable BG Respawn Timers (#3569) 2020-11-17 14:26:58 +01:00
Kitzunu
17bfcb77dc fix(Core/Condition): Implement CONDITION_QUESTSTATE (#3049) 2020-11-14 09:37:18 -06:00
Kitzunu
2788d495f9 fix(Core/Conditions): Implement CONDITION_DAILY_QUEST_DONE (#3050) 2020-11-14 06:08:00 +01:00
Kargatum
543753b641 feat(Core/MapUpdate): switch from ACE_Method_Request to PCQ (#3459) 2020-11-14 03:56:26 +07:00
placemolle
fc63d935b9 fix(Core/Item): Meta gems sometimes ignore added sockets (#3643) 2020-11-13 10:24:16 -06:00
Andrius Peleckas
d7becdae27 feat(Core/Spells): Functions will return cast result (#3635) 2020-11-13 08:00:07 -06:00
Shard
e7f1ab4a6a fix(Core/Logs): Fix arguments in function call (#3672) 2020-11-09 08:56:19 -06:00
Goatform
5254aec645 fix(Core/Unit): ranged auto-attack sound issue if a player attacks target not in LOS (#3610) 2020-11-07 18:23:42 +01:00
kubeeek
6574007e48 fix(Scripts/Ulduar): Supercharge stack issue fix (#3586) 2020-11-04 14:10:20 +01:00
kubeeek
2e298e7fc9 fix(Core/Ulduar): Stone Nova stacks [25 mode] 2020-11-03 08:38:16 -06:00
Silker
4a2c4f0f5f fix(Spell): Expose weakness (#3588)
This change allows the spell Expose Weakness (heroic encounters) to stack from additional sources.
Co-authored-by: Si1ker <55638679+Sombranator@users.noreply.github.com>
2020-10-31 00:19:51 -06:00
Petric
b3a967db60 fix(Core): fixed crash happening when clearing old mail (#3604) 2020-10-24 10:42:35 +02:00
Stefano Borzì
d07a34c1d5 feat(Core/Unit): don't allow additions threat in evade mode and implement AURA_INTERRUPT_FLAG_LEAVE_COMBAT (#3381) 2020-10-23 22:12:37 +02:00
Petric
d5bb6ba1c4 refactor(Core/Mail): avoid big mail loading/saving time, only load 50 mails at a time (#3420) 2020-10-21 15:20:32 +02:00
Kitzunu
036a8c2450 fix(Core/Unit): Eating anim (#3472) 2020-10-13 10:23:18 +02:00
Kargatum
a2b26272d2 refactor(Core/Game): restyle game lib with astyle (#3466) 2020-10-12 10:08:15 +02:00
Stefano Borzì
4cca286a4d fix(Core/Creature): dead creatures spawn position on respawn (#3382) 2020-10-09 11:18:01 +02:00
Andrius Peleckas
be09e03756 feat(Core/Movement): added orientation input for Point movement (#3456) 2020-10-05 12:28:25 +02:00
Stefano Borzì
91f4671d07 fix(Core/Spells): prevent client crash on use spell Neural Needle + ESC (#3383) 2020-09-27 16:31:41 +02:00
Stefano Borzì
1910b4ab35 chore(Core/Player): remove useless SendQuestComplete (#3380) 2020-09-26 14:46:27 +02:00
Stefano Borzì
868081e959 fix(Core/PacketsIO): Send correct messages about server first achievements depending on faction. (#3379) 2020-09-21 12:09:08 +02:00
Stefano Borzì
4e5440ad91 feat(Core/Events): update holiday code and remove misleading log (event date is the one from game_event) (#3365)
Cherry-picked 5b4287e683

Co-authored-by: ariel- <ariel-@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-09-20 20:36:33 +02:00
Andrius Peleckas
a445cca4bc feat(InstanceScripts): new scriptable function DoAction() (#3445)
This will work in a similar way as CreatureAI based DoAction function. This will allow avoiding SetData or ProcessEvent usage where basic input is needed
2020-09-19 23:27:47 +02:00
Francesco Borzì
b61ae8abcd fix(Core/Misc): all GCC warnings (#3457) 2020-09-14 17:31:12 +02:00
Kargatum
6a4b5ad1db chore(Core/Scripting): cleanup unused code (#3473) 2020-09-13 00:45:52 +02:00
Kargatum
e15a493927 feat(Core/Time): remove inherited ACE Time (#3455)
Co-authored-by: Viste <viste02@gmail.com>
2020-09-11 14:03:26 +02:00
Stefano Borzì
51330f54d8 refactor(Core/Misc): remove the ternary operator when used improperly (#3327) 2020-09-10 12:29:23 +02:00
Francesco Borzì
438cde6a56 fix(Core/Spline): -Wcast-function-type warning (#3442) 2020-09-08 23:08:52 +02:00
Stefano Borzì
821e7d03e8 fix(Core/player): do not show zone at first login (#3358)
* Update AuctionHouseHandler.cpp

* fix(Core/player): do not show location at first login

* Update Player.cpp

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2020-09-08 22:49:54 +02:00
Stefano Borzì
4a9476bbfd refactor(Core): replace ACE atomic types with standard C++ (#3421)
* Update AuctionHouseHandler.cpp

* refactor(atomic-type): replace ACE atomic types

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kargatum <dowlandtop@yandex.com>
2020-09-08 10:41:01 +02:00
Stefano Borzì
e9c805a743 refactor(lfg): refactor code and style (#3326)
* Update AuctionHouseHandler.cpp

* refactor(LFG): improve code style

* refactor(LFG): minor improvements

* chore(LFG): improve code style

* refactor(lfg): improve code style

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-09-04 10:18:43 +02:00
Petric
15cc6fe0b6 fix(Core/Spells): Implement SPELL_ATTR7_INTERRUPT_ONLY_NONPLAYER. (#3313)
Co-authored-by: HeartWell <moki.play@mail.ru>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-09-03 12:02:00 +02:00
Petric
29f2c2aeda feat(Core/Script): Playing music from GameObjects and added holiday zones music script (#3307) 2020-09-02 16:32:41 +02:00
Moki
26c99c383f Core/Scripts: fix Nightfall proc chance and reduce it for victims with level above 60. (#3304)
* Core/Scripts: fix Nightfall proc chance and reduce it for victims with level above 60

Adding a TrinityCore commit eac9c1f0b9

* Update rev_1597581112860069800.sql

* Update rev_1597581112860069800.sql

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-09-01 14:19:09 +02:00
Kitzunu
1f89282b22 refactor(Core): NULL -> nullptr (#3275)
* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 11:55:09 +02:00
Kitzunu
3aad2dc564 fix(Core/SpellEffects): Make Shadowmeld drop combat (#3272)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-30 22:50:28 +02:00
r0m1ntik
971d55d463 fix (Core/Quest) Correct link quest and fix command lookup quest for multilanguage dbc (#3271)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-30 19:42:36 +02:00
Shard
d8ad0c5200 Allow mages to refresh Living Bomb (#3228)
Currently, mages can't refresh Living Bomb if the target already have the dot.

###How to reproduce the issue :
1. Use Living Bomb on a target
2. Try to re-use Living Bomb on the same target
3. Observe the error message

###Expected Blizzlike behaviour
Living Bomb should be reapplyable 

###Why this PR : 
This PR allow to refresh the duration of Living Bomb on the same target

I've didn't found a bad mage's video that refreshes Living Bomb on his target, but found some Fire Mage 3.3.5 guides that mentions : 
"Never refresh your LB (Living Bomb) before the explosion (except if I clearly tell you to)."
https://sites.google.com/site/pvemage335/fire/rotation-gameplay

"Living Bomb – every 12 seconds **after the explosion**"
https://www.gnarlyguides.com/wotlk/guides/pve-fire-mage/#plink-rotation

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2020-08-26 11:44:41 +02:00
Viste
a9b90c9a07 refactor(Core): remove ace_autoptr, cleanup (#3276) 2020-08-25 12:52:22 +02:00
Kitzunu
c79a475708 fix(DB/SmartScriptMgr): Move CWZ valid check (#3206) 2020-08-24 17:20:22 +02:00
Vhiper
77b7a20fb9 fix(Core/DBCStores): prevent crash worldserver 2020-08-23 01:50:26 +02:00
Kitzunu
dd40e2e844 fix(Core/SpellAuras): Show auras to client limit (#3193)
Co-authored-by: Pascal Bachor <gerhood@users.noreply.github.com>
2020-08-22 10:34:12 +02:00
Christopher Galbraith
d7c9b36a5c fix(Core/Spells): Winter's Chill now stacks from multiple sources
Signed-off-by: Chris <chriscgalbraith@gmail.com>
2020-08-21 19:07:02 +02:00
Kitzunu
73d725312d feat(Core/Config): CONFIG_INTERVAL_SAVE (#3171) 2020-08-20 15:50:32 +02:00
IntelligentQuantum
5d284f02a7 feat(Core/SendListInventory): Add multivendor function (#3172) 2020-08-20 11:00:11 +02:00
Francesco Borzì
2bc832efe3 fix(CI/Core/ArenaSpectator): clang warnings + prevent new warnings (#3317)
Co-authored by @meerd
2020-08-19 19:44:07 +02:00
Viste
ffd03582c9 fix(Core/Unit): melee attack through LoS (#3265) 2020-08-18 14:07:32 +02:00