Commit Graph

2202 Commits

Author SHA1 Message Date
Anton Popovichenko
52d07bbfae fix(Core/InstanceMap): Stop using deleted player in RemovePlayerFromMap (#17069) 2023-09-05 06:36:34 -03:00
Kitzunu
1ed1cd0c73 fix(Core/Player): Allow to swap bags when they are filled (#17086) 2023-09-05 06:35:15 -03:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Kitzunu
3eb2463c69 chore(Core/Misc): Correct some fmt outputs (#17091) 2023-08-27 06:23:26 +02:00
Christopher Galbraith
aea540181b fix(Spell): set torment of the worgen to have 3% proc chance (#17005)
Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-08-26 17:35:56 +02:00
pvp100
856d17ac36 fix(Core/MiscHandler): Dungeon requirements Message (#16701)
* fix(DB/Gameobject): fix towercanno error location in Flamewatch Tower

adjusted wintergrasp towercanno position

* fix(Core/MiscHandler): dungeon access requirements message parameter

requirements level variable always 0
requirements item cannot get from locale

Co-authored-by: aviar <aviar@sina.com>

* revert: random edits

---------

Co-authored-by: aviar <aviar@sina.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2023-08-25 09:16:47 -03:00
Synful-Syn
6b583089f3 fix(Core/Spell): Stop Blink from the falling player to move upward by 1y and stop moving backward when facing a wall (#16657)
* blink-bad-warps

* Change formatting of an if
2023-08-25 09:14:27 -03:00
Christopher Galbraith
cee630774c fix(Core/Spells): Add SPELL_ATTR7_DONT_CAUSE_SPELL_PUSHBACK to Hand of Sac and Divine Sac spells (#17041)
* add no spell pushback flag to auras

* Revert "add no spell pushback flag to auras"

This reverts commit 545e9fe4ee69bb079b69a4f2ba6039b834568a59.

* spellInfoCorrection for no pushback on HoS and Divine Sac

---------

Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-08-25 09:02:27 -03:00
The GhostRider
b1c8b0eaa2 fix(Core/Item): Complimentary Brewfest Sampler (#16992)
* Fix(DB/C++):Item - Complimentary Brewfest Sampler

* Delete PlayerStorage.cpp

* Update rev_1691843684176706600.sql

Correction

* Ripristino il file PlayerStorage.cpp

* New file: SpellInfoCorrections.cpp

* Update rev_1691843684176706600.sql
2023-08-25 08:45:06 -03:00
Anton Popovichenko
4c287e2873 fix(Core/Vehicles): Fix crash in Vehicle::AddPassenger (#17038)
* fix(Crash): Fix crash in Vehicle::AddPassenger

As I understand it, a try-catch block cannot intercept the ABORT function. Therefore, let's use a simple if statement instead.

* Address code review feedback
2023-08-22 12:13:36 +02:00
Gultask
e42f43784c feat(Core/SmartAI): Implement SMART_ACTION_FOLLOW_GROUP (#17033)
* Update SmartScript.cpp

* INIT

* add as coauthor as well :)

Co-Authored-By: cyberium <346907+cyberium@users.noreply.github.com>

* codestyle

* test?

---------

Co-authored-by: cyberium <346907+cyberium@users.noreply.github.com>
2023-08-22 12:11:21 +02:00
Tereneckla
cf87a2d8fe fix(Core/Pet): Correct (most) warlock pet scaling (#16769)
* create

* Update Pet.cpp

* remove unwanted change

* Update data/sql/updates/pending_db_world/rev_1689522771491547000.sql

* Update rev_1689522771491547000.sql
2023-08-20 21:38:49 -03:00
Kitzunu
6185b1d73b fix(Core/Events): Implement Spirit of Competition event (#16963)
* fix(Core/Events): Implement Spirit of Competition event

Co-Authored-By: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* more stuff

* bye bye magic numbers

* fix dberrors

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* commoneers

* Update src/server/game/Battlegrounds/Battleground.cpp

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>

* ci

* Update rev_1691529514989936100.sql

* unnecessary whitespace

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update Battleground.cpp

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2023-08-20 00:41:44 +02:00
Anton Popovichenko
f6b77f9d64 fix(Core/Pets): Fix crash when pet tries to attack deleted object (#17034)
This situation occurs when, during a fight, a pet receives a command to apply a positive spell to an ally and then resume attacking its previous target.
2023-08-19 22:27:51 +02:00
Anton Popovichenko
57e0b496bd fix(Core/Transport): Fixes crash with loading player on deleted transport (#17021)
* fix(Crash): Fixes crash with loading player on deleted transport

* Remove whitespace
2023-08-18 16:13:43 +02:00
Gultask
8d803334eb feat(Core/SmartAI): Add new event parameter, event_param6 (#16944)
* init

* pt2

* this template stuff must go

* also for my other event
2023-08-12 14:53:15 -03:00
Kitzunu
a369402f4b fix(DB/Gossip): Change MenuID to INT from SMALLINT (#16982)
* fix(DB/Gossip): Change MenuID to INT from SMALLINT

* update cpp
2023-08-12 19:49:43 +02:00
Kitzunu
de2e2b6e8b fix(Scripts/Command): Improve output of event commands (#16980) 2023-08-12 00:03:03 +02:00
avarishd
7c43738214 fix(Spells/Scripts): Gnomish Poultryizer (#15554)
fix(Spells/Scripts): Gnomish Poultryizer not breaking on damage
2023-08-10 14:37:14 -03:00
Skjalf
808b8bf07a fix(Core/Arena): Fix LegacyArenaPoints logic (#16967) 2023-08-09 09:32:32 -03:00
Axel Cocat
5ba2c18ce6 feat(Core/Conf): add CONFIG_ARENA_QUEUE_ANNOUNCER_DETAIL (#16850)
* feat(Core/Conf): add CONFIG_ARENA_QUEUE_ANNOUNCER_DETAIL

* fix: bad copy paste

* add sql

* fix bad copy paste above again

* fix: move lang values

* Update rev_1690640715748711400.sql

* Update rev_1690640715748711400.sql

* Rename rev_1690640715748711400.sql to fix.sql

* reaching, maybe fix (?) c:

* love me god damn it

* update sql file

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-09 05:42:50 -03:00
Maria-sequel
1cd181f923 feat(Core/Config): Add Legacy Arena Points config option (#16940)
* feat:(Core/Config): Add legacy Arena points option

* Update IWorld.h

* Update World.cpp

* Update World.cpp

* typo

* Update worldserver.conf.dist

* Update worldserver.conf.dist

* Update World.cpp

* Update World.cpp

* defaults to true

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* config text

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/apps/worldserver/worldserver.conf.dist

* Update src/server/apps/worldserver/worldserver.conf.dist

* Update src/server/game/World/World.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-08-09 00:44:44 -03:00
Skjalf
f5e555082e fix(Core/Unit): Fix Arena Preparation aura being removed on player ac… (#16925)
fix(Core/Unit): Fix Arena Preparation aura being removed on player actions
2023-08-08 23:48:20 -03:00
Kitzunu
026fe7c962 fix(Core/Pets): Hunter pet scaling (#16959)
* fix(Core/Pets): Hunter pet scaling

* Fix pet scaling to properly take DBC data
* Edge case for Devilsaur where the DBC data is whack, therefore we use Spirit Beast data instead
* updated scale calculation based on client function (f09564b9d0)

Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* fix gcc

---------

Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2023-08-08 19:11:41 -03:00
Kitzunu
c866e17406 refactor(Core/Motd): Move motd to MotdMgr (#16933) 2023-08-06 23:02:54 +02:00
Gultask
0276b141a8 feat(Core/SmartAI): Implement castFlag THREATLIST_NOT_SINGLE (#16911)
* init

* Update SmartScript.cpp
2023-08-06 20:25:31 +02:00
v-mstrs
9eadbdf611 fix(Core/Spells): Warrior T5 2p (#16749)
* fix overpower bonus

* Update SpellInfoCorrections.cpp

* Update src/server/game/Spells/SpellInfoCorrections.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-06 03:32:52 +02:00
Maria-sequel
81a20d69de fix(Core/Spells): Silent Fang proc should not work in … (#16907)
fix(Spell/SpellInfoCorrections): Silent Fang proc should not work in arena
2023-08-06 03:21:01 +02:00
wenzuowei
ee154036bd fix(Core/Movement) Smoother movement of hunter pets when following players (#16796)
* Pets follow the player at the player's speed

* More accurate distance measurement
2023-08-06 03:19:23 +02:00
UltraNix
c3acf75618 fix(Core/Spells): Taunt always set proper target while channelling sp… (#13948)
* fix(Core/Spells): Taunt always set proper target while channelling spells.

Fixes #13841

* Update.

* Update.
2023-08-06 03:16:05 +02:00
Webdrian
226408329a fix(Core/Pets): Corret Pet size for normal and exotics & bigger pets (#16910)
* fix(Core/Pet)

Pet size fixed

* Update Pet.cpp

* Update Pet.cpp
2023-08-06 02:08:34 +02:00
AiurJordan
f0a4612964 fix(Core/Pets) Pet scaling only being applied to pets with DB Entry (#16401) 2023-08-02 14:51:11 -03:00
Skjalf
90675cab30 fix(Core/Battleground): Fix auto arena flush interval (#16877) 2023-08-02 14:45:59 -03:00
v-mstrs
aaabca1cd0 fix(Core/Spells) Add Explosive Shot exception (#16854)
* gitpain

* Update SpellAuras.cpp
2023-08-01 14:11:22 -03:00
Kitzunu
8c42a03328 fix(Core/Item): Mirror client logic when determining whether to apply… (#16861)
fix(Core/Item): Mirror client logic when determining whether to apply feral AP

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2023-07-30 23:59:21 -03:00
Kitzunu
ceca5d06f8 fix(Core/PacketIO): Prevent HandleGameobjectReportUse when Gob is not… (#16707)
fix(Core/PacketIO): Prevent HandleGameobjectReportUse when Gob is not selectable
2023-07-30 13:04:46 +02:00
Gultask
52aa18f8bd feat(Core/SmartAI): Implement AoE variants of VICTIM_CASTING and RANGE events (#16720)
* init

* areaRange

* Update SmartScript.cpp

* error checks

* update SAI for area range

* areaCasting

* more

* Update rev_1689199652093827600.sql

* typo

* dont interrupt totems

* Update SmartScriptMgr.cpp

* target type needs to be 7

* Update rev_1689199652093827600.sql
2023-07-30 10:17:48 +02:00
Axel Cocat
642bd1936b fix(Core/Arena): allow crossfaction arena teams (#16823) 2023-07-27 08:37:20 -03:00
Tereneckla
9482836e33 fix(Core/Session): don't refund soul shards when logging out with warlock pets (#16803) 2023-07-21 19:16:11 -03:00
avarishd
08ed1fb47a fix(Scripts/Pets): Darting Hatchling not running around. (#15251)
* fix(Scripts/Pets): Darting Hatchling not running around.

* cs

* Update pet_generic.cpp

* RemoveAurasDueToSpell
2023-07-18 13:53:44 -03:00
Synful-Syn
f84d786df0 chore(Scripts/Spells): Reduce the amount of player checks (#16719)
merge some player checks
2023-07-17 08:24:18 -03:00
Angelo Venturini
dbc39a2817 fix(Core/Spells): Implement ENCHANT_PROC_ATTR_WHITE_HIT (#16771)
Co-authored-by: Ariel Silva<ariel-@users.noreply.github.com>
2023-07-17 08:19:24 -03:00
Tereneckla
e78ff51336 fix(Core/Player): don't dismiss warlock pets on logout (#16766)
Update Player.cpp
2023-07-15 17:12:28 -03:00
wenzuowei
3a3dc6446b fix(Core/Gossip): Fix gossip menu for locale clients (#16531)
* fix(Core/Gossip): Fix gossip menu for locale clients

* using gossip_menu_option texts by default

---------

Co-authored-by: wzw1990 <>
2023-07-12 08:04:39 -03:00
Skjalf
f5d0246292 feat(Core/Object): Add helper to allow removing allowed looters (#16709) 2023-07-08 21:45:06 -03:00
天鹿
893a9beeac fix(Core/SmartScripts): Fix a check (#16663) 2023-07-05 09:25:02 +02:00
Tralenor
21cab04232 feat(Core/Achievements):Add getter for completed achievement map in AchievementManager (#16662)
* add getCompletedAchievementMap

* fix Function naming

* remove useless whitespace change from MR

* Update src/server/game/Achievements/AchievementMgr.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* fix const placement in header (review finding)

---------

Co-authored-by: tmoos <tmoos@meteomatics.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-07-03 12:22:42 +02:00
Tereneckla
718b0000ba fix(Core/Reputation): remove reputation splitting for being partied (#16660)
remove rate for party
2023-07-02 15:02:14 -03:00
Gultask
9d7e472160 chore(Core/SmartAI): Add min/max timer error check for NEAR_PLAYERS (#16661)
Update SmartScriptMgr.cpp
2023-07-02 09:15:52 -03:00
Gultask
54f8386d99 feat(Core/SmartAI): Add more smart events (#16642)
* init

* :)

* Update rev_1687966694240866600.sql

* >:)

change name from unit -> target
fix typo

Co-Authored-By: Angelo Venturini <nefertum.dev@protonmail.com>

* Update data/sql/updates/pending_db_world/rev_1687966694240866600.sql

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>

* more_events

* Update SmartScriptMgr.cpp

---------

Co-authored-by: Angelo Venturini <nefertum.dev@protonmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2023-07-02 08:57:56 +02:00