Commit Graph

1142 Commits

Author SHA1 Message Date
Viste
4dd9b92759 refactor(Core/Tools): remove ACE from tools (#3351) 2020-09-07 14:01:28 +02:00
Krath
aa60f0b324 fix(Scripts/ICC): visual of the Blood Council Bosses 2020-09-07 10:27:39 +02:00
Francesco Borzì
b95c14f91a refactor(Scripts/Stratholme): fix warnings and made code more readable (#3433) 2020-09-06 17:07:36 +02:00
Kitzunu
03bd4fafe6 refactor(Core/ICC): Move hardcoded spells to enum (#3337) 2020-09-05 16:21:21 +02:00
Kitzunu
f67635497f fix(Scripts/ICC): Don't show Heroic Attempts on Normal difficulty (#3336) 2020-09-05 13:19:31 +02:00
Francesco Borzì
9d381fa0f1 fix(Core/Tools): fix GCC warnings in extractors (#3430) 2020-09-05 00:30:13 +02:00
Francesco Borzì
fa6f814eba fix(Core/Misc): GCC warnings (#3428) 2020-09-04 17:39:02 +02:00
Stefano Borzì
e9c805a743 refactor(lfg): refactor code and style (#3326)
* Update AuctionHouseHandler.cpp

* refactor(LFG): improve code style

* refactor(LFG): minor improvements

* chore(LFG): improve code style

* refactor(lfg): improve code style

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-09-04 10:18:43 +02:00
Petric
7a4a409cae fix(Core/Script): Anomalus (#3325)
* Correct rift spawning/ empowering timings and Rift Shield cancellation

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-09-04 09:44:09 +02:00
Petric
e2cf12a2ce fix(CORE/Dungeon): Mage-Lord Urom now cats empowered arcane explosion when he teleports to the center (#3323)
Mage-Lord Urom in Oculus would teleport to the center of the room, but he would never cast empowered accane-explosion he would just wait there

Closes https://github.com/azerothcore/azerothcore-wotlk/issues/3320

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-09-03 16:18:34 +02:00
Petric
15cc6fe0b6 fix(Core/Spells): Implement SPELL_ATTR7_INTERRUPT_ONLY_NONPLAYER. (#3313)
Co-authored-by: HeartWell <moki.play@mail.ru>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-09-03 12:02:00 +02:00
Petric
29f2c2aeda feat(Core/Script): Playing music from GameObjects and added holiday zones music script (#3307) 2020-09-02 16:32:41 +02:00
imxari
60e8ec0575 fix(Core/Quest): Death Comes From On High (#2939)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-09-01 21:46:45 +02:00
Moki
26c99c383f Core/Scripts: fix Nightfall proc chance and reduce it for victims with level above 60. (#3304)
* Core/Scripts: fix Nightfall proc chance and reduce it for victims with level above 60

Adding a TrinityCore commit eac9c1f0b9

* Update rev_1597581112860069800.sql

* Update rev_1597581112860069800.sql

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-09-01 14:19:09 +02:00
Petric
321cf0d2b3 fix(CORE/Commands): Renamed .character deleted old to .character deleted purge (#3300)
* fix(CORE/Commands): Renamed .character deleted old to .character deleted purge
Closes https://github.com/azerothcore/azerothcore-wotlk/issues/2925

* Fixed indentation

* Renamed handler function

* Spacing

* Update data/sql/updates/pending_db_world/rev_1597499028423474100.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-09-01 12:37:30 +02:00
Petric
e1e8cc1bf5 fix(CORE/Raid): Muradin/Saurfang not de-spawning after finishing movement (#3294)
Saurfang and Muradin together with its 3 followers were not de-spawning once reaching the exit portal after the initial RP moment and remain standing in front of the exit portal forever.

Partially Closes https://github.com/azerothcore/azerothcore-wotlk/issues/3246

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 17:27:01 +02:00
Petric
4034a56f87 fix(CORE/Raid): Lich King “Pain and Suffering” snapping and “Shadow Trap” not targeting tanks (#3293)
-Lich King was snapping to north after using Pain and Suffering when instead he should be facing the direction of last target.
-Shadow Trap could not target tanks, it should be able to do so

Closes https://github.com/azerothcore/azerothcore-wotlk/issues/2826

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 14:19:22 +02:00
Kitzunu
1f89282b22 refactor(Core): NULL -> nullptr (#3275)
* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 11:55:09 +02:00
Kitzunu
3aad2dc564 fix(Core/SpellEffects): Make Shadowmeld drop combat (#3272)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-30 22:50:28 +02:00
r0m1ntik
971d55d463 fix (Core/Quest) Correct link quest and fix command lookup quest for multilanguage dbc (#3271)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-30 19:42:36 +02:00
Shard
d8ad0c5200 Allow mages to refresh Living Bomb (#3228)
Currently, mages can't refresh Living Bomb if the target already have the dot.

###How to reproduce the issue :
1. Use Living Bomb on a target
2. Try to re-use Living Bomb on the same target
3. Observe the error message

###Expected Blizzlike behaviour
Living Bomb should be reapplyable 

###Why this PR : 
This PR allow to refresh the duration of Living Bomb on the same target

I've didn't found a bad mage's video that refreshes Living Bomb on his target, but found some Fire Mage 3.3.5 guides that mentions : 
"Never refresh your LB (Living Bomb) before the explosion (except if I clearly tell you to)."
https://sites.google.com/site/pvemage335/fire/rotation-gameplay

"Living Bomb – every 12 seconds **after the explosion**"
https://www.gnarlyguides.com/wotlk/guides/pve-fire-mage/#plink-rotation

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2020-08-26 11:44:41 +02:00
Viste
a9b90c9a07 refactor(Core): remove ace_autoptr, cleanup (#3276) 2020-08-25 12:52:22 +02:00
Walter Pagani
563748ec31 fix(Core/Gossip): Remove hard-coded texts from the: The forge of souls C++ (#3219)
* Text of the gossip taken from the database

* Adding translations to quest_offer_reward_locale

* Adding enum for gossip.

* Changing the name of the enum to avoid conflicts.

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-24 19:10:02 +02:00
Kitzunu
c79a475708 fix(DB/SmartScriptMgr): Move CWZ valid check (#3206) 2020-08-24 17:20:22 +02:00
Stefano Borzì
78e2e551e5 fix(build): remove warning (#3205) 2020-08-24 09:48:05 +02:00
Stefano Borzì
78a02c8fd1 fix(quest): improve quest force of neltharaku (#3203)
* Update AuctionHouseHandler.cpp

* chore(quest): improve quest force of neltharaku

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2020-08-23 15:49:18 +02:00
Vhiper
77b7a20fb9 fix(Core/DBCStores): prevent crash worldserver 2020-08-23 01:50:26 +02:00
Kitzunu
dd40e2e844 fix(Core/SpellAuras): Show auras to client limit (#3193)
Co-authored-by: Pascal Bachor <gerhood@users.noreply.github.com>
2020-08-22 10:34:12 +02:00
Christopher Galbraith
5a5ece6d98 fix(Scripts/UtgardePinnacle): Svala Sorrowgrave's loot disappearing too quickly (#3188) 2020-08-22 00:46:13 +02:00
Christopher Galbraith
d7c9b36a5c fix(Core/Spells): Winter's Chill now stacks from multiple sources
Signed-off-by: Chris <chriscgalbraith@gmail.com>
2020-08-21 19:07:02 +02:00
Barbz
ed8ed175b7 fix(Core/Command): Can comment closed tickets (#3176) 2020-08-21 10:52:52 +02:00
Barbz
70bdba8309 feat(Core/Command): Reenable .teleport name on offline player (#3175)
- Reenable the possibility to .teleport name xxx $home even if the character is offline.
2020-08-20 23:26:17 +02:00
Kitzunu
73d725312d feat(Core/Config): CONFIG_INTERVAL_SAVE (#3171) 2020-08-20 15:50:32 +02:00
IntelligentQuantum
5d284f02a7 feat(Core/SendListInventory): Add multivendor function (#3172) 2020-08-20 11:00:11 +02:00
Francesco Borzì
2bc832efe3 fix(CI/Core/ArenaSpectator): clang warnings + prevent new warnings (#3317)
Co-authored by @meerd
2020-08-19 19:44:07 +02:00
Ercules76
3f8abc6bc2 refactor(CORE/Instance): Move Pandemonius script from SAI to Core script (#3165) 2020-08-19 16:15:43 +02:00
IntelligentQuantum
fae5753f81 feat(Core/Commands): Character check bag && work (#3164) 2020-08-19 13:47:48 +02:00
Ercules76
106f6f94a7 fix(Scripts/DB): Add Prison to spawn Yor, move Yor AI from SAI (#3163) 2020-08-19 11:10:41 +02:00
Erdem MEYDANLI
9e5c3f78af test: add code coverage report (#3312) 2020-08-18 16:34:45 +02:00
Viste
ffd03582c9 fix(Core/Unit): melee attack through LoS (#3265) 2020-08-18 14:07:32 +02:00
Yehonal
7fba8b910f fix(#2147): enrage and some false-negative spells (#3153)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-08-18 11:10:43 +02:00
Erdem MEYDANLI
da1725cfc3 test: fix unit test linking problem in ubuntu 18.04 2020-08-17 14:48:34 +02:00
Stefano Borzì
408366f39f chore(unit-object-accessor): add findConnectedPlayer to object accessor (#3155) 2020-08-17 10:36:42 +02:00
Kitzunu
8b9cec620d refactor(Core/SpellInfo): Positive/Negative spells from SpellFamilyName into DB (#3149)
* Implement SPELL_ATTR0_CU_POSITIVE_EFF0

* Implement SPELL_ATTR0_CU_POSITIVE_EFF1

* Implement SPELL_ATTR0_CU_POSITIVE_EFF2

* Move SpellFamilyName spells into DB to define if they are POSITIVE or NEGATIVE spells

* Rename column from entry to spell_id to make more sense
2020-08-16 13:25:26 +02:00
Francesco Borzì
c2b40b126d feature(testing-automation): unit tests with Google Framework (#3273) 2020-08-15 22:34:45 +02:00
CosmeF
4f04af6a64 fix(Core/ObjectMgr): solve Global Storage issue 2020-08-13 15:44:36 +02:00
Francesco Borzì
d2cc3fcbc2 feat(Docker): update to Ubuntu 20.04 + more improvements (#3277) 2020-08-13 00:25:20 +02:00
Francesco Borzì
0e1713d1b7 fix(Core/Spell): rogue's poisons logic check (#3278) 2020-08-11 15:29:53 +02:00
Vhiper
96dc9fc0f3 refactor(Scripts/SAI): move Gryphoneer Windbellow to SAI (#3137) 2020-08-10 10:10:08 +02:00
Kitzunu
a37ea1b60e chore(worldserver.conf): Update GM.StartLevel to core default (#3136) 2020-08-05 15:01:04 +02:00