Commit Graph

1848 Commits

Author SHA1 Message Date
Andrew
41dba1affb fix(Scripts/ObsidianSanctum): Fix Tenebron respawning (#17576)
fix(Scripts/ObsidianSanctum): Fix Shadron respawning
2023-10-25 06:14:09 -03:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Andrew
a56a224bd7 fix(Scripts/Karazhan): Update Aran with the new OnPowerUpdate() hook (#17561) 2023-10-23 05:28:29 -03:00
Andrew
69418ab936 fix(Scripts/Ulduar): Don't treat Algalon respawns as if they were the… (#17562)
* fix(Scripts/Ulduar): Don't treat Algalon respawns as if they were the first pull

* Update boss_algalon_the_observer.cpp
2023-10-22 15:12:30 +02:00
Grimgravy
1262bbd237 fix(DB/Quest): Improve The Summoning Chamber (#16588)
* fix(DB/quest): The Summoning Chamber

* update

* improvement

* update

* update

* Update rev_1687180111436507500.sql

* improvement
2023-10-22 13:12:18 +02:00
Andrew
4e41a02be2 fix(Scripts/Karazhan): Implement the side entrance door area trigger … (#17556)
fix(Scripts/Karazhan): Implement the side entrance door area trigger handling
2023-10-21 22:52:07 -03:00
podmepodme
945d7c6afe fix(Script/Misc): Replace hardcoded gossip and texts with DB ones. (#17502)
* fix(CORE/Creature): replace shadowmoon valley hardcoded gossips

* fix(CORE/GameObject): replace terokkar forrest hardcoded gossips

* fix(Core/Creature): replace shattrath city hardcoded gossips

* style(Core): code style edit

* style(CORE) codestyle edit

* style(CORE) codestyle edit

* style(CORE): codestyle edit

* ready for merge

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-10-22 03:16:51 +02:00
Andrew
c5ac4789d8 fix(Scripts/Karazhan): Opera left door should stay open in case of wipe (#17553) 2023-10-21 21:59:18 -03:00
Andrew
a3d728f791 fix(Scripts/Karazhan): Script Aran's Flame Wreath ability (#17551) 2023-10-21 21:08:12 -03:00
daobashun
d9d500923a fix(DB/SAI): Move the Ashbringer event AI of the Bloody Monastery mob to Smartai (#17078)
* Move scarlet_guard's Ashbringer event to smartAI

* Remove the code from the script

* Delete the commented out code

* Modify the distance of the "Scarlet Wizard" Cast Arcane Explosion

* Fix errors

* Update rev_1692891765582381000.sql

* Update rev_1692891765582381000.sql

* Remove duplicate statements

* Remove duplicate statements
2023-10-22 02:03:50 +02:00
Andrew
25328b54f9 fix(Scripts/Mechanar): Remove polarity shift stacks on polarity change (#17548) 2023-10-21 15:48:39 -03:00
avarishd
228f6635c0 fix(Core/Scripts): ScriptEffect Frog Kiss (#17482) 2023-10-21 09:15:20 -03:00
IntelligentQuantum
a0985f59b6 refactor(Scripts/Commands): convert cs_ticket to new system (#17547)
Update cs_ticket.cpp
2023-10-21 08:22:53 -03:00
avarishd
39bad395c2 fix(Core/Spells): Script Yeh'kinya's Bramble (#17516)
* fix(Core/Spells): Script Yeh'kinya's Bramble

* rogue screechers
2023-10-21 08:10:00 -03:00
avarishd
2c28cc0eb7 fix(DB/Items): Unhatched Jubling Egg obtaining + RP (#17478) 2023-10-20 20:39:04 -03:00
IntelligentQuantum
332ff49c13 refactor(Scripts/Commands): convert cs_reset to new system (#17546)
Update cs_reset.cpp
2023-10-20 19:41:02 -03:00
Grimgravy
e3592f7de7 fix(Scripts/Quest): improve Path of Conquest (#16353)
* fix(DB/Quest): improve Path of Conquest

* update

* Update rev_1684800494817311100.sql

* .

* .
2023-10-19 21:46:00 -03:00
Dan
c7324f3066 fix(Scripts/Paladin): ensure Judgements of the Just procs Seal of Vengeance/Corruption (#17470)
* initial

* no spaces

* add enum
2023-10-19 12:19:59 -03:00
avarishd
a39175bc3b fix(Core/Spells): Demonic Knowledge missing 1% per rank (#17495) 2023-10-18 19:21:46 -03:00
avarishd
1ef50c31b3 fix(Scripts/Spells): Script Leggings of Beast Mastery. (#17428) 2023-10-18 19:15:49 -03:00
IntelligentQuantum
39db3de5af refactor(Scripts/Commands): convert cs_guild to new system (#17515) 2023-10-18 10:57:28 -03:00
Ludwig
630b90a633 fix(Scripts/Midsummer): Implement Ribbon Pole dance effects (#17417)
* fix(Scripts/Midsummer): Implement Ribbon Pole dance effects

* midsummer.cpp: remove whitespaces at end of lines

* midsummer.cpp: fix unused parameter error

* add spacing after 0.0f

* replace Milliseconds(...) by ...ms and Seconds(...) by ...s

* cleanup comments

* remove manual cleanups / despawns from DoCleanupChecks()

- rely on NPC despawn timers
- manual cleanup / removal actually is a bit excessive

* set INTERVAL_DANCING_FLAMES to 15s

* set despawn time to 1min for big dancing flames according to spell 46827

* set spawnDist to 12 for big dancing flames according so spell 46827

* use library function Acore::Containers::RandomShuffle() to shuffle _danclerList

* sql: do not set SmartAI for NPC 17066

already using ScriptName and can't have both

* combine 3 sql files into 1

* remove INTERVAL_... enum values

* remove unnecessary checks of if(_bunny)

* sql: fix smartscript comment

* rename spell define to correct spell name
2023-10-18 14:22:26 +02:00
avarishd
ad66728973 fix(DB/Creature): Drunken Brewfest Reveler model (#17494)
* fix(DB/Creature): Drunken Brewfest Reveler model

* clarify enum

+ farm lines
2023-10-17 15:37:53 -03:00
Dan
bf5878f8dc fix(Scripts/SSC): fix issues with Fathomlord and add interactions (#17525) 2023-10-17 15:37:32 -03:00
avarishd
e30718db36 fix(Core/Spells): Script Scourge Banner (#17523)
* fix(Core/Spells): Script Scourge Banner

* correct statecheck
2023-10-16 23:13:54 +02:00
avarishd
62ef0db09f fix(Scripts/Karazhan): Side Enterance Door check (#17493) 2023-10-12 11:19:21 -03:00
avarishd
e4eb789e52 fix(Script/Spells): Script Priest Heal T4 4P Bonus (#17490)
* fix(Core/Spells): Script Priest Heal T4 4P Bonus

* RemoveAurasDueToSpell

* comment out unused stuff
2023-10-12 10:16:59 -03:00
avarishd
1753a8d0b9 fix(Core/Spells): Call of the Wild targeting other players (#17485)
* fix(Core/Spells): Call of the Wild targets

* comment
2023-10-11 17:09:53 -03:00
avarishd
214948bafb fix(DB/Quest): Port Cleansing Witch Hill from Trinity. (#17420)
* fix(DB/Quest): Port Cleansing Witch Hill from Trinity.

https: //github.com/TrinityCore/TrinityCore/issues/22262
Co-Authored-By: Carlos Morales <carlos.morales@insmet.cu>

* ""

Co-Authored-By: Carlos Morales <carlos.morales@insmet.cu>

---------

Co-authored-by: Carlos Morales <carlos.morales@insmet.cu>
2023-10-10 20:26:43 -03:00
avarishd
5aca484574 fix(Core/Scripts): Venomhide Hatchling improvements (#17454) 2023-10-10 20:25:26 -03:00
avarishd
e8b81430af fix(Core/Spells): Script Void Star Talisman resistances. (#17427)
* fix(Core/Spells): Script Void Star Talisman resistances.

* add check for armor

* change comment loc

* .

* fix(Core/Spells): Script Lord Valthalak's Amulet

* Revert "fix(Core/Spells): Script Lord Valthalak's Amulet"

This reverts commit 5a6a0a8e1fd596e0ffae906cfdac2f68fb1bc78d.

* Use spellInfo instead of hardcode
2023-10-10 13:12:11 -03:00
avarishd
96d0675624 fix(DB/SAI): Cuergo's Gold improvements (#17462)
* fix(DB/SAI):  Cuergo's Gold improvements

* Actionlist

* zzz
2023-10-10 10:36:04 -03:00
avarishd
e08de5f073 fix(DB/Creature): Hex Lord Malacrass missing weapon (#17475)
fix(DB/Creature): Hex Lord Malacrass wrong equipment

https: //github.com/TrinityCore/TrinityCore/commit/5856f520bbd8dded42f7742277839587b0645dde

Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com>
2023-10-10 10:23:27 -03:00
Andrew
7f36c5f059 fix(Scripts/Karazhan): Replace Big Bad Wolf chase mechanic with prope… (#17458)
fix(Scripts/Karazhan): Replace Big Bad Wolf chase mechanic with proper taunt spell
2023-10-08 17:19:48 -03:00
Dan
71312323a1 fix(Scripts/Karazhan): Nightbane clean-up script (#17446)
initial hackfix
2023-10-08 17:14:45 -03:00
avarishd
4e5077ed80 fix(Core/Spells): Script Shaman T8 Elemental 4P Bonus (#17424)
* fix(Core/Spells): Script Shaman T8 Elemental 4P Bonus

* 🧙‍♂️
2023-10-08 09:31:54 -03:00
Kitzunu
a4e4d6ddb2 feat(Core/Player): Implement commentator tag (#17449)
* feat(Core/Player): Implement commentator tag

* remove redundant session check
2023-10-08 09:07:17 +02:00
avarishd
91c6bdd540 fix(Core/Spells): Script Lord Valthalak's Amulet (#17431)
* fix(Core/Spells): Script Lord Valthalak's Amulet

* cs
2023-10-07 07:34:35 -03:00
Ludwig
de50ce3305 fix(Scripts/Midsummer): Randomize ribbon pole beam color (#17380)
* fix(Scripts/Midsummer): Randomize ribbon pole beam color

* Update data/sql/updates/pending_db_world/rev_1695820418952974700.sql

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>

* Add Validate() to spell script spell_midsummer_ribbon_pole

---------

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
2023-10-01 09:26:18 +02:00
Dan
62c6b158e5 refactor(Scripts/SSC): The Lurker Below boss script updated (#17082)
* initial

* restore me->CastSpell()

because apparently there is no overload of docastself that has triggerflags if I understand it correctly

* fix timers

may need some work - comments/thoughts welcome

* ms

* make kitzunu slightly less sad

* fixes

* revert

* Update boss_lurker_below.cpp

Co-authored-by: Angelo Venturini <Nefertumm@github.com>

* Update boss_lurker_below.cpp

---------

Co-authored-by: Angelo Venturini <Nefertumm@github.com>
2023-10-01 09:24:57 +02:00
Dan
57f5c6fb0c refactor(Scripts/SSC): Leotheras the Blind boss script updated (#17080)
* initial

* remove unused parameter

* fix timers

* useless commit to revive actions

* fixes

* weird mistake fixed

* browser programming kekW
2023-10-01 09:24:47 +02:00
Skjalf
c17a6c0a0e fix(Scripts/Karazhan): Fix Dorothee yell once Tito dies and clean up … (#17395)
* fix(Scripts/Karazhan): Fix Dorothee yell once Tito dies and clean up script

* fix dorothee interrupt immunity
2023-10-01 02:24:11 -03:00
Skjalf
9b403e0d10 fix(Scripts/Karazhan): Fix Curator arcane immunity (#17397)
* fix(Scripts/Karazhan): Fix Curator arcane immunity

* Update boss_curator.cpp

* Update boss_curator.cpp
2023-09-30 23:16:45 -03:00
Skjalf
7de2405604 fix(Scripts/Karazhan): Several Aran fixes (#17394)
- Fix drinking being interrupted by dots
- Fix first super timer
- Fix missing Arcane Explosion emote
- Fix supers being locked by spell interrupt
- Correct drinking to 10% mana down from 20%
2023-09-30 22:13:49 -03:00
Skjalf
547628fe70 fix(Scripts/Spells): Fix Dash applying bonuses in other forms (restor… (#17393)
fix(Scripts/Spells): Fix Dash applying bonuses in other forms (restores previous code functionality)
2023-09-30 17:59:15 -03:00
Skjalf
f583dbe98c fix(Scripts/Karazhan): Restore Netherspite DestroyPortals() function (#17392) 2023-09-30 15:34:18 -03:00
Ludwig
1004dae7e5 refactor(Scripts/Midsummer): Add/Update Validate() for spell checks (#17390) 2023-09-30 09:54:27 +02:00
Ludwig
7a1c303d49 refactor(Scripts/Midsummer): Assign enum values to gameobjects and sp… (#17379)
* refactor(Scripts/Midsummer): Assign enum values to gameobjects and spells

* rename GO_TORCH_TOSS_TARGET_BUNNY to NPC_TORCH_TOSS_TARGET_BUNNY

* add more enum values to enum flingTorch
2023-09-29 18:30:35 +02:00
AG
2779833768 feat(Core/Grids): Implement visibility notifier (#15919)
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Dan
29af6cc886 fix(Scripts/Magtheridon): make the timers of Quake and Blast Nova independent from each other (#17364)
* initial

* fix timers

* add delay for duration

* Update boss_magtheridon.cpp

10s
2023-09-28 05:48:40 -03:00