UltraNix
3fee40be7d
fix(Core/Creatures): Spells casted by player should tap the creature … ( #14725 )
...
…only if in combat with it.
2023-01-26 04:38:16 -03:00
UltraNix
ff8374ac98
fix(DB/SAI): Caretaker Smither. ( #14445 )
...
Fixes #14384
Author: @Gultask
<!-- First of all, THANK YOU for your contribution. -->
## Issues Addressed:
<!-- If your fix has a relating issue, link it below -->
- Closes #14384
## Tests Performed:
<!-- Does it build without errors? Did you test in-game? What did you
test? On which OS did you test? Describe any other tests performed -->
- Tested ingame.
## How to Test the Changes:
<!-- Describe in a detailed step-by-step order how to test the changes
-->
`.go c id 20363`
<!-- If you intend to contribute repeatedly to our project, it is a good
idea to join our discord channel. We set ranks for our contributors and
give them access to special resources or knowledge:
https://discord.com/invite/DasJqPba )
Do not remove the instructions below about testing, they will help users
to test your PR -->
## How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as **[WAITING TO BE
TESTED]**.
You can help by testing PRs and writing your feedback here on the PR's
page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
**REMEMBER**: when testing a PR that changes something **generic** (i.e.
a part of code that handles more than one specific thing), the tester
should not only check that the PR does its job (e.g. fixing spell XXX)
but **especially** check that the PR does not cause any regression (i.e.
introducing new bugs).
**For example**: if a PR fixes spell X by changing a part of code that
handles spells X, Y, and Z, we should not only test X, but **we should
test Y and Z as well**.
Co-authored-by: Gultask <gultask@gmail.com >
2023-01-25 17:00:19 -03:00
Benjamin Jackson
4e2270c935
feat(Core/ObjectMgr): Add handling specific to heroic player level stats (DKs). ( #14378 )
2023-01-25 13:14:31 -03:00
M'Dic
437d93926f
fix (core): macos12 depreciation workflow error / security CWE-120 ( #14746 )
...
* fix (core): macos12 depreciation workflow error
Fix workflow error message:
azerothcore-wotlk/src/common/Utilities/Util.cpp:558:9: fatal error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
sprintf(buffer, "%02X", bytes[i]);
* Update BattlegroundAV.cpp
* more macos12 fixit
* Update spell_generic.cpp
2023-01-23 06:13:27 -05:00
Axel Cocat
513dab0740
feat(Core/Mail): call CanSendMail() even if no items are sent ( #14435 )
...
* feat(Core/Mail): call CanSendMail() even if no items are sent
* Update src/server/game/Handlers/MailHandler.cpp
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2023-01-22 20:15:34 +01:00
UltraNix
1de52e5570
fix(Core/Formations): Implemented new creature formation flag: GROUP_… ( #14537 )
...
fix(Core/Formations): Implemented new creature formation flag: GROUP_AI_FLAG_ACQUIRE_NEW_TARGET_ON_EVADE.
Fixes #14494
2023-01-19 20:08:51 +01:00
55Honey
e9b040e3d2
feat: getter for the used instance IDs ( #14677 )
...
* feat: getter for the used instance IDs
* doxygen
2023-01-15 15:47:49 +01:00
Kitzunu
12f4a28b01
fix(Core/Characters): Correctly update char count on realm selection ( #14685 )
2023-01-15 15:44:17 +01:00
天鹿
14885e3e96
fix(core/packets): reduce sending unnecessary packets ( #13198 )
...
Co-authored-by: Dehravor <dehravor@gmail.com >
2023-01-15 15:31:00 +01:00
Kitzunu
aecf278cbe
chore(Core/Docs): Remvoe old comment ( #14684 )
...
* fixed in e322c017ea
2023-01-15 14:30:48 +01:00
UltraNix
0022b3a964
fix(Core): Crashfix. ( #14660 )
2023-01-14 10:41:40 +01:00
UltraNix
592a26cb8c
fix(Core): Crashfix. ( #14536 )
2023-01-11 02:40:03 -03:00
Kitzunu
ed2997ab10
fix(Core/Creature): Check model increase only for Exotic creatures ( #14526 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14525
2023-01-07 20:36:39 +01:00
UltraNix
9ba464a12b
fix(Core/Spells): Fixed applying some proc ex flags to melee attacks. ( #14254 )
...
Fixes #14216
2023-01-07 20:30:01 +01:00
UltraNix
8cb88cce52
fix(Scripts/The Underbog): Rewritten The Black Stalker's Levitate mec… ( #14541 )
...
* fix(Scripts/The Underbog): Rewritten The Black Stalker's Levitate mechanic.
Fixes #13988
* buildfix.
* Update src/server/scripts/Outland/CoilfangReservoir/underbog/boss_the_black_stalker.cpp
Co-authored-by: offl <offl@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2023-01-07 20:28:22 +01:00
lineagedr
777a1be394
fix(Core/Packets): Fix a crash in MSG_RANDOM_ROLL. ( #14545 )
2023-01-07 20:27:49 +01:00
Alvin Zhu
e322c017ea
fix(Core/Gossip): quest_greeting_locale doesn't work #10913 ( #14532 )
...
* fix issue #10913
fix GetQuestGreetingLocale typeIndex just like GetQuestGreeting
* Update ObjectMgr.h
* fix Core/Gossip: gossipMenuLocale doesn't work
* Revert "fix Core/Gossip: gossipMenuLocale doesn't work"
This reverts commit f59f07d1504f21cf2ae1eaa37aa088100c352e3b.
2023-01-07 20:21:47 +01:00
Kitzunu
7b774c8141
fix(Core/Spell): Roll 'dem Bones ( #14522 )
...
* fix(Core/Spell): Roll 'dem Bones
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14357
* Partial cp of 029527365f
Co-Authored-By: joschiwald <736792+joschiwald@users.noreply.github.com >
* newline pleb
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com >
2023-01-07 20:05:42 +01:00
Mickaël Mauger
21700f2760
fix(Core/Loot): Fix too many quest items visible by master looter ( #14510 )
...
* Fix too many quest items visible by master looter
* Fix typo
2023-01-07 13:27:28 -03:00
Kitzunu
8d2dda24ed
fix(Core/Pets): Correct Pet size for bigger pets ( #14511 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14488
2023-01-06 03:23:21 +01:00
Gultask
6b4ef50e7a
Revert "fix(Core/Spells): Ignite and Revitalize should not prelong co… ( #14513 )
...
Revert "fix(Core/Spells): Ignite and Revitalize should not prelong combat. (#13812 )"
This reverts commit 96fa9c5c7b .
2023-01-05 23:14:56 -03:00
UltraNix
c3b8df8cb2
fix(Core/Spells): Aura with SPELL_AURA_MOD_FEAR effect are always c… ( #14450 )
...
fix(Core/Spells): Aura with `SPELL_AURA_MOD_FEAR` effect are always considered as negative.
Fixes #14297
2023-01-06 00:53:37 +01:00
UltraNix
7a03130b94
fix(Core/Spells): Regen auras should not be removed by Rapid Recupera… ( #14269 )
...
fix(Core/Spells): Regen auras should not be removed by Rapid Recuperation.
Fixes #14263
2023-01-06 00:53:10 +01:00
UltraNix
14f3b444ae
fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SU… ( #14054 )
...
* fix(Core/Creatures): Implemented `SUMMON_PROP_FLAG_ONLY_VISIBLE_TO_SUMMONER` summon flag.
Fixes #6674
* Update.
2023-01-06 00:52:05 +01:00
UltraNix
0e1e8f27de
fix(Core/Spells): Every spell casted by player should tap the creature. ( #14037 )
...
Fixes #11888
2023-01-06 00:51:54 +01:00
UltraNix
96fa9c5c7b
fix(Core/Spells): Ignite and Revitalize should not prelong combat. ( #13812 )
...
Fixes #13330
2023-01-06 00:50:53 +01:00
Revision
1c523bd611
feat(Core/Config): Allow disable points of interest for quests ( #14501 )
2023-01-04 20:30:57 -03:00
Gultask
b4080ed0f1
revert "fix(Core/Formations): Implemented new creature formation flag: GROUP_AI_FLAG_ACQUIRE_NEW_TARGET_ON_EVADE." ( #14494 )
2023-01-04 14:44:42 +01:00
Mickaël Mauger
e35078a1f8
fix(Core/Loot) Fix master looter invisible quest items ( #14103 )
2023-01-02 21:47:08 -03:00
Angelo Venturini
9e18b86311
fix(Core/Auras): SPELL_AURA_MOD_SCALE should scale additively instead… ( #14425 )
...
...multiplicatively
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2023-01-02 20:43:20 -03:00
Gultask
f65d229823
Revert "fix(Core/Config): Set default corpse decay for normal creatures to 5 …" ( #14474 )
2023-01-02 22:27:22 +01:00
Mickaël Mauger
24fa3ba828
fix(MMAP/core/PathGenerator): Try to fix more water creatures ( #13705 )
...
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2023-01-02 22:26:12 +01:00
UltraNix
9b525d1cee
fix(Core/Gameobjects): Fixed LoS for traps summoned by creatures. ( #13873 )
2023-01-02 21:06:12 +01:00
Benjamin Jackson
5534455c32
refactor(Core/player_levelstats): Split player_levelstats into class and race specific tables. ( #14383 )
...
Co-authored-by: ahchxj2416 <64737877+ahchxj2416@users.noreply.github.com >
Co-authored-by: Shauren <shauren.trinity@gmail.com >
Co-authored-by: funjoker <torti-esser@web.de >
2023-01-02 21:04:08 +01:00
UltraNix
af2d3a7cfc
fix(Core/Spells): Spellmods should not drop charges if not consumed b… ( #13498 )
2023-01-02 20:36:44 +01:00
UltraNix
8448996639
fix(Core/Spells): Fixed Hunter's Mark not being casted by Swamplord M… ( #14457 )
...
fix(Core/Spells): Fixed Hunter's Mark not being casted by Swamplord Musel'ek.
Fixes #13993
2023-01-01 08:49:47 -03:00
Kitzunu
4870b14b1f
refactor(Core/Object): getLevel() -> GetLevel() ( #14122 )
...
* refactor(Core/Object): getLevel() -> GetLevel()
* fix build and sneak some doxygen in
* codeSTLE
* codestyle
2022-12-31 17:39:23 +01:00
55Honey
718454fd48
feat(Core/scripts): expose Halaa slider value and owner setter
2022-12-30 22:29:19 +01:00
Axel Cocat
7fa0aeeca7
feat(Core/Group): add GetGroupType() ( #14411 )
2022-12-29 14:45:49 +01:00
Axel Cocat
a104f397d9
feat(Core): move achievement manager and criteria progress getters to public ( #14387 )
2022-12-29 13:41:47 +01:00
UltraNix
a101f16124
fix(Core/Config): Set default corpse decay for normal creatures to 5 … ( #14039 )
2022-12-29 12:09:30 +01:00
Axel Cocat
97b5906124
feat(Core/Player): delete character cache in Player::DeleteFromDB() ( #14388 )
2022-12-28 19:22:28 -03:00
M'Dic
2850052f3e
Add (core): SendTeleportPacket helper ( #14389 )
...
* Add (core): SendTeleportPacket helper
add helper to SendTeleportPacket
* sin hard
2022-12-28 13:05:46 -05:00
Angelo Venturini
0a4051c4b2
fix(Core/Handlers): Crash ( #14390 )
2022-12-28 14:32:55 -03:00
UltraNix
6345958769
fix(Core/Loot): Disenchanted, milled or prospected items should be se… ( #14273 )
...
fix(Core/Loot): Disenchanted, milled or prospected items should be sent as retrieval mail in case of full bags.
Fixes #10798
2022-12-27 21:43:12 -03:00
Skjalf
2eb374c6e4
fix(Core/Totem): Implement casting delay for the Fire Totem used by c… ( #14276 )
...
* fix(Core/Totem): Implement casting delay for the Fire Totem used by creatures
* clear debug
* Update src/server/game/Entities/Totem/Totem.h
* fix build
* Update Totem.cpp
2022-12-28 00:38:00 +01:00
Skjalf
50b85220a0
fix(Core/AI): Fix target selectors logic when accounting for tanks ( #14368 )
2022-12-27 15:05:08 -03:00
UltraNix
233d284539
fix(Core/Formations): Implemented new creature formation flag: GROUP_AI_FLAG_ACQUIRE_NEW_TARGET_ON_EVADE. ( #13509 )
...
Fixes #13394
2022-12-27 11:31:08 +01:00
UltraNix
0c1b967f9b
fix(Core/Transports): Added Arrival bell sound for boats. ( #14272 )
...
Fixes #11340
2022-12-25 10:35:55 -03:00
UltraNix
49ad7402d9
fix(Core/LFG): Fixed showing dungeon access requirements only for lea… ( #14116 )
...
fix(Core/LFG): Fixed showing dungeon access requirements only for leaders in LFG.
Fixes #14070
2022-12-25 10:17:15 -03:00