Commit Graph

592 Commits

Author SHA1 Message Date
Ludwig
2e5d5f2dc7 fix(Events): fix commoner spawns, auras and equips for all events (#17632)
* fix(Core/Spells): Implement Gossip NPC Appearance spells

65511 Gossip NPC Appearance - Brewfest
65522 Gossip NPC Appearance - Winter Veil
65523 Gossip NPC Appearance - Default
65524 Gossip NPC Appearance - Lunar Festival
65525 Gossip NPC Appearance - Hallow's End
65526 Gossip NPC Appearance - Midsummer
65527 Gossip NPC Appearance - Spirit of Competition
65528 Gossip NPC Appearance - Pirates' Day
65529 Gossip NPC Appearance - Day of the Dead (DotD)

* fix(DB/SAI): fix commoner spawns and auras

* equip random mug on spell 65511 Gossip NPC Appearance - Brewfest

* check if creature before equipping brewfest mug

* minor optical fixes, DELETE first, then remove duplicate spawns

* fix two displayIDs in NPC Gossip Appearance spells

* Remove whitespace at the end of the lines

* remove commoner spawns for event 7 Harvest festival from game_event_creature

* fix harvest festival event id

* Update rev_1698785311231174200.sql
2023-11-10 20:26:49 +01:00
Ludwig
cb483d124f fix(Script/Spell): fix AOE circle bug on Midsummer Torch Catching (#17654)
* fix(Spells/Midsummer): fix script for spell 46747 SPELL_FLING_TORCH_DUMMY

* SpellInfoCorrections: fix target of spell 46747 Fling torch

* DB: assign spell 46747 Fling torch to item 34833 Unlit Torches

* remove whitespaces at src/server/game/Spells/SpellInfoCorrections.cpp:4610
2023-11-09 00:19:57 +01:00
Benjamin Jackson
f898fa75cd fix(Core/Spells): Correct spell scaling formula. (#17649)
* Replace old spell scaling with revised version.

Co-Authored-By: balakethelock <111737968+balakethelock@users.noreply.github.com>

* Remove a single-use variable.

* Use funky multiply operator.

More similar to original function, if a tad less readable IMO.

---------

Co-authored-by: balakethelock <111737968+balakethelock@users.noreply.github.com>
2023-11-08 08:44:05 +01:00
avarishd
8af077bc33 fix(DB/SAI): Naberius (#17639) 2023-11-08 08:01:24 +01:00
avarishd
fb83c22dd2 fix(Core/Spells): T5 Warlock 4 Set (#17589)
* fix(Core/Spells): T5 Warlock 4 Set

* BonusMultiplier is 1 so we don't care about it
2023-11-02 12:30:03 -03:00
avarishd
11c88cb30e fix(Core/Spells): T4 Shadow Priest 4 Set (#17587)
* fix(Core/Spells): T4 Shadow Priest 4 Set

* zzz
2023-11-02 08:54:44 -03:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
avarishd
8c8d459c6f fix(Core/Spells): Marked for Death affecting wrong spells. (#17406) 2023-10-21 10:28:57 -03:00
Ludwig
de6ece2462 fix(Core/Spells): interrupt midsummer ribbonpole dance on mount or sp… (#17442)
fix(Core/Spells): interrupt midsummer ribbonpole dance on mount or spell cast
2023-10-19 21:40:08 -03:00
avarishd
a39175bc3b fix(Core/Spells): Demonic Knowledge missing 1% per rank (#17495) 2023-10-18 19:21:46 -03:00
KJack
99bf49e0dd Fix (core/SpellEffects): Don't randomize summoned guardian position if target is in the DB (#17506)
* Doesn't randomize placement of guardian summons if the target position was specified in the DB

* Add `HasRadius()` check

* Add check for zero-radius effects, update IF condition style

* Accept IF condition statement suggestion

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-10-17 00:07:47 +02:00
avarishd
2cd4af9446 fix(Core/Spells): Allow casting ground mounts in water (#17481)
https: //github.com/TrinityCore/TrinityCore/pull/17488

Co-authored-by: SnapperRy <19622383+SnapperRy@users.noreply.github.com>
2023-10-10 20:23:45 -03:00
KJack
f127e583aa fix(core/scripting) Calculate percent-based damage before ModifyPeriodicDamageAurasTick hook (#17387)
Moved damage calculation for `SPELL_AURA_PERIODIC_DAMAGE_PERCENT` to before the hook.

Co-authored-by: KJack <kjack@electricnightowl.com>
2023-10-08 15:38:07 -03:00
avarishd
91c6bdd540 fix(Core/Spells): Script Lord Valthalak's Amulet (#17431)
* fix(Core/Spells): Script Lord Valthalak's Amulet

* cs
2023-10-07 07:34:35 -03:00
AG
2779833768 feat(Core/Grids): Implement visibility notifier (#15919)
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Skjalf
14ed5860e1 fix(Core/Spells): Correct swapped TARGET_UNIT_NEARBY_ALLY and TARGET_… (#17339)
fix(Core/Spells): Correct swapped TARGET_UNIT_NEARBY_ALLY and TARGET_UNIT_NEARBY_PARTY

(cherry picked from commit 7c6d92012a )
Co-Authored-By: xvwyh <43143822+xvwyh@users.noreply.github.com>
2023-09-25 08:33:23 -03:00
Skjalf
c7b7b7dc07 fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet (#17342)
* fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet

* Update src/server/game/Entities/Pet/Pet.cpp
2023-09-25 08:07:09 -03:00
Skjalf
4a0b879ee3 fix(Scripts/Karazhan): Fix Shade of Aran Blizzard and use proper spel… (#17329)
* fix(Scripts/Karazhan): Fix Shade of Aran Blizzard and use proper spells to summon elementals

* Update boss_shade_of_aran.cpp

* Update boss_shade_of_aran.cpp

* Update rev_1695546719351253200.sql

* missing sql
2023-09-25 06:41:21 -03:00
Skjalf
cc60bc0c35 fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to… (#17348)
* fix(Scripts/Spells): Fix Healing & Mana injectors not giving bonus to engineers

* Update SpellEffects.cpp

* Update spell_item.cpp
2023-09-25 06:10:23 -03:00
Grimgravy
6990a1d2a4 fix(Scripts/Quest): improve Catch the Wild Wolpertinger! (#17333) 2023-09-24 16:23:58 -03:00
Tralenor
0796df57ac feat(Core/Player): Addition of a Hook in CanFlyInZone check (#16590)
---------

Co-authored-by: tmoos <tmoos@meteomatics.com>
Co-authored-by: Winfidonarleyan <dowlandtop@yandex.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-09-20 22:40:08 +02:00
Angelo Venturini
be5db26d24 fix(Scripts/MagtheridonLair): Magtheridon Debris (#17249)
* fix(Core/Scripts): Magtheridon Debris

* unhack

* cleanup

* eof line

* unused variable

* more cleanup
2023-09-17 07:43:10 -03:00
Kitzunu
b84596fcab chore(Scripts/DK): Move CheckCast to spell_dk_raise_ally script (#17221)
* chore(Scripts/Spell): Move CheckCast to spell_dk_raise_ally script

* Update spell_dk.cpp

* Update spell_dk.cpp
2023-09-17 03:05:10 +02:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Kitzunu
3eb2463c69 chore(Core/Misc): Correct some fmt outputs (#17091) 2023-08-27 06:23:26 +02:00
Christopher Galbraith
aea540181b fix(Spell): set torment of the worgen to have 3% proc chance (#17005)
Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-08-26 17:35:56 +02:00
Synful-Syn
6b583089f3 fix(Core/Spell): Stop Blink from the falling player to move upward by 1y and stop moving backward when facing a wall (#16657)
* blink-bad-warps

* Change formatting of an if
2023-08-25 09:14:27 -03:00
Christopher Galbraith
cee630774c fix(Core/Spells): Add SPELL_ATTR7_DONT_CAUSE_SPELL_PUSHBACK to Hand of Sac and Divine Sac spells (#17041)
* add no spell pushback flag to auras

* Revert "add no spell pushback flag to auras"

This reverts commit 545e9fe4ee69bb079b69a4f2ba6039b834568a59.

* spellInfoCorrection for no pushback on HoS and Divine Sac

---------

Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-08-25 09:02:27 -03:00
The GhostRider
b1c8b0eaa2 fix(Core/Item): Complimentary Brewfest Sampler (#16992)
* Fix(DB/C++):Item - Complimentary Brewfest Sampler

* Delete PlayerStorage.cpp

* Update rev_1691843684176706600.sql

Correction

* Ripristino il file PlayerStorage.cpp

* New file: SpellInfoCorrections.cpp

* Update rev_1691843684176706600.sql
2023-08-25 08:45:06 -03:00
avarishd
7c43738214 fix(Spells/Scripts): Gnomish Poultryizer (#15554)
fix(Spells/Scripts): Gnomish Poultryizer not breaking on damage
2023-08-10 14:37:14 -03:00
v-mstrs
9eadbdf611 fix(Core/Spells): Warrior T5 2p (#16749)
* fix overpower bonus

* Update SpellInfoCorrections.cpp

* Update src/server/game/Spells/SpellInfoCorrections.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-06 03:32:52 +02:00
Maria-sequel
81a20d69de fix(Core/Spells): Silent Fang proc should not work in … (#16907)
fix(Spell/SpellInfoCorrections): Silent Fang proc should not work in arena
2023-08-06 03:21:01 +02:00
UltraNix
c3acf75618 fix(Core/Spells): Taunt always set proper target while channelling sp… (#13948)
* fix(Core/Spells): Taunt always set proper target while channelling spells.

Fixes #13841

* Update.

* Update.
2023-08-06 03:16:05 +02:00
v-mstrs
aaabca1cd0 fix(Core/Spells) Add Explosive Shot exception (#16854)
* gitpain

* Update SpellAuras.cpp
2023-08-01 14:11:22 -03:00
avarishd
08ed1fb47a fix(Scripts/Pets): Darting Hatchling not running around. (#15251)
* fix(Scripts/Pets): Darting Hatchling not running around.

* cs

* Update pet_generic.cpp

* RemoveAurasDueToSpell
2023-07-18 13:53:44 -03:00
Synful-Syn
f84d786df0 chore(Scripts/Spells): Reduce the amount of player checks (#16719)
merge some player checks
2023-07-17 08:24:18 -03:00
Angelo Venturini
dbc39a2817 fix(Core/Spells): Implement ENCHANT_PROC_ATTR_WHITE_HIT (#16771)
Co-authored-by: Ariel Silva<ariel-@users.noreply.github.com>
2023-07-17 08:19:24 -03:00
v-mstrs
d0fa5f04ef fix(Core/Spells): Add Beast Lord 4P bonus (#16655) 2023-07-01 16:31:17 -03:00
Tereneckla
a234314d35 fix (Core/Spells) Apply Seals of Pure talent to Seal of Vengeance/Corruption again (#16559)
Update SpellEffects.cpp
2023-06-30 09:18:02 -03:00
The GhostRider
2176435938 fix(Core/Spell): Net-o-Matic (#16482) 2023-06-08 22:33:31 -03:00
Angelo Venturini
3fc0a5b4fd fix(Core/Scripts): Ghaz'an acid spit should hit just one target (#16410) 2023-06-07 11:42:56 -03:00
Kitzunu
ee18f55f63 fix(Scripts/Spells): Convert some Druid spells to SpellScript (#16414)
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com>
2023-06-01 22:04:00 +02:00
Skjalf
6a73c38eb6 fix(Scripts/ShatteredHalls): Rework Nethekurse (#16265) 2023-05-21 18:11:31 -03:00
avarishd
ff6d88f6de fix(Core/Spells): Dungeon T3 2P Bonuses for Wastewalker & Doomplate. (#16076) 2023-05-14 11:37:50 -03:00
Tereneckla
a5d334db8b fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal of Corruption do not benefit from percentage damage increases (#15940)
* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp
2023-05-13 16:35:47 -03:00
Tereneckla
6fe6f891fc Revert "fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal… (#15938)
* Revert "fix(Core/Spells): Seal of Command, Seal of Vengeance and Seal of Corr… (#15193)"

This reverts commit 88401360ab.

* Keep Divine Storm in SPELLFAMILIY_PALADIN case

* Update SpellEffects.cpp
2023-05-13 14:41:27 -03:00
avarishd
38509d2b3a fix(Core/Spells): Apply AURA_STATE_FAERIE_FIRE to Lambent Blood. (#16103) 2023-05-13 14:11:04 -03:00
Gultask
64c7c99bda revert(Core/Player): Revert Delayed Damage System (#16246)
* Revert "fix(Core/Spells): Delayed Damage system (#16183)"

This reverts commit d282cce4af.

* Revert "fix: Crash on ProcessDelayedDamages (#16166)"

This reverts commit 3dbdea5e28.

* Revert "fix(core\player): Missing combat animation (#14199)"

This reverts commit a238e5e27b.
2023-05-13 13:50:27 -03:00
avarishd
3aedf2fbf8 fix(DB/SAI): Void Baron Galaxis encounter. (#15312)
* fix(DB/SAI): Void Baron Galaxis encounter.

* remove item cast + add void storm cloud
2023-05-10 06:29:51 -03:00