Commit Graph

707 Commits

Author SHA1 Message Date
Francesco Borzì
2ce2c8cf3a refactor(src/server/game/*): remove unused imports (big part 3) (#20315) 2024-10-27 13:10:28 +01:00
Francesco Borzì
cb7e28df05 refactor(src/server/game/*): remove unused imports (big part 1) (#20310) 2024-10-27 10:25:40 +01:00
Benjamin Jackson
4ad9d68f42 chore(Core): Correct typo of Suppress. (#20229)
* Init.

* Adjust spacing.
2024-10-17 22:09:53 +02:00
Rorschach91
91a5c49943 Fix(DB/Script): Phase change for DK starter area Eye of Acherus and npcs. (#20170)
* fix(Script/Mother Shahraz) Increase min teleport range and add new teleport points.

This fix increase minimum teleport range for Fatal Attraction and It adds 5 new teleport points if the boss is near the platform.

* Update boss_mother_shahraz.cpp

* fix(DB/Creature): Phase change for DK starter area npcs.

This fix change the phases when some npcs can be viewed.

* Update dk_phases_fix

* Update dk_phases_fix

* Create DK_NPC_Phases_Fix.sql

* Delete data/sql/updates/pending_db_world/dk_phases_fix

* Update DK_NPC_Phases_Fix.sql

* Update DK_NPC_Phases_Fix.sql

* Update DK_NPC_Phases_Fix.sql

* Update DK_NPC_Phases_Fix.sql

* Update SpellInfoCorrections.cpp

Eye of Acherus in Phase 2

* Update SpellInfoCorrections.cpp

Eye of Acherus ApplySpellFix removed (Eye of Acherus is in phase 2 now).

* Update DK_NPC_Phases_Fix.sql

Adding Npcs inside Acherus in phase 2.
2024-10-13 20:53:09 +02:00
Jelle Meeus
e0f08bbfb6 fix(Core/Spells): supress caster procs for Siphon Life heal (#20175)
supress caster procs for Siphon Life heal
2024-10-12 13:05:44 +02:00
Angelo Venturini
fede17f782 fix(Core/Spells): Fix crash (#20179)
Co-authored-by: Ariel Silva <ariel-@users.noreply.github.com>
2024-10-11 08:15:02 -03:00
Benjamin Jackson
c3ee737c80 fix(Core/SpellInfoCorrections): Add Arcane Missiles spell info correction. (#20165)
Init.

Co-authored-by: Ernesto Gonzalez <80600689+ernesto-glz@users.noreply.github.com>
2024-10-11 11:51:29 +02:00
Jelle Meeus
859a42a41e fix(Core/Vehicles): feat vehicle seat addon, vehicle enter/exit positions (#20082)
* implement initial vehicle_seat_addon

Co-authored-by: Ovah <dreadkiller@gmx.de>

* add more vehicle_seat_addon data

* make exiting passenger visible

fixes "immediate despawn" of travelers mammoth

* style, update comments

* remove hacked pos relocate

* remove sending MSG_MOVE_ROOT/UNROOT on Ack

* set and unset UNIT_NPC_FLAG_PLAYER_VEHICLE on init/entry

* ulduar demolisher: remove flag correction and no longer needed usableseat

* fixup! implement initial vehicle_seat_addon

* fixup! fixup! implement initial vehicle_seat_addon

* re-add AddPassenger Flame Leviathan hack

was commented by mistake

* Update rev_1725993194571320983.sql

add missing ticks

---------

Co-authored-by: Ovah <dreadkiller@gmx.de>
2024-10-11 07:08:14 +02:00
Benjamin Jackson
cc5c582b4d fix(Core/Spell): Include damaging spells for starting combat. (#20154)
Init.
2024-10-07 08:55:28 -03:00
Jelle Meeus
9a1f27121a fix(Core/Unit): Flight Form riding crop, vehicle speed auras (#20079)
* vehicle aura stacking

Rename flight speed related auras
Co-authored-by: Laise <fenrisse@gmail.com>

* rename to better match existing flight auras
2024-10-01 21:39:42 +02:00
Andrew
ee870ff3b3 fix(Core/Spells): Restricted aura application prevention when immune to banish effects (e.g cyclone) (#20060) 2024-10-01 11:47:44 +02:00
Francesco Borzì
484e19d21b refactor(src/server/game/Spells): remove unused imports (#20092) 2024-10-01 08:05:15 +02:00
Jelle Meeus
6e4a9bbb14 fix(Core/Unit): fix Dual Wield for more creatures, CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK, creature disarm damage (#20015)
* enable CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK

* sql set CREATURE_FLAG_EXTRA_USE_OFFHAND

* use new HasOffHandWeaponForAttack instead of haveOffhandWeapon

no longer requires m_CanDualwield set to use Offhand attack
requires non-disarmed weapon in Offhand OR creature_flag_extra enabled

Co-authored-by: Ovah <dreadkiller@gmx.de>
Co-authored-by: Warlockbugs <warlockbugs@outlook.com>

* Make shapeshift forms which dont override attack speed use weapon damage

Co-authored-by: killerwife <killerwife@gmail.com>

* SetEquipmentSlots turning off damage update when using template default

Co-authored-by: killerwife <killerwife@gmail.com>

* Setup DualWield & Damage On Equipment Updates, implement Set and GetVirtualItem

Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com>

* creature disarm damage

set disarm to reduce minmax damage by 50% instead of setting to 0

Co-authored-by: Warlockbugs <warlockbugs@outlook.com>

---------

Co-authored-by: Ovah <dreadkiller@gmx.de>
Co-authored-by: Warlockbugs <warlockbugs@outlook.com>
Co-authored-by: killerwife <killerwife@gmail.com>
Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com>
2024-09-25 16:53:39 +02:00
Walter Pagani
891bcd8e00 refactor(SQL/Quest) Rescuing the Rescuers ID 11244 (#20030)
* refactor(SQL/Quest) Rescuing the Rescuers ID 11244

* fix range and max targets

* Texts are added and the smart_script list is modified

Co-authored-by: DEV Seaferer <91832265+edgardavid94@users.noreply.github.com>

---------

Co-authored-by: DEV Seaferer <91832265+edgardavid94@users.noreply.github.com>
2024-09-25 10:36:56 +02:00
Andrew
dea3d44b46 fix(Core/Spells): Prevent aura application if the target is immune (#20031) 2024-09-24 15:17:22 -03:00
Andrew
78cc255f43 fix(Core/Spells): Fix Fatal Attraction procing multiple times for eac… (#20014)
fix(Core/Spells): Fix Fatal Attraction procing multiple times for each player nearby
2024-09-22 14:52:19 -03:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
a0057b9e90 fix(Core/Spells): Resolve a case of triggered spells prolonging combat. (#19991)
* Revert "fix(Core/Spells): Revert triggered spell logic change. (#19983)"

This reverts commit 3bb5ec779d.

* Add aura effect check.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Add comment, use target instead of owner.

* Adjust comment terminology.

---------

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-09-19 09:49:56 -03:00
Benjamin Jackson
3bb5ec779d fix(Core/Spells): Revert triggered spell logic change. (#19983)
Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…"

This reverts commit edd7e10dfc.
2024-09-16 11:15:50 -03:00
Grimdhex
4fc60bbbdf fix(Core/Spells): Shadow demon - Allow to move while casting Paralyze (#19948)
* fix(Scripts/BlackTemple): fix stationary shadow demons

* optimization: use else if to stop the execution when a condition is reach

* revert last changes and fix the spell to allow move while casting

* .
2024-09-14 08:39:03 -03:00
Saqra1
321ac4a8c2 fix(Core/Spell): Summoning Portal position (#19705)
* fix(Core/Spell): Summoning Portal position

Summoning Portal is created in front of the caster but it is still too
close to them. Move it away a bit.

* Cleanup unused SpellInfo correction

Spell 61994 was stopped being used for summons in favor of 23598 on:
67010623a0
2024-09-11 12:37:56 -03:00
Saqra1
4734582e58 fix(Core/Spell): Refreshment Table position (#19704)
Refreshment Table game object should be created at the same position its
Refreshment Portal was created.
2024-09-11 11:53:07 -03:00
Benjamin Jackson
edd7e10dfc fix(Core/Spells): Resolve a case of triggered spells prolonging combat. (#19819)
* Init.

* Expand trigger info check.

* Enclose evaluation in parentheses.

Maybe workflow will be happy?
2024-09-11 11:52:15 -03:00
Saqra1
c42b3ee258 fix(Core/Pet): Control Infernal without enslave (#19784)
Check SummonProperties Category(Control) too to decide the type of
controls a Guardian should have.

Don't enslave Warlock's Infernal
2024-09-11 11:18:13 -03:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Kitzunu
9af86553c5 chore(Core/Misc): update floor and ceil to std (#19837) 2024-09-03 08:01:00 -03:00
Jelle Meeus
e1abc72a25 fix(Core/Spell): warrior stances proccing darkmoon card vengeance damage (#19796)
add spellinfocorrection
2024-09-01 20:58:03 -03:00
Saqra1
62b825f8bd fix(Core/Movement): Don't move for change in orientation only (#19687)
Changing only the orientation of a unit also flags it as if it were
moving, which causes spells to be interrupted.
2024-09-01 20:57:17 -03:00
Kitzunu
5d31b9f98f refactor(Core/Item): Add helpers (#19828) 2024-08-31 19:38:50 -03:00
Benjamin Jackson
b595586bf0 refactor(Core/SpellMgr): Remove nested ifs for binary evaluation. (#19762)
* Init.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Whitespace.

* Tiny nitpick.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Tiny nitpick.*

Today Bench learns the difference between break and continue.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Parentheses warnings.

* Apply suggestion.

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

---------

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-08-28 08:13:42 -03:00
Benjamin Jackson
8f335bbc2b fix(Core/SpellMgr): Remove binary attribute from Drain Soul. (#19760)
Init.
2024-08-27 15:17:54 -03:00
Saqra1
68402b6d91 fix(Core/Spell): Reset cd on some channeled spells (#19696)
If a spell is both channeled and has SPELL_ATTR0_COOLDOWN_ON_EVENT
attribute (only rituals) is channeled for its full duration, it goes on
an infinite cooldown. The client needs to be notified when the ritual
ends without being completed.
2024-08-25 23:43:01 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Tereneckla
3419f0246b fix (Core/Spells) partially revert #19529 (#19703)
Update Spell.cpp
2024-08-22 20:36:39 -03:00
Andrew
c0b6eae0e1 fix(Core/Spells): Fix movement impairment auras not being removed (#19684) 2024-08-22 15:09:43 -03:00
Andrew
ef4e0c0d4a fix(Core/Spells): Power of the Guardian should persist through death (#19638) 2024-08-21 06:36:05 -03:00
Tereneckla
79a653b13e fix (Core/Spells): remove object size for hit calculation of aoe aura spells that target enemies (#19529)
remove object size for aoe on enemy spells
2024-08-18 20:34:56 -03:00
sudlud
adc9f4e7ab fix(Core/Spell): check for player before dereferencing (#19666) 2024-08-18 05:57:02 -03:00
Benjamin Jackson
adff3c3846 fix(Core/Spells): Revert ownership and follow logic adjustment for guardian summons. (#19664)
Revert "fix(Core/Spells): Adjust ownership and follow logic for guardian summ…"

This reverts commit cc2ef9d6dd.
2024-08-17 20:29:21 -03:00
Grimdhex
9dc20bc261 fix(Core/Entities): crash fix cause by a pointer change in #19622 (#19633)
* fix(Core/Entities): crash fix cause by a pointer change in #19622

* fix blank space for codestyle check
2024-08-15 16:28:50 -03:00
Grimdhex
7457aef78d refactor(Core/Entities): Cleanup Unit header file (#19622)
* move several enum definitions in a new files

* move more things

* remove the include comment

* move the related code to CharmInfo in this own file

*original idea of Ovahlord

Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* fix clang build errors and few blank lines

* missing forward declaration

* new tentative to fix gcc/clang build

* add several include could be necessary for gcc/clang compilation

* .

* revert some include since the last AC update

* fix some loop inconsistencies

* align all enums in UnitDefine.h

---------

Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-08-15 05:12:44 -03:00
Andrew
1565758da4 Revert "chore(Script/Misc): cleanup" (#19627)
Revert "chore(Script/Misc): cleanup (#19619)"

This reverts commit 7ff8f72397.
2024-08-15 05:43:11 +02:00
Kitzunu
7ff8f72397 chore(Script/Misc): cleanup (#19619)
* chore(Script/Misc): cleanup

* more cleanup

* cleanup
2024-08-14 16:29:50 -03:00
Benjamin Jackson
67010623a0 fix(Core): Adjustments to summoning ritual object handling. (#19600)
* Init.

* Allow self-summoning.

* Revert unintended change.

Self-summoning still works fine without this being removed, I see no harm in putting it back.
2024-08-13 12:12:05 -03:00
Saqra1
ad411b49b7 fix(Core/Spell) Ritual spells cooldown on cancel (#19604)
762f78b313

Co-authored-by: killerwife <killerwife@gmail.com>
2024-08-13 12:05:12 -03:00
Saqra1
ed824de7b8 fix(Core): Ritual animations (#19602)
Channel the same spell as the original caster when clicking on a ritual
portal, but ignore the effects of the spell.

Co-authored-by: killerwife <killerwife@gmail.com>
2024-08-13 11:54:17 -03:00
Benjamin Jackson
cc2ef9d6dd fix(Core/Spells): Adjust ownership and follow logic for guardian summons. (#19599)
* Init.

* Remove totem ownership transfer.
2024-08-13 11:53:43 -03:00
Benjamin Jackson
35b551c0da fix(Core/SpellInfo): Disallow damage scaling trigger spells to get scaled twice. (#19605)
* Init.

* Deleted the wrong one.

* Add double scaling check.

* Whitespace.
2024-08-13 11:53:14 -03:00
Kitzunu
e4df159f5c refactor(Core/Chat): Move SendNotification to ChatHander (#19491)
* refactor(Core/Chat): Move SendNotification to ChatHander

* Update Battleground.cpp

* fix build

* Update src/server/game/Chat/Chat.h
2024-08-10 11:39:46 -03:00
Gultask
09e77dfd1c fix(Scripts/BlackTemple): Mother Shahraz Periodic part 2 (#19561)
* init

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp

* Update boss_mother_shahraz.cpp
2024-08-06 11:53:19 -03:00