Commit Graph

144 Commits

Author SHA1 Message Date
Kitzunu
28f1dc5c0c refactor(Core): replace NULL with nullptr (#4593) 2021-03-02 01:34:20 +01:00
Kitzunu
dbc0ff6554 refactor(Core): sort #includes alphabetically (#4579) 2021-02-24 22:34:42 +01:00
Footman
695a7402ad fix(Core): creature movement bugs (#4544)
- fix UpdateEnvironmentIfNeeded was changing flying creature status all the time. closes: #4447
- fix hovering state was causing bugs at #4466
- add animation state priority: fly > hover > ground

Co-authored-by: Wotex <fm@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Patrick Lewis <pat@lo5t.com>
2021-02-12 11:42:41 +01:00
Kitzunu
bfcc3c6f87 refactor(Core/Spell): Move some SpellImmune from script to db (#4381)
* refactor(Core/Spell): Move some SpellImmune from script to db
2021-02-05 18:57:51 -05:00
Kitzunu
0d52b4ca4a feat(Core/Spell): Implement ValidateSpellInfo (#4323)
* feat(Core/Spell): Implement ValidateSpellInfo

* cherry-pick from 2b5d7eef3a & a0a158b5b8

* sLog->outError

* cleanup

* convert to ValidateSpellInfo

* fix error log

* improve sLog->outError

* remove non related spells stuff from Validate

* remove the last

* build

* build x2
2021-02-01 18:57:25 +01:00
Yehonal
c8f43d8584 feat(Core/Movement): Improved pathfinding, collisions and movements (#4220)
Npc positioning
Implemented slope check to avoid unwanted climbing for some kind of movements (backwards, repositioning etc.)
Implemented backwards movement
Re-implemented circle repositioning algorithm (smartest than retail, but with the same feeling)
Fixed random position of summoned minions
Improved pet following movement. Also, they attack NPC from behind now. Thanks to @Footman

Swimming creatures
Fixed max_z coordinate for swimming creatures. Now only part of their body is allowed to be out of the water level
Fixed pathfinder for swimming creatures creating shortcuts for specific segments, now they swim underwater to reach the seashore instead of flying above the water level.
Creatures with water InhabitType but no swimming flag now, when not in combat, will walk on water depth instead of swimming. Thanks @jackpoz for the original code
UNIT_FLAG_SWIMMING in UpdateEnvironmentIfNeeded to show the swimming animation correctly when underwater
Implemented HasEnoughWater check to avoid swimming creatures to go where the water level is too low but also to properly enable swimming animation only when a creature has enough water to swim.

Walking creatures
Extended the DetourNavMeshQuery adding area cost based on walkability (slope angle + source height) to find better paths at runtime instead of completely remove them from mmaps
improve Z height in certain conditions (see #4205, #4203, #4247 )

Flying creatures
Rewriting of the hover system
Removed hacks and improved the UpdateEnvironmentIfNeeded. Now creatures can properly switch from flying to walk etc.
Spells
LOS on spell effect must be calculated on CollisionHeight and HitSpherePoint instead of position coords.
Improved position for object/creature spawned via spells
Improved checks for Fleeing movements (fear spells)

Other improvements
Implemented method to calculate the CollisionWidth from dbc (used by repositioning algorithm etc.)
Improved raycast and collision checks

Co-authored-by: Footman <p.alexej@freenet.de>
Co-authored-by: Helias <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-02-01 01:34:27 +01:00
55Honey
12bf9731af fix(Scripts/boss_freya): adds apply SPELL_CONSERVATOR_GRIP 6s after spawn (#4082)
Co-authored-by: WiZZy <bilucristian25@gmail.com>
2021-01-17 01:06:40 +01:00
Kitzunu
d5c41aa5d7 fix(DB/Quest): Taken by the Scourge (#4079) 2021-01-16 13:43:49 +01:00
WiZZy
b9375ffff7 fix(Core/The Oculus) Drakos dragon keepers (#3531) 2021-01-12 14:46:16 +01:00
Kitzunu
b0aff365a9 chore(core): Remove malformed whitespace (#4248) 2021-01-10 18:20:45 +01:00
Kitzunu
da4edd547d chore(core): remove malformed whitespaces (#4244)
* from https://www.codefactor.io/repository/github/azerothcore/azerothcore-wotlk/issues?category=Style&groupId=838&lang=5&page=75
2021-01-10 14:27:55 +01:00
Kargatum
ea93a5c1a1 feat(CI/Codestyle): added codestyle check (#3668) 2021-01-09 11:59:50 +01:00
Vox
9592028ad1 fix(scripts/instance): Force correct gossip/text updates (#3838) 2021-01-08 13:34:05 +01:00
WiZZy
aec0dbb747 fix(scripts/Ulduar): Kologarn - Focused Eyebeam (#3529) 2020-12-25 12:10:19 -06:00
WiZZy
d710057a31 fix(scripts/Ulduar): Expedition Base Camp (#3558) 2020-12-25 09:56:32 -06:00
Silker
26bf415ce0 fix(scripts/Oculus): Reset Mage-Lord Urom's position at death (#4012) 2020-12-19 18:29:02 -06:00
Francesco Borzì
d4a58700d4 refactor(Core): apply clang-tidy modernize-use-override (#3817) 2020-12-06 18:04:55 +01:00
Silker
87c905af26 fix(Scripts/Ulduar): Yogg-Saron's portals (#3810) 2020-12-04 22:55:18 -06:00
Andrius Peleckas
01fa6257c8 fix(Scripts/ObsidianSanctum): Code revamp [1/2] (#3634) 2020-11-28 15:36:05 -06:00
Vox
d4612c7ac6 fix(Scripts/ICC): Intro Event Timers and Text 2020-11-28 15:22:42 +01:00
Goatform
37d1f2be47 fix(Scripts/VOA): code-style improvements + bandwidth consumptio (#3632) 2020-11-27 12:50:50 +01:00
aradep
223738e910 fix(Scripts/DB): Mimiron Computer NPC text (#3722) 2020-11-27 10:07:15 +01:00
Silker
bcac48b573 fix(scripts/Ulduar): Assembly of Iron - interrupt immune effect (#3765) 2020-11-26 08:53:29 -06:00
Silker
4105d370bf fix(DB/scripts): Freya - Sun beam (#3730) 2020-11-22 11:16:35 -06:00
Silker
d6c1b84bd9 fix(Scripts): Ignis the Furnace Master - Iron construct buff stacks #3731 2020-11-21 15:31:22 -06:00
Patrick Lewis
6ef7627c69 fix(Script/ICC): Spirit Alarm and Deathbound Ward (#3592) 2020-11-04 14:32:33 -06:00
aradep
c10bffb9a9 fix(Scripts/Ulduar): Boss XT-002 enrage sound 2020-11-03 02:50:59 -06:00
aradep
18d7f8b92f fix(Scripts/Ulduar): Hodir flash freeze safe spots 2020-11-02 15:06:50 +01:00
Andrius Peleckas
ab5933effa fix(Core/Util): EventMap::RepeatEvent when eventId is retrieved by ExecuteEvent() call (#3426) 2020-10-17 14:59:22 +02:00
mslmdevu
32da0eeb9e fix(Scripts/Ulduar): cast electrical charge only if player dies (#3480) 2020-10-16 21:24:39 +02:00
Kargatum
5e20b46812 refactor(Core/Scripts): restyle scripts lib with astyle (#3467) 2020-10-11 10:35:34 +02:00
Arthas Wow
22f8195c14 fix(Core/Boss): Toravon Script Mechanics (#2868) 2020-10-07 12:17:36 +02:00
Patrick Lewis
b67c30e263 fix(Core/Script) npc Tom Hegger target player for aggro text (#3444) 2020-10-03 16:25:54 +02:00
Francesco Borzì
b61ae8abcd fix(Core/Misc): all GCC warnings (#3457) 2020-09-14 17:31:12 +02:00
Krath
ce8db433cf fix(Scripts/Ulduar): Hodir Door (#3346)
Co-authored-by: Krath <affannimattia@libero.it>
2020-09-12 20:10:12 +02:00
Stefano Borzì
51330f54d8 refactor(Core/Misc): remove the ternary operator when used improperly (#3327) 2020-09-10 12:29:23 +02:00
Francesco Borzì
ebfb4b4cea fix(Scripts/Wintergrasp): fix disabled always false (#3437) 2020-09-09 11:46:41 +02:00
Petric
68b1112821 fix(Scripts/AzjolNerub): Amanitar not casting “Mini” and mushroom not cleansing the player on death (#3348)
Amanitar was not casting his “mini” spell during the fight and the shrooms did never remove this effect as how they should.
2020-09-07 16:52:24 +02:00
Krath
aa60f0b324 fix(Scripts/ICC): visual of the Blood Council Bosses 2020-09-07 10:27:39 +02:00
Kitzunu
03bd4fafe6 refactor(Core/ICC): Move hardcoded spells to enum (#3337) 2020-09-05 16:21:21 +02:00
Kitzunu
f67635497f fix(Scripts/ICC): Don't show Heroic Attempts on Normal difficulty (#3336) 2020-09-05 13:19:31 +02:00
Petric
7a4a409cae fix(Core/Script): Anomalus (#3325)
* Correct rift spawning/ empowering timings and Rift Shield cancellation

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-09-04 09:44:09 +02:00
Petric
e2cf12a2ce fix(CORE/Dungeon): Mage-Lord Urom now cats empowered arcane explosion when he teleports to the center (#3323)
Mage-Lord Urom in Oculus would teleport to the center of the room, but he would never cast empowered accane-explosion he would just wait there

Closes https://github.com/azerothcore/azerothcore-wotlk/issues/3320

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-09-03 16:18:34 +02:00
Petric
e1e8cc1bf5 fix(CORE/Raid): Muradin/Saurfang not de-spawning after finishing movement (#3294)
Saurfang and Muradin together with its 3 followers were not de-spawning once reaching the exit portal after the initial RP moment and remain standing in front of the exit portal forever.

Partially Closes https://github.com/azerothcore/azerothcore-wotlk/issues/3246

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 17:27:01 +02:00
Petric
4034a56f87 fix(CORE/Raid): Lich King “Pain and Suffering” snapping and “Shadow Trap” not targeting tanks (#3293)
-Lich King was snapping to north after using Pain and Suffering when instead he should be facing the direction of last target.
-Shadow Trap could not target tanks, it should be able to do so

Closes https://github.com/azerothcore/azerothcore-wotlk/issues/2826

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 14:19:22 +02:00
Kitzunu
1f89282b22 refactor(Core): NULL -> nullptr (#3275)
* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 11:55:09 +02:00
Walter Pagani
563748ec31 fix(Core/Gossip): Remove hard-coded texts from the: The forge of souls C++ (#3219)
* Text of the gossip taken from the database

* Adding translations to quest_offer_reward_locale

* Adding enum for gossip.

* Changing the name of the enum to avoid conflicts.

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-24 19:10:02 +02:00
Christopher Galbraith
5a5ece6d98 fix(Scripts/UtgardePinnacle): Svala Sorrowgrave's loot disappearing too quickly (#3188) 2020-08-22 00:46:13 +02:00
Francesco Borzì
d2cc3fcbc2 feat(Docker): update to Ubuntu 20.04 + more improvements (#3277) 2020-08-13 00:25:20 +02:00
lineagedr
2743874e5d fix(Core/Script): Trial of the Crusader (#2888)
* The floor will remain broken after a wipe

* Anub'arak will respawn correctly after wiping
2020-05-27 21:58:28 +02:00