Commit Graph

110 Commits

Author SHA1 Message Date
Kitzunu
1cc5518147 fix(Core/Spell): Killing Spree range (#4097)
Co-authored-by: Keader <keader.android@gmail.com>
2021-01-17 00:40:30 +01:00
Silker
3f79f16960 fix(Core/SpellMgr): Death Plague stacks (#4299) 2021-01-16 12:52:06 -06:00
Kitzunu
43f59c4c82 feat(Core/Player): implement GetFreeInventorySpace() (#4297) 2021-01-16 17:33:30 +01:00
Stefano Borzì
df600f9946 fix(Core/CreatureAI): revert NPC repositioning and path system (temporarily) (#4274) 2021-01-14 19:17:34 +01:00
Kitzunu
fd3505411d chore(Core/SpellAuraEffects): Comment out empty if (#4246) 2021-01-11 14:48:07 +01:00
Kitzunu
da4edd547d chore(core): remove malformed whitespaces (#4244)
* from https://www.codefactor.io/repository/github/azerothcore/azerothcore-wotlk/issues?category=Style&groupId=838&lang=5&page=75
2021-01-10 14:27:55 +01:00
Kargatum
ea93a5c1a1 feat(CI/Codestyle): added codestyle check (#3668) 2021-01-09 11:59:50 +01:00
r0m1ntik
b35d3a8fb8 fix(Core/Spell): [Potion] Elixir of Minor Fortitude effect disappear (#4217) 2021-01-08 23:26:17 +01:00
Stefano Borzì
b2761626fe feat(Core/CreatureAI): improve npc position during the combat (#3369)
+ tangent equation to find correct angle and distance when moving

+ implemented proper backward

* Improved performance + random angle margin

* chore: add tollerance calculation in instance

* improved LOS checks with movements

* implemented collisions using raycast (imported by TC)

+ improved collision detection for CanReachPositionAndGetCoords

+ improved collision check

+ set correct flags for the backward movement

+ first implementation of slope angle (to improve)

Co-authored-by: Yehonal <yehonal.azeroth@gmail.com>
2021-01-04 20:23:08 +01:00
Stefano Borzì
e7dc6df31e fix(Core/GO): failed attempt (#4036)
Co-authored-by: Yehonal <yehonal.azeroth@gmail.com>
2020-12-28 11:05:37 +01:00
Kitzunu
269482778d chore(Core/SpellMgr): Indentation (#4028) 2020-12-26 20:58:22 -06:00
WiZZy
d710057a31 fix(scripts/Ulduar): Expedition Base Camp (#3558) 2020-12-25 09:56:32 -06:00
Kitzunu
672057316a fix(Core/Spell): Clicking lock portal cost mana (#4013) 2020-12-22 21:24:52 +00:00
Francesco Borzì
c5a35efd7b refactor(Core): apply clang-tidy modernize-use-default-member-init (#3827) 2020-12-07 13:34:06 -06:00
Francesco Borzì
161302252e refactor(Core): apply clang-tidy modernize-use-nodiscard (#3835) 2020-12-06 19:39:48 +01:00
Francesco Borzì
d4a58700d4 refactor(Core): apply clang-tidy modernize-use-override (#3817) 2020-12-06 18:04:55 +01:00
Kitzunu
5a8b60361a refactor(Core/SpellMgr): simplify dbc data corrections (#3709)
* refactor(Core/SpellMgr): simplify dbc data corrections

* I hate failing builds... so guess sleep isnt neccessary

* only works when you actually fill out them all

* blankspace

* step 1 - rename

* This takes so long Q.Q

* Update SpellMgr.cpp

* Revert "Update SpellMgr.cpp"

This reverts commit e1de9712a52fd6547761c3ccd70c17a7d4aa8036.

* Revert "Revert "Update SpellMgr.cpp""

This reverts commit e9253c2846b83bfe2760e71a0fc52d2d9fbed853.

* revert

* DONE

* cleanup

* cleanup

* New error so good, why try to correct spells that dont exist :)

* brackets

* Github merge conflict fix SUCKS
2020-11-21 17:03:19 +01:00
Kitzunu
973dcbf47c fix(Core/SpellMgr): Thorns should not miss (#3695) 2020-11-18 10:06:41 -06:00
Andrius Peleckas
d7becdae27 feat(Core/Spells): Functions will return cast result (#3635) 2020-11-13 08:00:07 -06:00
Shard
e7f1ab4a6a fix(Core/Logs): Fix arguments in function call (#3672) 2020-11-09 08:56:19 -06:00
kubeeek
6574007e48 fix(Scripts/Ulduar): Supercharge stack issue fix (#3586) 2020-11-04 14:10:20 +01:00
kubeeek
2e298e7fc9 fix(Core/Ulduar): Stone Nova stacks [25 mode] 2020-11-03 08:38:16 -06:00
Silker
4a2c4f0f5f fix(Spell): Expose weakness (#3588)
This change allows the spell Expose Weakness (heroic encounters) to stack from additional sources.
Co-authored-by: Si1ker <55638679+Sombranator@users.noreply.github.com>
2020-10-31 00:19:51 -06:00
Kargatum
a2b26272d2 refactor(Core/Game): restyle game lib with astyle (#3466) 2020-10-12 10:08:15 +02:00
Stefano Borzì
91f4671d07 fix(Core/Spells): prevent client crash on use spell Neural Needle + ESC (#3383) 2020-09-27 16:31:41 +02:00
Francesco Borzì
b61ae8abcd fix(Core/Misc): all GCC warnings (#3457) 2020-09-14 17:31:12 +02:00
Petric
15cc6fe0b6 fix(Core/Spells): Implement SPELL_ATTR7_INTERRUPT_ONLY_NONPLAYER. (#3313)
Co-authored-by: HeartWell <moki.play@mail.ru>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-09-03 12:02:00 +02:00
Kitzunu
1f89282b22 refactor(Core): NULL -> nullptr (#3275)
* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 11:55:09 +02:00
Kitzunu
3aad2dc564 fix(Core/SpellEffects): Make Shadowmeld drop combat (#3272)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-30 22:50:28 +02:00
Shard
d8ad0c5200 Allow mages to refresh Living Bomb (#3228)
Currently, mages can't refresh Living Bomb if the target already have the dot.

###How to reproduce the issue :
1. Use Living Bomb on a target
2. Try to re-use Living Bomb on the same target
3. Observe the error message

###Expected Blizzlike behaviour
Living Bomb should be reapplyable 

###Why this PR : 
This PR allow to refresh the duration of Living Bomb on the same target

I've didn't found a bad mage's video that refreshes Living Bomb on his target, but found some Fire Mage 3.3.5 guides that mentions : 
"Never refresh your LB (Living Bomb) before the explosion (except if I clearly tell you to)."
https://sites.google.com/site/pvemage335/fire/rotation-gameplay

"Living Bomb – every 12 seconds **after the explosion**"
https://www.gnarlyguides.com/wotlk/guides/pve-fire-mage/#plink-rotation

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2020-08-26 11:44:41 +02:00
Kitzunu
dd40e2e844 fix(Core/SpellAuras): Show auras to client limit (#3193)
Co-authored-by: Pascal Bachor <gerhood@users.noreply.github.com>
2020-08-22 10:34:12 +02:00
Christopher Galbraith
d7c9b36a5c fix(Core/Spells): Winter's Chill now stacks from multiple sources
Signed-off-by: Chris <chriscgalbraith@gmail.com>
2020-08-21 19:07:02 +02:00
Yehonal
7fba8b910f fix(#2147): enrage and some false-negative spells (#3153)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-08-18 11:10:43 +02:00
Kitzunu
8b9cec620d refactor(Core/SpellInfo): Positive/Negative spells from SpellFamilyName into DB (#3149)
* Implement SPELL_ATTR0_CU_POSITIVE_EFF0

* Implement SPELL_ATTR0_CU_POSITIVE_EFF1

* Implement SPELL_ATTR0_CU_POSITIVE_EFF2

* Move SpellFamilyName spells into DB to define if they are POSITIVE or NEGATIVE spells

* Rename column from entry to spell_id to make more sense
2020-08-16 13:25:26 +02:00
Francesco Borzì
d2cc3fcbc2 feat(Docker): update to Ubuntu 20.04 + more improvements (#3277) 2020-08-13 00:25:20 +02:00
Francesco Borzì
0e1713d1b7 fix(Core/Spell): rogue's poisons logic check (#3278) 2020-08-11 15:29:53 +02:00
gengarshadowball
0b35a24053 fix(Core/Spell): Implement SPELL_ATTR0_CU_DONT_BREAK_STEALTH (#3056)
* Implement the ability to add SPELL_ATTR0_CU_DONT_BREAK_STEALTH on spells from DB

Co-authored-by: Shadowball Gengar <shadowballgengar60@gmail>
2020-06-19 12:00:21 +02:00
Kitzunu
fecba9f287 refactor(Core/Query): escape some MySQL 8.0 keywords (#3027) 2020-05-17 07:33:47 +02:00
Francesco Borzì
3cf3f69e13 fix(Core/Spell): Melee ranged spells (#2686)
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-20 18:52:30 +01:00
Yehonal
0cabb8e7e1 refactor(Core/Spells): Improved logic and DX Spell::EffectSummonPet (#2634) 2020-02-20 07:55:04 +01:00
niaro-kitty
32dcb3bf63 feat(Core/Spell): Header include optimization for files: SpellAura.h SpellAuraEffects.h (#2632) 2020-02-19 07:55:18 +01:00
Rochet2
c16f21a271 fix(Core/Eluna): Fix issues with spell procs with Eluna (#2636) 2020-02-12 07:58:29 +01:00
Kaev
2fa9f5c249 fix(Core): potential crashes/bugs reported by static analysis #2 (#2622) 2020-02-03 07:52:27 +01:00
Kaev
999d588c37 fix(Core): Fixed a few crashes/bugs that were found via static code analysis (#2617) 2020-01-25 14:26:38 +01:00
Shard
9f690a3741 fix(Core) : Enable randomProperties or suffix up to 5 (#2340) 2020-01-23 08:06:05 +01:00
Shard
067d9e791f fix(Core/Battlegrounds) Rewrite RandomBG and enabling bg/arenas weights (#2516) 2019-12-28 09:40:13 +01:00
CosmeF
e4fc5def21 fix(Core/Spell) Add an intervene trigger condition to avoid stealth removal (#2492) 2019-12-22 09:29:13 +01:00
Kargatum
4a8f1de538 feat(Core/Misc): remove and replace ACE_Singleton (#2418) 2019-12-21 00:29:29 +07:00
Viste
e22d78ecd6 refactor(Core): rename namespaces and macros to acore (#2454) 2019-12-01 13:13:31 +01:00
GMKyle
da6c255a70 fix(Core/Raid):Putricide mutated abomination being energized by players (#2386) 2019-11-24 09:26:30 +01:00