* fix(Core/Spell): Allow using SpellDifficulty in bg
* cherry-pick commit (e4caf52e5a)
* "Allow get SpellDifficulty on battleground maps
This is only for Isle of Conquest (Bracket 71-79 is Regular Difficulty, Bracket 80-84 is heroic or 25Man)
Spells of IoC Battleground vehicles, cannons, bombs and bosses have SpellDifficulty in DBC"
* Remove redundant CastSpell and assign a variable instead
Co-Authored-By: Gildor <521036+Jildor@users.noreply.github.com>
* Update isle_of_conquest.cpp
---------
Co-authored-by: Gildor <521036+Jildor@users.noreply.github.com>
* Nefaran says low hp and shadowflame texts, use ScheduleHealthCheckEvent
* use drakonic bone spells
* remove no longer needed _scheduler
* remove extra file
* fix(Scripts/Spells): Revive pets with full mana in bgs
* Pets were incorrectly revived without restoring its mana
* Closes#15894
* ready for merge
---------
Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
* remove seed of corruption handling in unit.cpp
* add generic and warlock aurascript
add warlock aurascript
add enum
add generic aurascript
add OnRemove
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
detonation threshold scaling added in: df5afca278
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* add LoS check to generic damage
* refactor 2 scripts to 1 with args
refactor const_cast to GetAura()->GetEffect(
refactor reduce a line
* fix detonation threshold scaling
changed SPELL_DIRECT_DAMAGE to DOT
* remove not needed IsExpired() check
removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE
* update comment
* refactor script with args to single spellscript, fix detonate by evade
* refactor
detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged
* refactor to 2 spell scripts again
* rename detonation spell from seed_of_corruption to seed_of_corruption_damage
avoids confusion with seed of corruption (with dot effect)
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* add Demonic Pact Aura script
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* spell_warlock aura:spell_warl_demonic_pact_aura
* fixup! spell_warlock aura:spell_warl_demonic_pact_aura
* remove not needed spell correction, flag is already set
* subtract current proc bonus before calculating new bonus
* also increase healing done
* remove Demonic Pact handling in Unit
* refactor indent, remove bonus from spell group effects e.g. totem of wrath
* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"
This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.
* refactor indent
* manually set proc cooldown
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com>
* feat(Core/Chat): Provide a fully-formed protocol for addons to interact with GM commands
* Send success/fail state, allow interleaving, and indicate end of output. Add framework for supporting non-human-readable output in commands.
* cherry-pick commit (508c9d2fc1)
This PR implements a well-formed protocol for addons to communicate with the server, outlined below:
- All communication happens over the addon channel (`LANG_ADDON` in terms of the core, `CHAT_MSG_ADDON`/`SendAddonMessage` for the client). The prefix used for all messages is `AzerothCore` (in client terms - in core terms, every message starts with `AzerothCore\t`).
- In each message, the first character is the opcode. The following four characters are a unique identifier for the invocation in question, and will be echoed back by the server in every message related to that invocation. Following is the message body, if any.
- The following opcodes are supported:
- Client to server:
- `p` - Ping request. The core will always respond by ACKing with the passed identifier. No body.
- `i` or `h` - Command invocation. The message body is the command text without prefix. `i` requests machine-readable output, `h` requests human-readable.
- Server to client:
- `a` - ACK. The first message sent in response to any invocation (before any output). No body.
- `m` - Message. Sent once per line of output the server generates. Body = output line.
- `o` - OK. Indicates that the command finished processing with no errors. No body.
- `f` - Failed. Indicates that command processing is done, but there was an error. No body.
Expected overhead is minimal, and this integrates seamlessly with existing command scripts (no changes necessary).
PS: There's also a client-side addon library that exposes this protocol in a developer-friendly way over at https://github.com/azerothcore/LibAzerothCore-1.0
---------
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
* chore(Scripts/Commands): QOL server debug
* England
* might as well do updatetime while we are at it. Consistency right?
* Hey let's sneak this ENGLAND in
* fix(Core/Unit): Invalidate update object cache when changing health in the same world update tick.
Should fix an issue when the client sees dead NPCs when they are not.
* Fix styling
* Another codestyle fix
