Jelle Meeus
5674c23d04
fix(Scripts/BlackwingLair): Nefarian say low health and rewrite p3 ( #19405 )
...
* Nefaran says low hp and shadowflame texts, use ScheduleHealthCheckEvent
* use drakonic bone spells
* remove no longer needed _scheduler
* remove extra file
2024-07-17 08:09:38 -03:00
Saqra1
a950a7f44e
fix(Core/Pets): Add option to revive pets with full mana ( #19383 )
...
* fix(Scripts/Spells): Revive pets with full mana in bgs
* Pets were incorrectly revived without restoring its mana
* Closes #15894
* ready for merge
---------
Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-17 12:38:10 +02:00
Jelle Meeus
e8af1aaffc
fix(Scripts/Spells): warlock seed of corruption ( #19322 )
...
* remove seed of corruption handling in unit.cpp
* add generic and warlock aurascript
add warlock aurascript
add enum
add generic aurascript
add OnRemove
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
detonation threshold scaling added in: df5afca278
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
* add LoS check to generic damage
* refactor 2 scripts to 1 with args
refactor const_cast to GetAura()->GetEffect(
refactor reduce a line
* fix detonation threshold scaling
changed SPELL_DIRECT_DAMAGE to DOT
* remove not needed IsExpired() check
removal upon expiration is notified by AURA_REMOVE_BY_EXPIRE
* update comment
* refactor script with args to single spellscript, fix detonate by evade
* refactor
detonation to Detonate()
rename amount to remainingDamage
remove no tneeded HealthBelowPctDamaged
* refactor to 2 spell scripts again
* rename detonation spell from seed_of_corruption to seed_of_corruption_damage
avoids confusion with seed of corruption (with dot effect)
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
2024-07-17 01:50:38 +02:00
Jelle Meeus
9109de6500
fix(Scripts/Karazhan): Nightbane Combat Abilities ( #19321 )
...
* fix(Scripts/Karazhan): NightbaneCombatAbilities
update fear
WIP add comments
increase air phase
* remove distracting ash from ground phase
* :sort
2024-07-17 01:46:23 +02:00
avarishd
90c7658320
fix(Script/Spells): Script Glumdor's Steal Weapon ( #19258 )
...
* fix(Core/Spells): Script Glumdor's Steal Weapon
* add creature check
2024-07-17 01:44:49 +02:00
Kitzunu
275b8b5d7f
chore(Scripts/ServerMail): Cleanup the code ( #19412 )
...
* chore(Scripts/ServerMail): Cleanup the code
* try to fix build error
* okay we resort to the AIs
2024-07-17 01:33:26 +02:00
Kitzunu
f0e6b0f1ab
chore(Core/GameObjectAI): Cleanup register macro ( #19409 )
2024-07-17 00:17:49 +02:00
Kitzunu
2008d64e7b
fix(Scripts/Commands): Ticket response ( #19406 )
...
* fix(Scripts/Commands): Ticket response
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/19390
* Implements two new commands
* ticket response delete - Delete a ticket response
* ticket response show - Show current ticket response
* this better
* English?
* bette rlogic
* Update cs_ticket.cpp
2024-07-16 03:22:23 +02:00
avarishd
e92a5829a0
fix(Scripts/ZG): Jin'do using wrong hex spell ( #19389 )
2024-07-14 13:24:23 -03:00
Gultask
8eb7b24670
fix(Scripts/Netherstorm): Rewrite Phase Hunter AI ( #19401 )
...
* Update zone_netherstorm.cpp
* Update zone_netherstorm.cpp
* db
2024-07-14 12:27:32 -03:00
sudlud
7b8e2514bf
fix(Scripts/Midsummer): correctly despawn gameobjects ( #19387 )
2024-07-14 12:24:06 -03:00
avarishd
c3d98054dd
fix(Core/Spells): BT - Summon Shadowfiens should spawn 11, instead of 1 ( #19391 )
...
* fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1
* Revert "fix(Core/Spells): BT - Summon Shadowfiens should spawn 10, instead of 1"
This reverts commit e5040484b6bf1bce9343b5d2fae0b24057eeaf7f.
* 39649
* spellscript
* should summon 11
* Validate
2024-07-14 12:22:24 -03:00
avarishd
f109768665
fix(Scripts/TK): KT Mindcontrol should respect Line of Sight ( #19398 )
2024-07-14 05:41:10 -03:00
Jelle Meeus
a69d02e513
fix(Scripts/Spells): warlock demonic pact ( #19386 )
...
* add Demonic Pact Aura script
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
* spell_warlock aura:spell_warl_demonic_pact_aura
* fixup! spell_warlock aura:spell_warl_demonic_pact_aura
* remove not needed spell correction, flag is already set
* subtract current proc bonus before calculating new bonus
* also increase healing done
* remove Demonic Pact handling in Unit
* refactor indent, remove bonus from spell group effects e.g. totem of wrath
* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"
This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.
* refactor indent
* manually set proc cooldown
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
2024-07-13 12:38:59 -03:00
Benjamin Jackson
c7d086862a
fix(Scripts/HyjalSummit): Adjust Azgalor's Rain of Fire timings. ( #19393 )
...
* Init.
* Bad number.
2024-07-12 20:07:25 -03:00
Andrew
6b50570247
refactor(Scripts/BlackTemple): Update Mother Sharahz script ( #19378 )
...
* refactor(Scripts/BlackTemple): Update Mother Sharahz script
* Update boss_mother_shahraz.cpp
2024-07-09 18:56:13 -03:00
Francesco Borzì
4040f93f85
refactor(Scripts/Commands): remove unused imports ( #19340 )
...
* refactor(Scripts/Commands): remove unused imports
* chore: fix build
* chore: revert unwanted change
2024-07-09 14:17:06 -03:00
Benjamin Jackson
ccf5f06128
fix(Scripts/HyjalSummit): Correct Soul Charge color assignments. ( #19345 )
...
Init.
2024-07-09 14:15:34 -03:00
Jelle Meeus
2763625498
refactor(Scripts/Northrend): spell scripts registry macros ( #19346 )
...
* zone_sholazar_basin spell:spell_q12726_song_of_wind_and_water
* zone_sholazar_basin spell:spell_q12620_the_lifewarden_wrath
* zone_sholazar_basin spell:spell_q12589_shoot_rjr
* zone_sholazar_basin spell:spell_shango_tracks
* zone_borean_tundra aura:spell_q11919_q11940_drake_hunt_aura
* zone_borean_tundra spell:spell_arcane_chains_character_force_cast
* zone_borean_tundra spell:spell_q11719_bloodspore_ruination_45997
* isle_of_conquest aura:spell_ioc_repair_turret_aura
* isle_of_conquest spell:spell_ioc_bomb_blast_criteria
* isle_of_conquest spell:spell_ioc_gunship_portal
* isle_of_conquest aura:spell_ioc_parachute_ic_aura
* isle_of_conquest spell:spell_ioc_launch
* zone_dragonblight spell:spell_q12478_frostmourne_cavern
* zone_dragonblight aura:spell_q12243_fire_upon_the_waters_aura
* zone_dragonblight spell:spell_q24545_aod_special
* zone_dragonblight spell:spell_q12096_q12092_dummy
* zone_dragonblight spell:spell_q12096_q12092_bark
* zone_storm_peaks aura:spell_q13003_thursting_hodirs_spear_aura
* zone_storm_peaks spell:spell_q13007_iron_colossus
* zone_storm_peaks aura:spell_close_rift_aura
* zone_wintergrasp spell:spell_wintergrasp_force_building
* zone_wintergrasp spell:spell_wintergrasp_create_vehicle
* zone_wintergrasp spell:spell_wintergrasp_rp_gg
* zone_wintergrasp spell:spell_wintergrasp_portal
* zone_wintergrasp spell:spell_wintergrasp_water
* zone_wintergrasp aura:spell_wintergrasp_hide_small_elementals_aura
* zone_wintergrasp spell:spell_wg_reduce_damage_by_distance
* zone_icecrown spell:spell_switch_infragreen_bomber_station
* zone_icecrown pair:spell_charge_shield_bomber
* zone_icecrown spell:spell_fight_fire_bomber
* zone_icecrown spell:spell_anti_air_rocket_bomber
* zone_icecrown spell:spell_onslaught_or_call_bone_gryphon
* zone_grizzly_hills spell:spell_shredder_delivery
* zone_grizzly_hills aura:spell_infected_worgen_bite_aura
* zone_grizzly_hills spell:spell_vehicle_warhead_fuse
* zone_grizzly_hills spell:spell_warhead_detonate
* zone_grizzly_hills aura:spell_z_check_aura
* zone_grizzly_hills aura:spell_warhead_fuse_aura
* fixup! zone_icecrown pair:spell_charge_shield_bomber
2024-07-09 13:07:41 -03:00
Gultask
02104ca89b
fix(Scripts/AuchenaiCrypts): Remove double scheduling of Carnivorous Bite ( #19353 )
...
Update boss_shirrak_the_dead_watcher.cpp
2024-07-09 13:05:09 -03:00
sudlud
37e3d89f91
fix(CI): linux-build: add -Werror parameter ( #19240 )
...
* fix(CI): linux-build: add -Werror parameter
* add KI
tzunu
* Revert "feat(CI): enable fail-fast for pch/nopch (#19058 )"
This reverts commit 564cbca7d3 .
* Update midsummer.cpp - drop unused variable
* initialize variable
* Update core-build-nopch.yml - drop gcc12
* fix(Core/CalendarMgr): do not use element after delete, but before
* attempt to fix Socket.h error
* Revert "attempt to fix Socket.h error"
This reverts commit c1a59145ed3c49d0f76be2f81925434ea969db97.
* fix Socket.h error - attempt 2
* Update Socket.h
* Update Socket.h
* npc_shattrath_daily_quest: init variable templateID
* fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()
* boss_archimonde: drop unused variable
* Revert "fix(Scripts/Karazhan): use size_t within loop in boss_shade_of_aran:Reset()"
This reverts commit 1f71aaef256990c5cdc16561676be302c954ea9d.
* SmartScripts: SMART_TARGET_RANDOM_POINT: fix unintended fallthrough
* Revert "Revert "feat(CI): enable fail-fast for pch/nopch (#19058 )""
This reverts commit d13df293624e0f50d9374272bfd05ab56242511d.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-07 22:00:24 +02:00
Kitzunu
f41b80ddf1
fix(Build): -Wsign-compare ( #19320 )
2024-07-07 20:02:31 +02:00
Gultask
8279d9c272
fix(Scripts/HyjalSummit): Rage Winterchill Spells ( #19335 )
...
Update boss_rage_winterchill.cpp
2024-07-07 13:48:24 -03:00
Benjamin Jackson
d0cd435807
fix(Scripts/HyjalSummit): Add damage over time component to Doomfire debuff. ( #19317 )
...
* Init.
https: //github.com/mangostwo/server/commit/6a2e23cac09a88d7ec1221393ba96482d71187f6
Co-Authored-By: Miroslav Drbal [ApoC] <apoc@nymfe.net >
* Don't forget the query.
* Add spell attribute.
* Adjust tick script.
More dynamically calculates damage from ticks.
Co-Authored-By: avarishd <46330494+avarishd@users.noreply.github.com >
* Remove unnecessary `aurEff`
Co-Authored-By: avarishd <46330494+avarishd@users.noreply.github.com >
* #include
---------
Co-authored-by: Miroslav Drbal [ApoC] <apoc@nymfe.net >
Co-authored-by: avarishd <46330494+avarishd@users.noreply.github.com >
2024-07-06 20:02:35 +02:00
Kitzunu
9e6eca979b
fix(Scripts/ShadeOfAran): Make immune to Mind-numbing and Cure of Tongue ( #19309 )
...
* closes https://github.com/chromiecraft/chromiecraft/issues/6900
2024-07-06 11:22:13 +02:00
Gultask
76b6da1b3f
fix(Scripts/BlackTemple): Move Teron Gorefiend to scheduler and add Berserk ( #19288 )
...
Update boss_teron_gorefiend.cpp
2024-07-05 21:16:41 -03:00
Kitzunu
fc8b67bbe4
chore(Scripts/Commands): QOL server debug ( #19297 )
...
* chore(Scripts/Commands): QOL server debug
* England
* might as well do updatetime while we are at it. Consistency right?
* Hey let's sneak this ENGLAND in
2024-07-06 01:18:38 +02:00
Kitzunu
172f73db92
fix(Core/Misc): unused param ( #19286 )
2024-07-05 15:06:03 -03:00
Andrew
d9f4ba5e1d
fix(Scripts/Item): Fix Fel Mana Potion not benefiting from Alchemist'… ( #19281 )
...
fix(Scripts/Item): Fix Fel Mana Potion not benefiting from Alchemist's Stone
2024-07-05 06:32:33 -03:00
avarishd
7cf25c94ab
fix(Scripts/Shattrath): Daily Dungeon quests holograms ( #19233 )
...
* fix(Scripts/Shattrath): Daily Dungeon quests holographs
* Move to single script + doaction SAI
* ocd
* use NEAR_PLAYER
* use only Wind Trader as SAI
* use creature_guid target
* rename action
* cleanup
* zzz
* Update zone_shattrath_city.cpp
2024-07-04 15:50:11 -03:00
Dan
b959d5cc87
refactor(Scripts/ZulAman): Nalorakk refactored ( #19010 )
...
* init
* update movement
* updates and debug
* stuck :/
scheduler doesn't seem to update when at the end of wp movement???
* fix wps and implement fight
* finalise
* unused
* Update boss_nalorakk.cpp
* keep oprientation
* ran_intro
2024-07-04 20:13:41 +02:00
Jelle Meeus
9de2178eb5
fix(Scripts/Naxxramas): Razuvious' Death Knight Understudy RP ( #19183 )
2024-07-04 14:59:53 -03:00
Benjamin Jackson
c3e22c0fe2
fix(Scripts/HyjalSummit): Couple Archimonde adjustments. ( #19193 )
...
* Init.
Co-Authored-By: cyberium <cyberium@users.noreply.github.com >
Co-Authored-By: killerwife <killerwife@users.noreply.github.com >
* Corrections.
* Adjust fear timer.
* Wrong spell.
* Whitespace.
* Use the much cooler and more hip scheduler.
* Correct teleport timers.
Matches up with sniffed 3.4.3 data.
* Swap magic number for constant.
Co-Authored-By: killerwife <killerwife@users.noreply.github.com >
* Adjust notation.
* Public.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Kitzunu's fault.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: cyberium <cyberium@users.noreply.github.com >
Co-authored-by: killerwife <killerwife@users.noreply.github.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-04 14:31:22 -03:00
Kitzunu
e8f7d70ee0
refactor(Script/Dalaran): Minigob Manabonk ( #19244 )
...
* refactor(Script/Dalaran): Minigob Manabonk
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/16841
* Update src/server/scripts/Northrend/zone_dalaran.cpp
2024-07-04 14:28:10 -03:00
avarishd
f84a4f1408
fix(Scripts/TK): Kael'thas mind control should reset threat ( #19264 )
...
* fix(Scripts/TK): Kael'thas mind control should reset threat
* lol
* -2 lines
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-04 13:50:45 -03:00
Benjamin Jackson
e41080468f
fix(Scripts/TheEye): Kael'thas adjustments. ( #19213 )
...
* Init.
* Update advisor phase timer.
2024-07-04 09:26:23 -03:00
Kitzunu
0a8175ef03
refactor(Core/ObjectMgr): Handle Profanity & Reserved Names in load ( #19259 )
...
* refactor(Core/ObjectMgr): Handle Profanity & Reserved Names in load
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/18556
* Update ObjectMgr.cpp
* Update ObjectMgr.cpp
* I swear I am not drunk
* We already check all of these
* fix build
* Forgot we dont send the responsecode in senderrormessage
* last commit I swear
2024-07-03 00:23:32 +02:00
Kitzunu
f96d4c8670
Revert "Add (core\db): Support for Homebind Orientation ( #13389 )" ( #19257 )
...
* Revert "Add (core\db): Support for Homebind Orientation (#13389 )"
This reverts commit 2e6f6e26da .
Changes to be committed:
modified: src/server/database/Database/Implementation/CharacterDatabase.cpp
modified: src/server/game/DungeonFinding/LFGScripts.cpp
modified: src/server/game/Entities/Player/Player.cpp
modified: src/server/game/Entities/Player/Player.h
modified: src/server/game/Entities/Player/PlayerStorage.cpp
modified: src/server/game/Entities/Player/PlayerUpdates.cpp
modified: src/server/game/Handlers/CharacterHandler.cpp
modified: src/server/game/Handlers/MiscHandler.cpp
modified: src/server/game/Handlers/MovementHandler.cpp
modified: src/server/game/Maps/Map.cpp
modified: src/server/game/Spells/Spell.cpp
modified: src/server/scripts/Commands/cs_misc.cpp
modified: src/server/scripts/Commands/cs_tele.cpp
modified: src/server/scripts/Northrend/VaultOfArchavon/instance_vault_of_archavon.cpp
Untracked files:
data/sql/updates/pending_db_world/rev_1719945200692175000.sql
* Revert "Add (core\db): Support for Homebind Orientation (#13389 )"
* whoops
2024-07-02 22:02:15 +02:00
Kitzunu
5a4692e45a
chore(Core/Misc): #include cleanup ( #19255 )
2024-07-02 15:52:02 +02:00
Jelle Meeus
47ad691c92
refactor(Scripts/EasternKingdoms): RegisterSpellScript macro ( #19241 )
...
* zone_undercity spell:spell_blight_worm_ingest
* zone_blasted_lands spell:spell_razelikh_teleport_group
* zone_isle_of_queldanas spell:spell_bh_cleanse_quel_delar
2024-07-01 23:28:03 +02:00
Kitzunu
1289e351a2
fix(Script/Commands): output lookup quest and npc near ( #19243 )
...
* close https://github.com/azerothcore/azerothcore-wotlk/issues/19216
2024-07-01 07:24:54 -03:00
Kitzunu
688d7e2fdf
fix(Script/GunshipBattle): Wipe if no player is on the deck ( #19239 )
...
* fix(Script/GunshipBattle): Wipe if no player is on the deck
* reorder
* Update boss_icecrown_gunship_battle.cpp
* Update worldserver.conf.dist
* Update boss_icecrown_gunship_battle.cpp
* missed it!
* Update instance_icecrown_citadel.cpp
2024-06-30 18:30:44 -03:00
Andrew
8b81b1dad1
fix(Scripts/Hyjal): Workaround bosses getting stuck in progress ( #19231 )
2024-06-30 05:39:29 -03:00
Jelle Meeus
ed38e6e550
fix(Scripts/Naxxramas): Gothik missing visuals at minions death ( #18666 )
...
* add sql rev
* enable NPC_TRIGGER
* add npc_gothik_trigger
* add rest of script
* spell info correction
* fix compile issue
* fix desummon call
* remove comment
* access gothik by GUID
* add missing function overrides
* add braces
* add missing trigger, adjust CGUID value
* fixup! add missing trigger, adjust CGUID value
* select skulls based on coordinates
style
invert remove
remove CGUID comment
fix remove_if check, use correct def
* JustSummoned: target same side with mapLOS
* select random initial target on the same side
* add REACT_AGGRESSIVE and increase CallForHelp radius
* refactor spellscript
* style
2024-06-29 15:12:12 -03:00
Kitzunu
bc91074b14
fix(build): mac ( #19229 )
2024-06-29 11:48:58 -03:00
avarishd
63c8c6480e
fix(Core/Spells): Eye of Grillok improvements ( #19148 )
...
* fix(Core/Spells): Eye of Grillok improvements
* my eyes
* discovery of RegisterSpellAndAuraScriptPair
* comment
2024-06-29 07:33:23 -03:00
Dinkledork
01f063e242
fix(Scripts/World): Emerald Dragons no longer have 0% health events ( #18893 )
...
Events happen at 75, 50 or 25 percent health and should not include 0%.
2024-06-29 06:13:14 -03:00
Jelle Meeus
64e92b9bb5
refactor(Scripts/Spells): Spell Scripts registry macros, rogue killing spree ( #19226 )
...
* spell_rogue pair:spell_rog_killing_spree move public AddTarget up
spell_rogue pair:spell_rog_killing_spree
* fixup! spell_rogue pair:spell_rog_killing_spree
2024-06-29 06:11:50 -03:00
Jelle Meeus
e3da4e4986
refactor(Scripts/World): Spell Scripts registry macros ( #19224 )
...
* boss_emerald_dragons spell:spell_dream_fog_sleep
* boss_emerald_dragons spell:spell_mark_of_nature
2024-06-29 06:06:59 -03:00
Jelle Meeus
0d7f4c43e8
refactor(Scripts/SunwellPlateau): Spell Scripts registry macros ( #19223 )
2024-06-29 06:06:38 -03:00