* fix(Core/Reputations): Faction rep gained by killing mobs is now properly rounded up.
Do not increase reputation rank if exceeds max rank cap.
Fixes#8718
* fix(Core/Spells): Passive auras with SPELL_ATTR0_ONLY_INDOORS/SPELL_ATTR0_ONLY_OUTDOORS should not be removed when entering/leaving buildings.
Fixes#9209
* Change TO ThreadUNSAFE
This will process the far sight packet as a is not thread-safe - process it in World::UpdateSessions() compared to the former packet is thread-safe - process it in Map::Update().
This matches up with tc in everything we have with the HandleFarSightOpcode.
* Further Adjustments
* Move to Debug Loggin
TC has it as move to Debug Logging. Stating its a weird opcode handling issue which is not really known why.
* fix(Core/Spell): Core is not handling AURA_INTERRUPT_FLAG_TELEPORTED
Actually auras from spells with AURA_INTERRUPT_FLAG_TELEPORTED are not removed
on teleportation. This change makes it handled at teleportation on same map AND
if map changes, but it does not remove the aura when entering world to avoid
such auras being removed at character login.
Closes AzerothCore issue #9542
* delete invalid tabulations
* Move auras removing into the map/distance check above
* Do not remove unnecessary auras, and remove from other condition
* move it outside the 100 yards check, so it removes auras with this flag whenever teleporting
* remove whitespace at EOL
* Move the removal under the 100yards condition
This removes the specified auras
only if teleports more than 100 yards away
and avoids spells such as blink or shadowstep
removing such auras
* remove a few auras on loot
* remove mount, doesn't work
* removed unnecessary check. Changed to vector
* exception for pickpocketing
* Update src/server/game/Entities/Player/Player.cpp
* Update src/server/game/Entities/Player/Player.cpp
* Update src/server/game/Entities/Player/Player.cpp
* Update src/server/game/Entities/Player/Player.cpp
* Update src/server/game/Entities/Player/Player.cpp
* not as elegant yadi yada but it seems to work
* extra comment
* stealth doesn't remove on containers and enchant anymore, but should it?
* moved a few lines to the right place
* remove disenchant and prospect from not breaking stealth
* typo
* comments
Co-authored-by: Kargatum <dowlandtop@yandex.com>
* Remove unnecessary slang
Removes ZOMG! that is used in the src in logging and notes. Completely Unnecessary. Contributes to nothing useful. Inflates source. Not needed at all in any shape or form. Not Developer Lingo either.
* Further Clean Up
Removed Profanity
* sensible grammar correction
* More ZOMG! removal
Update Position::GetPosition() and similar methods signatures to reflect 2a4c9bc changes by return a Position object instead of accepting a Position parameter by reference.
Cherry pick of 2585e799f9
