Update PULL_REQUEST_TEMPLATE.md

src/Ai/Raid/Onyxia/Action/RaidOnyxiaActions.cpp

@@ -45,19 +45,8 @@ bool RaidOnyxiaSpreadOutAction::Execute(Event event)
     if (!boss)
         return false;
 
-    // Trigger may fire on one tick, but the action can execute on a later tick.
+    Player* target = boss->GetCurrentSpell(CURRENT_GENERIC_SPELL)->m_targets.GetUnitTarget()->ToPlayer();
-    // By that time the cast may have finished, so current spell can be null.
+    if (target != bot)
-    Spell* currentSpell = boss->GetCurrentSpell(CURRENT_GENERIC_SPELL);
-    if (!currentSpell || !currentSpell->m_spellInfo)
-        return false;
-
-    // Fireball
-    if (currentSpell->m_spellInfo->Id != 18392)
-        return false;
-
-    Unit* unitTarget = currentSpell->m_targets.GetUnitTarget();
-    Player* target = unitTarget ? unitTarget->ToPlayer() : nullptr;
-    if (!target || target != bot)
         return false;
 
     // bot->Yell("Spreading out — I'm the Fireball target!", LANG_UNIVERSAL);
@@ -71,7 +60,7 @@ bool RaidOnyxiaMoveToSafeZoneAction::Execute(Event event)
         return false;
 
     Spell* currentSpell = boss->GetCurrentSpell(CURRENT_GENERIC_SPELL);
-    if (!currentSpell || !currentSpell->m_spellInfo)
+    if (!currentSpell)
         return false;
 
     uint32 spellId = currentSpell->m_spellInfo->Id;

src/Ai/Raid/Onyxia/Trigger/RaidOnyxiaTriggers.cpp

@@ -17,7 +17,7 @@ bool OnyxiaDeepBreathTrigger::IsActive()
     // Check if Onyxia is casting
     Spell* currentSpell = boss->GetCurrentSpell(CURRENT_GENERIC_SPELL);
 
-    if (!currentSpell || !currentSpell->m_spellInfo)
+    if (!currentSpell)
         return false;
 
     uint32 spellId = currentSpell->m_spellInfo->Id;
@@ -65,7 +65,7 @@ bool RaidOnyxiaFireballSplashTrigger::IsActive()
 
     // Check if Onyxia is casting Fireball
     Spell* currentSpell = boss->GetCurrentSpell(CURRENT_GENERIC_SPELL);
-    if (!currentSpell || !currentSpell->m_spellInfo || currentSpell->m_spellInfo->Id != 18392)  // 18392 is the classic Fireball ID  // 18392 is the classic Fireball ID
+    if (!currentSpell || currentSpell->m_spellInfo->Id != 18392)  // 18392 is the classic Fireball ID
         return false;
 
     GuidVector nearbyUnits = AI_VALUE(GuidVector, "nearest friendly players");