Full revert: no xp bot when master has xp disabled (#1948 )

Will reimplement the feature later in time.
Quickfix: performance problems (XP gain when master has XP turned off) (#1947 )
2026-01-24 05:56:23 +00:00 · 2025-12-25 03:00:21 +01:00 · 2025-12-25 02:07:59 +01:00
1 changed files with 10 additions and 7 deletions
--- a/src/RandomPlayerbotMgr.cpp
+++ b/src/RandomPlayerbotMgr.cpp
@@ -2593,14 +2593,17 @@ void RandomPlayerbotMgr::Refresh(Player* bot)

 bool RandomPlayerbotMgr::IsRandomBot(Player* bot)
 {
-    if (!bot)
-        return false;
+    if (bot && GET_PLAYERBOT_AI(bot))
+    {
+        if (GET_PLAYERBOT_AI(bot)->IsRealPlayer())
+            return false;
+    }
+    if (bot)
+    {
+        return IsRandomBot(bot->GetGUID().GetCounter());
+    }

-    PlayerbotAI* botAI = GET_PLAYERBOT_AI(bot);
-    if (!botAI || botAI->IsRealPlayer())
-        return false;
-
-    return IsRandomBot(bot->GetGUID().GetCounter());
+    return false;
 }

 bool RandomPlayerbotMgr::IsRandomBot(ObjectGuid::LowType bot)
Author	SHA1	Message	Date
bashermens	2317652d72	Full revert: no xp bot when master has xp disabled (#1948 ) Will reimplement the feature later in time.	2025-12-25 03:00:21 +01:00
bashermens	1fcd6c5cda	Quickfix: performance problems (XP gain when master has XP turned off) (#1947 ) Disable bot XP gain when master has XP turned off feature has a big performance impact. Instead of reverting placed back to original code before the feature PR's for now as quickfix	2025-12-25 02:07:59 +01:00