Commit Graph

30 Commits

Author SHA1 Message Date
root
387c491265 fix(Playerbots): Remove auras before teleporting to prevent crash
Add RemoveAurasWithInterruptFlags call before all TeleportTo operations
to prevent race condition crash in battlegrounds.

The crash occurs when area auras (like "Entering Battleground") are
queued for removal in Aura::UpdateTargetMap's targetsToRemove list,
but the unit is deleted before the 500ms update cycle completes,
causing SIGSEGV when accessing the dangling pointer.

This fix removes auras with AURA_INTERRUPT_FLAG_TELEPORTED and
AURA_INTERRUPT_FLAG_CHANGE_MAP before teleporting, matching the
behavior in Player::TeleportTo for real players.

Affected locations:
- BattleGround join/teleport
- Spirit healer/graveyard teleport
- Corpse resurrection teleport
- Meeting stone teleport
- Master follow teleport
- RPG unstuck teleport
- Random bot teleport
- Chat command teleport

Raid-specific teleports excluded as they require separate testing.
2025-10-03 15:58:36 +10:00
bash
0cc15411c1 license update (#1674) 2025-09-30 15:19:44 +02:00
avirar
23d9931f65 Resolved crash in BGStatusAction (#1656)
* Prevent race condition and server crash

* Updated other direct packet handling lines to queue packets instead
2025-09-28 00:01:24 +02:00
Revision
fcb956ec1b Removed unnecessary spaces 2025-09-19 22:43:50 +02:00
bash
8d51092d42 As requested revert for threadfixes last few days (#1552)
* Revert "[Large server fix] #1537 Serialize playerBots/botLoading with a mutex and use snapshot-based loops to fix concurrency crashes (#1540)"

This reverts commit 3fff58df1a.

* Revert "[Fix] teleport to invalid map or invalid coordinates (x , y , z  200000, o ) given when teleporting player (g UI d full type player low , name , map , x , y , z , o )  (#1538)"

This reverts commit ca2e2ef0db.

* Revert "Fix: prevent MoveSplineInitArgs::Validate velocity asserts (velocity > 0.01f) for bots, pets, and charmed units (#1534)"

This reverts commit 4e3ac609bd.

* Revert "[Fix issue #1527] : startup crash in tank target selection — add TOCTOU & null-safety guards (#1532)"

This reverts commit c6b0424c29.

* Revert "[Fix issue #1528] Close small window where the “in a BG/arena” state can change between the check (InBattleground() / InArena()) and grabbing the pointer (GetBattleground()), which leads to a null dereference. (#1530)"

This reverts commit 2e0a161623.

* Revert "Harden playerbot logout & packet dispatch; add null-safety in chat hooks and RPG checks (#1529)"

This reverts commit e4ea8e2694.

* Revert "Dont wait to travel when in combat. (#1524)"

This reverts commit ddfa919154.

* Revert "nullptr fix (#1523)"

This reverts commit 380312ffd2.

* Revert "Playerbots/LFG: fix false not eligible & dungeon 0/type 0, add clear diagnostics (#1521)"

This reverts commit 872e417613.

* Revert "nullptr exception (#1520)"

This reverts commit 3d28a81508.

* Revert "Removed bot freezing at startup and system message, not relevant anymore (#1519)"

This reverts commit bcd6f5bc06.
2025-08-12 22:10:47 +02:00
Alex Dcnh
ca2e2ef0db [Fix] teleport to invalid map or invalid coordinates (x , y , z 200000, o ) given when teleporting player (g UI d full type player low , name , map , x , y , z , o ) (#1538)
* MoveSplineInitArgs::Validate: expression 'velocity > 0.01f' failed for GUID Full

* Update BotMovementUtils.h

* Playerbots: guard against invalid-Z teleports
2025-08-12 01:54:17 +02:00
kadeshar
c34617e133 - Reverted arena join queue changes (#1333) 2025-05-24 17:11:19 +08:00
Cryo81
07e4dec70d Warning fix + ilvl function fix (#1210)
* 1 variable order warning fixed
70 unused variable warning fixed

* Fixed GetEquipGearScore function

---------

Co-authored-by: Julien MAS <julien.mas81@gmail.com>
2025-04-20 14:26:42 +08:00
Yunfan Li
2f3f8d565c Make battleground join / arena join / loot money session packet (#1178)
* Make battleground / arena join session packet

* Loot money

* Avoid aoe crash
2025-04-08 10:11:03 +08:00
bash
3cd68c6dec [performance] new baseline (#644) 2024-10-29 01:15:26 +01:00
bash
12be2c9971 Revert "Rewrote scaling, moving away from cmangos solutions"
This reverts commit 62aef235d1.
2024-10-17 17:52:05 +00:00
bash
62aef235d1 Rewrote scaling, moving away from cmangos solutions 2024-10-13 22:05:39 +00:00
bash
158d923c15 Autoscale latency modifier 2024-10-11 21:20:43 +00:00
Fuzz
520633b4b9 [Arena] self bot now leaves finished arena game reliably (may also fix issues with other bot types leaving arena or all bot types leaving BG's but I wasnt able to reproduce any 'bots stay in bg/arena' bugs except self-bots in arena) 2024-08-15 21:14:20 +10:00
Yunfan Li
53611c9040 Run clang-format 2024-08-04 10:23:36 +08:00
CrypticAvacado
804c3adbd3 Fix formatting and use correct value data type 2024-07-29 20:45:00 +12:00
CrypticAvacado
f1114d71d2 Fix rated arena and battleground bot autojoining 2024-07-29 04:53:25 +12:00
Revision
838bfe333d Fix: Updated to work with newer commits of AzerothCore 2024-07-22 00:39:06 +02:00
Yunfan Li
24853a3fa3 [Crash fix] Fix a crash in bg join with group 2024-07-13 21:37:53 +08:00
Fuzz
718f90c4e9 improved check to avoid unresponsive BG/arena bot, and removed possibility of battleground strat crashing server when in wrong BG 2024-07-04 18:09:47 +10:00
Fuzz
08cbe2f4ec fixes for arena I've been working on with Dave (most credit belongs to him I feel) 2024-07-04 14:08:21 +10:00
Fuzz
6dddab7c1a [Misc] fixed dead code, unused variables other merge errors introduced by commit 3879b5116e 2024-06-26 17:28:50 +10:00
Brian Oost
3879b5116e Add performance tuning
Add a diff with and without player in server. The server will tune bot activity to reach the desired server tick speed (in ms), as what CMaNGOS' playerbots are using.

ce4bd79d2d is used as a reference.
2024-05-27 23:30:06 +02:00
Yunfan Li
29b748803e enable battleground 2023-10-19 00:20:45 +08:00
郑佩茹
9871cd34c4 Auto Join BG config 2023-04-04 13:41:01 -06:00
郑佩茹
dbb80b6aa2 Fix CMSG_BATTLEMASTER_JOIN packet format 2022-04-01 08:34:42 -06:00
郑佩茹
16ef20cd3e Prevent invalid BGJoinAction 2022-03-31 09:22:58 -06:00
郑佩茹
f1bcca1a7b Port fixes until b4094bf - flying, mount animations, bot attack range, free food option 2022-03-22 17:13:10 -06:00
郑佩茹
a7f412b428 Fix corrupt item cache crashes, bot whispers, trade crashes 2022-03-22 11:04:21 -06:00
UltraNix
b952636f0d Big update. 2022-03-12 22:27:09 +01:00