fix(strategy): Revert InitTriggers to previous implementation (#1272)

Fixes #1169

Reverts TankAssistStrategy and DpsAssistStrategy InitTriggers implementations to their previous versions.
The changes from commit 24efa7e appeared to be optimizations without fixing any documented bugs, but were causing issues.
This commit is contained in:
Type1Error
2025-05-07 19:54:41 +00:00
committed by GitHub
parent 4603dbaf35
commit 0c6f656236
4 changed files with 8 additions and 17 deletions

View File

@@ -7,11 +7,10 @@
#include "Playerbots.h"
NextAction** DpsAssistStrategy::getDefaultActions()
void DpsAssistStrategy::InitTriggers(std::vector<TriggerNode*>& triggers)
{
return NextAction::array(
0, new NextAction("dps assist", 50.0f),
nullptr);
triggers.push_back(
new TriggerNode("not dps target active", NextAction::array(0, new NextAction("dps assist", 50.0f), nullptr)));
}
void DpsAoeStrategy::InitTriggers(std::vector<TriggerNode*>& triggers)

View File

@@ -16,7 +16,7 @@ public:
DpsAssistStrategy(PlayerbotAI* botAI) : NonCombatStrategy(botAI) {}
std::string const getName() override { return "dps assist"; }
NextAction** getDefaultActions() override;
void InitTriggers(std::vector<TriggerNode*>& triggers) override;
};
class DpsAoeStrategy : public NonCombatStrategy

View File

@@ -7,15 +7,8 @@
#include "Playerbots.h"
NextAction** TankAssistStrategy::getDefaultActions()
void TankAssistStrategy::InitTriggers(std::vector<TriggerNode*>& triggers)
{
return NextAction::array(
0, new NextAction("tank assist", 50.0f),
nullptr);
triggers.push_back(
new TriggerNode("tank assist", NextAction::array(0, new NextAction("tank assist", 50.0f), nullptr)));
}
// void TankAssistStrategy::InitTriggers(std::vector<TriggerNode*>& triggers)
// {
// triggers.push_back(
// new TriggerNode("tank assist", NextAction::array(0, new NextAction("tank assist", 50.0f), nullptr)));
// }

View File

@@ -17,8 +17,7 @@ public:
std::string const getName() override { return "tank assist"; }
uint32 GetType() const override { return STRATEGY_TYPE_TANK; }
NextAction** getDefaultActions() override;
// void InitTriggers(std::vector<TriggerNode*>& triggers) override;
void InitTriggers(std::vector<TriggerNode*>& triggers) override;
};
#endif