Commit Graph

1646 Commits

Author SHA1 Message Date
Angelo Venturini
fb7164be05 fix(Scripts/HellfireRamparts): Fix Nazan not casting abilities (#16598) 2023-06-21 23:26:11 -03:00
Angelo Venturini
a62143e540 fix(Scripts/ShadowLabyrinth): Murmur's Touch (#16600) 2023-06-21 23:12:23 -03:00
Skjalf
ec5eabce25 fix(Scripts/Karazhan): Malchezaar should not cast Enfeeble on phase 3 (#16587) 2023-06-18 15:29:19 -03:00
Dan
a15016ac08 fix(Scripts/ZulFarrak): add Hearthstone mechanic to Blys party when event not started in time (#16333)
* initial

* codestyle

* remove unused taskscheduler

* fix unsummon mechanic

better syntax

* fix other issues

* another issue

* dummy fix

* should fix gossip and event

* attempt to fix movement

* attempt at fixing Bly walk

* also make Weegli hostile + another attempt at move

ment fix

* another attempt at walk fix

* initialise and debug

* debuggo

* v2

* moooore

* oops

* try to fix with boolean again

* fix?

* fixmaybe

* revert

* remove leftovers

* and more on Weegli
2023-06-18 12:06:59 -03:00
Skjalf
7ae4b85c43 fix(Scripts/HellfireRamparts): Fix Gargolmar Retalliation procs with … (#16585)
fix(Scripts/HellfireRamparts): Fix Gargolmar Retalliation procs with targets behind him
2023-06-18 11:54:05 -03:00
Johaine
5060407598 fix(Scripts/TheBlackMorass): rework time rift event logic (#16535)
* Fix visual crystals

This fixes the crystals not despawning on Medivh's death and being
resummoned after every reset

* Fix summoning circle visual after cleanup

Fix respawn of summoning circle visual NPC
Move respawn to same moment as Medivh respawn

* Fix race condition during script cleanup after event failure

This fixes the bug that rifts still spawn after shield is at 0%,
enabling players to exploit the instance and defeat bosses at their own
pace.

In general, removing rifts schedules spawning of new rifts

After failing the event (shield at 0%) this introduces a race between
rift despawn and (scheduler) cleanup

Fix it by introducing a check if the event has been started and should
still progress.

* Fix softlock of event during break after boss

Make sure that the delay condition is removed if event fails

Meeting certain conditions it was possible to softlock the event by
extending the after-boss-break indefinitely

* Cleanup failed instance without player interaction

This respawns Medivh and re-enables the event 5 minutes after a failure

Retrying the event shouldn't require all players to leave the instance
and to reenter

* Misc cleanups

Remove unused DataTypes

Rename variable to something more self-explanatory

Remove unnecessary checks and make scheduling of rifts more
straightforward

Fix typos
2023-06-18 11:47:27 -03:00
Dan
5b36dfa2c0 chore(Scripts/GruulsLair): modernise boss scripts + make timers more accurate (#16576) 2023-06-18 11:36:11 -03:00
Dan
a10c183e99 chore(Scripts/MagtheridonsLair): rework Magtheridon boss script (#16527)
* initial commit

* remove leftovers

* codestyle
2023-06-14 18:23:13 -03:00
Gultask
65607c114a fix(Scripts/Underbog): Lower range check for Tentacle Lash (#16497)
* Update underbog.cpp

* Update src/server/scripts/Outland/CoilfangReservoir/underbog/underbog.cpp

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-06-11 11:49:14 -03:00
Skjalf
0fb4928285 fix(Scripts/ShadowLabirynth): Fix Murmur not using abilities (#16505) 2023-06-09 18:44:53 -03:00
Dan
a13601bbc5 fix(Scripts/Karazhan): Opera Wizard of Oz fight correct start timers for combat as well fixing restart of the event (#16303) 2023-06-08 22:40:24 -03:00
Eddy Vega
8e51183fa6 refactor(Scripts/Auchindoun): Mass struct/model update (#16266)
* init

* ubuntu-20.04-clang-with-modules

* unused context

* .

* .

* .

* pew

* .
2023-06-08 16:32:44 -03:00
Angelo Venturini
7a37d51538 refactor(Scripts/ShatteredHalls): move Porung from SAI to cpp (#16417)
* refactor(Scripts/ShatteredHalls): move Porung from SAI to cpp

* Space
2023-06-06 23:38:01 -03:00
Dan
3e19b5e637 fix(Scripts/Underbog): modernise boss scripts (#16149) 2023-06-04 23:42:40 -03:00
Kitzunu
ee18f55f63 fix(Scripts/Spells): Convert some Druid spells to SpellScript (#16414)
Co-authored-by: joschiwald <736792+joschiwald@users.noreply.github.com>
2023-06-01 22:04:00 +02:00
KJack
a696227e8d fix(Scripts/UBRS): Update UBRS/Pyroguard Emberseer script to fix issues and increase accuracy (#16352)
* Update UBRS/Pyroguard Emberseer script to fix issues and increase accuracy.

- Remove EVENT_PLAYER_CHECK which was causing triggering the fight to work only sporadically
- Break out pre-enter-combat phase to better emulate actual timing. Fixes DBM timing being off
- Pre-enter-combat sequence starts as soon as the adds are engaged, not after 32 seconds
- disable fire shield during pre-enter-combat to keep the fight from resetting
- remove faster add despawn which doesn't appear to be in the WotLK Classic version
- remove adds doing EVENT_ENCAGE every 10-20s, which was unneccesary and caused them to glitch move around the player

* Small change to pre-add timing.
2023-06-01 08:40:02 -03:00
KJack
2a6bb85540 fix(Scripts/Quest): Make quest "Triage" (6622/6624) completable (#16335)
* Resolves issue where patients were dying extremely quickly during the quest.

- updates other parameters to make the quest more Blizz-like and completable

* Correct starting patient count for Horde

* Correctly handle starting patient count for both factions.

* Whitespace removal

* Un-Pythonese variable name, slightly improve initial patient count call

* Match WotLK Classic timing for patient deaths
2023-06-01 08:38:52 -03:00
Angelo Venturini
d4150b8e08 fix(Core/Scripts): Sepethrea should prioritize players that don't hav… (#16412)
* fix(Core/Scripts): Sepethrea should prioritize players that don't have Dragon's breath aura

* oops
2023-05-31 23:26:26 -03:00
Dan
40eb5da6d5 fix(Scripts/ShatteredHalls): hack fix to prevent pets from pulling the non-attackable peons in Nethekurse room (#16396)
* initial

hack fix added

* add sql to change unit flags

* using setimmunetoall() instead

* remove comment add credit

bump

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

* Update update-peon-unit-flag.sql

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

* add intro start on lockpick

might still have some troubles with double starting the intro with AT
--please give report if so

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-31 23:22:38 -03:00
Angelo Venturini
dc624fd86f fix(Core/Scripts): Rework Pandemonius (#16407) 2023-05-31 23:22:00 -03:00
Angelo Venturini
746aa5b493 fix(Core/Scripts): Ikiss polymorph target (#16409) 2023-05-31 23:20:53 -03:00
avarishd
b5ef9ee3de fix(Script/HellfirePeninsula): Beacons not attracting mobs. (#15296)
* fix(Script/Zone): Hellfire Peninsula - Beacons not attracting mobs.

* update

* add HOME_MOTION_TYPE check to prevent yoyo effect

* Use GetNearPosition
2023-05-28 21:29:51 -03:00
Skjalf
1e49eef413 fix(Scripts/ShatteredHalls): Nethekurse shouldn't roleplay in combat (#16395) 2023-05-28 17:40:15 -03:00
Skjalf
d985615908 fix(Scripts/ShatteredHalls): Fire Executioner's call on heroic only (#16394) 2023-05-28 17:40:06 -03:00
Eddy Vega
be622fa720 refactor(Scripts/CavernsOfTime): Mass struct/model update (#16268)
init
2023-05-28 16:30:30 -03:00
KJack
b5f311bf56 fix(Scripts/Commands): Fix '.send items' command to no longer require an itemId count (#16340)
* Fix '.send items' command to no longer require an itemId count

* Remove leftover debugging output, oops.
2023-05-28 16:28:01 -03:00
Eddy Vega
ef74da9640 refactor(Scripts/Outland): World Boss model update (#16279)
* init

* check codestyle (ubuntu-20.04)
2023-05-28 16:27:33 -03:00
Skjalf
97f3037021 fix(Scripts/ShatteredHalls): Implement the Flame Gauntlet event (#16383)
Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-28 15:50:50 -03:00
Gultask
ce788f68c2 fix(Scripts/ShatteredHalls): Prevent boss from being pulled early (#16389)
* init

* Update boss_nethekurse.cpp
2023-05-28 14:43:56 -03:00
Angelo Venturini
0755f8cde3 fix(Core/Script): Kargath should prevent adds spawn on death (#16388) 2023-05-28 13:28:35 -03:00
Skjalf
cd248ef665 fix(Scripts/ShatteredHalls): Fix Nethekurse delay after peon dies (#16384)
* fix(Scripts/ShatteredHalls): Fix Nethekurse delay after peon dies

* Update boss_nethekurse.cpp

* typo

* Update boss_nethekurse.cpp

* Update boss_nethekurse.cpp
2023-05-28 10:52:46 -03:00
KJack
cafb8e3cfb fix(Scripts/Npc) Experience Eliminator only asks pertinent questions (#16310)
* Experience Eliminator will only ask you pertinent questions.

* Add brackets per AC code standards.
2023-05-27 23:07:40 -03:00
Angelo Venturini
30f475829a fix(Core/Spells): Hunter snake trap damage (#16326) 2023-05-23 22:39:55 -03:00
Angelo Venturini
a56a400a13 fix(Scripts/ShatteredHalls): Rewrite Warchief Kargath Bladefist (#16355) 2023-05-23 06:48:23 -03:00
Angelo Venturini
67be37def6 fix(Core/Scripts): Rewrite Warbringer O'mrogg (#16346)
* fix(Core/Scripts): Rewrite Warbringer O'mrogg

* typo
2023-05-21 18:24:07 -03:00
Skjalf
6a73c38eb6 fix(Scripts/ShatteredHalls): Rework Nethekurse (#16265) 2023-05-21 18:11:31 -03:00
Gultask
c5f2031833 chore(Scripts/BloodFurnace): Clean up Keli'dan script (#16321)
* init

* Update rev_1684449165991504600.sql

* leftover
2023-05-20 18:25:38 -03:00
KJack
7945e11557 fix(Scripts/ZulGurub): fix timing regression for Venoxis cobras (#16309)
Fixes timing regression caused by conversion miss in #14876
2023-05-18 15:34:50 -03:00
Eddy Vega
1724088e06 fix(Scripts/HellfireCitadel): Mass struct/model update (#16264)
* init

* .

* check codestyle (ubuntu-20.04)

* ubuntu-20.04-clang-with-modules

* clang
2023-05-14 19:13:42 -03:00
Dan
7e258bbd28 fix(Scripts/ShatteredHalls): fix some timers/mechanics of Grand Warlock Nethekurse (#16167) 2023-05-13 16:36:07 -03:00
avarishd
73e61e3234 fix(DB/SAI): Move Floon,Raliq the Drunk and Sal'salabim to SAI. (#15505)
* fix(DB/SAI): Move Floon,Raliq the Drunk and Sal'salabim to SAI.

Co-authored-by: aletson <aletson@users.noreply.github.com>

* Update Sal

* add ooc emote 92

* set SheatheState to 1

---------

Co-authored-by: aletson <aletson@users.noreply.github.com>
2023-05-13 15:29:29 -03:00
pedrohfm9
3c401ad4ad fix(Scripts/HallsOfReflection): Improve Halls of Reflection Events (Horde) (#16165)
* fix(DB/Creature): Grunda Bronzewing is now mounted

Grunda Bronzewing is now mounted

* Update Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql

Grunda Bronzewing is now mounted

* Rename Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql to Fix-Grunda.sql

Grunda Bronzewing is now mounted

* Delete Fix-Grunda.sql

* Create Fix-NPCs_Halls_Off_Reflection.sql

* Fix-events_Halls_of_Reflection(HORDE)

* Rename Fix-NPCs_Halls_Off_Reflection.sql to Fix-NPCs_Halls_of_Reflection.sql

* Rename halls_of_reflection.cpp to fix halls_of_reflection.cpp

* Rename halls_of_reflection.h to fix halls_of_reflection.h

* Rename instance_halls_of_reflection.cpp to fix instance_halls_of_reflection.cpp

* Update fix halls_of_reflection.h

* Update and rename fix halls_of_reflection.cpp to halls_of_reflection.cpp

* Update and rename fix instance_halls_of_reflection.cpp to instance_halls_of_reflection.cpp

* Update instance_halls_of_reflection.cpp

* Update instance_halls_of_reflection.cpp

* Update instance_halls_of_reflection.cpp

* Update and rename fix halls_of_reflection.h to halls_of_reflection.h

* Update instance_halls_of_reflection.cpp

* Update halls_of_reflection.h

* Update Fix-NPCs_Halls_of_Reflection.sql

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update instance_halls_of_reflection.cpp

* Update halls_of_reflection.h

* Update instance_halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update Fix-NPCs_Halls_of_Reflection.sql

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update and rename Fix-NPCs_Halls_of_Reflection.sql to Fix_NPCs_Halls_of_Reflection.sql

* Update halls_of_reflection.cpp

* Update halls_of_reflection.cpp

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update Fix_NPCs_Halls_of_Reflection.sql

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

* Apply suggestions from code review

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

* Update src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp

---------
2023-05-13 15:25:53 -03:00
Johaine
ea3e6e8f3b fix(Scripts/Deadmines): Fix Factory Door in Deadmines being closable (#15201)
* fix(DB/SAI): Open Factory Door correctly (irreversibly)

Activate the Factory Door after the boss' death to open it instead of changing gameobject state only which can be reversed by another activation.

* fix(Script/Instance): Prevent Door being closed again after Server Restart

* Drop database name from update SQL

Other people might not use the standard database names

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-13 14:52:44 -03:00
Eddy Vega
eca5f79d6f fix(Scripts/Mechanar): Avoid Nether Charge despawn (#16190)
init
2023-05-13 14:51:33 -03:00
Dan
8e28b64ccf fix(Scripts/HellfireRamparts): modernise boss scripts for Hellfire Ramparts (#16250)
* first two bosses

* add vazruden+nazan

* dumb mistake fix

* remove double summon say from Omor

* new attempt at scheduling talking

* fix boolean condition for speaking

* debug

* revert debug

* initial

* diff comment
2023-05-13 14:50:46 -03:00
Grimgravy
09c40a8cd3 fix(Scripts/VioletHold): Activation Crystals (#13176)
* fix(Scripts/Activation Crystals): Instance The Violet Hold

* update

* Update violet_hold.cpp
2023-05-13 14:48:26 -03:00
Skjalf
8d6392d60f fix(Scripts/Underbog): Rework Swamplord Muselek (#14724)
* fix(Scripts/Underbog): Rework Swamplord Muselek

* Update boss_swamplord_muselek.cpp

* update to bossai

* Update outland_script_loader.cpp

* Update boss_swamplord_muselek.cpp

* Update boss_swamplord_muselek.cpp

* prevent chase movement while walking backwards

* Update boss_swamplord_muselek.cpp
2023-05-13 14:44:20 -03:00
Dan
154fa624f0 fix(Scripts/ShatteredHalls): fixes to Warbring O'mrogg combat scripts and timers (#16091)
* initial attempt at combat fix

with modernising

* fixes to scheduler

first Draft PR commit. Scheduler now works with boolean in capture list of lambda function.

* whitespaces

* debug

* debug2

* debug3

* debug4

* add omrogg equip query and debug5

* remove tabs

* Update data/sql/updates/pending_db_world/omroggequip.sql

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>

* grouped taskscheduler

* added more groups

* adjust timer

* better handling

* v2 (too many commits)

* fixed melee

* clean up debug info

removal of yells

* more debug

* attempt at fix

* some changes to scheduling

* final

* whitespaces and extra lines

* better formatting

* final whitespace fix

* context fix

* dumb fix

---------

Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
2023-05-13 14:01:22 -03:00
UltraNix
2a1d706a2f fix(Scripts/Underbog): Underbat's Tentacle Lash should be casted only … (#14566)
* fix(Scripts/Underbog: Underbat's Tentacle Lash should be casted only on targets behind the bat.

Fixes #13972

* buildfix.
2023-05-12 09:15:02 -03:00
Dan
79954c34d4 fix(Scripts/Outland): add missing C++ code and remove SAI scripts from Tavarok and Darkweaver Syth (#16178)
* initial

* whitespace1

* Update tavarok_darkweaver_sai_removal.sql

fix sql
2023-05-12 08:23:56 -03:00