Commit Graph

404 Commits

Author SHA1 Message Date
amed80
eed20b4647 fix(Scripts/Hyjal): Change the spawn and the movement of Doomfire (#19027)
* Doomfire_spirit_speed

* Update boss_archimonde.cpp

* Rename
2024-06-08 13:07:39 +02:00
Benjamin Jackson
bb69f1c3ec fix(Scripts/HyjalSummit): Assign Death Knight Soul Charge. (#19020)
Init.

Alphabetize and correct DK soul charge assign.
2024-06-07 12:32:02 +02:00
Andrew
79ec83d03e fix(Scripts/Hyjal): Fix Azgalor Doom targetting tanks since its an AoE spell (#19012)
* fix(Scripts/Hyjal): Fix Azgalor Doom targetting tanks since its an AoE spell

* Update boss_azgalor.cpp
2024-06-06 00:12:19 +02:00
Andrew
218dce417e chore(Scripts/Hyjal): Clean up unsafe calls and code style (#19004)
* chore(Scripts/Hyjal): Clean up unsafe calls and code style

* another one
2024-06-03 20:33:07 -03:00
Andrew
8ee980e4ba fix(Scripts/Hyjal): Anetheron cast Carrion Swarm on non player targets (#19005) 2024-06-03 20:25:58 -03:00
Dan
8256d3cb55 fix(Scripts/Hyjal): archimonde enrage after 10 minutes (#19003)
init
2024-06-03 14:10:44 -03:00
Andrew
70fc43ff8d fix(Script/Hyjal): Fix encounter states not reseting if bosses are de… (#19000)
* fix(Script/Hyjal): Fix encounter states not reseting if bosses are despawned while in combat

* Update instance_hyjal.cpp
2024-06-03 00:31:31 -03:00
Dan
ba8a152479 fix(Scripts/Hyjal): correctly despawn summoned creatures on Jaina/Thrall death (#18997)
* init

* change logic

despawning of bosses is not really done the normal way, but it's forced with a set amount of guids. So we simply need to register the summons as guids as well

* small fixes

* Delete creature_scripts.sql

* Update boss_azgalor.cpp
2024-06-02 17:07:42 +02:00
sudlud
8e9e134924 fix(Scripts/Hyjal): fix some build warnings for unused parameters (#18986) 2024-06-01 12:25:53 +02:00
Dan
0f5992045c fix(Scripts/Hyjal): increase ranges on doomfire to make movement less inclined to stick close to the boss (#18976)
initial
2024-05-29 23:57:56 +02:00
Dan
9d672f8b62 fix(Scripts/Hyjal): remove summoned mobs on boss evade and reset waves (#18975)
init
2024-05-29 23:57:34 +02:00
Dan
fe6137b0a0 fix(Scripts/Hyjal): tweak movement of Doomfire (#18970)
initial
2024-05-29 08:04:13 +02:00
Andrew
2c246e49d0 fix(Scripts/Hyjal): Anetheron dont cast sleep on tank (#18969) 2024-05-28 19:39:21 -03:00
Andrew
9b363594e7 fix(Scripts/Hyjal): Fix Doom spawning Doomguards twice on expire (#18968) 2024-05-28 19:39:05 -03:00
Andrew
7692b709ac fix(Scripts/Hyjal): Azgalor doom shouldnt target tank MKII (#18964) 2024-05-28 14:55:28 -03:00
Andrew
2a1d23e520 fix(Scripts/Hyjal): Implement Eternal Silence spell when going into t… (#18960)
fix(Scripts/Hyjal): Implement Eternal Silence spell when going into the Well of Eternity
2024-05-28 01:24:10 +02:00
Andrew
73e44859f0 fix(Scripts/Hyjal): Azgalor mark of doom spawn demons on target death (#18959) 2024-05-27 20:48:29 +02:00
Dan
3985db3006 fix(Scripts/Hyjal): Anetheron should not cast sleep on MT (#18948)
* init

* also talk when spell fails
2024-05-27 14:24:37 -03:00
Andrew
8200385efb chore(Scripts/Hyjal): Update Mark of Kazrogal script (#18958) 2024-05-27 18:51:41 +02:00
Andrew
458eadd9e4 fix(Scripts/Hyjal): Azgalor Rain of Fire should target non-player tar… (#18956)
fix(Scripts/Hyjal): Azgalor Rain of Fire should target non-player targets
2024-05-27 17:41:10 +02:00
Andrew
df688afaff chore(Scripts/Hyjal): Don't initialize headers twice (#18939) 2024-05-23 06:02:10 -03:00
Dan
7f42ec0371 fix(Scripts/Hyjal): initialize/reset local private variables in Reset function (#18932)
initial
2024-05-22 16:15:13 -03:00
Dan
f78820e9d5 fix(Scripts/Hyjal): Air Burst should not be cast on MT (#18933)
* fix movement of doomfire

* fix air burst

* conditions

* movechase random target

* Update boss_archimonde.cpp

* update movement

* Update boss_archimonde.cpp

* Update boss_archimonde.cpp
2024-05-20 22:05:56 -03:00
Andrew
2912cb47f3 fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enr… (#18928)
fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enrage/outro
2024-05-20 10:40:46 +02:00
Andrew
0aaf521423 fix(Scripts/Hyjal): Limit Anetheron sleep to 3 targets (#18929) 2024-05-20 10:40:28 +02:00
Jelle Meeus
c738f0d67c fix(Scripts/Hyjal): Cannibalize should heal more than 1 (#18766)
* init

* include SpellScript.h
2024-04-19 22:20:24 -03:00
Walter Pagani
eced002ef9 fix(Scripts/Hyjal): fatal error: comparison of integers of different signs (#18755)
* fix. fatal error: comparison of integers of different signs

* Update src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_kazrogal.cpp

---------

Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
2024-04-14 19:37:02 -03:00
amed80
781190c73b fix(Scripts/Hyjal): fix Mark of Kaz'rogal timer (#18753)
fix Mark of Kaz'rogal timer
2024-04-14 20:10:29 +02:00
Andrew
a8471d0f87 fix(Scripts/Hyjal): Azgalor Doom should not be cast on the MT (#18738) 2024-04-14 08:30:27 -03:00
Andrew
cdc72216c8 fix(Scripts/Hyjal): Fix Mark of Kazrogal not dealing damage when unab… (#18732)
fix(Scripts/Hyjal): Fix Mark of Kazrogal not dealing damage when unable to drain mana
2024-04-13 17:15:20 +02:00
Dan
ec10eb841c fix(Scripts/Hyjal): Archimonde finger of death condition (#18681)
* init

* yes

* Update src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_archimonde.cpp
2024-04-12 13:28:24 -03:00
Dan
39b94880db fix(Scripts/Hyjal): make sure Jaina takes no damage from Death and Decay (#18680)
init
2024-04-07 20:32:28 -03:00
Johaine
c80ad3d779 fix(Scripts/TempleOfAhnQiraj): Fix Vem enrage (#18652)
Fix Vem enrage

Vem should enrage when it is the last bug alive
(Regression from last refactor)
2024-04-06 09:19:14 -03:00
Dan
102bf7c9c5 fix(Scripts/Hyjal): Shadowy Necromancers now use Unholy Frenzy + Skeleton mage abilities (#18640)
init
2024-03-31 13:59:27 -03:00
Dan
02cf369fe2 fix(Scripts/Hyjal): Archimonde refactored (#18594)
* wip

* wippers

* more wip

* wip314

* some work

* lesgo

* summonlist fixed

* I need glasses

* open from draft PR

* some fixes

* unused
2024-03-26 22:37:00 -03:00
chaosua
4e95c9e006 (Instance/Culling of Stratholme/Trial of Crusader) removed duplicated gossip_menus, fixed hardcoded texts (#18516)
* (Instance/Culling of Stratholme) removed duplicated gossip_menus, fixed hardcoded texts

* Update culling_of_stratholme.sql

* Update culling_of_stratholme.sql

* (Instance/TrialOfTheCrusader) fixed hardcoded text from Jaraxxus text line
boss_twin_valkyr: removed unnececarry random txt line select (already exist groupid 6 id 0 and 1 in creature_text)
added ruRU locale for Acidmaw and Dreadscale GroupID 2

* move sqls

* Update culling_of_stratholme.sql

* Update data/sql/updates/pending_db_world/culling_of_stratholme.sql

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* Update culling_of_stratholme.sql

* update naming of variables to better understand the sequence of events

* Change locale attribute to Locale

I'm not 100% sure, but since in Linux, uppercase and lowercase letters represent different values, I think that's why it doesn't pass the tests. In Windows nothing happens, but in Linux there are 2 different attributes.

* strange MySQL in Linux

* Update trial_of_crusader.sql

* updated sequence of txt lines with cityman before Malganis appear according to @Trinitycore enum RPEventLines2
combine all SQL in 1 file

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Walter Pagani <paganiwalter@gmail.com>
2024-03-24 16:47:34 +01:00
Gultask
a7761597ba fix(Scripts/HyjalSummit): Frost Wyrms casting wrong spell (#18603)
lmaaaooo

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
2024-03-22 21:42:42 +01:00
Gultask
58eb83c74e fix(Scripts/HyjalSummit): Don't reset trash counter on scheduled waves (#18604)
* Update instance_hyjal.cpp

* Update instance_hyjal.cpp
2024-03-22 17:39:12 -03:00
Stefano Borzì
ec1b2f7a28 fix(Scripts/HyjalSummit): Rewrite Battle for Mount Hyjal (#18512)
* arrays

* summon_groups

* part 2 lesgooo

* holy frick it works???

* drafted

* forgot to add co-author

Co-Authored-By: Saltgurka <22568446+saltgurka@users.noreply.github.com>

* thrall & tyrande

* Update hyjal.cpp

* trash

* winterchill & anetheron

* kazrogal & azgalor

* Update rev_1708737709108426300.sql

* entrance rp and scourge base

* it worked thank you nyeriah and ayamiss the hunter from AQ20 cause I remembered that it had a similar mechanic and i went to check how to deal with it. did you know ayamiss was my turning point in my emulation "career"? it was a very interesting fight and i spent many hours researching it, leading to my discovery into how the swarmers work, if i did it nowadays i'd have found out immediately but it was a journey nonetheless

Co-Authored-By: Andrew <47818697+Nyeriah@users.noreply.github.com>

* Update rev_1708737709108426300.sql

* no gem farming!

* infernals

* leftovers

* doors

* archimonde

* Update rev_1708737709108426300.sql

* jaina didnt reset gossip flag its over

* crashfix

Co-Authored-By: Andrew <47818697+Nyeriah@users.noreply.github.com>

* Update instance_hyjal.cpp

* no more dberrors

* fix archimonde model and size

scale was set to 0.4, also fixed the speed and attack time, as well as adding model info

* Update rev_1708737709108426300.sql

* Update rev_1708737709108426300.sql

* more stuff

* Update data/sql/updates/pending_db_world/rev_1708737709108426300.sql

* fix: warning

* fix: warning

* buildfix

don't need to assign anything, as long as it doesn't return null we're good

* buildfix

infernal has no DoAction behaviour so it's fine

* Update data/sql/updates/pending_db_world/rev_1708737709108426300.sql

* Update data/sql/updates/pending_db_world/rev_1708737709108426300.sql

* yay

Co-Authored-By: Dan <83884799+elthehablo@users.noreply.github.com>

* a

* looks nicer, less updates overall

* crashfix?

messy code gomenasai 🙇

* hide undesirables >:(

* Update instance_hyjal.cpp

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

---------

Co-authored-by: Gultask <sagemochi@hotmail.com>
Co-authored-by: Saltgurka <22568446+saltgurka@users.noreply.github.com>
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-03-19 21:49:28 +01:00
sudlud
307c1ab09d refactor(Core): remove some unused variables (#18538)
- let's get rid of some compiler warnings
2024-03-13 06:52:43 -03:00
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Dan
a4dc083b42 fix(Scripts/Hyjal): move Hyjal boss waypoints to DB (#18299)
* put anetheron movement in wps

* move all wps to db for bosses
2024-02-12 08:17:39 -03:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Kalimist
65d6bd0472 fix(Core/Creature): hardcoded gossip in zone_azshara (#18289)
* Changing hardcoded text in #define to enum member

- Changing #define to new enum member for AddGossipItemFor method

* Adding SQL Query File

* Forgot to add ';' in DELETE FROM
2024-02-08 07:41:23 +01:00
IntelligentQuantum
fa884ae385 chore(Scripts/Kalimdor): remove useless includes (#18065) 2023-12-26 06:08:37 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Gultask
d3bef76fae fix(Scripts/Darkshore): Rabid Thistle Bear spawning with StandState Dead (#17875) 2023-11-26 21:22:58 -03:00
KJack
42ec86680c fix(Scripts/RuinsOfAhnQiraj): Andorov does not respawn after being killed (#17788) 2023-11-20 21:18:13 -03:00
Andrew
0fe18f7c6b fix(Scripts/ThousandNeedles): Improve the handling of quest 5151 (Hyp… (#17811) 2023-11-20 18:14:43 -03:00
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00