Commit Graph

378 Commits

Author SHA1 Message Date
Walter Pagani
eced002ef9 fix(Scripts/Hyjal): fatal error: comparison of integers of different signs (#18755)
* fix. fatal error: comparison of integers of different signs

* Update src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_kazrogal.cpp

---------

Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
2024-04-14 19:37:02 -03:00
amed80
781190c73b fix(Scripts/Hyjal): fix Mark of Kaz'rogal timer (#18753)
fix Mark of Kaz'rogal timer
2024-04-14 20:10:29 +02:00
Andrew
a8471d0f87 fix(Scripts/Hyjal): Azgalor Doom should not be cast on the MT (#18738) 2024-04-14 08:30:27 -03:00
Andrew
cdc72216c8 fix(Scripts/Hyjal): Fix Mark of Kazrogal not dealing damage when unab… (#18732)
fix(Scripts/Hyjal): Fix Mark of Kazrogal not dealing damage when unable to drain mana
2024-04-13 17:15:20 +02:00
Dan
ec10eb841c fix(Scripts/Hyjal): Archimonde finger of death condition (#18681)
* init

* yes

* Update src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_archimonde.cpp
2024-04-12 13:28:24 -03:00
Dan
39b94880db fix(Scripts/Hyjal): make sure Jaina takes no damage from Death and Decay (#18680)
init
2024-04-07 20:32:28 -03:00
Johaine
c80ad3d779 fix(Scripts/TempleOfAhnQiraj): Fix Vem enrage (#18652)
Fix Vem enrage

Vem should enrage when it is the last bug alive
(Regression from last refactor)
2024-04-06 09:19:14 -03:00
Dan
102bf7c9c5 fix(Scripts/Hyjal): Shadowy Necromancers now use Unholy Frenzy + Skeleton mage abilities (#18640)
init
2024-03-31 13:59:27 -03:00
Dan
02cf369fe2 fix(Scripts/Hyjal): Archimonde refactored (#18594)
* wip

* wippers

* more wip

* wip314

* some work

* lesgo

* summonlist fixed

* I need glasses

* open from draft PR

* some fixes

* unused
2024-03-26 22:37:00 -03:00
chaosua
4e95c9e006 (Instance/Culling of Stratholme/Trial of Crusader) removed duplicated gossip_menus, fixed hardcoded texts (#18516)
* (Instance/Culling of Stratholme) removed duplicated gossip_menus, fixed hardcoded texts

* Update culling_of_stratholme.sql

* Update culling_of_stratholme.sql

* (Instance/TrialOfTheCrusader) fixed hardcoded text from Jaraxxus text line
boss_twin_valkyr: removed unnececarry random txt line select (already exist groupid 6 id 0 and 1 in creature_text)
added ruRU locale for Acidmaw and Dreadscale GroupID 2

* move sqls

* Update culling_of_stratholme.sql

* Update data/sql/updates/pending_db_world/culling_of_stratholme.sql

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* Update culling_of_stratholme.sql

* update naming of variables to better understand the sequence of events

* Change locale attribute to Locale

I'm not 100% sure, but since in Linux, uppercase and lowercase letters represent different values, I think that's why it doesn't pass the tests. In Windows nothing happens, but in Linux there are 2 different attributes.

* strange MySQL in Linux

* Update trial_of_crusader.sql

* updated sequence of txt lines with cityman before Malganis appear according to @Trinitycore enum RPEventLines2
combine all SQL in 1 file

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Walter Pagani <paganiwalter@gmail.com>
2024-03-24 16:47:34 +01:00
Gultask
a7761597ba fix(Scripts/HyjalSummit): Frost Wyrms casting wrong spell (#18603)
lmaaaooo

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
2024-03-22 21:42:42 +01:00
Gultask
58eb83c74e fix(Scripts/HyjalSummit): Don't reset trash counter on scheduled waves (#18604)
* Update instance_hyjal.cpp

* Update instance_hyjal.cpp
2024-03-22 17:39:12 -03:00
Stefano Borzì
ec1b2f7a28 fix(Scripts/HyjalSummit): Rewrite Battle for Mount Hyjal (#18512)
* arrays

* summon_groups

* part 2 lesgooo

* holy frick it works???

* drafted

* forgot to add co-author

Co-Authored-By: Saltgurka <22568446+saltgurka@users.noreply.github.com>

* thrall & tyrande

* Update hyjal.cpp

* trash

* winterchill & anetheron

* kazrogal & azgalor

* Update rev_1708737709108426300.sql

* entrance rp and scourge base

* it worked thank you nyeriah and ayamiss the hunter from AQ20 cause I remembered that it had a similar mechanic and i went to check how to deal with it. did you know ayamiss was my turning point in my emulation "career"? it was a very interesting fight and i spent many hours researching it, leading to my discovery into how the swarmers work, if i did it nowadays i'd have found out immediately but it was a journey nonetheless

Co-Authored-By: Andrew <47818697+Nyeriah@users.noreply.github.com>

* Update rev_1708737709108426300.sql

* no gem farming!

* infernals

* leftovers

* doors

* archimonde

* Update rev_1708737709108426300.sql

* jaina didnt reset gossip flag its over

* crashfix

Co-Authored-By: Andrew <47818697+Nyeriah@users.noreply.github.com>

* Update instance_hyjal.cpp

* no more dberrors

* fix archimonde model and size

scale was set to 0.4, also fixed the speed and attack time, as well as adding model info

* Update rev_1708737709108426300.sql

* Update rev_1708737709108426300.sql

* more stuff

* Update data/sql/updates/pending_db_world/rev_1708737709108426300.sql

* fix: warning

* fix: warning

* buildfix

don't need to assign anything, as long as it doesn't return null we're good

* buildfix

infernal has no DoAction behaviour so it's fine

* Update data/sql/updates/pending_db_world/rev_1708737709108426300.sql

* Update data/sql/updates/pending_db_world/rev_1708737709108426300.sql

* yay

Co-Authored-By: Dan <83884799+elthehablo@users.noreply.github.com>

* a

* looks nicer, less updates overall

* crashfix?

messy code gomenasai 🙇

* hide undesirables >:(

* Update instance_hyjal.cpp

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

---------

Co-authored-by: Gultask <sagemochi@hotmail.com>
Co-authored-by: Saltgurka <22568446+saltgurka@users.noreply.github.com>
Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2024-03-19 21:49:28 +01:00
sudlud
307c1ab09d refactor(Core): remove some unused variables (#18538)
- let's get rid of some compiler warnings
2024-03-13 06:52:43 -03:00
Andrew
6df652a8dd fix(Core/Creature): Prevent combat movement disabled creatures from r… (#18428)
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary

* fixbuild

* Apply suggestions from code review
2024-02-27 10:11:39 -03:00
Dan
a4dc083b42 fix(Scripts/Hyjal): move Hyjal boss waypoints to DB (#18299)
* put anetheron movement in wps

* move all wps to db for bosses
2024-02-12 08:17:39 -03:00
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Kalimist
65d6bd0472 fix(Core/Creature): hardcoded gossip in zone_azshara (#18289)
* Changing hardcoded text in #define to enum member

- Changing #define to new enum member for AddGossipItemFor method

* Adding SQL Query File

* Forgot to add ';' in DELETE FROM
2024-02-08 07:41:23 +01:00
IntelligentQuantum
fa884ae385 chore(Scripts/Kalimdor): remove useless includes (#18065) 2023-12-26 06:08:37 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Gultask
d3bef76fae fix(Scripts/Darkshore): Rabid Thistle Bear spawning with StandState Dead (#17875) 2023-11-26 21:22:58 -03:00
KJack
42ec86680c fix(Scripts/RuinsOfAhnQiraj): Andorov does not respawn after being killed (#17788) 2023-11-20 21:18:13 -03:00
Andrew
0fe18f7c6b fix(Scripts/ThousandNeedles): Improve the handling of quest 5151 (Hyp… (#17811) 2023-11-20 18:14:43 -03:00
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
Andrew
a5b5278929 refactor(Scripts/World): Clean up script files (#17728)
* refactor(Scripts/World): Clean up script files

* Update boss_azuregos.cpp
2023-11-16 14:00:42 -03:00
Andrew
deff0ac587 refactor(Scripts/Ashenvale): Move Naga Brazier script to SAI (#17733) 2023-11-16 13:58:42 -03:00
Andrew
d325332090 refactor(Scripts/OHF): Clean up script files (#17724) 2023-11-15 20:44:39 -03:00
Andrew
db851b483e refactor(Scripts/RuinsOfAhnQiraj): Clean up script files (#17723) 2023-11-15 20:41:56 -03:00
Andrew
03612e8bff refactor(Scripts/TempleOfAhnQiraj): Clean up script files (#17718)
* refactor(Scripts/TempleOfAhnQiraj): Clean up script files

* Update src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_fankriss.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_ouro.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-11-15 14:17:29 -03:00
avarishd
4cb25b4b5e fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds (#17667)
* fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds

* Ss

* DoForAllSummons
2023-11-14 08:53:17 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
KJack
f7fdc7cb6c refactor(Scripts/RuinsOfAhnQiraj)Ç AQ20: Modernize Kurinnaxx (#17671) 2023-11-10 18:59:46 -03:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
podmepodme
945d7c6afe fix(Script/Misc): Replace hardcoded gossip and texts with DB ones. (#17502)
* fix(CORE/Creature): replace shadowmoon valley hardcoded gossips

* fix(CORE/GameObject): replace terokkar forrest hardcoded gossips

* fix(Core/Creature): replace shattrath city hardcoded gossips

* style(Core): code style edit

* style(CORE) codestyle edit

* style(CORE) codestyle edit

* style(CORE): codestyle edit

* ready for merge

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-10-22 03:16:51 +02:00
avarishd
214948bafb fix(DB/Quest): Port Cleansing Witch Hill from Trinity. (#17420)
* fix(DB/Quest): Port Cleansing Witch Hill from Trinity.

https: //github.com/TrinityCore/TrinityCore/issues/22262
Co-Authored-By: Carlos Morales <carlos.morales@insmet.cu>

* ""

Co-Authored-By: Carlos Morales <carlos.morales@insmet.cu>

---------

Co-authored-by: Carlos Morales <carlos.morales@insmet.cu>
2023-10-10 20:26:43 -03:00
Skjalf
0bf559f975 feat(Core/Instance): Add TaskScheduler to the InstanceScript class (#17284)
feat(Core/Instance): Add TaskScheduler to the instancescript class
2023-09-17 10:56:02 -03:00
Kitzunu
f1111be152 chore(misc): cleanup (#17274) 2023-09-17 10:19:09 -03:00
Dan
45d6009cb7 fix(Scripts/Darkshore): ensure Kerlonian Evershade is always in bear form (#17062)
initial
2023-09-17 09:42:07 -03:00
Francesco Borzì
eaa6487fc2 refactor(Scripts): remove unused imports (#17097) 2023-08-27 22:25:22 -03:00
Anton Popovichenko
f4658a1df2 fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. (#17070)
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.

* Fix build
2023-08-25 09:15:07 -03:00
podmepodme
820eac083c fix(Scripts/Orgrimmar): replace hardcoded gossips in zone_orgrimmar (#16947)
* fix(CORE/Creature): replace hardcoded gossips in zone_orgrimmar

Closes AzerothCore issue #4179

* fix(CORE): Codestyle

* refactor(CORE/Character): Switch statement for thrall dialog

* fix(CORE): Codestyle
2023-08-25 08:52:51 -03:00
Skjalf
80a8f6d47a fix(Scripts/OHF): Don't update the escort steps when Drake dies (#17024)
* fix(Scripts/OHF): Don't update the escort steps when Drake dies

* update gossip req

* Update rev_1692233536025387200.sql
2023-08-20 15:46:39 -03:00
Dan
8621118b83 fix(Scripts/OHF): Fix not being able to start the escort if you already killed Lt. Drake (#17006) 2023-08-14 13:05:20 -03:00
Skjalf
8dc8424f09 fix(Scripts/OHF): Killing Drake should not be required to start Thral… (#17000)
fix(Scripts/OHF): Killing Drake should not be required to start Thrall's escort
2023-08-13 13:39:08 -03:00
Grimgravy
c256d8da55 fix(Scripts/Spell): Improve Inoculation quest (#15759)
* fix(Core/Quest): Improve Inoculation

* update fix

* .

* ..
2023-08-12 00:17:06 +02:00
Johaine
f0a96b4489 fix(Scripts/EscapeFromDurnholde): Fix escort mission getting stuck (#16636)
Fix stuck event

Fix escort event possibly getting stuck by preventing
DATA_ESCORT_PROGRESS from being decreased
2023-08-02 14:52:18 -03:00
Skjalf
d4e97a25f4 fix(Scripts/Azuregos): Arcane Vacuum should also reset pet threat (#16868) 2023-07-31 05:44:35 -03:00
天鹿
90e23cbc66 fix(Core/Raid): Archimonde's Unable to kill (#15128)
Fix(Core);[raid]Archimonde's BUG
2023-07-27 10:33:24 -03:00
Dan
b55ebc186d fix(Scripts/TempleOfAhnQiraj): make C'thun Dark Glare face location of last eyebeam before cast, instead of random target (#16785)
* initial

* fix oopsie

* whitespace
2023-07-18 08:45:58 -03:00