Andrew
dea3d44b46
fix(Core/Spells): Prevent aura application if the target is immune ( #20031 )
2024-09-24 15:17:22 -03:00
Andrew
78cc255f43
fix(Core/Spells): Fix Fatal Attraction procing multiple times for eac… ( #20014 )
...
fix(Core/Spells): Fix Fatal Attraction procing multiple times for each player nearby
2024-09-22 14:52:19 -03:00
Kitzunu
386aea03ee
chore(Core/Misc): Some cleanup ( #19970 )
...
* remove weird blanks
* update if
* ) ) to ))
* missed some ) )
* now switch
* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
a0057b9e90
fix(Core/Spells): Resolve a case of triggered spells prolonging combat. ( #19991 )
...
* Revert "fix(Core/Spells): Revert triggered spell logic change. (#19983 )"
This reverts commit 3bb5ec779dwalkline.ua@gmail.com >
* Add comment, use target instead of owner.
* Adjust comment terminology.
---------
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com >
2024-09-19 09:49:56 -03:00
Benjamin Jackson
3bb5ec779d
fix(Core/Spells): Revert triggered spell logic change. ( #19983 )
...
Revert "fix(Core/Spells): Resolve a case of triggered spells prolonging comba…"
This reverts commit edd7e10dfc
2024-09-16 11:15:50 -03:00
Grimdhex
4fc60bbbdf
fix(Core/Spells): Shadow demon - Allow to move while casting Paralyze ( #19948 )
...
* fix(Scripts/BlackTemple): fix stationary shadow demons
* optimization: use else if to stop the execution when a condition is reach
* revert last changes and fix the spell to allow move while casting
* .
2024-09-14 08:39:03 -03:00
Saqra1
321ac4a8c2
fix(Core/Spell): Summoning Portal position ( #19705 )
...
* fix(Core/Spell): Summoning Portal position
Summoning Portal is created in front of the caster but it is still too
close to them. Move it away a bit.
* Cleanup unused SpellInfo correction
Spell 61994 was stopped being used for summons in favor of 23598 on:
67010623a0
2024-09-11 12:37:56 -03:00
Saqra1
4734582e58
fix(Core/Spell): Refreshment Table position ( #19704 )
...
Refreshment Table game object should be created at the same position its
Refreshment Portal was created.
2024-09-11 11:53:07 -03:00
Benjamin Jackson
edd7e10dfc
fix(Core/Spells): Resolve a case of triggered spells prolonging combat. ( #19819 )
...
* Init.
* Expand trigger info check.
* Enclose evaluation in parentheses.
Maybe workflow will be happy?
2024-09-11 11:52:15 -03:00
Saqra1
c42b3ee258
fix(Core/Pet): Control Infernal without enslave ( #19784 )
...
Check SummonProperties Category(Control) too to decide the type of
controls a Guardian should have.
Don't enslave Warlock's Infernal
2024-09-11 11:18:13 -03:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Kitzunu
9af86553c5
chore(Core/Misc): update floor and ceil to std ( #19837 )
2024-09-03 08:01:00 -03:00
Jelle Meeus
e1abc72a25
fix(Core/Spell): warrior stances proccing darkmoon card vengeance damage ( #19796 )
...
add spellinfocorrection
2024-09-01 20:58:03 -03:00
Saqra1
62b825f8bd
fix(Core/Movement): Don't move for change in orientation only ( #19687 )
...
Changing only the orientation of a unit also flags it as if it were
moving, which causes spells to be interrupted.
2024-09-01 20:57:17 -03:00
Kitzunu
5d31b9f98f
refactor(Core/Item): Add helpers ( #19828 )
2024-08-31 19:38:50 -03:00
Benjamin Jackson
b595586bf0
refactor(Core/SpellMgr): Remove nested ifs for binary evaluation. ( #19762 )
...
* Init.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Whitespace.
* Tiny nitpick.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Tiny nitpick.*
Today Bench learns the difference between break and continue.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
* Parentheses warnings.
* Apply suggestion.
Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com >
---------
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com >
2024-08-28 08:13:42 -03:00
Benjamin Jackson
8f335bbc2b
fix(Core/SpellMgr): Remove binary attribute from Drain Soul. ( #19760 )
...
Init.
2024-08-27 15:17:54 -03:00
Saqra1
68402b6d91
fix(Core/Spell): Reset cd on some channeled spells ( #19696 )
...
If a spell is both channeled and has SPELL_ATTR0_COOLDOWN_ON_EVENT
attribute (only rituals) is channeled for its full duration, it goes on
an infinite cooldown. The client needs to be notified when the ritual
ends without being completed.
2024-08-25 23:43:01 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Tereneckla
3419f0246b
fix (Core/Spells) partially revert #19529 ( #19703 )
...
Update Spell.cpp
2024-08-22 20:36:39 -03:00
Andrew
c0b6eae0e1
fix(Core/Spells): Fix movement impairment auras not being removed ( #19684 )
2024-08-22 15:09:43 -03:00
Andrew
ef4e0c0d4a
fix(Core/Spells): Power of the Guardian should persist through death ( #19638 )
2024-08-21 06:36:05 -03:00
Tereneckla
79a653b13e
fix (Core/Spells): remove object size for hit calculation of aoe aura spells that target enemies ( #19529 )
...
remove object size for aoe on enemy spells
2024-08-18 20:34:56 -03:00
sudlud
adc9f4e7ab
fix(Core/Spell): check for player before dereferencing ( #19666 )
2024-08-18 05:57:02 -03:00
Benjamin Jackson
adff3c3846
fix(Core/Spells): Revert ownership and follow logic adjustment for guardian summons. ( #19664 )
...
Revert "fix(Core/Spells): Adjust ownership and follow logic for guardian summ…"
This reverts commit cc2ef9d6dd
2024-08-17 20:29:21 -03:00
Grimdhex
9dc20bc261
fix(Core/Entities): crash fix cause by a pointer change in #19622 ( #19633 )
...
* fix(Core/Entities): crash fix cause by a pointer change in #19622
* fix blank space for codestyle check
2024-08-15 16:28:50 -03:00
Grimdhex
7457aef78d
refactor(Core/Entities): Cleanup Unit header file ( #19622 )
...
* move several enum definitions in a new files
* move more things
* remove the include comment
* move the related code to CharmInfo in this own file
*original idea of Ovahlord
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* fix clang build errors and few blank lines
* missing forward declaration
* new tentative to fix gcc/clang build
* add several include could be necessary for gcc/clang compilation
* .
* revert some include since the last AC update
* fix some loop inconsistencies
* align all enums in UnitDefine.h
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-08-15 05:12:44 -03:00
Andrew
1565758da4
Revert "chore(Script/Misc): cleanup" ( #19627 )
...
Revert "chore(Script/Misc): cleanup (#19619 )"
This reverts commit 7ff8f72397
2024-08-15 05:43:11 +02:00
Kitzunu
7ff8f72397
chore(Script/Misc): cleanup ( #19619 )
...
* chore(Script/Misc): cleanup
* more cleanup
* cleanup
2024-08-14 16:29:50 -03:00
Benjamin Jackson
67010623a0
fix(Core): Adjustments to summoning ritual object handling. ( #19600 )
...
* Init.
* Allow self-summoning.
* Revert unintended change.
Self-summoning still works fine without this being removed, I see no harm in putting it back.
2024-08-13 12:12:05 -03:00
Saqra1
ad411b49b7
fix(Core/Spell) Ritual spells cooldown on cancel ( #19604 )
...
762f78b313killerwife@gmail.com >
2024-08-13 12:05:12 -03:00
Saqra1
ed824de7b8
fix(Core): Ritual animations ( #19602 )
...
Channel the same spell as the original caster when clicking on a ritual
portal, but ignore the effects of the spell.
Co-authored-by: killerwife <killerwife@gmail.com >
2024-08-13 11:54:17 -03:00
Benjamin Jackson
cc2ef9d6dd
fix(Core/Spells): Adjust ownership and follow logic for guardian summons. ( #19599 )
...
* Init.
* Remove totem ownership transfer.
2024-08-13 11:53:43 -03:00
Benjamin Jackson
35b551c0da
fix(Core/SpellInfo): Disallow damage scaling trigger spells to get scaled twice. ( #19605 )
...
* Init.
* Deleted the wrong one.
* Add double scaling check.
* Whitespace.
2024-08-13 11:53:14 -03:00
Kitzunu
e4df159f5c
refactor(Core/Chat): Move SendNotification to ChatHander ( #19491 )
...
* refactor(Core/Chat): Move SendNotification to ChatHander
* Update Battleground.cpp
* fix build
* Update src/server/game/Chat/Chat.h
2024-08-10 11:39:46 -03:00
Gultask
09e77dfd1c
fix(Scripts/BlackTemple): Mother Shahraz Periodic part 2 ( #19561 )
...
* init
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
* Update boss_mother_shahraz.cpp
2024-08-06 11:53:19 -03:00
avarishd
fcdc50306f
fix(Core/Spells): Chromatic Resistance Aura shouldn't give holy resis… ( #19549 )
...
fix(Core/Spells): Chromatic Resistance Aura shouldn't give holy resistance
2024-08-03 12:02:49 -03:00
avarishd
c54fd66c73
fix(Core/Spells): Flame Wave ( #19144 )
...
* fix(Core/Spells): Flame Wave
* )
* .
flamewave faction id
3365e6a4b8/sql/old/9.x/world/21081_2021_10_15/2021_09_29_04_world_2018_06_17_04_world.sql (L46)carlos.morales@insmet.cu >
* lol
---------
Co-authored-by: Carlos Morales <carlos.morales@insmet.cu >
2024-08-02 16:20:27 -03:00
Francesco Borzì
02a05fbd4c
refactor(src/common): remove unused imports ( #19506 )
...
* refactor(src/common): remove unused imports
* fix: build
* chore: fix build
* chore: size_t -> std::size_t
* chore: fix fuckup from previous commit
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build with std::size_t
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
* chore: fix build
2024-07-30 20:06:46 -03:00
Gultask
fccfe51594
fix(Scripts/BlackTemple): Mother Shahraz Periodic Beams ( #19525 )
...
* init
* Update boss_mother_shahraz.cpp
2024-07-29 23:49:58 -03:00
avarishd
a567259770
fix(Core/Spells): [TK] Wing Buffet should be a cone. ( #19382 )
...
* fix(Core/Spells): [TK] Wing Buffet should be a cone.
* radius to 20, from 15
* Update SpellInfoCorrections.cpp
2024-07-29 21:39:36 -03:00
Gultask
e34ce755c8
fix(Scripts/ShadowmoonValley): Rewrite Dragonmaw Races ( #19084 )
...
* init
* fly :)
* finally
* melee attack :/
* Update zone_shadowmoon_valley.cpp
Co-Authored-By: Dan <83884799+elthehablo@users.noreply.github.com >
* Update zone_shadowmoon_valley.cpp
* Update zone_shadowmoon_valley.cpp
* Update zone_shadowmoon_valley.cpp
---------
Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com >
2024-07-27 07:32:17 -03:00
Gultask
917c34cf52
fix(Scripts/BlackTemple): Move Supremus to TaskScheduler and tweak a bit ( #19418 )
...
* Update boss_supremus.cpp
* Update boss_supremus.cpp
* Update boss_supremus.cpp
* ble
* egh
* ye
* ermps
* ok done
* Update SpellInfoCorrections.cpp
* Update SpellInfoCorrections.cpp
2024-07-26 21:48:33 -03:00
Tereneckla
6289be19c7
fix (Core/Spells): Commanding Shout and Blood Pact remember percentage of health ( #19479 )
...
* Update SpellAuraEffects.cpp
* add comment
2024-07-26 21:47:04 -03:00
Jelle Meeus
2d1e4393ba
fix(Spells/SpellInfoCorrections): remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER from some mounts ( #19431 )
...
remove AURA_INTERRUPT_FLAG_NOT_ABOVEWATER for some mounts
2024-07-18 21:56:12 -03:00
Kitzunu
59766e10c6
fix(Core/Spell): Allow using SpellDifficulty in bg ( #19422 )
...
* fix(Core/Spell): Allow using SpellDifficulty in bg
* cherry-pick commit (e4caf52e5a521036+Jildor@users.noreply.github.com >
* Update isle_of_conquest.cpp
---------
Co-authored-by: Gildor <521036+Jildor@users.noreply.github.com >
2024-07-18 18:12:41 +02:00
avarishd
ade4c2527f
fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPEL… ( #19102 )
...
* fix(Core/Spells): Restore sending SMSG_CAST_FAILED for spells in SPELL_STATE_PREPARING state (cast bar in progress) unintentionally removed
https: //github.com/TrinityCore/TrinityCore/commit/844efbfca84580f7b2bd700f40209515f2aaa959
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* ocd
* correct animation and castbar staying
---------
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2024-07-17 09:14:06 -03:00
avarishd
cf7c015ea4
fix(Core/Spell): Implement SPELL_ATTR6_NO_PUSHBACK ( #19292 )
...
fix(Core/Spell): ImplementSPELL_ATTR6_NO_PUSHBACK
2024-07-17 09:09:34 -03:00
avarishd
f510e122a0
fix(Script/Quest): Protecting Our Own ( #19247 )
...
* fix(Core/Spells): Gor'drek's Ointment
* Update spell_item.cpp
* ;
2024-07-17 13:19:48 +02:00
Jelle Meeus
a69d02e513
fix(Scripts/Spells): warlock demonic pact ( #19386 )
...
* add Demonic Pact Aura script
2ff855054f (diff-ea612aafadff90005e88b243eb000369be9e5cb6f8dc85a008d31e42b156e0ec)ariel-@users.noreply.github.com >
* spell_warlock aura:spell_warl_demonic_pact_aura
* fixup! spell_warlock aura:spell_warl_demonic_pact_aura
* remove not needed spell correction, flag is already set
* subtract current proc bonus before calculating new bonus
* also increase healing done
* remove Demonic Pact handling in Unit
* refactor indent, remove bonus from spell group effects e.g. totem of wrath
* Revert "refactor indent, remove bonus from spell group effects e.g. totem of wrath"
This reverts commit 104041172d34f542cc934e9f468407c36912cc7f.
* refactor indent
* manually set proc cooldown
---------
Co-authored-by: ariel- <ariel-@users.noreply.github.com >
2024-07-13 12:38:59 -03:00
