Commit Graph

69 Commits

Author SHA1 Message Date
manstfu
ddd7c1fb6c Updated with master branch 2024-09-14 18:25:46 +02:00
manstfu
c85e9772a8 Update PlayerQuest.cpp
Fixed spells not granted by quests
2024-09-14 09:12:52 +02:00
Yunfan Li
414805e692 Merge branch 'master' into Playerbot 2024-09-04 23:46:34 +08:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Yunfan Li
a642358a43 Merge branch 'master' into Playerbot 2024-08-26 22:29:54 +08:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Yunfan Li
1f54cb14fa Merge branch 'master' into Playerbot 2024-07-07 13:33:14 +08:00
Kitzunu
d5ba5e0168 fix(Core/Quest): typo in RewardQuest makes LFG quests not reward if dead (#19271)
fix(Core/Quest): typo in RewardQuest

* Allow LFG quests to be rewarded even when dead
2024-07-04 09:41:53 -03:00
Yunfan Li
20f917c48f Merge branch 'master' into Playerbot 2024-06-22 16:09:16 +08:00
sudlud
b3f21d909a fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_CAN_FAIL_IN… (#19116)
fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_CAN_FAIL_IN_ANY_STATE

- this allows flagging quests so that they are allowed to fail in Player::FailQuest()
  independant of their current state
- update quest 853 accordingly as a first use case
2024-06-22 03:04:56 -03:00
Yunfan Li
72725635ba Merge branch 'master' into Playerbot 2024-06-19 14:32:16 +08:00
atrapalis
dea3748629 fix(Core/Quest): Correct XP Display when modified by SPELL_AURA_MOD_XP_QUEST_PCT (#19060)
* fix(Core): Correct Quest XP Display when modified by SPELL_AURA_MOD_XP_QUEST_PCT

The quest XP displayed on the gossip window was not modified for auras that increase quest XP gain (e.g. spell ID 57353). This commit corrects the quest XP display when accepting/returning quests.

* refactor(Entities/Player): Added a `CalculateQuestRewardXP()` function to reduce duplicated code

* cleanup(Entities/Creature): Removed now unused variable `playerLevel`

* Apply suggestions from code review

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-06-19 00:41:39 +02:00
Yunfan Li
72634b2829 Merge branch 'master' into Playerbot 2024-06-07 22:28:03 +08:00
sudlud
3913618f87 fix(Core/PlayerQuest): make timed quests failable (#18940) 2024-06-04 18:30:10 +02:00
Yunfan Li
ccf92f481d Merge branch 'master' into Playerbot 2024-01-04 19:22:20 +08:00
Kitzunu
6202835cff fix(Core/LFG): Hide XP from max players (#18103)
* Cherry-pick Player::IsMaxLevel from TrinityCore
* Correctly hide XP reward for max level players in LFG
* Closes #18101
2024-01-03 19:47:26 +01:00
Yunfan Li
7915f79d04 Merge branch 'master' into Playerbot 2023-12-12 20:52:42 +08:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Yunfan Li
72660b1ed8 Merge branch 'master' into Playerbot 2023-05-24 17:57:30 +08:00
AnchyDev
444793346d feat(Core/Hooks): Add parameter to detect XP origin for OnGiveXP hook. (#16109)
Added enum parameter to detect where XP originated from.
2023-05-05 22:39:36 -03:00
郑佩茹
be7c57507f Merge branch 'master' into Playerbot
# Conflicts:
#	src/server/game/Entities/Player/Player.h
2023-03-16 10:00:13 -06:00
Stefano Borzì
034b521501 feat(CI): add cppcheck (#15211)
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-03-05 18:47:18 +01:00
郑佩茹
826bac08ec Merge branch 'master' into Playerbot
# Conflicts:
#	src/server/game/World/IWorld.h
#	src/server/game/World/World.h
2023-03-01 11:52:02 -07:00
Julio A. Leyva Osorio
725aa27d7e fix(Core/Quests): Fix exploit in icc reputation rings (#15092) 2023-02-27 13:13:19 -03:00
郑佩茹
03b3f9d051 Merge branch 'master' into Playerbot
# Conflicts:
#	src/server/game/World/World.h
2023-02-09 12:40:25 -07:00
Benjamin Jackson
fafeacbcad fix(Core/PlayerQuest): Get base skill value for quest prereqs. (#14393) 2023-01-28 11:00:18 +01:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
ZhengPeiRu21
ac5bcfae12 Merge branch 'azerothcore:master' into Playerbot 2022-09-02 10:49:43 -06:00
ZhengPeiRu21
a347e3fca8 fix(Core): Fix Missing OnBeforeQuestComplete Hook (#12892) 2022-09-01 16:03:48 -04:00
ZhengPeiRu21
92841a35e1 Merge branch 'azerothcore:master' into Playerbot 2022-04-26 08:42:57 -06:00
SilentCLD
ffa2f071bc fix(Core/Wintergrasp): Reimplement Wintergrasp quests and fix vendors (#11533) 2022-04-25 18:20:10 -03:00
ZhengPeiRu21
ec96415fda Merge branch 'azerothcore:master' into Playerbot 2022-04-16 21:41:45 -06:00
UltraNix
b7c8c09920 fix(Core/Quests): Fixed displaying correct quest marks for autocomplete/repeatable/daily completed quests. (#11349)
Fixes #11237
2022-04-15 11:47:13 -03:00
ZhengPeiRu21
44b7a0666c feat(Scripting/Hooks): implement OnQuestComputeXP() hook (#10934) 2022-03-24 10:27:15 +01:00
郑佩茹
ff0e5d5e3b Merge branch 'questXPHook' into Playerbot 2022-03-21 14:47:43 -06:00
UltraNix
12d41d1314 Big update. 2022-03-12 22:28:00 +01:00
郑佩茹
d60bb4fc90 feat(Scripting/Hooks): Implement OnQuestComputeXP() hook 2022-03-07 19:17:29 -07:00
Kitzunu
d927ce6fac feat(Core/Creature): Implement quest_greetings table (#10526)
* cherry-pick commit (6dda09818d)

Co-Authored-By: ForesterDev <11771800+ForesterDev@users.noreply.github.com>
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
2022-03-06 18:19:08 +01:00
Kargatum
de13bf426e feat(Core/DBLayer): replace char const* to std::string_view (#10211)
* feat(Core/DBLayer): replace `char const*` to `std::string_view`

* CString

* 1

* chore(Core/Misc): code cleanup

* cl

* db fix

* fmt style sql

* to fmt

* py

* del old

* 1

* 2

* 3

* 1

* 1
2022-02-05 00:37:11 +01:00
Kargatum
5969df4e30 refactor(Core/Logging): switch to fmt style for LOG_ (#10366)
* feat(Core/Common): add support fmt style for ASSERT and ABORT

* correct CheckCompactArrayMaskOverflow

* 1

* Update src/server/game/Spells/Spell.cpp

* rework logging

* add fmt replace logs

* logging

* FMT_LOG_

* settings

* fix startup

* 1

* 2

* 3

* 4

* 5

* fmt::print

* to fmt
2022-01-27 16:44:41 +01:00
Kargatum
8b7df23f06 feat(Core/Time): Implement saparated manager for game time (#8630) 2022-01-24 17:55:00 +07:00
IntelligentQuantum
75fc2d1b2d fix(Scripts/Commands): quest complate kill reward (#9926) 2022-01-24 09:22:40 +01:00
UltraNix
ba63354410 fix(Core/Quests): Do not remove inventory items/non-empty bags on quest reward. (#10073)
Fixes #10016
2022-01-13 18:04:03 -03:00
acidmanifesto
4330e44ad0 fix (Core/CodeReduction) TC_ removal (#10162)
TC_ remove from any commit out TC_LOG in the event when we do need to run debug logging, we can just remove the // instead of // TC_
2022-01-13 14:39:54 -05:00
Kitzunu
ac99eb48e1 refactor(Core/Misc): abs() to std::abs() (#9789) 2021-12-31 19:29:39 -03:00
Skjalf
a72d299f68 fix(Core/Player): Solve the issue with creature not offering low level quests (#9862) 2021-12-23 15:26:58 -03:00
Cláudio Costa
81cf9e3aa7 fix(Core/Player): Quest Question marks (#9683)
* fix(Core): Quest Question marks

* extra changes

* changes for players with repetable quests
2021-12-22 08:37:01 -03:00
Skjalf
e7b5bb2420 feat(Core/Player): Split Dungeon Finder quest rates (#9788) 2021-12-19 19:29:26 -03:00
Skjalf
2d55974c0c Revert "fix(Core/Spells): Forward core changes (#8841)" (#9631)
This reverts commit 85d2c39a48.
2021-12-10 15:31:48 +01:00
acidmanifesto
85d2c39a48 fix(Core/Spells): Forward core changes (#8841) 2021-12-09 18:24:16 -03:00