Commit Graph

40 Commits

Author SHA1 Message Date
Anton Popovichenko
c66972b900 fix(Core/Scripts): Fix heap-use-after-free in Fingers of Frost proc handler (#21943) 2025-04-17 09:27:49 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Grimdhex
61f3a631c3 fix(Server): remove double blank lines at the end of several files (#19735) 2024-08-25 07:21:14 -03:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Kitzunu
5bfeabde81 chore(Core/Misc): rename spellInfo pointers (#17914)
* Rename all
2023-12-02 06:03:15 -03:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix
9b59f35cb8 fix(Core/Spells): Fixed Master of Elements not refunding mana. (#14665) 2023-01-28 10:59:25 +01:00
Gultask
6b4ef50e7a Revert "fix(Core/Spells): Ignite and Revitalize should not prelong co… (#14513)
Revert "fix(Core/Spells): Ignite and Revitalize should not prelong combat. (#13812)"

This reverts commit 96fa9c5c7b.
2023-01-05 23:14:56 -03:00
UltraNix
96fa9c5c7b fix(Core/Spells): Ignite and Revitalize should not prelong combat. (#13812)
Fixes #13330
2023-01-06 00:50:53 +01:00
Angelo Venturini
9c16f56ccb fix(Core/Scripts): Master of elements odd crash (#13849) 2022-11-21 16:52:08 -03:00
UltraNix
9e89917fd7 fix(Core): Crashfix. (#13484)
Fixes #13329
Fixes #13145
2022-11-01 06:21:30 -03:00
Angelo Venturini
ad4ce0895f fix: Qaston revert (#13320)
* Revert "fix(Core/QAston): fixed shields oneshotting (#13271)"

This reverts commit e05f61d1b3.

* Revert "fix(Core): Crash (#13292)"

This reverts commit a818bcf3e2.

* Revert "fix: Crash (#13241)"

This reverts commit be423a91b5.

* delete sql

* Revert "refactor(Core/Spells): Implement QAston Proc System (#11079)"

This reverts commit cbd3fd0967.

* add sql revert

* fix sql

* remove update from world.updates
2022-10-05 21:53:20 +02:00
Angelo Venturini
be423a91b5 fix: Crash (#13241) 2022-10-03 16:14:43 -03:00
IntelligentQuantum
cbd3fd0967 refactor(Core/Spells): Implement QAston Proc System (#11079)
* .

* sql

* .

* .

* 1

* 2

* 3

* 4

* 5

* 6

* 7

* 8

* 9

* 10

* 11

* 12

* 13

* 14

* 15

* Update spell_item.cpp

* Update Unit.cpp

* 16

* 17

* 18

* 19

* 20

* 21

* Update Unit.cpp

* REVERT UltraNIX Commit

* 22

* 23

* .

* .

* .

* warrior

* warlock

* shaman rogue priest paladin mage

* spell item

* hunter

* druid

* dk

* war

* error style

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* Update rev_1647677899565690722.sql

* .

* DOND DEL ME WAD DO DO

* error 2

* .

* .

* .

* FIX

* Update SpellInfoCorrections.cpp

* Update SpellInfoCorrections.cpp

* .

* ja genau

* Update .gitignore

* .

* .

* .,

* .

* .

* .

* .

* Update Unit.cpp
2022-10-02 19:39:34 +02:00
UltraNix
a5ab96c79d fix(Scripts/Spells): Finger of Frost Shatter Combo. (#13006) 2022-09-19 00:46:17 -03:00
Kitzunu
455899dc75 fix(Core/Misc): Change const to be after type name (#10591) 2022-02-14 16:05:45 -03:00
UltraNix
3ca99c5683 fix(Scripts/Spell): Removed doubled damage from Deep Freeze. (#9810) 2021-12-22 19:53:12 -03:00
Nefertumm
61c7488698 fix(Core/Spells): possible crashes within class spells (#9168) 2021-11-21 11:41:51 -03:00
Kitzunu
ef0bbc4c7b refactor(Scripts/Spells): convert spell_mage into new system (#9058) 2021-11-09 11:44:37 +01:00
Skjalf
1e57b6fb99 fix(Core/Spells): add several missing null checks for the DamageInfo struct to fix a crash (#8322) 2021-10-10 16:07:14 +02:00
UltraNix
66809383d1 fix(Core/Spells): add several missing null checks for the DamageInfo struct to fix a crash - Part II. (#8376) 2021-10-10 15:56:42 +02:00
Kargatum
52aa0e9966 feat(License): add new headers information about license (#7941)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2021-09-30 13:40:52 +07:00
Asthalor
7618e7706e fix(Scripts/Spell): combustion will now properly go on cooldown when the buff is manually cancelled (#7185)
* fix(CORE/Spell): Combustion will now properly go on cooldown when the buff is manually cancelled
* fix(DB/Scripts): Added the script for combustion
* Update spell_mage.cpp
* Update src/server/scripts/Spells/spell_mage.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-08-06 11:13:45 +02:00
UltraNix
9a820e2d26 fix(Core/Spells): Master of Elements (#7102)
* Core/Spells: Master of Elements:

Proc now also from arcane spells.
Properly proc from periodic spells.
Fixed #6035.

* You shouldn't be there.

* Buildfix.

* missing sql.
2021-08-02 01:02:38 +02:00
Kitzunu
a75e34c793 feat(Core/Spell): AssertSpellInfo (#6115)
* feat(Core/Spell): AssertSpellInfo

(cherry picked from commit e52878b6b5)
(cherry picked from commit 8c44259fae)
Co-Authored-By: Shauren <shauren.trinity@gmail.com>
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>

* Update SpellMgr.h
2021-06-03 07:39:48 +02:00
Francesco Borzì
f6a17164be fix(Core/License): issue with old files license (#4762) 2021-03-17 09:46:01 -06:00
Kitzunu
28f1dc5c0c refactor(Core): replace NULL with nullptr (#4593) 2021-03-02 01:34:20 +01:00
Kitzunu
dbc0ff6554 refactor(Core): sort #includes alphabetically (#4579) 2021-02-24 22:34:42 +01:00
Kitzunu
0d52b4ca4a feat(Core/Spell): Implement ValidateSpellInfo (#4323)
* feat(Core/Spell): Implement ValidateSpellInfo

* cherry-pick from 2b5d7eef3a & a0a158b5b8

* sLog->outError

* cleanup

* convert to ValidateSpellInfo

* fix error log

* improve sLog->outError

* remove non related spells stuff from Validate

* remove the last

* build

* build x2
2021-02-01 18:57:25 +01:00
Kargatum
ea93a5c1a1 feat(CI/Codestyle): added codestyle check (#3668) 2021-01-09 11:59:50 +01:00
Francesco Borzì
d4a58700d4 refactor(Core): apply clang-tidy modernize-use-override (#3817) 2020-12-06 18:04:55 +01:00
Kargatum
5e20b46812 refactor(Core/Scripts): restyle scripts lib with astyle (#3467) 2020-10-11 10:35:34 +02:00
Kitzunu
1f89282b22 refactor(Core): NULL -> nullptr (#3275)
* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 11:55:09 +02:00
Stoabrogga
b776e68665 fix(Core/Spell): Glyph of Eternal Water (#2508) 2019-12-26 09:09:50 +01:00
Nefertumm
dd300003e2 Update license links (#783) 2018-03-12 10:54:57 +01:00
Yehonal
17332304fd Using TC structure allowing easier patches importing 2017-12-21 00:20:29 +01:00
Yehonal
b0c8eceb08 Refactoring part 2 [W.I.P] 2016-08-12 02:38:26 +02:00
Yehonal
f6eefedcd5 converted all tabs to 4 spaces 2016-06-26 19:23:57 +02:00
Yehonal
e8e94a0a66 First Commit
For Azeroth!
2016-06-26 10:39:44 +02:00