Commit Graph

56 Commits

Author SHA1 Message Date
Benjamin Jackson
b7d7089da6 fix(Core/Entities): Daily and other quests should grant XP when rewarded on subsequent completions. (#23160) 2025-10-10 17:37:14 +02:00
Vanna White
b711c55c1e fix(CORE/lfg): Correct random LFG reward bug (#22599)
Co-authored-by: Kito <kito@vortexirc.com>
2025-08-01 09:55:22 +01:00
Exitare
98ceb1c067 fix(Core/PlayerScript) Align player script function names (#21020)
Co-authored-by: sudlud <sudlud@users.noreply.github.com>
2025-02-16 14:59:41 +01:00
Kitzunu
47c5ff904f refactor(Core/Disables): Convert from Namespace to Class Structure (#21109) 2025-02-01 22:48:52 +01:00
Exitare
4d1dba4a09 fix(Core/Player): Quest failure sound when inventory full (#20970)
* Add quest failure sound when inventory is full or quest failed

* Fix sound being played for all players & move call to correct function
2024-12-18 21:58:32 -03:00
Jelle Meeus
9f58216383 fix(Core/Spell): EffectQuestComplete, set quest to rewarded instead of complete (#20358)
set quest to rewarded instead of complete when targetted by SPELL_EFFECT_QUEST_COMPLETE

Prevents people from ending up with strange quests in their quest logs.

https://github.com/TrinityCore/TrinityCore/commit/6d62f852acf3e1a3ee57cde2442832280aee814

Co-authored-by: SnapperRy <snapperryen@gmail.com>
2024-11-15 03:47:41 -03:00
Kitzunu
386aea03ee chore(Core/Misc): Some cleanup (#19970)
* remove weird blanks

* update if

* ) ) to ))

* missed some ) )

* now switch

* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
1edac37ac3 refactor(Core): Make more use of helpers. (#19835)
* Init.

* Reword.

* Update codestyle script.

Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Add gameobject type ID check, reorder checks.

* Add helper/codestyle check for unit type.

* `IsUnit()` -> `IsCreature()`

* Add `IsUnit()` method.

* Use type mask.

https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* Replace instances of `isType` with `IsUnit`.

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2024-09-03 14:41:31 -03:00
Grimdhex
643362d697 refactor(Core/Object): adds consistency in the use of type object check (#19671) 2024-08-25 09:57:37 -03:00
Kitzunu
d5ba5e0168 fix(Core/Quest): typo in RewardQuest makes LFG quests not reward if dead (#19271)
fix(Core/Quest): typo in RewardQuest

* Allow LFG quests to be rewarded even when dead
2024-07-04 09:41:53 -03:00
sudlud
b3f21d909a fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_CAN_FAIL_IN… (#19116)
fix(Core/PlayerQuest): Introduce flag QUEST_SPECIAL_FLAGS_CAN_FAIL_IN_ANY_STATE

- this allows flagging quests so that they are allowed to fail in Player::FailQuest()
  independant of their current state
- update quest 853 accordingly as a first use case
2024-06-22 03:04:56 -03:00
atrapalis
dea3748629 fix(Core/Quest): Correct XP Display when modified by SPELL_AURA_MOD_XP_QUEST_PCT (#19060)
* fix(Core): Correct Quest XP Display when modified by SPELL_AURA_MOD_XP_QUEST_PCT

The quest XP displayed on the gossip window was not modified for auras that increase quest XP gain (e.g. spell ID 57353). This commit corrects the quest XP display when accepting/returning quests.

* refactor(Entities/Player): Added a `CalculateQuestRewardXP()` function to reduce duplicated code

* cleanup(Entities/Creature): Removed now unused variable `playerLevel`

* Apply suggestions from code review

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2024-06-19 00:41:39 +02:00
sudlud
3913618f87 fix(Core/PlayerQuest): make timed quests failable (#18940) 2024-06-04 18:30:10 +02:00
Kitzunu
6202835cff fix(Core/LFG): Hide XP from max players (#18103)
* Cherry-pick Player::IsMaxLevel from TrinityCore
* Correctly hide XP reward for max level players in LFG
* Closes #18101
2024-01-03 19:47:26 +01:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
AnchyDev
444793346d feat(Core/Hooks): Add parameter to detect XP origin for OnGiveXP hook. (#16109)
Added enum parameter to detect where XP originated from.
2023-05-05 22:39:36 -03:00
Stefano Borzì
034b521501 feat(CI): add cppcheck (#15211)
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-03-05 18:47:18 +01:00
Julio A. Leyva Osorio
725aa27d7e fix(Core/Quests): Fix exploit in icc reputation rings (#15092) 2023-02-27 13:13:19 -03:00
Benjamin Jackson
fafeacbcad fix(Core/PlayerQuest): Get base skill value for quest prereqs. (#14393) 2023-01-28 11:00:18 +01:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
ZhengPeiRu21
a347e3fca8 fix(Core): Fix Missing OnBeforeQuestComplete Hook (#12892) 2022-09-01 16:03:48 -04:00
SilentCLD
ffa2f071bc fix(Core/Wintergrasp): Reimplement Wintergrasp quests and fix vendors (#11533) 2022-04-25 18:20:10 -03:00
UltraNix
b7c8c09920 fix(Core/Quests): Fixed displaying correct quest marks for autocomplete/repeatable/daily completed quests. (#11349)
Fixes #11237
2022-04-15 11:47:13 -03:00
ZhengPeiRu21
44b7a0666c feat(Scripting/Hooks): implement OnQuestComputeXP() hook (#10934) 2022-03-24 10:27:15 +01:00
Kitzunu
d927ce6fac feat(Core/Creature): Implement quest_greetings table (#10526)
* cherry-pick commit (6dda09818d)

Co-Authored-By: ForesterDev <11771800+ForesterDev@users.noreply.github.com>
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
2022-03-06 18:19:08 +01:00
Kargatum
de13bf426e feat(Core/DBLayer): replace char const* to std::string_view (#10211)
* feat(Core/DBLayer): replace `char const*` to `std::string_view`

* CString

* 1

* chore(Core/Misc): code cleanup

* cl

* db fix

* fmt style sql

* to fmt

* py

* del old

* 1

* 2

* 3

* 1

* 1
2022-02-05 00:37:11 +01:00
Kargatum
5969df4e30 refactor(Core/Logging): switch to fmt style for LOG_ (#10366)
* feat(Core/Common): add support fmt style for ASSERT and ABORT

* correct CheckCompactArrayMaskOverflow

* 1

* Update src/server/game/Spells/Spell.cpp

* rework logging

* add fmt replace logs

* logging

* FMT_LOG_

* settings

* fix startup

* 1

* 2

* 3

* 4

* 5

* fmt::print

* to fmt
2022-01-27 16:44:41 +01:00
Kargatum
8b7df23f06 feat(Core/Time): Implement saparated manager for game time (#8630) 2022-01-24 17:55:00 +07:00
IntelligentQuantum
75fc2d1b2d fix(Scripts/Commands): quest complate kill reward (#9926) 2022-01-24 09:22:40 +01:00
UltraNix
ba63354410 fix(Core/Quests): Do not remove inventory items/non-empty bags on quest reward. (#10073)
Fixes #10016
2022-01-13 18:04:03 -03:00
acidmanifesto
4330e44ad0 fix (Core/CodeReduction) TC_ removal (#10162)
TC_ remove from any commit out TC_LOG in the event when we do need to run debug logging, we can just remove the // instead of // TC_
2022-01-13 14:39:54 -05:00
Kitzunu
ac99eb48e1 refactor(Core/Misc): abs() to std::abs() (#9789) 2021-12-31 19:29:39 -03:00
Skjalf
a72d299f68 fix(Core/Player): Solve the issue with creature not offering low level quests (#9862) 2021-12-23 15:26:58 -03:00
Cláudio Costa
81cf9e3aa7 fix(Core/Player): Quest Question marks (#9683)
* fix(Core): Quest Question marks

* extra changes

* changes for players with repetable quests
2021-12-22 08:37:01 -03:00
Skjalf
e7b5bb2420 feat(Core/Player): Split Dungeon Finder quest rates (#9788) 2021-12-19 19:29:26 -03:00
Skjalf
2d55974c0c Revert "fix(Core/Spells): Forward core changes (#8841)" (#9631)
This reverts commit 85d2c39a48.
2021-12-10 15:31:48 +01:00
acidmanifesto
85d2c39a48 fix(Core/Spells): Forward core changes (#8841) 2021-12-09 18:24:16 -03:00
Kargatum
51adbffae4 feat(Core/Modules): add separated lib for modules (#9281) 2021-12-02 20:28:58 +07:00
UltraNix
8668a03e14 fix(Core/DungeonFinder): Dead players should be able to get XP reward from random dungeon. (#9319)
Fixes #9082
2021-12-01 07:04:41 -03:00
UltraNix
fc4b5a93a0 fix(Core/Quests): Do not save queststatus for autocomplete quests . S… (#9425)
* fix(Core/Quests): Do not save queststatus for autocomplete quests . Source: TrinityCore.

Fixes #9150
2021-11-30 21:05:06 -03:00
acidmanifesto
29f49108a5 chore(Core): Remove unnecessary slang Cosmetic (#9325)
* Remove unnecessary slang

Removes ZOMG! that is used in the src in logging and notes. Completely Unnecessary. Contributes to nothing useful. Inflates source. Not needed at all in any shape or form. Not Developer Lingo either.

* Further Clean Up

Removed Profanity

* sensible grammar correction

* More ZOMG! removal
2021-11-25 04:31:54 -03:00
Skjalf
2187470df7 refactor(Scripts/Commands): Update cs_quest to the new model (#9267) 2021-11-24 01:21:16 -03:00
Kargatum
f62664c987 refactor(Core/Misc): headers cleanup (#9259) 2021-11-22 17:24:39 +07:00
acidmanifesto
70b0de4e1f fix(Core/Quest): Refresh SMSG_QUESTGIVER_STATUS_MULTIPLE after a quest change (#8902)
Co-authored-by: Malcrom <malcromdev@gmail.com>
2021-11-04 23:51:54 +01:00
Malcrom
a7cc26e2ef fix(Core) Quest Relations (#8777) 2021-10-29 07:53:29 -03:00
UltraNix
1fb6830b15 feat(Core/Quests): Implemented quest_money_rewards (for quest with Qu… (#8610)
Fixes #8440
2021-10-20 05:45:56 -03:00
Kargatum
1c40caa4d6 feat(Core/Player): add helper for send large count mail items (#8460) 2021-10-14 15:25:15 +07:00
Kitzunu
4e590ed20c fix(Core/Quest): Update all quests when item is optained/removed (#7862)
Co-Authored-By: Gildor <521036+Jildor@users.noreply.github.com>
Co-Authored-By: Wyrserth <43747507+Wyrserth@users.noreply.github.com>
2021-10-09 10:20:07 +02:00
Kargatum
52aa0e9966 feat(License): add new headers information about license (#7941)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2021-09-30 13:40:52 +07:00
Artem
87a4e493a3 fix(Core/Script): 'Battle at Valhalas' quests done automatically (#7036)
* fix(Core/Script): 'Battle at Valhalas' quests done automatically

Battle at Valhalas series of quests, get to automatically complete

Closes #6753

* Refactoring

* Refactoring

* Refactoring PlayerUpdates.cpp

Co-authored-by: IntelligentQuantum <IntelligentQuantum@ProtonMail.Com>

* Refactoring PlayerQuest.cpp

Co-authored-by: IntelligentQuantum <IntelligentQuantum@ProtonMail.Com>

* Update src/server/scripts/Northrend/zone_icecrown.cpp

Co-authored-by: IntelligentQuantum <IntelligentQuantum@ProtonMail.Com>
2021-09-25 16:59:49 +02:00