Commit Graph

4111 Commits

Author SHA1 Message Date
The GhostRider
b1c8b0eaa2 fix(Core/Item): Complimentary Brewfest Sampler (#16992)
* Fix(DB/C++):Item - Complimentary Brewfest Sampler

* Delete PlayerStorage.cpp

* Update rev_1691843684176706600.sql

Correction

* Ripristino il file PlayerStorage.cpp

* New file: SpellInfoCorrections.cpp

* Update rev_1691843684176706600.sql
2023-08-25 08:45:06 -03:00
Dan
d63aba78bd refactor(Scripts/SSC): modernise Morogrim Tidewalker with BossAI (#17028)
* fix ohf

* revert

* initial

* make bench happy

* make bench happier
2023-08-25 08:40:41 -03:00
Anton Popovichenko
4c287e2873 fix(Core/Vehicles): Fix crash in Vehicle::AddPassenger (#17038)
* fix(Crash): Fix crash in Vehicle::AddPassenger

As I understand it, a try-catch block cannot intercept the ABORT function. Therefore, let's use a simple if statement instead.

* Address code review feedback
2023-08-22 12:13:36 +02:00
Gultask
e42f43784c feat(Core/SmartAI): Implement SMART_ACTION_FOLLOW_GROUP (#17033)
* Update SmartScript.cpp

* INIT

* add as coauthor as well :)

Co-Authored-By: cyberium <346907+cyberium@users.noreply.github.com>

* codestyle

* test?

---------

Co-authored-by: cyberium <346907+cyberium@users.noreply.github.com>
2023-08-22 12:11:21 +02:00
Kitzunu
12456b5496 refactor(Misc/Conf): DBErrors is now Errors (#17053)
* refactor(Misc/Conf): DBErrors is now StartupErrors

* pt2

* Update ci-error-check.sh

* Update ci-error-check.sh
2023-08-22 12:08:53 +02:00
Skjalf
f24fb95575 fix(Scripts/Arcatraz): Fix not being able to try Skyriss a second time after wipes (#17018)
* fix(Scripts/Arcatraz): Revive Warden Mellichar on wipes at Skyriss

* Update boss_harbinger_skyriss.cpp
2023-08-22 00:12:49 -03:00
Walter Pagani
957ccdb845 fix(Script/Spells): Book of Fel Names (#17051) 2023-08-21 21:15:00 +02:00
Tereneckla
cf87a2d8fe fix(Core/Pet): Correct (most) warlock pet scaling (#16769)
* create

* Update Pet.cpp

* remove unwanted change

* Update data/sql/updates/pending_db_world/rev_1689522771491547000.sql

* Update rev_1689522771491547000.sql
2023-08-20 21:38:49 -03:00
Skjalf
80a8f6d47a fix(Scripts/OHF): Don't update the escort steps when Drake dies (#17024)
* fix(Scripts/OHF): Don't update the escort steps when Drake dies

* update gossip req

* Update rev_1692233536025387200.sql
2023-08-20 15:46:39 -03:00
Kitzunu
6185b1d73b fix(Core/Events): Implement Spirit of Competition event (#16963)
* fix(Core/Events): Implement Spirit of Competition event

Co-Authored-By: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* more stuff

* bye bye magic numbers

* fix dberrors

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* commoneers

* Update src/server/game/Battlegrounds/Battleground.cpp

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>

* ci

* Update rev_1691529514989936100.sql

* unnecessary whitespace

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update Battleground.cpp

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2023-08-20 00:41:44 +02:00
Anton Popovichenko
1a1a320ea1 fix(Scripts/Dragonblight): Fix crash from Wintergarde Gryphon. (#17032)
fix(Vehicle): Fix crash on ExitVehicle from Wintergarde Gryphon.
2023-08-19 22:30:39 +02:00
Anton Popovichenko
f6b77f9d64 fix(Core/Pets): Fix crash when pet tries to attack deleted object (#17034)
This situation occurs when, during a fight, a pet receives a command to apply a positive spell to an ally and then resume attacking its previous target.
2023-08-19 22:27:51 +02:00
Grimgravy
edc92b4282 fix(Scripts/Quest): Improved Varedis Must Be Stopped (#16799)
* fix(Scripts/Quest): Varedis Must Be Stopped

* Update spell_quest.cpp

* Update data/sql/updates/pending_db_world/rev_1689813586760998100.sql

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-19 22:13:56 +02:00
Mike Delago
cf30d534f1 fix(Tools/DBImport): Add Env var support to DBimport tool (#17019)
add env var support for dbimport
2023-08-19 18:52:12 +02:00
Anton Popovichenko
57e0b496bd fix(Core/Transport): Fixes crash with loading player on deleted transport (#17021)
* fix(Crash): Fixes crash with loading player on deleted transport

* Remove whitespace
2023-08-18 16:13:43 +02:00
Kitzunu
4f015d0967 refactor(Deps/MySQL): Tidy up FindMySQL for windows (#16948) 2023-08-14 23:39:03 +02:00
Kitzunu
39ec7464ef fix(build): macOS (#17007)
* fix(build): macOS

* Revert "fix(build): macOS"

This reverts commit 612c41e41b2aea55069c0cfaf751c3ba7205e52f.

* Update Config.cpp
2023-08-14 23:38:30 +02:00
Anton Popovichenko
d69ee90ed3 feat(Core/Config): Implement config override with env vars (#16817)
* Core/Config: Implement config override with env vars

Implement overriding of configuration from the .conf file with environment variables.
Environment variables keys are autogenerated based on the keys defined in .conf file.

Usage example:

$ export TC_DATA_DIR=/usr
$ AC_WORLD_SERVER_PORT=8080 ./worldserver

* Add tests for env vars config
2023-08-14 22:07:43 +02:00
Dan
8621118b83 fix(Scripts/OHF): Fix not being able to start the escort if you already killed Lt. Drake (#17006) 2023-08-14 13:05:20 -03:00
Skjalf
49c2eabea1 fix(Scripts/Karazhan): Fix Servant Quarters rares not spawning (#17001)
* fix(Scripts/Karazhan): Fix Servant Quarters rares not spawning

* Update rev_1691944209332122100.sql
2023-08-13 13:51:43 -03:00
Skjalf
8dc8424f09 fix(Scripts/OHF): Killing Drake should not be required to start Thral… (#17000)
fix(Scripts/OHF): Killing Drake should not be required to start Thrall's escort
2023-08-13 13:39:08 -03:00
Gultask
8d803334eb feat(Core/SmartAI): Add new event parameter, event_param6 (#16944)
* init

* pt2

* this template stuff must go

* also for my other event
2023-08-12 14:53:15 -03:00
Kitzunu
a369402f4b fix(DB/Gossip): Change MenuID to INT from SMALLINT (#16982)
* fix(DB/Gossip): Change MenuID to INT from SMALLINT

* update cpp
2023-08-12 19:49:43 +02:00
Grimgravy
c256d8da55 fix(Scripts/Spell): Improve Inoculation quest (#15759)
* fix(Core/Quest): Improve Inoculation

* update fix

* .

* ..
2023-08-12 00:17:06 +02:00
Skjalf
211ceecc32 chore(Scripts/Karazhan): Clean up Maiden of Virtue script (#16977) 2023-08-12 00:14:47 +02:00
Kitzunu
de2e2b6e8b fix(Scripts/Command): Improve output of event commands (#16980) 2023-08-12 00:03:03 +02:00
Tung Bui (Leo)
da8ebbae0b fix(Scripts/UBRS): typo in Blackrock Spire instance (#16976)
* fix(spells/scripts): typo in Blackrock Spire instance

* fix(spells/scripts): typo in Blackrock Spire instance - usage
2023-08-10 23:13:45 -03:00
avarishd
7c43738214 fix(Spells/Scripts): Gnomish Poultryizer (#15554)
fix(Spells/Scripts): Gnomish Poultryizer not breaking on damage
2023-08-10 14:37:14 -03:00
Dan
310b143008 chore(Scripts/Karazhan): rework Opera scripts using TaskScheduler (#16688)
* initial

* removing guids/using creature instance data

* move summontito

* add data for oz adds

* removal of unused stuff + removal of if condition
that makes it get stuck

* fix

* fix and add validators

* some fixes and validators

* attempt to reset

* fix talk + change flags

* debug to see where it is going wrong

* handle despawn on all

* cleanup

* codestyle

* more codestyle

* add tito data + tito despawn

* first steps on romulo and j

* with setdata

* test

* test

* some debug

* no way this was the problem

* add action to resume combat on revive

* leftovers

* remove old check to ensure abilities don't

keep casting. this was preventing the scheduler from updating

* getdata

* camelCase

* restore updatevictim

might make them attack you

* some cleanup

* some cleanup and door

door should now open on wipe

* fix mistake

* fix?

* attempt to fix dead attacking

* fix mistake

* schedule location fix

* fix logic

- Julianne and Romulo now resurrect properly
- fight stops when both die within 10 seconds
- correct lines are being said, I think
- made the script a bit better overall

* fix codestyle?

* remove leftovers

* remove leftovers

* add spaces
2023-08-10 14:03:48 -03:00
Skjalf
808b8bf07a fix(Core/Arena): Fix LegacyArenaPoints logic (#16967) 2023-08-09 09:32:32 -03:00
Axel Cocat
5ba2c18ce6 feat(Core/Conf): add CONFIG_ARENA_QUEUE_ANNOUNCER_DETAIL (#16850)
* feat(Core/Conf): add CONFIG_ARENA_QUEUE_ANNOUNCER_DETAIL

* fix: bad copy paste

* add sql

* fix bad copy paste above again

* fix: move lang values

* Update rev_1690640715748711400.sql

* Update rev_1690640715748711400.sql

* Rename rev_1690640715748711400.sql to fix.sql

* reaching, maybe fix (?) c:

* love me god damn it

* update sql file

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-09 05:42:50 -03:00
Maria-sequel
1cd181f923 feat(Core/Config): Add Legacy Arena Points config option (#16940)
* feat:(Core/Config): Add legacy Arena points option

* Update IWorld.h

* Update World.cpp

* Update World.cpp

* typo

* Update worldserver.conf.dist

* Update worldserver.conf.dist

* Update World.cpp

* Update World.cpp

* defaults to true

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* config text

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/apps/worldserver/worldserver.conf.dist

* Update src/server/apps/worldserver/worldserver.conf.dist

* Update src/server/game/World/World.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com>
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-08-09 00:44:44 -03:00
Skjalf
f5e555082e fix(Core/Unit): Fix Arena Preparation aura being removed on player ac… (#16925)
fix(Core/Unit): Fix Arena Preparation aura being removed on player actions
2023-08-08 23:48:20 -03:00
Kitzunu
026fe7c962 fix(Core/Pets): Hunter pet scaling (#16959)
* fix(Core/Pets): Hunter pet scaling

* Fix pet scaling to properly take DBC data
* Edge case for Devilsaur where the DBC data is whack, therefore we use Spirit Beast data instead
* updated scale calculation based on client function (f09564b9d0)

Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* fix gcc

---------

Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2023-08-08 19:11:41 -03:00
Kitzunu
c866e17406 refactor(Core/Motd): Move motd to MotdMgr (#16933) 2023-08-06 23:02:54 +02:00
Gultask
0276b141a8 feat(Core/SmartAI): Implement castFlag THREATLIST_NOT_SINGLE (#16911)
* init

* Update SmartScript.cpp
2023-08-06 20:25:31 +02:00
Roddan
e08ceb3d8d fix(Script/Quest): Doing Your Duty (#16923)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-06 18:17:38 +02:00
v-mstrs
9eadbdf611 fix(Core/Spells): Warrior T5 2p (#16749)
* fix overpower bonus

* Update SpellInfoCorrections.cpp

* Update src/server/game/Spells/SpellInfoCorrections.cpp

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-06 03:32:52 +02:00
Maria-sequel
81a20d69de fix(Core/Spells): Silent Fang proc should not work in … (#16907)
fix(Spell/SpellInfoCorrections): Silent Fang proc should not work in arena
2023-08-06 03:21:01 +02:00
wenzuowei
ee154036bd fix(Core/Movement) Smoother movement of hunter pets when following players (#16796)
* Pets follow the player at the player's speed

* More accurate distance measurement
2023-08-06 03:19:23 +02:00
Timothy Vaccarelli
23a420acbb fix(Script/Quest): Arelion's Secret. Add combat sequence to Magister … (#15878)
* fix(Script/Quest): Arelion's Secret. Add combat sequence to Magister Aledis

Co-authored-by: SnapperRy

* Use single quotes for SQL

* Update based on review comments

Co-authored-by: SnapperRy <snapperryen@gmail.com>
2023-08-06 03:17:26 +02:00
Grimgravy
c3c6ce9d7a fix(DB/Quest): improve A Dip in the Moonwell (#15259)
* fix(DB/Quest): improve A Dip in the Moonwell

* Add Npc Steam Tonk

* Update rev_1677930037418943000.sql

* Atualizar o rev_1677930037418943000.sql
2023-08-06 03:16:19 +02:00
UltraNix
c3acf75618 fix(Core/Spells): Taunt always set proper target while channelling sp… (#13948)
* fix(Core/Spells): Taunt always set proper target while channelling spells.

Fixes #13841

* Update.

* Update.
2023-08-06 03:16:05 +02:00
Webdrian
226408329a fix(Core/Pets): Corret Pet size for normal and exotics & bigger pets (#16910)
* fix(Core/Pet)

Pet size fixed

* Update Pet.cpp

* Update Pet.cpp
2023-08-06 02:08:34 +02:00
Mathematical
9f1f305a41 fix(DB/SAI) Wood Mites should skitter around (#14806)
* Wood Mites

* Update rev_1675139356539586000.sql

* Update data/sql/updates/pending_db_world/rev_1675139356539586000.sql

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-04 17:01:20 +02:00
Johaine
f0a96b4489 fix(Scripts/EscapeFromDurnholde): Fix escort mission getting stuck (#16636)
Fix stuck event

Fix escort event possibly getting stuck by preventing
DATA_ESCORT_PROGRESS from being decreased
2023-08-02 14:52:18 -03:00
AiurJordan
f0a4612964 fix(Core/Pets) Pet scaling only being applied to pets with DB Entry (#16401) 2023-08-02 14:51:11 -03:00
Skjalf
90675cab30 fix(Core/Battleground): Fix auto arena flush interval (#16877) 2023-08-02 14:45:59 -03:00
Skjalf
b3eb43a113 fix(Scripts/Commands): Allow using flusharenapoints from console (#16879) 2023-08-02 14:44:13 -03:00
Skjalf
93113edc7d fix(Scripts/MagtheridonLair): Script Manticron Cube conditions (#16867)
* fix(Scripts/MagtheridonLair): Script Manticron Cube conditions

Co-Authored-By: Lucas Nascimento <keader.android@gmail.com>

* Create rev_1690769530684832000.sql

Co-Authored-By: Lucas Nascimento <keader.android@gmail.com>

* missing include

* warning

---------

Co-authored-by: Lucas Nascimento <keader.android@gmail.com>
2023-08-01 16:11:12 -03:00