Commit Graph

93 Commits

Author SHA1 Message Date
Kargatum
a2b26272d2 refactor(Core/Game): restyle game lib with astyle (#3466) 2020-10-12 10:08:15 +02:00
Francesco Borzì
b61ae8abcd fix(Core/Misc): all GCC warnings (#3457) 2020-09-14 17:31:12 +02:00
Kitzunu
1f89282b22 refactor(Core): NULL -> nullptr (#3275)
* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

* NULL to nullptr

Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2020-08-31 11:55:09 +02:00
Kitzunu
dd40e2e844 fix(Core/SpellAuras): Show auras to client limit (#3193)
Co-authored-by: Pascal Bachor <gerhood@users.noreply.github.com>
2020-08-22 10:34:12 +02:00
IntelligentQuantum
5d284f02a7 feat(Core/SendListInventory): Add multivendor function (#3172) 2020-08-20 11:00:11 +02:00
Francesco Borzì
2bc832efe3 fix(CI/Core/ArenaSpectator): clang warnings + prevent new warnings (#3317)
Co-authored by @meerd
2020-08-19 19:44:07 +02:00
Francesco Borzì
d2cc3fcbc2 feat(Docker): update to Ubuntu 20.04 + more improvements (#3277) 2020-08-13 00:25:20 +02:00
Kitzunu
64778f8dec feature(World/Config): Implement MaxWhoListReturns (#3127) 2020-08-04 22:36:01 +02:00
Stefano Borzì
fdb84742d1 fix(Core/MailHandler): Prevent client crash while receiving a malformed mail (#3223)
* Fix an issue in the MailHandler that let you crash the users client.
2020-07-28 11:02:09 +02:00
Kitzunu
3d9d51977d fix(Core/MailHandler): Security check (#2889) 2020-06-03 08:42:12 +02:00
Stefano Borzì
3c5bb73f29 fix(Core/ChatHandler): Prevent messages > 255 characters (#3063) 2020-05-27 08:50:21 +02:00
TheWatchingI
c7f4204d1f fix(Core/Pet): Risen Ghoul random name & pet detail (#2945)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2020-05-23 15:38:38 +02:00
Kitzunu
55dc9afc73 feat(Core/Battleground): Config to allow/disallow ability to Share Quest & Ready Check (#2924) 2020-05-22 16:54:17 +02:00
IntelligentQuantum
c9b7c75e1e feat(Core/conf): Move arena charters cost to config (#2790)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2020-05-04 12:01:19 +02:00
Stefano Borzì
ad6985f459 fix(core/packet): prevent client crash from malformed packet/message (#2910)
* Update AuctionHouseHandler.cpp

* fix(core/packet): prevent crash from malformed string
2020-04-21 00:00:26 +02:00
Viste
1432f17c32 fix(Core/Mail): Mailhandler cleanup (#2802) 2020-04-15 12:23:30 +02:00
Amin.MasterkinG
378cd6fe28 fix(core): "Silenced - You can only chat with GMs" spell (#2716) 2020-04-04 11:01:11 +02:00
arenacraftwow
cfdbf00afe fix(Core/Hook): OnFirstLogin can now make persistent changes (#2793)
PlayerScript#OnFirstLogin was broken in that if you tried to teach the
player a spell or give an item to him that change wouldn't persist.
Meaning that the next time the Player would log in, his awarded spells
or items would be gone.

Meanwhile PlayerScript#OnLogin didn't have this behavior meaning
that the sematics of PlayerScript#OnFirstLogin and PlayerScript#OnLogin
where very different, which is unexpected.

This issue was caused by an implementation detail in Player#learnSpell
(and similiar) which behaves differently depending on
Player#isBeingLoaded phase. This code change makes its that
PlayerOnFirstLogin hook executes when Player#isBeingLoaded == false
fixing the issue.

Alternatives: The fact that Player#learnSpells and others behave
differently depending on the load phase is questionable and from my
research it seems like this impl detail is only used when giving the
player his template spells. We could add a overload to
Player#learnSpell with a flag like `isSpellTemporary` and make
the template spells loading use it. Then we would be able to remove
this implicit temporary spell mechanism when Player#isBeingLoaded
thing.  However this is a deeper change and not worth the risk.
2020-04-01 20:16:00 +02:00
Nefertumm
bb6047248a fix(Calendar/Packets): add additional validation when creating events (#2799) 2020-03-28 22:47:53 +01:00
Stefano Borzì
5ef98b95c9 chore(Core/AH): Restore little comment (#2702) 2020-03-25 20:40:25 +01:00
Nefertumm
8d6bf1f4dc Fix(Core/Packet): Calendar events exploits (#2753)
* Calendar handler exploit fix

* Travis and sugestions

* What a noob <.<
2020-03-17 22:11:07 +01:00
Francesco Borzì
8231a7cc1a fix(GameObject/Quest): GameObject quest / gossip window (#2676)
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-15 10:09:25 +01:00
Stefano Borzì
ce2f622ef0 fix(core/packet): check malformed guild packet to prevent client crash (#2739)
* Update AuctionHouseHandler.cpp

* fix(core/packet): prevent crash for malformed guild message

* fix(lint): fix codacy warnings
2020-03-07 10:12:16 +01:00
Stoabrogga
2eb0705668 fix(Core/Pet): only show pet details for hunter pets and demons (#2637) 2020-02-28 17:02:54 +01:00
Stefano Borzì
0749a861aa fix(Core): build with ENABLE_EXTRA_LOGS (#2709) 2020-02-27 08:04:24 +01:00
Amin.MasterkinG
17fc93d864 fix(Core/Crash): remove unneeded hook OnPlayerChat (#2707) 2020-02-26 08:03:18 +01:00
Stefano Borzì
9e307455a8 refactor(HandleAuctionListOwnerItems): prevent crash (#2684) 2020-02-24 08:40:02 +01:00
Shard
35b6bedd81 fix(Core/DK): Don't allow starter dk to queue bg (#2584) 2020-01-26 16:25:48 +01:00
Kaev
999d588c37 fix(Core): Fixed a few crashes/bugs that were found via static code analysis (#2617) 2020-01-25 14:26:38 +01:00
Shard
067d9e791f fix(Core/Battlegrounds) Rewrite RandomBG and enabling bg/arenas weights (#2516) 2019-12-28 09:40:13 +01:00
Stoabrogga
b776e68665 fix(Core/Spell): Glyph of Eternal Water (#2508) 2019-12-26 09:09:50 +01:00
Kargatum
4a8f1de538 feat(Core/Misc): remove and replace ACE_Singleton (#2418) 2019-12-21 00:29:29 +07:00
IntelligentQuantum
ae810491e7 fix(Core/ItemHandler): crash buy back item (#2511) 2019-12-19 07:48:26 +01:00
IntelligentQuantum
b6c0f58dda feat(Core/ItemHandler): Optional item recovery (#2442) 2019-12-09 08:03:33 +01:00
Viste
e22d78ecd6 refactor(Core): rename namespaces and macros to acore (#2454) 2019-12-01 13:13:31 +01:00
Viste
7a1ac8245b feat(Core/PacketIO): restrict CMSG_EMOTE/CMSG_STANDSTATECHANGE to only allow emotes/stand states that client can send by itself (#2412)
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2019-11-15 16:28:54 +07:00
Stefano Borzì
ab637800e7 fix(Core): prevent movement exploit (#2410) 2019-11-15 10:03:57 +01:00
Kargatum
23b77c1303 fix(Core/MovementHandler): fix crash at null guid in mover (#2426) 2019-11-13 20:51:36 +07:00
Viste
854b426978 feat(Core): Added ABORT() macro to prevent the usage of ASSERT(false) as a quick hack to crash the core misusing assert (#2273) 2019-09-26 09:51:33 +02:00
GMKyle
58f3cfe387 fix(Core/Hunter): Stable Master, exotics pets management, tame validations. (#2100) 2019-09-25 18:29:18 +02:00
mik1893
67d180ea77 fix(Core/Worldsession): add option to prevent logout when AFK in a sanctuary zone (#2205) 2019-09-09 23:53:37 +02:00
LichKing255
3aeb2e564d fix(Core): Build error concerning debug log message (#2265) 2019-09-05 22:33:06 +02:00
Stoabrogga
dbfa66c698 fix(DB/Core): "Sons of Hodir" quests / areas (#2231) 2019-09-04 16:43:44 +02:00
Francesco Borzì
0b88e24808 refactor(ItemTemplate): add missing enums + other minor improvements (#2236) 2019-08-26 20:43:53 +02:00
Kargatum
d40e894618 feat(Core/CFBG): Added support module mod-cfbg (#2064)
https://github.com/Winfidonarleyan/mod-cfbg - Original module
https://github.com/azerothcore/mod-cfbg - the fork in AC
2019-08-06 09:21:11 +07:00
Amin.MasterkinG
502d8fc14b Fix client game crash with invite player to invalid name for Channel. (#2087)
* Fix client game crash with invite player to invalid name for Channel.

7b8f294c02

https://github.com/TrinityCore/TrinityCore/issues/23215

* Change `#include <utf8.h>` to `#include "utf8.h"`
2019-07-26 15:25:10 +02:00
Poszer
e14964c52b fix(Core/Wintergrasp): Leaving Wintergrasp with the minimap button (#2018) 2019-07-04 09:01:24 +02:00
Poszer
97e65bd447 feat(Core/Player): PartyLevelReq invite settings (#1919)
- Minimum level at which players can invite to group setting
2019-06-09 09:03:18 +02:00
Shard
0e08350b69 fix(Core/Spells): Shaman Reincarnation (#1844) 2019-05-28 14:29:31 +02:00
Kargatum
824a80005c Refactor(Core/Misc): Remove remaining COMPILER_HAS_CPP11_SUPPORT related macros (#1627)
* Delete macros UNORDERED_MAP
* Delete macros UNORDERED_SET
2019-03-26 00:01:56 +07:00