* enable CREATURE_FLAG_EXTRA_USE_OFFHAND_ATTACK
* sql set CREATURE_FLAG_EXTRA_USE_OFFHAND
* use new HasOffHandWeaponForAttack instead of haveOffhandWeapon
no longer requires m_CanDualwield set to use Offhand attack
requires non-disarmed weapon in Offhand OR creature_flag_extra enabled
Co-authored-by: Ovah <dreadkiller@gmx.de>
Co-authored-by: Warlockbugs <warlockbugs@outlook.com>
* Make shapeshift forms which dont override attack speed use weapon damage
Co-authored-by: killerwife <killerwife@gmail.com>
* SetEquipmentSlots turning off damage update when using template default
Co-authored-by: killerwife <killerwife@gmail.com>
* Setup DualWield & Damage On Equipment Updates, implement Set and GetVirtualItem
Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com>
* creature disarm damage
set disarm to reduce minmax damage by 50% instead of setting to 0
Co-authored-by: Warlockbugs <warlockbugs@outlook.com>
---------
Co-authored-by: Ovah <dreadkiller@gmx.de>
Co-authored-by: Warlockbugs <warlockbugs@outlook.com>
Co-authored-by: killerwife <killerwife@gmail.com>
Co-authored-by: Yatzii <47720837+Yatzii93@users.noreply.github.com>
If a spell is both channeled and has SPELL_ATTR0_COOLDOWN_ON_EVENT
attribute (only rituals) is channeled for its full duration, it goes on
an infinite cooldown. The client needs to be notified when the ritual
ends without being completed.
* Init.
* Allow self-summoning.
* Revert unintended change.
Self-summoning still works fine without this being removed, I see no harm in putting it back.
Channel the same spell as the original caster when clicking on a ritual
portal, but ignore the effects of the spell.
Co-authored-by: killerwife <killerwife@gmail.com>
* chore(Core/DBC): define unused unknown dbc fields
* Name unused unknown dbc fields using WDBX and wowdev.wiki
* rename SpellShapeshiftEntry to SpellShapeshiftFormEntry to properly match the DBC used
* rename sSpellShapeshiftStore to sSpellShapeshiftFormStore to properly match the DBC used
* Comment out unused field for GlyphPropertiesEntry
* Comment out unused field for MapEntry
* forgot one
* SpellShapeshiftfmt to SpellShapeshiftFormfmt
* SpellShapeshiftFormEntryfmt
* skip other effects in case of taunt DR
* set flags_extra creature_template
fe38b78c87
Co-authored-by: offl <offl@users.noreply.github.com>
* update query to only entries found in acore_world.creature_template
* add name as comment
* fix ci codestyle
---------
Co-authored-by: offl <offl@users.noreply.github.com>
fix(Core/Spells): Don't send SMSG_CAST_FAILED for interrupted spells after they were launched or channelling was started (this clears cooldown on client)
https: //github.com/TrinityCore/TrinityCore/commit/63bc405faeb7afcf99de6f7531e4ea59065165f4
Co-authored-by: Shauren <shauren.trinity@gmail.com>
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
