Commit Graph

2354 Commits

Author SHA1 Message Date
Barbz
9d0ebcd8ea style(DB): battelground_template entries now commented by type (arena or bg) (#2722)
- Can be useful for people who don't know WOW by heart
- Can be used to select only arenas or only battlegrounds
- Added full name for Nagrand Arena
2020-04-02 20:45:00 +02:00
arenacraftwow
cfdbf00afe fix(Core/Hook): OnFirstLogin can now make persistent changes (#2793)
PlayerScript#OnFirstLogin was broken in that if you tried to teach the
player a spell or give an item to him that change wouldn't persist.
Meaning that the next time the Player would log in, his awarded spells
or items would be gone.

Meanwhile PlayerScript#OnLogin didn't have this behavior meaning
that the sematics of PlayerScript#OnFirstLogin and PlayerScript#OnLogin
where very different, which is unexpected.

This issue was caused by an implementation detail in Player#learnSpell
(and similiar) which behaves differently depending on
Player#isBeingLoaded phase. This code change makes its that
PlayerOnFirstLogin hook executes when Player#isBeingLoaded == false
fixing the issue.

Alternatives: The fact that Player#learnSpells and others behave
differently depending on the load phase is questionable and from my
research it seems like this impl detail is only used when giving the
player his template spells. We could add a overload to
Player#learnSpell with a flag like `isSpellTemporary` and make
the template spells loading use it. Then we would be able to remove
this implicit temporary spell mechanism when Player#isBeingLoaded
thing.  However this is a deeper change and not worth the risk.
2020-04-01 20:16:00 +02:00
Barbz
ea709de58b fix(app/db_assembler): Allow recursion with bash (#2731)
- Before that commit, the recursion with "**" stopped after the first directory
2020-03-31 23:34:20 +02:00
Stefano Borzì
19c3a70d41 feat(Core/Config): make stop time for creatures with WP movement configurable #2715 (#2829)
Original author Stoabrogga
2020-03-31 01:30:39 +02:00
AzerothCoreBot
633ef83b47 Import pending SQL update file...
Referenced commit(s): 71f98abc2c
2020-03-30 00:27:37 +00:00
LukasVolgger
71f98abc2c fix(DB/creature_formations): Thal'trak Proudtusk pathing (#2724)
Use creature_formations instead of pathing for each npc. This avoids that they get out of sync after a while or get stuck.
2020-03-30 02:08:14 +02:00
AzerothCoreBot
386ee6f162 Import pending SQL update file...
Referenced commit(s): 2fd2984cb2
2020-03-29 21:05:18 +00:00
LukasVolgger
2fd2984cb2 fix(DB/creature_formations): Moon Priestess Amara pathing (#2711) 2020-03-29 23:02:47 +02:00
AzerothCoreBot
f9f3efe0d3 Import pending SQL update file...
Referenced commit(s): ccb1d813f6
2020-03-29 01:13:01 +00:00
Kitzunu
ccb1d813f6 feat(DB/Creature): Add missing Little Adeline NPC #2747
Originally from 9ed27e7d58
2020-03-29 03:10:26 +02:00
Nefertumm
bb6047248a fix(Calendar/Packets): add additional validation when creating events (#2799) 2020-03-28 22:47:53 +01:00
AzerothCoreBot
1411336dcb Import pending SQL update file...
Referenced commit(s): 76bdbae9f4
2020-03-28 01:47:32 +00:00
LukasVolgger
76bdbae9f4 fix(DB/reputation): Sporeggar repeatable quest reputation rate (#2698)
The 2 repeatable quests of faction 970 had a wrong rate x3 instead of
x1.

Co-authored-by: Endeffect93 <55922592+Endeffect93@users.noreply.github.com>
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-28 02:44:50 +01:00
Nefertumm
f5e38a7f57 Fix(Core/Packets/AntiDOS): Remove from default some repetitive movement packets (#2809) 2020-03-26 21:51:10 -03:00
AzerothCoreBot
fcc81ed0a2 Import pending SQL update file...
Referenced commit(s): a21e24d746
2020-03-26 18:35:12 +00:00
LukasVolgger
a21e24d746 fix(DB): Marsh Lurker spawn position (#2697)
Creature guid 64845 had wrong coordinates in position_z

Co-authored-by: Endeffect93 <55922592+Endeffect93@users.noreply.github.com>
2020-03-26 19:32:31 +01:00
Stefano Borzì
5ef98b95c9 chore(Core/AH): Restore little comment (#2702) 2020-03-25 20:40:25 +01:00
Stefano Borzì
19144d8bff fix(Core/Pet): Pet chase range check for melee ranged spells (#2694)
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-25 17:34:04 +01:00
Viste
fa57954ff9 fix(DB): error on default MySQL install (#2776) 2020-03-24 23:06:53 +01:00
AzerothCoreBot
cfcd81ff5d Import pending SQL update file...
Referenced commit(s): 566f86b6b6
2020-03-24 18:29:08 +00:00
LukasVolgger
566f86b6b6 feat(DB/lang): Import german quest_request_items texts from GTDB (Part 2/4) (#2692)
Co-authored-by: Endeffect93 <55922592+Endeffect93@users.noreply.github.com>
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-24 19:26:26 +01:00
Nefertumm
b868f0ad04 Revert "Fix(Core/Gameobjects): non-consumable goobers no longer despawn on use (#2750)" (#2797)
This is causing troubles with veins and bg gameobjects (those are known)
This reverts commit 0521a314b5.
2020-03-24 03:44:40 -03:00
Nefertumm
846f7862d8 feat(Core/Packet): Implement AntiDOS protection from Trinity (#2789)
* Implement AntiDOS protection from Trinity


Co-authored-by: jackpoz <giacomopoz@gmail.com>
Co-authored-by: Shauren <shauren.trinity@gmail.com>
Co-authored-by: Vincent-Michael <trinity.michael_vincent@gmx.eu>
2020-03-23 15:46:00 -03:00
Kitzunu
c5a7497f4d fix(Core/Gossip): fix titles in quest reward being able to show in gossip (#2791)
Co-Authored-By: Wyrserth <wyrserth@users.noreply.github.com>
2020-03-23 23:40:15 +07:00
AzerothCoreBot
5b093d3a67 Import pending SQL update file...
Referenced commit(s): 49424be66e
2020-03-22 21:46:57 +00:00
LukasVolgger
49424be66e fix(DB/creature): Remove duplicates Cenarion Stormcrow (#2708)
The 2 creatures with guid 84366, 84368 are wrong and will be removed.

Co-authored-by: Endeffect93 <55922592+Endeffect93@users.noreply.github.com>
2020-03-22 22:44:16 +01:00
Kitzunu
0521a314b5 Fix(Core/Gameobjects): non-consumable goobers no longer despawn on use (#2750)
Taken from 50c5d30d13 & 2b1e8d135b


Co-authored-by: Wyrserth <wyrserth@protonmail.com>
2020-03-21 22:29:52 +01:00
Francesco Borzì
3cf3f69e13 fix(Core/Spell): Melee ranged spells (#2686)
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-20 18:52:30 +01:00
AzerothCoreBot
8c8d2fb88f Import pending SQL update file...
Referenced commit(s): 6daaa5b7dc
2020-03-19 18:44:39 +00:00
Stefano Borzì
6daaa5b7dc fix(DB/creature_template): PvP flagged creatures in Talon Den (#2681)
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-19 19:41:51 +01:00
Viste
ef5d6eae9b Core/Misc: Remove dependency on undefined behaviour (#2678)
Co-authored-by: Ujp8LfXBJ6wCPR <github@lillecarl.com>

Co-authored-by: Ujp8LfXBJ6wCPR <github@lillecarl.com>
2020-03-18 20:07:59 +01:00
Nefertumm
8d6bf1f4dc Fix(Core/Packet): Calendar events exploits (#2753)
* Calendar handler exploit fix

* Travis and sugestions

* What a noob <.<
2020-03-17 22:11:07 +01:00
AzerothCoreBot
1668b765ad Import pending SQL update file...
Referenced commit(s): 4cf3a792f7
2020-03-16 21:05:49 +00:00
Kitzunu
4cf3a792f7 fix(DB/Gameobject): Secret Safe loot (#2738)
- Fix wrong groupid and loot chances
- refactor: Use more logical ID

Co-authored-by: Barbz <BarbzYHOOL@users.noreply.github.com>
2020-03-16 21:30:34 +01:00
AzerothCoreBot
f1e21f2ca5 Import pending SQL update file...
Referenced commit(s): 8231a7cc1a
2020-03-15 09:11:55 +00:00
Francesco Borzì
8231a7cc1a fix(GameObject/Quest): GameObject quest / gossip window (#2676)
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-15 10:09:25 +01:00
Stefano Borzì
ec91c779f3 fix(Core/SAI): SMARTCAST_COMBAT_MOVE (#2672)
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-14 17:41:03 +01:00
AzerothCoreBot
c09b3e6d2b Import pending SQL update file...
Referenced commit(s): 1500a643d4
2020-03-12 20:07:11 +00:00
Stefano Borzì
1500a643d4 fix(DB/Quest): Shaman quest "Earth Sapta" (#2663)
Co-authored-by: Stoabrogga <38475780+Stoabrogga@users.noreply.github.com>
2020-03-12 21:04:36 +01:00
AzerothCoreBot
d131840f34 Import pending SQL update file...
Referenced commit(s): fe28247fdc
2020-03-11 22:33:43 +00:00
Volgger
fe28247fdc feat(DB/lang): Import german quest_offer_reward texts from GTDB (Part 1/4) (#2670) 2020-03-11 23:31:10 +01:00
AzerothCoreBot
a4973304ab Import pending SQL update file...
Referenced commit(s): e72371ee4a
2020-03-09 21:56:49 +00:00
Alan
e72371ee4a fix: Zul'Aman raid improvements (#2654) 2020-03-09 22:54:18 +01:00
Barbz
2eeab4c72b fix(apps): Script for default git commit template returns output (#2642)
- Before that, it didn't return anything and could confuse people
2020-03-08 18:21:18 +01:00
Stefano Borzì
ce2f622ef0 fix(core/packet): check malformed guild packet to prevent client crash (#2739)
* Update AuctionHouseHandler.cpp

* fix(core/packet): prevent crash for malformed guild message

* fix(lint): fix codacy warnings
2020-03-07 10:12:16 +01:00
Kitzunu
ed4d95f98e fix: TC link and fix spacing (#2737) 2020-03-06 18:43:42 +01:00
Barbz
7aad17433d chore(README): Add linkedin link (#2723) 2020-03-05 19:34:14 +01:00
AzerothCoreBot
cb251f63a3 Import pending SQL update file...
Referenced commit(s): 1c23bf4024
2020-03-04 21:05:36 +00:00
Barbz
1c23bf4024 fix(DB/quests): Added german locale for "Ashenvale Hunt" (#2730)
- Updated quest texts 2, 23 and 24 to patch stand 3.3.5a
2020-03-04 22:03:01 +01:00
gengarshadowball
95251dfd2d fix(Core/Dungeon): Halls of stone doors (#2646)
* Improved logic and DX

Simplified the Developer Experience reading such a messy code and removed some duplicated useless conditions

* fix(core/dungeon): Halls of stone door

The door is closed before Maiden of Grief and Krystalus die.

* Revert "Merge commit 'refs/pull/2634/head' of https://github.com/azerothcore/azerothcore-wotlk into pr-2634"

This reverts commit 04e8ac45e4d868eda4a89229f3721ee699ba4be5, reversing
changes made to 2fa9f5c249.

* Review changes

* improvement to check

Co-authored-by: Yehonal <yehonal.azeroth@gmail.com>
2020-03-03 14:00:40 +01:00