* fix(Core/Spell): Allow using SpellDifficulty in bg
* cherry-pick commit (e4caf52e5a)
* "Allow get SpellDifficulty on battleground maps
This is only for Isle of Conquest (Bracket 71-79 is Regular Difficulty, Bracket 80-84 is heroic or 25Man)
Spells of IoC Battleground vehicles, cannons, bombs and bosses have SpellDifficulty in DBC"
* Remove redundant CastSpell and assign a variable instead
Co-Authored-By: Gildor <521036+Jildor@users.noreply.github.com>
* Update isle_of_conquest.cpp
---------
Co-authored-by: Gildor <521036+Jildor@users.noreply.github.com>
* fix(Script/GunshipBattle): Wipe if no player is on the deck
* reorder
* Update boss_icecrown_gunship_battle.cpp
* Update worldserver.conf.dist
* Update boss_icecrown_gunship_battle.cpp
* missed it!
* Update instance_icecrown_citadel.cpp
* fix(CORE/Raid): Anub'Arak not using proper spell to clear his debuffs on submerge
Anub'Arak (id: 34564) was using the RemoveAllAuras method instead of the ClearAllDebuffs spell to clear all his debuffs when submerging.
Closes AzerothCore issue #19136
* fix(instace/Azjol'Nerub): Anub'Arak not removing debuffs on submerge
anub'arak was not removing his debuffs on submerging with the right spell.
closes issue #19113
* Update boss anub'arak of PR #19140
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
* Update boss Anub'Arak code improvement
* Update boss anub'arak
* Update src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_anubarak_trial.cpp
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
* Update boss_icecrown_gunship_battle.cpp
Makes the Cannons on Gunship Blizzlike. They generate power (heat) on cast and not on Hit. Removes Engergize from Spell 69399 cause its only triggers on target->hit in core
Still uses spellscript effect but on cast instead
* Update boss_icecrown_gunship_battle.cpp
* fix the sleep visual, add stand up event
* make Mimi selectable during outro
so you can see his faction change
* talk with emote oneshot talk
* fix selectable
* adjust timings
* set done status when chest spawns
* combat should stop when Mimiron ejects
* Revert "combat should stop when Mimiron ejects"
This reverts commit 6e476a55a49c33109f9112b2782d0d186eef49f3.
* style
* add cooldown to proc
* convert to spell and aurascript pair macro
* remove no longer needed validate override
* set cooldown with Cooldown field in table spell_proc_event
* gossip keepers, keepers, sara
freya spell
improvements
better gossip
update
converter to update spellscript
refactor sanity wells spawn position, summons zonecombat
make sara summon sanity wells again
thorim casts start again, handle sanity wells only by sanity well spawn
script
refactor sanity
brackets
update comment
gossip keepers, keepers, sara
freya spell
improvements
better gossip
update
converter to update spellscript
refactor sanity wells spawn position, summons zonecombat
make sara summon sanity wells again
thorim casts start again, handle sanity wells only by sanity well spawn
script
refactor sanity
brackets
update comment
gossip keepers, keepers, sara
freya spell
improvements
better gossip
update
converter to update spellscript
refactor sanity wells spawn position, summons zonecombat
make sara summon sanity wells again
thorim casts start again, handle sanity wells only by sanity well spawn
script
refactor sanity
brackets
update comment
gossip keepers, keepers, sara
freya spell
improvements
better gossip
update
converter to update spellscript
refactor sanity wells spawn position, summons zonecombat
make sara summon sanity wells again
thorim casts start again, handle sanity wells only by sanity well spawn
script
refactor sanity
brackets
update comment
* refactor: remove _keepersGUID[4]
* make keeper auras only target players, remove apply scale immunity to well/keepers
include caster in cast
* update keeper flags
* summon and despawn gossip keepers
spawn only if fight done
add intro spell and handle outro
fix off by 1
fix casting simple teleport, only spawn after teleporting
remove empty line
* add teleport to shared ulduar.h
* each keeper triggers their own gossip spawn
* update is called in Reset(), no need to do it here
* add SpellHit override to Freya, Hodir
* Freya, Hodir: use scheduler to schedule post-fight teleport
* JustSummoned rename cr to summon
* sanity well summons are handled by freya instead of sara
* rename pCreature to creature
* keeper use RegisterUlduarCreatureAI
* Freya, Hodir, Thorim: increase despawn time
* despawn tentacles, sanity wells after fight
despawn tentacles after fight
* change order of teleport spells
* am missing header?
* WIP maexxna web wrap
* add custom summon web wrap
* progress
* save
* something that works
* update sql
* cleanup script
* clean sql
* remove orientation from position
* fix: cast web wrap on multiple targets
* fix: web wraps should not attack
* adjust vertical speed to reduce speed if close, avoid ceiling yeet
* rename candIt to itr
* remove unused wraps2
* style
* use event instead of update(diff)
* update spell_dbc sql
* include player header to fix error: invalid use of incomplete type
* include SpellAuraEffects header
* fix Effects start at 1 in DBC
* fix web wraps attacking
* calc distance with hypotf, define vspeed ranges, remove trig webwrap enum
* fixup! calc distance with hypotf, define vspeed ranges, remove trig webwrap enum
* fix: call target selection with pos 0, use IsPlayer()
* add validate
* fixup! fix: call target selection with pos 0, use IsPlayer()
* remove not needed header
* remove empty lines
* use registry macro
* Revert "remove not needed header"
This reverts commit 254717d27e196a1ec108db5a5e29e37e9e2237a6.
* (Instance/Culling of Stratholme) removed duplicated gossip_menus, fixed hardcoded texts
* Update culling_of_stratholme.sql
* Update culling_of_stratholme.sql
* (Instance/TrialOfTheCrusader) fixed hardcoded text from Jaraxxus text line
boss_twin_valkyr: removed unnececarry random txt line select (already exist groupid 6 id 0 and 1 in creature_text)
added ruRU locale for Acidmaw and Dreadscale GroupID 2
* move sqls
* Update culling_of_stratholme.sql
* Update data/sql/updates/pending_db_world/culling_of_stratholme.sql
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
* Update culling_of_stratholme.sql
* update naming of variables to better understand the sequence of events
* Change locale attribute to Locale
I'm not 100% sure, but since in Linux, uppercase and lowercase letters represent different values, I think that's why it doesn't pass the tests. In Windows nothing happens, but in Linux there are 2 different attributes.
* strange MySQL in Linux
* Update trial_of_crusader.sql
* updated sequence of txt lines with cityman before Malganis appear according to @Trinitycore enum RPEventLines2
combine all SQL in 1 file
---------
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Walter Pagani <paganiwalter@gmail.com>
* fix(Core/Creature): Prevent combat movement disabled creatures from repositioning if target moves within model boundary
* fixbuild
* Apply suggestions from code review
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
* fix(Scripts/Dalaran): Update Toy Shop Toy Plane behaviour based on sniffs
* update comments and waypoints for smoother movement
* move initalization to Reset() function
* fix(DB/Creature): Grunda Bronzewing is now mounted
Grunda Bronzewing is now mounted
* Update Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql
Grunda Bronzewing is now mounted
* Rename Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql to Fix-Grunda.sql
Grunda Bronzewing is now mounted
* Delete Fix-Grunda.sql
* Create fix_quest_12862_13060.sql
* Update zone_storm_peaks.cpp
* Update zone_storm_peaks.cpp
* Update zone_storm_peaks.cpp
* Update zone_storm_peaks.cpp
* Update zone_storm_peaks.cpp
* clean up redundancy
* Update fix_quest_12862_13060.sql
* Update zone_storm_peaks.cpp
* Update src/server/scripts/Northrend/zone_storm_peaks.cpp
* Update zone_storm_peaks.cpp
* fix_quest_12862_13060.sql
* delay spell cast by 1 sec
* Update zone_storm_peaks.cpp
---------
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
* fix(DB/Creature): Grunda Bronzewing is now mounted
Grunda Bronzewing is now mounted
* Update Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql
Grunda Bronzewing is now mounted
* Rename Fix-Grunda Bronzewing in Honor Hold is not riding on a golden gryphon.sql to Fix-Grunda.sql
Grunda Bronzewing is now mounted
* Delete Fix-Grunda.sql
* Update zone_sholazar_basin.cpp
* Update zone_sholazar_basin.cpp
