Commit Graph

115 Commits

Author SHA1 Message Date
sudlud
87c3421262 fix(Scripts/Midsummer): Improve Torch Catching based on sniffs (#18071)
- Update creature 26188 '[PH] Torch Catching Target Bunny' with sniffed values
- correctly randomize torch target positions
2024-01-01 09:06:54 -03:00
sudlud
1710d4d1c3 fix(Scripts/Midsummer): Implement Midsummer Bonfire mechanics (#18023) 2023-12-25 03:06:15 -03:00
sudlud
f2007aa59e refactor(Scripts/Midsummer): use scheduler provided by CreatureAI (#17955) 2023-12-08 23:44:51 +01:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
sudlud
09d9a0b73f fix(Scripts/Midsummer): AuraEffectRemoveFn -> AuraEffectApplyFn (#17793) 2023-11-19 13:28:38 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Ludwig
cb483d124f fix(Script/Spell): fix AOE circle bug on Midsummer Torch Catching (#17654)
* fix(Spells/Midsummer): fix script for spell 46747 SPELL_FLING_TORCH_DUMMY

* SpellInfoCorrections: fix target of spell 46747 Fling torch

* DB: assign spell 46747 Fling torch to item 34833 Unlit Torches

* remove whitespaces at src/server/game/Spells/SpellInfoCorrections.cpp:4610
2023-11-09 00:19:57 +01:00
Ludwig
630b90a633 fix(Scripts/Midsummer): Implement Ribbon Pole dance effects (#17417)
* fix(Scripts/Midsummer): Implement Ribbon Pole dance effects

* midsummer.cpp: remove whitespaces at end of lines

* midsummer.cpp: fix unused parameter error

* add spacing after 0.0f

* replace Milliseconds(...) by ...ms and Seconds(...) by ...s

* cleanup comments

* remove manual cleanups / despawns from DoCleanupChecks()

- rely on NPC despawn timers
- manual cleanup / removal actually is a bit excessive

* set INTERVAL_DANCING_FLAMES to 15s

* set despawn time to 1min for big dancing flames according to spell 46827

* set spawnDist to 12 for big dancing flames according so spell 46827

* use library function Acore::Containers::RandomShuffle() to shuffle _danclerList

* sql: do not set SmartAI for NPC 17066

already using ScriptName and can't have both

* combine 3 sql files into 1

* remove INTERVAL_... enum values

* remove unnecessary checks of if(_bunny)

* sql: fix smartscript comment

* rename spell define to correct spell name
2023-10-18 14:22:26 +02:00
avarishd
ad66728973 fix(DB/Creature): Drunken Brewfest Reveler model (#17494)
* fix(DB/Creature): Drunken Brewfest Reveler model

* clarify enum

+ farm lines
2023-10-17 15:37:53 -03:00
Ludwig
de50ce3305 fix(Scripts/Midsummer): Randomize ribbon pole beam color (#17380)
* fix(Scripts/Midsummer): Randomize ribbon pole beam color

* Update data/sql/updates/pending_db_world/rev_1695820418952974700.sql

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>

* Add Validate() to spell script spell_midsummer_ribbon_pole

---------

Co-authored-by: Dan <83884799+elthehablo@users.noreply.github.com>
2023-10-01 09:26:18 +02:00
Ludwig
1004dae7e5 refactor(Scripts/Midsummer): Add/Update Validate() for spell checks (#17390) 2023-09-30 09:54:27 +02:00
Ludwig
7a1c303d49 refactor(Scripts/Midsummer): Assign enum values to gameobjects and sp… (#17379)
* refactor(Scripts/Midsummer): Assign enum values to gameobjects and spells

* rename GO_TORCH_TOSS_TARGET_BUNNY to NPC_TORCH_TOSS_TARGET_BUNNY

* add more enum values to enum flingTorch
2023-09-29 18:30:35 +02:00
AG
2779833768 feat(Core/Grids): Implement visibility notifier (#15919)
* Cherry-picked from TrinityCore (unable to find author)
2023-09-28 22:28:28 +02:00
Ludwig
6649ad08d7 fix(Scripts/Midsummer): Make beam target Ribbon Pole top (#17358)
* fix(Scripts/Midsummer): Make beam target Ribbon Pole top

progress #12145

* refactor(Scripts/Midsummer): shorten spell_midsummer_ribbon_pole_visual::UpdateTarget
2023-09-26 18:51:59 -03:00
Ludwig
e2e393502c fix(Scripts/Midsummer): Add missing torch shadows (#17323) 2023-09-24 16:24:33 -03:00
Grimgravy
6990a1d2a4 fix(Scripts/Quest): improve Catch the Wild Wolpertinger! (#17333) 2023-09-24 16:23:58 -03:00
Ludwig
58f8fe6426 refactor(Scripts/Midsummer): Remove old unused code for spell 45644 (#17324)
- spell 45644 used to be linked to spell_midsummer_juggling_torch

- spell 45644 was later linked to new implementation
  spell_midsummer_torch_catch in e1e4c6cddc

- old implementation of spell 45644 was never removed from
  spell_midsummer_juggling_torch
2023-09-23 18:55:45 -03:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Gultask
c0bbb52483 fix(Scripts/Midsummer): Stop Bonfires from spawning more gameobjects (#16618)
* Update midsummer.cpp

* .
2023-06-24 20:29:05 -03:00
Revision
6e39ffa64e fix(Core/GameObject): Pumpkin Shrine (#13460)
Co-authored-by: M'Dic <joshua.lee.betts@gmail.com>
2023-03-16 18:57:36 +01:00
Kitzunu
bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
Maelthyr
afb071bb04 refactor(Scripts): Update vanilla scripts to std::chrono (#14876)
Co-authored-by: Maelthyrr <AmanThul-Project@proton.me>
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-02-05 12:35:48 -03:00
Skjalf
bf30c66ba4 feat(Core/GameObject): Expand IsSummonedBy() to GameObjects (#14789)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-29 09:44:33 -03:00
Skjalf
b4e3f1310b feat(Core/Unit): Add KillSelf overload (#14785)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-28 17:57:23 -03:00
M'Dic
437d93926f fix (core): macos12 depreciation workflow error / security CWE-120 (#14746)
* fix (core): macos12 depreciation workflow error

Fix workflow error message:
azerothcore-wotlk/src/common/Utilities/Util.cpp:558:9: fatal error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
        sprintf(buffer, "%02X", bytes[i]);

* Update BattlegroundAV.cpp

* more macos12 fixit

* Update spell_generic.cpp
2023-01-23 06:13:27 -05:00
UltraNix
e2bf207ae4 fix(Scripts/Spells): Apple Trap should not activate without the playe… (#13868)
fix(Scripts/Spells): Apple Trap should not activate without the player being on a Rental Ram.

Fixes #13186
2022-12-06 09:42:17 -03:00
Maelthyr
3024bee3ba refactor(Core/UnitAI): Update target selector (#13169)
* refactor(Core/UnitAI): Update TargetSelector.

Cherry-pick:
*https://github.com/TrinityCore/TrinityCore/pull/19930

Co-authored-by: Treeston <treeston@users.noreply.github.com>

* fix GGC/CLang errors in scripts

* .

* missing a file and fix a script error

* .

* fix path changes dude to a miss click in the second commit

* .

Co-authored-by: Maelthyrr <lynethris@protonmail.ch>
Co-authored-by: Treeston <treeston@users.noreply.github.com>
2022-12-06 09:27:13 -03:00
UltraNix
7f4fe2e3ec fix(Scripts/Spells): Hallow's End Candy punpkin treat should turn pla… (#13808)
...yer into a pirate.
2022-11-21 18:59:24 -03:00
UltraNix
dbd785593d fix(Scripts/HallowsEnd): Fixed starting "Let the fires come" event. (#13487)
Fixes #13440
Fixes #13441
2022-10-23 12:04:55 -03:00
UltraNix
24c60ec302 fix(Scripts/Brewfest): Fixed race for tokens dailies. (#13109)
* fix(Scripts/Brewfest): Fixed race for tokens dailies.

Fixes #13077

* Update.
2022-09-25 22:45:25 -03:00
UltraNix
ddcf0e79b6 fix(Scripts/Brewfest): Added inebriate effect to Complimentary Brewfe… (#13112)
fix(Scripts/Brewfest): Added inebriate effect to Complimentary Brewfest Sampler.

Fixes #13085
2022-09-25 13:11:31 -03:00
Meramaf
e1e4c6cddc Script/Spell: fix Midsummer's Juggling Torch (#12198)
* Script/Spell: fix Midsummer's Juggling Torch

* Update juggling_torch_fix.sql

* Update data/sql/updates/pending_db_world/juggling_torch_fix.sql

Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>

* Update midsummer.cpp

Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>
2022-07-02 16:30:58 -04:00
Maelthyr
d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
IntelligentQuantum
ab4ee71762 feat(Core/Maps): AreaBoundary (#10525)
* cherry-picked commit (2da458c56d)
2022-04-15 14:10:41 +02:00
Kitzunu
856aed6fc6 feat(Core/Unit): New helpers for UnitFlag and UnitFlag2 (#11227) 2022-03-30 07:59:42 -03:00
UltraNix
a92708686d fix(Core/Spells): Crown Parcel Service Uniform should dismount players (#10654)
- Closes #10652
2022-02-15 12:46:53 +01:00
Kitzunu
455899dc75 fix(Core/Misc): Change const to be after type name (#10591) 2022-02-14 16:05:45 -03:00
Nefertumm
c9ac48e824 fix(Core/Events): Apothecary Hummel (#10615)
* Fix(Core/Events): Apothecary Hummel

Co-authored-by: sirikfoll <sirikfoll@hotmail.com>
Co-authored-by: Killyana <Killyana@users.noreply.github.com>

* missed return

* Missing include

* Fixed delete

Co-authored-by: sirikfoll <sirikfoll@hotmail.com>
Co-authored-by: Killyana <Killyana@users.noreply.github.com>
2022-02-11 06:00:10 -03:00
Kitzunu
27df910cb7 refactor(Script/Event): convert midsummer into new system (#9607) 2022-02-10 04:26:37 +01:00
Skjalf
7bed30a52d chore(Scripts/Events): fix typo (#10604) 2022-02-09 11:11:13 -03:00
Skjalf
4b32ad1853 fix(Scripts/Events): Fix not being able to start the Apothecary Trio … (#10596)
* fix(Scripts/Events): Fix not being able to start the Apothecary Trio encounter

* ops

* Update love_in_air.cpp

* Update love_in_air.cpp
2022-02-09 04:13:38 -03:00
Kargatum
8b7df23f06 feat(Core/Time): Implement saparated manager for game time (#8630) 2022-01-24 17:55:00 +07:00
Kargatum
259b9133f6 feat(Core/Common): add new helpers for time utility (#10207) 2022-01-19 12:01:59 +07:00
Kitzunu
d1cc65b1c7 refactor(Core/Misc): isEmpty to IsEmpty (#10011) 2022-01-13 21:43:15 -05:00
Kitzunu
cb7e355291 refactor(Core/Misc): sin() to std::sin() (#9795) 2022-01-06 19:29:40 +01:00
Kitzunu
69683a3472 chore(Scripts/Misc): Cleanup some more JustDied hooks (#9768) 2021-12-31 12:00:40 -03:00
Kargatum
c81891fc11 feat(Core/AI): convert SelectAggroTarget to enum class (#9893) 2021-12-28 19:13:12 -03:00
Francesco Borzì
cbc7e5466a refactor(Core): remove unused imports (#9767) 2021-12-19 19:41:14 +01:00
Kitzunu
5685a0e401 refactor(Scripts/Events): convert childrens_week to new system (#9611) 2021-12-14 21:15:16 -03:00