Commit Graph

370 Commits

Author SHA1 Message Date
Footman
695a7402ad fix(Core): creature movement bugs (#4544)
- fix UpdateEnvironmentIfNeeded was changing flying creature status all the time. closes: #4447
- fix hovering state was causing bugs at #4466
- add animation state priority: fly > hover > ground

Co-authored-by: Wotex <fm@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Patrick Lewis <pat@lo5t.com>
2021-02-12 11:42:41 +01:00
Stifler82
d7981de01e fix(Core/Spell): solve issue with Life Tap All Ranks (#4408) 2021-02-11 15:08:27 +01:00
Kitzunu
1a137dadde fix(Core/Script): Startup error in spell_bwl_shadowflame (#4474) 2021-02-10 17:53:30 -05:00
Francesco Borzì
3c670cb5a0 fix(DB/Commands): align core and DB (#4479) 2021-02-08 23:45:00 +01:00
Kitzunu
05a8217270 refactor(Core/Player): add helper method for PLAYER_FLAGS_DEVELOPER (#4395)
Co-Authored-By: ForesterDev <11771800+ForesterDev@users.noreply.github.com>
2021-02-08 16:55:04 -05:00
Kitzunu
bfcc3c6f87 refactor(Core/Spell): Move some SpellImmune from script to db (#4381)
* refactor(Core/Spell): Move some SpellImmune from script to db
2021-02-05 18:57:51 -05:00
55Honey
47160f3c36 fix(Core/Commands): remove character creation flag from .save command 2021-02-05 19:12:53 +01:00
Kitzunu
b43c5c9bf3 fix(Core/Spell): Instant Statue (#4319)
* fix(Core/Spell): Instant Statue

* make sure GetCaster() is not null

* values

* unit not player

* scriptName

* Update spell_item.cpp

* feat(Core/Spell): Implement ValidateSpellInfo

* Cherry-pick from 2b5d7eef3a & a0a158b5b8

* Revert "feat(Core/Spell): Implement ValidateSpellInfo"

This reverts commit 7690f02b49c82c65de3e92307063211a2e9941f5.

* Revert "Revert "feat(Core/Spell): Implement ValidateSpellInfo""

This reverts commit 8ffbb46fafe1f2d1597b4295b9e5fcec822d1181.

* Update spell_item.cpp

* dependant on https://github.com/azerothcore/azerothcore-wotlk/pull/4323

* untargetable
2021-02-02 16:08:52 +01:00
Francesco Borzì
f85cb30c99 feat(Core/Conf): toggle XP price (#4388) 2021-02-02 04:11:54 +01:00
Peter
f65cfb6f20 fix(DB/Creature): Convert npc_anchorite_truuen to sai (#4324)
* fix(DB/Core): Anchorite Truuen

Anchorote Truuen is escorted in quest Tomb of the Lightbringer, but he's
too fast and doesn't aggro on anything.

* Updated using suggestions from @pklloveyou

Co-authored-by: Zoidwaffle <zoidwaffle@gmail.com>
2021-02-02 00:13:01 +01:00
Kitzunu
0d52b4ca4a feat(Core/Spell): Implement ValidateSpellInfo (#4323)
* feat(Core/Spell): Implement ValidateSpellInfo

* cherry-pick from 2b5d7eef3a & a0a158b5b8

* sLog->outError

* cleanup

* convert to ValidateSpellInfo

* fix error log

* improve sLog->outError

* remove non related spells stuff from Validate

* remove the last

* build

* build x2
2021-02-01 18:57:25 +01:00
Yehonal
c8f43d8584 feat(Core/Movement): Improved pathfinding, collisions and movements (#4220)
Npc positioning
Implemented slope check to avoid unwanted climbing for some kind of movements (backwards, repositioning etc.)
Implemented backwards movement
Re-implemented circle repositioning algorithm (smartest than retail, but with the same feeling)
Fixed random position of summoned minions
Improved pet following movement. Also, they attack NPC from behind now. Thanks to @Footman

Swimming creatures
Fixed max_z coordinate for swimming creatures. Now only part of their body is allowed to be out of the water level
Fixed pathfinder for swimming creatures creating shortcuts for specific segments, now they swim underwater to reach the seashore instead of flying above the water level.
Creatures with water InhabitType but no swimming flag now, when not in combat, will walk on water depth instead of swimming. Thanks @jackpoz for the original code
UNIT_FLAG_SWIMMING in UpdateEnvironmentIfNeeded to show the swimming animation correctly when underwater
Implemented HasEnoughWater check to avoid swimming creatures to go where the water level is too low but also to properly enable swimming animation only when a creature has enough water to swim.

Walking creatures
Extended the DetourNavMeshQuery adding area cost based on walkability (slope angle + source height) to find better paths at runtime instead of completely remove them from mmaps
improve Z height in certain conditions (see #4205, #4203, #4247 )

Flying creatures
Rewriting of the hover system
Removed hacks and improved the UpdateEnvironmentIfNeeded. Now creatures can properly switch from flying to walk etc.
Spells
LOS on spell effect must be calculated on CollisionHeight and HitSpherePoint instead of position coords.
Improved position for object/creature spawned via spells
Improved checks for Fleeing movements (fear spells)

Other improvements
Implemented method to calculate the CollisionWidth from dbc (used by repositioning algorithm etc.)
Improved raycast and collision checks

Co-authored-by: Footman <p.alexej@freenet.de>
Co-authored-by: Helias <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-02-01 01:34:27 +01:00
Kitzunu
628c75d67f fix(Core/SpellMgr): Add cooldown to some vehicle spells (#4300)
* fix(Core/SpellMgr): Add cooldown to some spells

* author and spellscript

Co-Authored-By: Wyrserth <43747507+Wyrserth@users.noreply.github.com>
2021-01-31 03:09:50 +01:00
FALL1N1
6ef7341313 fix(Core/Scripts): Blackwing Lair overhaul (#3673)
* [Core/Scripts] BWL - Make Razorgore talk, script blackwing mage, make his spell break eggs

* more to vaelastrasz

* accidentally removed some of the waypoints, fuck me

* Broodlord Lashlayer overhaul + supressors

* Formations, waypoints for Ebonroc and roaming Flamegor (might be non-blizzlike)

* complete overhaul for the basic scripts, merge with TC

* last for today, door cleanup and nefarian refactor (from TC)

* Doors are now working, hooraay!

* Fix the boss gossip that we broke... non-intentionally lolz

* Vaelstraz intro - done

* small corrections to the timers, they are not blizzlike since we got no sniffs.. :^)

* nefarian checked, everything seems to be fine... let the cleanup begin now

* SQL seems fine as well, let's gooo

* Partially Revert "SQL seems fine as well, let's gooo"

This partially reverts commit b1750da58d169e9ed916eb6a6a95da93caeb0ff8.

* idk why mine's called wander_distance

* wtb new eyes

* lost an override @ flamegor

* more junk to fix the compile

* anything else? whining shit..

* SpellScript header..

* how about now?

* hopefully this does the trick, the condition in general works just fine, the spell is targeting the boss

* Update 0000_00_00_00.sql

fuck. you.

* Cleanup SQL, temp comment out code for creature relations so they don't pull several rooms at once

* Move the file with proper revision and location

* Remove the creature_relations *fix* until there's a proper core-side fix for it.

* spawndist > wander_distance

* compile fix

* lost a bracket in the merge

* *sigh*

* add new line at the end

* Nefarian's whitespaces

* Vael's whitespaces

* Razorgore good to go as well

* Header as well

* finale
2021-01-31 01:38:00 +01:00
Kitzunu
8851152815 fix(Core/Item): Implement mount speed mod items (#4258) 2021-01-30 00:46:59 +01:00
Kitzunu
9cee5e1d61 fix(Core/Spell): Paralytic Poison (#4128) 2021-01-23 16:59:43 +01:00
Silker
0a8a7ef149 fix(Core): Activate creatures and objects during opening cinematics (#4045)
Co-authored-by: Si1ker <55638679+Sombranator@users.noreply.github.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-01-22 01:03:30 +01:00
Francesco Borzì
8d5347b9ab fix(Core/QuestTracker): do not store quest if quest_id is null (#4027) 2021-01-20 01:14:04 +01:00
WiZZy
42244612ff fix(DB/Creature): Gyromasts Revenge (#4115) 2021-01-19 22:04:49 +01:00
Kitzunu
8ddd904324 refactor(Core/cs_reload): Improve page_text(_locale) output (#3115) 2021-01-19 00:52:32 +01:00
55Honey
12bf9731af fix(Scripts/boss_freya): adds apply SPELL_CONSERVATOR_GRIP 6s after spawn (#4082)
Co-authored-by: WiZZy <bilucristian25@gmail.com>
2021-01-17 01:06:40 +01:00
Kitzunu
d5c41aa5d7 fix(DB/Quest): Taken by the Scourge (#4079) 2021-01-16 13:43:49 +01:00
Stefano Borzì
df600f9946 fix(Core/CreatureAI): revert NPC repositioning and path system (temporarily) (#4274) 2021-01-14 19:17:34 +01:00
lineagedr
943c1e7ae7 fix(Scripts/DB/Creature): Set PvP flag for some creatures (#4270) 2021-01-14 19:15:55 +01:00
WiZZy
b9375ffff7 fix(Core/The Oculus) Drakos dragon keepers (#3531) 2021-01-12 14:46:16 +01:00
Kitzunu
b0aff365a9 chore(core): Remove malformed whitespace (#4248) 2021-01-10 18:20:45 +01:00
Kitzunu
da4edd547d chore(core): remove malformed whitespaces (#4244)
* from https://www.codefactor.io/repository/github/azerothcore/azerothcore-wotlk/issues?category=Style&groupId=838&lang=5&page=75
2021-01-10 14:27:55 +01:00
Kargatum
ea93a5c1a1 feat(CI/Codestyle): added codestyle check (#3668) 2021-01-09 11:59:50 +01:00
Kitzunu
c5fe21fe9a fix(Core/Spell): Earthliving weapon proc (#4015) 2021-01-08 20:18:36 +01:00
Vox
9592028ad1 fix(scripts/instance): Force correct gossip/text updates (#3838) 2021-01-08 13:34:05 +01:00
Stefano Borzì
b2761626fe feat(Core/CreatureAI): improve npc position during the combat (#3369)
+ tangent equation to find correct angle and distance when moving

+ implemented proper backward

* Improved performance + random angle margin

* chore: add tollerance calculation in instance

* improved LOS checks with movements

* implemented collisions using raycast (imported by TC)

+ improved collision detection for CanReachPositionAndGetCoords

+ improved collision check

+ set correct flags for the backward movement

+ first implementation of slope angle (to improve)

Co-authored-by: Yehonal <yehonal.azeroth@gmail.com>
2021-01-04 20:23:08 +01:00
WiZZy
469d5a8bca fix(DB/Creature): Engineer "Spark" and Geezle (#4089) 2021-01-02 18:45:04 +01:00
Stefano Borzì
9be41ff4e6 fix(Core/Quest): They're Alive! Maybe... (#4035)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-01-01 20:02:08 +01:00
Silker
3654c18784 fix(scripts/Felmyst): Adjust beam target (#4055) 2020-12-26 12:56:21 -06:00
WiZZy
aec0dbb747 fix(scripts/Ulduar): Kologarn - Focused Eyebeam (#3529) 2020-12-25 12:10:19 -06:00
WiZZy
d710057a31 fix(scripts/Ulduar): Expedition Base Camp (#3558) 2020-12-25 09:56:32 -06:00
Walter Pagani
6a95e61801 refactor(scripts/BlackrockMountain): Remove commented NPC scripts (#3229) 2020-12-24 20:21:46 +00:00
Silker
b6ec66eebd fix(scripts/CullingOfStratholme): Remove "Corrupting Blight" at Infinite Corruptor's death (#4011) 2020-12-19 22:07:54 -06:00
Silker
26bf415ce0 fix(scripts/Oculus): Reset Mage-Lord Urom's position at death (#4012) 2020-12-19 18:29:02 -06:00
Hacaw
086ad6c9c2 fix(DB/Quest): Text for quest "When the Cows Come Home" (#3840) 2020-12-13 13:35:18 -06:00
Francesco Borzì
d4a58700d4 refactor(Core): apply clang-tidy modernize-use-override (#3817) 2020-12-06 18:04:55 +01:00
Silker
87c905af26 fix(Scripts/Ulduar): Yogg-Saron's portals (#3810) 2020-12-04 22:55:18 -06:00
Andrius Peleckas
01fa6257c8 fix(Scripts/ObsidianSanctum): Code revamp [1/2] (#3634) 2020-11-28 15:36:05 -06:00
Vox
d4612c7ac6 fix(Scripts/ICC): Intro Event Timers and Text 2020-11-28 15:22:42 +01:00
Goatform
37d1f2be47 fix(Scripts/VOA): code-style improvements + bandwidth consumptio (#3632) 2020-11-27 12:50:50 +01:00
aradep
223738e910 fix(Scripts/DB): Mimiron Computer NPC text (#3722) 2020-11-27 10:07:15 +01:00
Silker
bcac48b573 fix(scripts/Ulduar): Assembly of Iron - interrupt immune effect (#3765) 2020-11-26 08:53:29 -06:00
Silker
931609d2c2 fix(scripts/Commands): Avoid get gm phase when summoning (#3764)
This change avoids to set the same phase as the one the GM has to a player when this is summoned by command

Co-authored-by: Si1ker <55638679+Sombranator@users.noreply.github.com>
2020-11-26 06:12:22 -06:00
Silker
4105d370bf fix(DB/scripts): Freya - Sun beam (#3730) 2020-11-22 11:16:35 -06:00
Silker
d6c1b84bd9 fix(Scripts): Ignis the Furnace Master - Iron construct buff stacks #3731 2020-11-21 15:31:22 -06:00