Commit Graph

104 Commits

Author SHA1 Message Date
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Andrew
f9f71fff36 fix(Core/Player): Check if the player can summon the warlock pet on B… (#18064)
fix(Core/Player): Check if the player can summon the warlock pet on BG ress
2024-01-01 14:56:32 +01:00
Winfidonarleyan
eb1ecc38a5 feat(Core/Scripting): move all script objects to separated files (#17860)
* feat(Core/Scripts): move all script objects to separated files

* Apply 5bfeabde81

* try gcc build

* again
2023-12-02 21:13:20 +01:00
Kitzunu
5bfeabde81 chore(Core/Misc): rename spellInfo pointers (#17914)
* Rename all
2023-12-02 06:03:15 -03:00
forgives
ca7eb956aa feature(Core/Pet): Add pet talent rate config (#17678)
* feat: add pet talent rate config

* feat(Core/Pet): keep consistent with player talent config

* refactor(Core/Pet): delete empty line
2023-11-12 09:33:06 +01:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
Skjalf
c7b7b7dc07 fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet (#17342)
* fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet

* Update src/server/game/Entities/Pet/Pet.cpp
2023-09-25 08:07:09 -03:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Tereneckla
cf87a2d8fe fix(Core/Pet): Correct (most) warlock pet scaling (#16769)
* create

* Update Pet.cpp

* remove unwanted change

* Update data/sql/updates/pending_db_world/rev_1689522771491547000.sql

* Update rev_1689522771491547000.sql
2023-08-20 21:38:49 -03:00
Anton Popovichenko
f6b77f9d64 fix(Core/Pets): Fix crash when pet tries to attack deleted object (#17034)
This situation occurs when, during a fight, a pet receives a command to apply a positive spell to an ally and then resume attacking its previous target.
2023-08-19 22:27:51 +02:00
Kitzunu
026fe7c962 fix(Core/Pets): Hunter pet scaling (#16959)
* fix(Core/Pets): Hunter pet scaling

* Fix pet scaling to properly take DBC data
* Edge case for Devilsaur where the DBC data is whack, therefore we use Spirit Beast data instead
* updated scale calculation based on client function (f09564b9d0)

Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com>

* fix gcc

---------

Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com>
2023-08-08 19:11:41 -03:00
Webdrian
226408329a fix(Core/Pets): Corret Pet size for normal and exotics & bigger pets (#16910)
* fix(Core/Pet)

Pet size fixed

* Update Pet.cpp

* Update Pet.cpp
2023-08-06 02:08:34 +02:00
AiurJordan
f0a4612964 fix(Core/Pets) Pet scaling only being applied to pets with DB Entry (#16401) 2023-08-02 14:51:11 -03:00
Angelo Venturini
30f475829a fix(Core/Spells): Hunter snake trap damage (#16326) 2023-05-23 22:39:55 -03:00
Axel Cocat
d028a6253a fix(Core/Pet): fix Pet::resetTalentsForAllPetsOf for stabled pets (#15779) 2023-04-02 14:48:03 +02:00
UltraNix
ac0581bd43 fix(Core/Pet): Fixed set hunter pet's speed on load. (#15206) 2023-03-04 17:41:10 -03:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
UltraNix
da70db415b fix(Core/Config): Added new config to make pet's health be modified b… (#14051) 2023-02-11 00:08:28 -03:00
Kitzunu
ed2997ab10 fix(Core/Creature): Check model increase only for Exotic creatures (#14526)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14525
2023-01-07 20:36:39 +01:00
Kitzunu
8d2dda24ed fix(Core/Pets): Correct Pet size for bigger pets (#14511)
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14488
2023-01-06 03:23:21 +01:00
Angelo Venturini
9e18b86311 fix(Core/Auras): SPELL_AURA_MOD_SCALE should scale additively instead… (#14425)
...multiplicatively

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2023-01-02 20:43:20 -03:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
UltraNix
79bef9a057 fix(Core/Pets): Save all spell cooldowns to db. (#13809)
Fixes #13539
2022-11-16 01:26:46 -03:00
UltraNix
670d5724cb fix(Core/Pets): Tamed hunter pets should deal physical damage. (#13522)
Fixes #13497
2022-10-29 07:14:07 -03:00
UltraNix
1b0d76e6d2 fix(Core/Spells): Fixed applying Command aura to shaman Feral Spirits. (#13000) 2022-09-13 21:35:00 -03:00
Maelthyr
d0d1671745 feat(Core/Debug): GetDebugInfo implementation (#12705)
Cherry-pick: 9a924fb9d5

Co-authored-by: jackpoz <giacomopoz@gmail.com>

Co-authored-by: jackpoz <giacomopoz@gmail.com>
2022-08-15 09:43:41 -03:00
UltraNix
b81a14976c fix(Scripts/Spells): Glyph of Felguard. (#12497)
* fix(Scripts/Spells): Glyph of Felguard.

Fixes #12432

* Update.
2022-07-24 13:38:03 -03:00
Maelthyr
2c7b274bc5 refactor(Core): Improve struct alignment and codestyle (#12335)
refactor(Core): improve struct alignment and codestyle
2022-07-10 14:19:11 -04:00
UltraNix
255c5d8b72 fix(Core): Crashfix. (#11903)
* fix(Core): Crashfix.

Fixes #11650

* Update.
2022-06-26 04:50:22 -03:00
UltraNix
d6c95b4db8 fix(Core/Pets): Handle health-aurastates on pet loading. (#11491)
Fixes #11481
2022-04-23 11:32:46 -03:00
Kitzunu
edb7cac19b feat(Core/Unit): NPCFlags helpers (#11286)
* cherry-pick commit (TrinityCore/TrinityCore@d611925)
Co-Authored-By: Shauren <shauren.trinity@gmail.com>
2022-04-05 13:52:42 +02:00
Kitzunu
535c7451a2 feat(Core/Unit): New helpers for DynamicFlags (#11230)
* feat(Core/Unit): New helpers for DynamicFlags

* cherry-pick commit (d611925dc7)

Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* oopsie

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-04-01 07:14:29 -03:00
Kitzunu
856aed6fc6 feat(Core/Unit): New helpers for UnitFlag and UnitFlag2 (#11227) 2022-03-30 07:59:42 -03:00
IntelligentQuantum
b275499de4 refactor(Core/Packet): Pet (#9473)
Co-authored-by: temperrr <temperrr@users.noreply.github.com>
2022-03-01 13:50:50 +01:00
Kitzunu
455899dc75 fix(Core/Misc): Change const to be after type name (#10591) 2022-02-14 16:05:45 -03:00
Kitzunu
13643c969c refactor(Core/Spell): Use ApplySpellFix with SpellInfo (#9938) 2022-02-08 14:09:15 +01:00
Kargatum
de13bf426e feat(Core/DBLayer): replace char const* to std::string_view (#10211)
* feat(Core/DBLayer): replace `char const*` to `std::string_view`

* CString

* 1

* chore(Core/Misc): code cleanup

* cl

* db fix

* fmt style sql

* to fmt

* py

* del old

* 1

* 2

* 3

* 1

* 1
2022-02-05 00:37:11 +01:00
Kargatum
5969df4e30 refactor(Core/Logging): switch to fmt style for LOG_ (#10366)
* feat(Core/Common): add support fmt style for ASSERT and ABORT

* correct CheckCompactArrayMaskOverflow

* 1

* Update src/server/game/Spells/Spell.cpp

* rework logging

* add fmt replace logs

* logging

* FMT_LOG_

* settings

* fix startup

* 1

* 2

* 3

* 4

* 5

* fmt::print

* to fmt
2022-01-27 16:44:41 +01:00
Kargatum
e8f34b2309 feat(Core/Common): add support fmt style for ASSERT and ABORT (#10355)
* feat(Core/Common): add support fmt style for ASSERT and ABORT

* correct CheckCompactArrayMaskOverflow

* 1

* Update src/server/game/Spells/Spell.cpp
2022-01-25 23:15:51 +01:00
Kargatum
8b7df23f06 feat(Core/Time): Implement saparated manager for game time (#8630) 2022-01-24 17:55:00 +07:00
UltraNix
2f8318fd58 fix(Scripts/Hunter): Bestial Wrath shoul not be castable on dead pets. (#9896)
Bestial Wrath should expire while pet is offline.
2022-01-23 23:45:24 -03:00
UltraNix
1cbf52fb3d fix(Core/Spells): Fixed Revive Pet. (#10324)
Fixed #10267
2022-01-23 21:19:52 -03:00
Francesco Borzì
9dc88def35 refactor(Core): apply clang-tidy modernize-* (#9975)
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2022-01-17 14:35:07 +01:00
UltraNix
19b68ffb57 fix(Core/Pets): Manual using pet spell should not reset attack command. (#9635)
Fixes #9632
2022-01-16 14:44:21 -05:00
Kargatum
7f05e20994 fix(Core/Pets): fix crash at pet resurrect (#10120) 2022-01-15 19:08:54 -03:00
Kargatum
c1ebda66ba fix(Core/Pets): fixed crash happening when current pet is forcibly removed (#10025) 2022-01-10 09:19:43 -03:00
Francesco Borzì
b748730bc8 refactor(Core): remove unused imports (#9969) 2022-01-02 20:22:09 +01:00
Kargatum
e12494d993 feat(Core/Pets): Management refactoring (#9712)
* feat(Core/Pets): rework managment

* 1

* 2

* 3

* 4

* 5

* cs pet

* check before ressurect

* pet DECLINED_NAMES

* display

- https://github.com/azerothcore/azerothcore-wotlk/issues/9297

* ArenaSpectator

* 1
2021-12-30 18:45:13 -03:00
UltraNix
d87d0a2ae8 fix(Core/Pets): Improved Revive Pet should affect dead despawned pet. (#9625)
* fix(Core/Pets): Improved Revive Pet should affect dead despawned pet.

Fixes #9589
2021-12-15 05:32:16 -03:00
UltraNix
4e93671b3c fix(Core/Pets): Properly cast spells on friendly target if not in LoS… (#9570)
* fix(Core/Pets): Properly cast spells on friendly target if not in LoS or out of range.

Fixes #7790
2021-12-12 09:25:10 -03:00