Npc positioning
Implemented slope check to avoid unwanted climbing for some kind of movements (backwards, repositioning etc.)
Implemented backwards movement
Re-implemented circle repositioning algorithm (smartest than retail, but with the same feeling)
Fixed random position of summoned minions
Improved pet following movement. Also, they attack NPC from behind now. Thanks to @Footman
Swimming creatures
Fixed max_z coordinate for swimming creatures. Now only part of their body is allowed to be out of the water level
Fixed pathfinder for swimming creatures creating shortcuts for specific segments, now they swim underwater to reach the seashore instead of flying above the water level.
Creatures with water InhabitType but no swimming flag now, when not in combat, will walk on water depth instead of swimming. Thanks @jackpoz for the original code
UNIT_FLAG_SWIMMING in UpdateEnvironmentIfNeeded to show the swimming animation correctly when underwater
Implemented HasEnoughWater check to avoid swimming creatures to go where the water level is too low but also to properly enable swimming animation only when a creature has enough water to swim.
Walking creatures
Extended the DetourNavMeshQuery adding area cost based on walkability (slope angle + source height) to find better paths at runtime instead of completely remove them from mmaps
improve Z height in certain conditions (see #4205, #4203, #4247 )
Flying creatures
Rewriting of the hover system
Removed hacks and improved the UpdateEnvironmentIfNeeded. Now creatures can properly switch from flying to walk etc.
Spells
LOS on spell effect must be calculated on CollisionHeight and HitSpherePoint instead of position coords.
Improved position for object/creature spawned via spells
Improved checks for Fleeing movements (fear spells)
Other improvements
Implemented method to calculate the CollisionWidth from dbc (used by repositioning algorithm etc.)
Improved raycast and collision checks
Co-authored-by: Footman <p.alexej@freenet.de>
Co-authored-by: Helias <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
* fix(Core/Spell): items disappearing in Spell::CheckItems()
* 18b36734f6
* remove GetFreeInventorySpace
* restore p_caster to make other PR needing to merge before this
* fix build
* fuck github conflicts
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Currently, mages can't refresh Living Bomb if the target already have the dot.
###How to reproduce the issue :
1. Use Living Bomb on a target
2. Try to re-use Living Bomb on the same target
3. Observe the error message
###Expected Blizzlike behaviour
Living Bomb should be reapplyable
###Why this PR :
This PR allow to refresh the duration of Living Bomb on the same target
I've didn't found a bad mage's video that refreshes Living Bomb on his target, but found some Fire Mage 3.3.5 guides that mentions :
"Never refresh your LB (Living Bomb) before the explosion (except if I clearly tell you to)."
https://sites.google.com/site/pvemage335/fire/rotation-gameplay
"Living Bomb – every 12 seconds **after the explosion**"
https://www.gnarlyguides.com/wotlk/guides/pve-fire-mage/#plink-rotation
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
* Core/Spells : Mage permafrost talent
- Will fix issue with permafrost (Talent ) apply the heal reduction even if dispelled.
Co-Authored-By: talamortis <talamortis@gmail.com>
* Update Spell.cpp
Removed the whole case function as requested in AC comments.
Fix "Spell which is reflected doesn't create DR on whom is casting the spell"
Now warrior would not add diminishing returns if he reflect spell (code may be a bit hacky)
Closes issue #650 on github
