Commit Graph

134 Commits

Author SHA1 Message Date
Samsequel
3d00fb7948 fix(Script/Professions): Unlearn alchemy profession mastery at 325 (#16810) 2023-07-26 08:48:00 -03:00
KJack
2a6bb85540 fix(Scripts/Quest): Make quest "Triage" (6622/6624) completable (#16335)
* Resolves issue where patients were dying extremely quickly during the quest.

- updates other parameters to make the quest more Blizz-like and completable

* Correct starting patient count for Horde

* Correctly handle starting patient count for both factions.

* Whitespace removal

* Un-Pythonese variable name, slightly improve initial patient count call

* Match WotLK Classic timing for patient deaths
2023-06-01 08:38:52 -03:00
KJack
cafb8e3cfb fix(Scripts/Npc) Experience Eliminator only asks pertinent questions (#16310)
* Experience Eliminator will only ask you pertinent questions.

* Add brackets per AC code standards.
2023-05-27 23:07:40 -03:00
avarishd
8c9b4f1fb6 fix(DB/SAI): Port On Nethery Wing visuals from Trinity. (#15806)
* fix(DB/SAI): Port On Nethery Wing visuals from Trinity.

/TrinityCore/TrinityCore/issues/23905

Co-Authored-By: Dr-J <1444120+dr-j@users.noreply.github.com>

* increase SpellFocusObject from 90 to 150

* correct taxipath and add 4 spawns from TC

---------

Co-authored-by: Dr-J <1444120+dr-j@users.noreply.github.com>
2023-04-04 09:34:14 -03:00
UltraNix
213aaee42c fix(Scripts/Spells): Fixed Improved Healthstone not affecting Ritual … (#15588)
fix(Scripts/Spells): Fixed Improved Healthstone not affecting Ritual of Souls.

Fixes #15510
2023-03-29 00:31:36 -03:00
avarishd
d2c132772f fix(Script/Core): Remove hardcoded gossips in npc_taxi (#15052) 2023-03-17 17:38:25 +01:00
UltraNix
6a66b36a5d fix(Scripts/Creatures): Fixed some profession trainers. (#15349) 2023-03-13 08:18:44 -03:00
UltraNix
3f25a70934 fix(Scripts/Achievement): Fixed Flirt With Disaster achievement. Sourc… (#15352) 2023-03-12 15:56:23 -03:00
Gultask
8cbe63f110 chore(Core/Scripts): Use serverside spell instead of SummonCreature for Nether-wraith Beacon (#15285) 2023-03-05 17:32:04 -03:00
avarishd
1c23bca9cb fix(Scripts/WorldNPCs): npcs_special hardcode removal and fixes. (#15240) 2023-03-04 17:37:15 -03:00
Kitzunu
bd6034e1a9 refactor(Core/AI): Some more refactoring prep for Comat Threat system… (#15026)
Co-authored-by: Treeston <14020072+Treeston@users.noreply.github.com>
2023-02-13 21:39:40 +01:00
Kitzunu
f039836a2f chore(Core/Misc): Change all TODO to doxygen comment (#14966) 2023-02-12 10:05:34 -03:00
Skjalf
bf30c66ba4 feat(Core/GameObject): Expand IsSummonedBy() to GameObjects (#14789)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-29 09:44:33 -03:00
Skjalf
b4e3f1310b feat(Core/Unit): Add KillSelf overload (#14785)
Co-authored-by: jackpoz <giacomopoz@gmail.com>
2023-01-28 17:57:23 -03:00
UltraNix
6889ed4f2a fix(Core/Items): Players should dismount upon using Brazier of Dancin… (#14055)
* fix(Core/Items): Players should dismount upon using Brazier of Dancing Flames.

Fixes #10327

* Update.
2023-01-06 00:52:23 +01:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
Charlton Lau
ba796bee43 fix(Scripts/GO): Druid‘s fly quest (#14085) 2022-12-27 11:27:48 +01:00
schell244
c54d56c7d0 fix(Core/Event): STV Riggle Bassbait broadcast text ids (#13517)
* fix broadcast_text not found

* use creature->AI()->Talk() instead of creature->Yell()

Co-authored-by: schell244 <>
2022-10-24 10:09:52 -04:00
schell244
28d1913276 fix(Core/Event): Rework STV Fishing Extravaganza (#12506)
* rework riggle bassbait script

* make sure STV_FISHING_HAS_WINNER gets reset

* add script for npc Jang, some improvements for Riggle script. TODO: Jang quest menu and Fishbot5000 quest condition

* fix jang not offering quest

* script fishbot 5000

* some cleanup

* some more cleanuo

* endline

* minimum fishing req for quests is 150

* min fishing skill for flyer is 150

* link box to correct event

* riggle: broadcast texts, announcement happens when pools despawn

* remove redundant code

* Convert Fishbot5000 to db, cleanup comments

* add missing end line - finished now.

* attempt to fix event not launching in real time

* fix condition for world states, when value is 0, convert jang to db

* keep jang gossip also when event has a winner

* small further improvements

* Update src/server/scripts/World/npcs_special.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/World/npcs_special.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/World/npcs_special.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* apply suggestions

* Update src/server/scripts/World/npcs_special.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* apply suggestions

* apply one more suggestion

* Update src/server/scripts/World/npcs_special.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/World/npcs_special.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/World/npcs_special.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* apply suggestion

* use Talk() instead of Yell()

* use Yell() without passing LANG_UNIVERSAL

Co-authored-by: schell244 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2022-10-20 08:39:30 -04:00
Grimgravy
9ac3b52d44 fix(Scripts/NPC): Arcanite Dragonling (#13233)
* fix(Scripts/NPC): Arcanite Dragonling

* update
2022-10-15 11:03:23 -04:00
Maelthyr
1f472bddd3 refactor(Core/Combat): Code style and improvement of ThreatMgr (#12992) 2022-09-25 15:20:34 -03:00
schell244
241cbac46a fix(Core/Event): Hourly bell: Dwarf horn sound should only play once (#12795)
Co-authored-by: schell244 <>
2022-08-21 10:57:07 -03:00
Skjalf
523d4fbb08 fix(Scripts/World): Emerald Dragon's Dream Fog should chase switch ta… (#12728)
…rgets once reaching their chase target
2022-08-15 04:03:36 -03:00
Skjalf
4952e6032f fix(Scripts/Misc): Lower Artorius damage treshold when he damages him… (#12695)
* fix(Scripts/Misc): Lower Artorius damage treshold when he damages himself & his dot shouldn't be affected by his enrage

* Update SpellInfoCorrections.cpp
2022-08-13 22:24:58 -03:00
Nefertumm
62ffa75765 fix(Scripts/EmeraldDragons): fix summon player spam (#12573) 2022-07-29 09:39:47 -03:00
Maelthyr
654ad10b7f fix(Scripts/World): Ysondre - Spawn adds should scale with raid size v2 (Source: VMangos) (#12368) 2022-07-12 08:30:06 -03:00
Maelthyr
5cb69ef600 fix(Scripts/World): Prevent Taerar to be untargetable on death (#12351)
prevent unlooting and untargetable boss if kill too quickly
2022-07-10 14:19:43 -04:00
ZhengPeiRu21
7df342b41c fix(Scripts): Midsummer Music Range (#12248)
* fix(Scripts): Midsummer Music Range

* Refactor iterating nearby players

Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>

* Update go_scripts.cpp

* Update go_scripts.cpp

Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>
2022-07-01 22:24:01 +02:00
ZhengPeiRu21
12f53ba2d1 fix(Scripts): Brazier of Dancing Flames should dance when spawned (#12156) 2022-06-28 16:13:48 -04:00
Maelthyr
d928d8d96a refactor(Core/Unit): PC&NPC Immunity (#11986)
* initial

* refactor(Core/Unit): PC & NPC Immunities

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* fix builds error

Cherry-pick TC: 74af880217

Co-authored-by: Treeston <treeston.nmoc@gmail.com>

* Fix nef combat, and replace SetFlag by SetUnitFlag

* fix combat with jedoga

Co-authored-by: Treeston <treeston.nmoc@gmail.com>
2022-06-18 08:16:45 -04:00
temperrr
b5122ab046 fix(Scripts/EmeraldDragons): Lethon should use shadow bolt whirl (#12045)
Co-authored-by: Nefertumm <nefertum.dev@protonmail.com>
2022-06-15 07:24:45 -03:00
Skjalf
b273da1a59 fix(Scripts/World): Fix Emeriss putrid mushrooms not doing anything (#12035)
* fix(Scripts/World): Fix Emeriss putrid mushrooms not doing anything

* Update rev_1655056541364669100.sql
2022-06-13 06:36:26 -03:00
temperrr
491f73382b fix(Scripts/EmeraldDragons): Emerald dragons should 'enrage' at health per… (#12029) 2022-06-12 16:32:44 -03:00
UltraNix
9dd4123ff0 fix(Scripts/ZulGurub): Fixed Edge of Madness tablets. (#11959)
Based on @offl work.
Fixes #11610
2022-06-09 20:30:07 -03:00
Maelthyr
c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00
Skjalf
822aff29e6 fix(Scripts/World): fix nullptr crash (#11770) 2022-05-15 18:28:40 +02:00
Kitzunu
7ecd738674 feat(Core/Mail): Server mail (#10628) 2022-04-19 23:43:14 +02:00
IntelligentQuantum
ab4ee71762 feat(Core/Maps): AreaBoundary (#10525)
* cherry-picked commit (2da458c56d)
2022-04-15 14:10:41 +02:00
Kitzunu
b709a22ddc feat(Core/Players): PlayerFlag helpers (#11294)
* feat(Core/Players): PlayerFlag helpers

* Update Player.h

* fix build
2022-04-05 18:53:50 +02:00
Benjamin Jackson
9f234ea489 fix(Core/Gossip): Leatherworking specialization 2022-04-05 10:17:42 -03:00
Kitzunu
b41967a067 feat(Core/GameObject): Gob flag helpers (#11287) 2022-04-05 13:52:58 +02:00
Kitzunu
edb7cac19b feat(Core/Unit): NPCFlags helpers (#11286)
* cherry-pick commit (TrinityCore/TrinityCore@d611925)
Co-Authored-By: Shauren <shauren.trinity@gmail.com>
2022-04-05 13:52:42 +02:00
Kitzunu
535c7451a2 feat(Core/Unit): New helpers for DynamicFlags (#11230)
* feat(Core/Unit): New helpers for DynamicFlags

* cherry-pick commit (d611925dc7)

Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* oopsie

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-04-01 07:14:29 -03:00
Kitzunu
856aed6fc6 feat(Core/Unit): New helpers for UnitFlag and UnitFlag2 (#11227) 2022-03-30 07:59:42 -03:00
Nefertumm
4806769beb fix(Core/Professions): Leatherworking specialization (#10415) 2022-03-14 12:50:18 +01:00
Kitzunu
455899dc75 fix(Core/Misc): Change const to be after type name (#10591) 2022-02-14 16:05:45 -03:00
Kargatum
de13bf426e feat(Core/DBLayer): replace char const* to std::string_view (#10211)
* feat(Core/DBLayer): replace `char const*` to `std::string_view`

* CString

* 1

* chore(Core/Misc): code cleanup

* cl

* db fix

* fmt style sql

* to fmt

* py

* del old

* 1

* 2

* 3

* 1

* 1
2022-02-05 00:37:11 +01:00
Kargatum
5969df4e30 refactor(Core/Logging): switch to fmt style for LOG_ (#10366)
* feat(Core/Common): add support fmt style for ASSERT and ABORT

* correct CheckCompactArrayMaskOverflow

* 1

* Update src/server/game/Spells/Spell.cpp

* rework logging

* add fmt replace logs

* logging

* FMT_LOG_

* settings

* fix startup

* 1

* 2

* 3

* 4

* 5

* fmt::print

* to fmt
2022-01-27 16:44:41 +01:00
Kargatum
8b7df23f06 feat(Core/Time): Implement saparated manager for game time (#8630) 2022-01-24 17:55:00 +07:00
Kargatum
259b9133f6 feat(Core/Common): add new helpers for time utility (#10207) 2022-01-19 12:01:59 +07:00