Commit Graph

1249 Commits

Author SHA1 Message Date
UltraNix
2ed34db42f fix(Core/Spells):SPELL_ATTR5_AURA_AFFECTS_NOT_JUST_REQ_EQUIPED_ITEM (#7205)
- Closes #6617
2021-08-06 12:32:30 +02:00
KiK0
31e41890e3 fix(Core/Spells): Killing Spree should not affect invisible units (#7191) 2021-08-06 11:50:27 +02:00
Asthalor
7618e7706e fix(Scripts/Spell): combustion will now properly go on cooldown when the buff is manually cancelled (#7185)
* fix(CORE/Spell): Combustion will now properly go on cooldown when the buff is manually cancelled
* fix(DB/Scripts): Added the script for combustion
* Update spell_mage.cpp
* Update src/server/scripts/Spells/spell_mage.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-08-06 11:13:45 +02:00
Kitzunu
ac8dfeef4f fix(Core/SOAP): mem leak and new/free mismatch (#7181)
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-08-06 09:32:51 +02:00
UltraNix
2d56a94016 fix(Core/Spells): Next melee swing spells are supposed to be queued up even when out of range. (#7180)
- Closes #6588
2021-08-06 03:07:36 +02:00
UltraNix
cf5aeaea06 fix(Core/Totems): Totems should not fall to the depth in water. (#7179)
* fix(Core/Totems): Totems should not fall to the depth in water.

Fixed #6562

* chore(Core/Totem.cpp): add brackets

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-06 00:21:41 +02:00
UltraNix
32650b61ee fix(Core/Spells): Implemented SPELL_ATTR3_NO_PROC_EQUIP_REQUIREMENT. (#7178)
* fix(Core/Spells): Implemented SPELL_ATTR3_NO_PROC_EQUIP_REQUIREMENT.

Fixed #6559.

* Excluded shoot spells.

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-05 23:44:14 +02:00
UltraNix
5a93dce915 fix(Core/Spells): Disarmed creatures should no cast spells that requi… (#7171)
* fix(Core/Spells): Disarmed creatures should no cast spells that requires weapon.

Fixed #6404
Fixed #6764.

* codestyle.

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-05 22:41:51 +02:00
UltraNix
7e6727c12a fix(Core/Spells): Forbid using charge if already charging to someone. (#7172)
Fixed #6453

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-05 21:24:57 +02:00
UltraNix
f755a277d8 fix(Core/Cooldowns): Fixed replacing longer cooldowns by equip cooldown. (#7163)
Fixed #6366
Fixed #6054.

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-05 20:42:37 +02:00
UltraNix
279b6de88c fix(Core/Spells): Fixed displaying "That Glyph is already inscribed in your spellbook" when activating the same glyph in different spec. (#7162)
Fixed #6342

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-05 20:06:10 +02:00
UltraNix
d2e84eabb8 fix(Core/Items): Removed tradeable flag from items with temp enchants. (#7160)
Fixed #6325.

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-05 18:37:10 +02:00
UltraNix
ffdd990aa4 fix(Core/Spells): Glyphs should send SMSG_LEARNED_SPELL/SMSG_REMOVED_… (#7161)
* fix(Core/Spells): Glyphs should send SMSG_LEARNED_SPELL/SMSG_REMOVED_SPELL packet in case of updating spell tooltips.

Fixed #6323

* chore(Core/CharacterHandler): improve comment

* chore(Core/SpellEffects): improve comment

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-05 15:58:50 +02:00
UltraNix
ed4cfd37f4 fix(Core/Totems): Searing Totem will properly attack neutral targets. (#7157)
Fixed #6310

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-05 15:15:12 +02:00
UltraNix
36a1777b99 fix(Core/Movement): properly handle UNIT_STATE_CHARGING (#7152)
- Closes #6065
- Closes #6669
2021-08-05 13:55:11 +02:00
UltraNix
8522809bb3 Core/Spells: Regenerating POWER_HAPPINESS should not generate additional threat. (#7146)
Fixed #6190

Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2021-08-04 16:56:47 +02:00
UltraNix
d0b994496f fix(Core/Pets): Corrected pet speed catchup system. (#7131) 2021-08-04 07:05:27 +02:00
UltraNix
9a820e2d26 fix(Core/Spells): Master of Elements (#7102)
* Core/Spells: Master of Elements:

Proc now also from arcane spells.
Properly proc from periodic spells.
Fixed #6035.

* You shouldn't be there.

* Buildfix.

* missing sql.
2021-08-02 01:02:38 +02:00
Kitzunu
80ff915f24 fix(Core/Spell): Impelement SPELL_ATTR7_NO_ATTACK_DODGE & SPELL_ATTR7_NO_ATTACK_PARRY & SPELL_ATTR7_NO_ATTACK_MISS (#7099)
cherry-pick commit (bd6de8eb61)

Co-Authored-By: Ovah <18347559+Ovahlord@users.noreply.github.com>
Co-Authored-By: Gildor <521036+Jildor@users.noreply.github.com>
2021-08-01 22:03:45 +02:00
Shiroe
7f4c556148 fix(Core): Impelement CREATURE_FLAG_EXTRA_NO_PLAYER_DAMAGE_REQ (#7101) 2021-08-01 18:37:49 +02:00
Kargatum
dc1945196a feat(Core/Logging): add support fmt::format logging (#6893) 2021-07-31 23:54:55 +02:00
Kitzunu
87b2cd1299 fix(Core/Spell): Make use of SPELL_ATTR2_NO_SCHOOL_IMMUNITIES (#5880) 2021-07-31 15:31:00 +02:00
Christopher Galbraith
19bbe2cd79 fix(Script/Mandorik): enrage on reset and on subsequent pulls. (#7176)
* Fixed issue with Ohgan data not being reset properly causing Mandokir to enrage even when Ohgan is alive on subsequent pulls. Mandokir now correctly removes Frenzy when resetting.

Signed-off-by: ChrisCGalbraith <chriscgalbraith@gmai.com>

* Update src/server/scripts/EasternKingdoms/ZulGurub/boss_mandokir.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2021-07-31 11:16:02 +02:00
Kitzunu
275b107fea fix(Docs/Doxygen): improve some comments (#7118) 2021-07-30 23:25:38 +02:00
Shiroe
2f63e81a94 feat(Core/DB): Add Creature ExperienceModifier (#7095) 2021-07-30 07:56:42 +02:00
UltraNix
47f7c46f96 fix(Core/Spells): melee spells on sitting targets guaranteed critical strikes (#7085)
- Closes #5986
2021-07-27 13:37:47 +02:00
UltraNix
f9125f130e fix(Core): player's fall position on elevators (#7076)
- Closes #5804.
- Closes #5936.
2021-07-27 10:08:00 +02:00
UltraNix
e37dba8df6 fix(Core/Spells): Far Sight auras are supposed to extend view distance and allows seeing objects from further distance (#7068)
- Closes #5793.
2021-07-26 10:23:08 +02:00
UltraNix
1f3a097761 fix(Core/Spells): Divine Shield should prevent from environmental damage (#7071)
- Closes #5804
2021-07-25 19:44:16 +02:00
UltraNix
270f7bf506 fix(Core/Items): items with charges should not remove on item unequip its … (#7064)
- Closes #5716
2021-07-25 03:36:40 +02:00
Kitzunu
fa03541563 chore(Script/Misc): add comments to some scripts (#7011) 2021-07-24 19:37:45 +02:00
UltraNix
59c8f7276e fix(Core/Movement): correct weird pathing by clearing old path (#7034)
- Closes #5220.
2021-07-24 16:26:18 +02:00
Kitzunu
4ace9f17de fix(Core/Spell): handle 5,000 Gold with SpellScript (#6996) 2021-07-24 00:40:20 +02:00
天鹿
fdfa9e3c57 fix(Core/LootItemStorage): missing write of 'conditionLootId' (#6950) 2021-07-23 13:16:14 +02:00
UltraNix
ba85988d31 fix(Scripts/Item): Gnomish Death Ray. (#7062)
- Closes #5648
2021-07-23 13:13:49 +02:00
UltraNix
cf104e01c6 fix(Core/Pets): spells disappearing while pet being offline (#7046)
- Closes #5320
2021-07-23 11:54:01 +02:00
UltraNix
e450fd6f68 fix(Core/Units): charmed creatures do not need to check hostility to attacked creature (#7043)
Properly remove channelled charm auras on demand.
- Closes #5447
2021-07-23 09:31:04 +02:00
UltraNix
e5680dfe10 fix(Scripts/Naxxramas): properly handle Thaddius' polarity stacks (#7030)
- Closes #6929
2021-07-22 19:34:47 +02:00
Francesco Borzì
3b752dd796 refactor(Scripts/Spells): code cleanup (part 9) (#6946) 2021-07-22 01:12:28 +02:00
Kitzunu
9ab6ba9664 chore(Core/Misc): remove toxic language (#6988) 2021-07-21 23:57:20 +02:00
Francesco Borzì
e556560bc1 refactor(Scripts/Pet): code cleanup (part 8) (#6928) 2021-07-21 19:05:05 +02:00
Francesco Borzì
383946af6c refactor(Scripts/OutdoorPvP): code cleanup (part 7) (#6927) 2021-07-21 14:12:40 +02:00
robinsch
a3e3fd029f fix(Core/Item): prevent possible items dupe (#6943) 2021-07-21 12:05:12 +02:00
Francesco Borzì
172d33d507 refactor(Scripts/Events): code cleanup (part 6) (#6924) 2021-07-20 09:55:31 +02:00
Francesco Borzì
e5f1104849 refactor(Scripts/EasternKingdoms): code cleanup (part 5) - also fix potential crash (#6923) 2021-07-19 11:23:27 +02:00
Francesco Borzì
fab0fc421b refactor(Scripts/Commands): code cleanup (part 4) (#6921) 2021-07-18 13:25:44 +02:00
raizo
b8f05472e4 refactor(Core/Player): created update player category (#6872) 2021-07-17 23:47:14 +02:00
Kargatum
96c51317f5 feat(Deps/ACE): remove ACE library (part 1/2) (#6980) 2021-07-16 15:05:39 +02:00
Francesco Borzì
ee5ed33fec fix(Core/SpellAuras): prevent crash in Aura::GetType() (#6922) 2021-07-16 12:19:42 +02:00
Kargatum
8568c4fb33 feat(Core): replace ACE network with Boost.Asio (#6574) 2021-07-16 10:43:56 +02:00